# HG changeset patch # User prr # Date 1449076359 28800 # Node ID e72ce9484d9ee67ddbd9a053b9688b7d9c4ad1ed # Parent 14108cfd08230c2dd02505b22e4a1621e31dec15 8144074: [PIT] Crash calling Toolkit.getScreenSize() on Windows. Reviewed-by: flar diff -r 14108cfd0823 -r e72ce9484d9e jdk/src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp --- a/jdk/src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp Mon Nov 23 15:02:19 2015 -0800 +++ b/jdk/src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp Wed Dec 02 09:12:39 2015 -0800 @@ -2357,6 +2357,9 @@ int width = ::GetSystemMetrics(SM_CXSCREEN); + if (!Devices::GetInstance()) { + Devices::UpdateInstance(env); + } Devices::InstanceAccess devices; AwtWin32GraphicsDevice *device = devices->GetDevice( AwtWin32GraphicsDevice::GetDefaultDeviceIndex()); @@ -2376,6 +2379,10 @@ TRY; int height = ::GetSystemMetrics(SM_CYSCREEN); + + if (!Devices::GetInstance()) { + Devices::UpdateInstance(env); + } Devices::InstanceAccess devices; AwtWin32GraphicsDevice *device = devices->GetDevice( AwtWin32GraphicsDevice::GetDefaultDeviceIndex()); diff -r 14108cfd0823 -r e72ce9484d9e jdk/test/java/awt/Toolkit/GetSizeTest/GetScreenSizeTest.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/java/awt/Toolkit/GetSizeTest/GetScreenSizeTest.java Wed Dec 02 09:12:39 2015 -0800 @@ -0,0 +1,35 @@ +/* + * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + @test + @bug 8144074 + @summary Crash while getting screen size during Toolkit initialisation + @run main/othervm GetScreenSize +*/ + +public class GetScreenSize { + public static void main(String[] args) { + java.awt.Toolkit.getDefaultToolkit().getScreenSize(); + } +}