# HG changeset patch # User sherman # Date 1468453044 25200 # Node ID cac81257c65720fc4ecd1a138f8b838723c524a1 # Parent 8769812a294fab84c6853b11e83d937e2fc4c4d4 7031075: GZIPInputStream's available() reports 1, but read() gives -1. Reviewed-by: bpb diff -r 8769812a294f -r cac81257c657 jdk/src/java.base/share/classes/java/util/zip/InflaterInputStream.java --- a/jdk/src/java.base/share/classes/java/util/zip/InflaterInputStream.java Tue Jul 12 07:58:40 2016 -0700 +++ b/jdk/src/java.base/share/classes/java/util/zip/InflaterInputStream.java Wed Jul 13 16:37:24 2016 -0700 @@ -179,6 +179,10 @@ ensureOpen(); if (reachEOF) { return 0; + } else if (inf.finished()) { + // the end of the compressed data stream has been reached + reachEOF = true; + return 0; } else { return 1; } diff -r 8769812a294f -r cac81257c657 jdk/test/java/util/zip/InflaterInputStream/TestAvailable.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/java/util/zip/InflaterInputStream/TestAvailable.java Wed Jul 13 16:37:24 2016 -0700 @@ -0,0 +1,94 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* @test + * @library /lib/testlibrary/ + * @build jdk.testlibrary.* + * @run main TestAvailable + * @bug 7031075 + * @summary Make sure that available() method behaves as expected. + * @key randomness + */ + +import java.io.*; +import java.util.Random; +import java.util.zip.*; +import jdk.testlibrary.RandomFactory; + +public class TestAvailable { + + public static void main(String args[]) throws Throwable { + Random r = RandomFactory.getRandom(); + for (int n = 0; n < 10; n++) { + byte[] src = new byte[r.nextInt(100)]; + r.nextBytes(src); + + // test InflaterInputStream + ByteArrayOutputStream baos = new ByteArrayOutputStream(); + try (DeflaterOutputStream dos = new DeflaterOutputStream(baos)) { + dos.write(src); + } + try (InflaterInputStream iis = new InflaterInputStream( + new ByteArrayInputStream(baos.toByteArray()))) { + test(iis, src); + } + + // test GZIPInputStream + baos = new ByteArrayOutputStream(); + try (GZIPOutputStream dos = new GZIPOutputStream(baos)) { + dos.write(src); + } + try (GZIPInputStream gis = new GZIPInputStream( + new ByteArrayInputStream(baos.toByteArray()))) { + test(gis, src); + } + } + } + + private static void test(InputStream is, byte[] expected) throws IOException { + int cnt = 0; + do { + int available = is.available(); + if (available > 0) { + int b = is.read(); + if (b == -1) { + throw new RuntimeException("available() > 0, read() == -1 : failed!"); + } + if (expected[cnt++] != (byte)b) { + throw new RuntimeException("read() : failed!"); + } + } else if (available == 0) { + if (is.read() != -1) { + throw new RuntimeException("available() == 0, read() != -1 : failed!"); + } + break; + } else { + throw new RuntimeException("available() < 0 : failed!"); + } + } while (true); + if (cnt != expected.length) { + throw new RuntimeException("read : failed!"); + } + } + +}