# HG changeset patch # User mhaupt # Date 1463585854 -7200 # Node ID c348779a6c2b190a038ecf52580b54923126c487 # Parent 8c55199bc96b45a1416979dc7b636d2443ed7ed4 8157250: BeanLinker assumes fixed array type linkage Reviewed-by: attila, sundar diff -r 8c55199bc96b -r c348779a6c2b nashorn/src/jdk.dynalink/share/classes/jdk/dynalink/beans/BeanLinker.java --- a/nashorn/src/jdk.dynalink/share/classes/jdk/dynalink/beans/BeanLinker.java Wed May 18 20:17:48 2016 +0530 +++ b/nashorn/src/jdk.dynalink/share/classes/jdk/dynalink/beans/BeanLinker.java Wed May 18 17:37:34 2016 +0200 @@ -113,7 +113,7 @@ // Some languages won't have a notion of manipulating collections. Exposing "length" on arrays as an // explicit property is beneficial for them. // REVISIT: is it maybe a code smell that StandardOperation.GET_LENGTH is not needed? - setPropertyGetter("length", MethodHandles.arrayLength(clazz), ValidationType.IS_ARRAY); + setPropertyGetter("length", MethodHandles.arrayLength(clazz), ValidationType.EXACT_CLASS); } else if(List.class.isAssignableFrom(clazz)) { setPropertyGetter("length", GET_COLLECTION_LENGTH, ValidationType.INSTANCE_OF); } @@ -544,7 +544,7 @@ // Otherwise, create a binding based on the actual type of the argument with an appropriate guard. if(clazz.isArray()) { return new GuardedInvocationComponent(MethodHandles.arrayLength(clazz).asType(callSiteType), - Guards.isArray(0, callSiteType), ValidationType.IS_ARRAY); + Guards.isArray(0, callSiteType), ValidationType.EXACT_CLASS); } if(Collection.class.isAssignableFrom(clazz)) { return new GuardedInvocationComponent(GET_COLLECTION_LENGTH.asType(callSiteType), Guards.asType( COLLECTION_GUARD, callSiteType), Collection.class, ValidationType.INSTANCE_OF); diff -r 8c55199bc96b -r c348779a6c2b nashorn/test/script/basic/JDK-8157250.js --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/nashorn/test/script/basic/JDK-8157250.js Wed May 18 17:37:34 2016 +0200 @@ -0,0 +1,34 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8157250: BeanLinker assumes fixed array type linkage + * + * @test + * @run + */ + +var intArray = Java.type("int[]") +var doubleArray = Java.type("double[]") +var arrs = [new intArray(0), new doubleArray(0)] +for (var i in arrs) arrs[i].length diff -r 8c55199bc96b -r c348779a6c2b nashorn/test/script/basic/JDK-8157250.js.EXPECTED --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/nashorn/test/script/basic/JDK-8157250.js.EXPECTED Wed May 18 17:37:34 2016 +0200 @@ -0,0 +1,1 @@ +0