# HG changeset patch
# User mgronlun
# Date 1567544086 -7200
# Node ID 8dea18a54031313faba31add9f3345b501c89da9
# Parent  dc5746ce3b929d96b4a5b8bb7000f30c6823c617
single pass only to install typeset blobs to sample candidates

diff -r dc5746ce3b92 -r 8dea18a54031 src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
--- a/src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp	Tue Sep 03 16:25:05 2019 +0200
+++ b/src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp	Tue Sep 03 22:54:46 2019 +0200
@@ -110,7 +110,13 @@
   if (unloaded_klass_set == NULL) {
     unloaded_klass_set = c_heap_allocate_array<traceid>();
   }
-  add(unloaded_klass_set, klass_id);
+  unloaded_klass_set->append(klass_id);
+}
+
+static void sort_unloaded_klass_set() {
+  if (unloaded_klass_set != NULL && unloaded_klass_set->length() > 1) {
+    unloaded_klass_set->sort(sort_traceid);
+  }
 }
 
 void ObjectSampleCheckpoint::on_klass_unload(const Klass* k) {
@@ -212,6 +218,13 @@
   assert(entry != NULL, "invariant");
 }
 
+static GrowableArray<traceid>* id_set = NULL;
+
+static void prepare_for_resolution() {
+  id_set = new GrowableArray<traceid>(JfrOptionSet::old_object_queue_size());
+  sort_unloaded_klass_set();
+}
+
 static bool stack_trace_precondition(const ObjectSample* sample) {
   assert(sample != NULL, "invariant");
   return sample->has_stack_trace_id() && !sample->is_dead();
@@ -224,9 +237,7 @@
   const JfrStackTrace* resolve(const ObjectSample* sample);
   void install(ObjectSample* sample);
  public:
-  StackTraceBlobInstaller(const JfrStackTraceRepository& stack_trace_repo) :
-    _stack_trace_repo(stack_trace_repo),
-    _cache(JfrOptionSet::old_object_queue_size()) {}
+  StackTraceBlobInstaller(const JfrStackTraceRepository& stack_trace_repo);
   void sample_do(ObjectSample* sample) {
     if (stack_trace_precondition(sample)) {
       install(sample);
@@ -234,6 +245,11 @@
   }
 };
 
+StackTraceBlobInstaller::StackTraceBlobInstaller(const JfrStackTraceRepository& stack_trace_repo) :
+  _stack_trace_repo(stack_trace_repo), _cache(JfrOptionSet::old_object_queue_size()) {
+  prepare_for_resolution();
+}
+
 const JfrStackTrace* StackTraceBlobInstaller::resolve(const ObjectSample* sample) {
   return _stack_trace_repo.lookup(sample->stack_trace_hash(), sample->stack_trace_id());
 }
@@ -264,17 +280,10 @@
   sample->set_stacktrace(blob);
 }
 
-static GrowableArray<traceid>* id_set = NULL;
-
-static void allocate_traceid_working_set() {
-  id_set = new GrowableArray<traceid>(JfrOptionSet::old_object_queue_size());
-}
-
-static void resolve_stack_traces(const ObjectSampler* sampler, JfrStackTraceRepository& stack_trace_repo) {
+static void install_stack_traces(const ObjectSampler* sampler, JfrStackTraceRepository& stack_trace_repo) {
   assert(sampler != NULL, "invariant");
   const ObjectSample* const last = sampler->last();
   if (last != sampler->last_resolved()) {
-    allocate_traceid_working_set();
     StackTraceBlobInstaller installer(stack_trace_repo);
     iterate_samples(installer);
   }
@@ -284,7 +293,7 @@
 void ObjectSampleCheckpoint::on_rotation(const ObjectSampler* sampler, JfrStackTraceRepository& stack_trace_repo) {
   assert(sampler != NULL, "invariant");
   assert(LeakProfiler::is_running(), "invariant");
-  resolve_stack_traces(sampler, stack_trace_repo);
+  install_stack_traces(sampler, stack_trace_repo);
 }
 
 static traceid get_klass_id(traceid method_id) {
@@ -400,47 +409,63 @@
   }
 }
 
-class BlobInstaller {
- private:
-  const JfrBlobHandle& _blob;
- public:
-  BlobInstaller(const JfrBlobHandle& blob) : _blob(blob) {}
-  void sample_do(ObjectSample* sample) {
-    if (!sample->is_dead()) {
-      sample->set_type_set(_blob);
-    }
-  }
-};
-
 static void clear_unloaded_klass_set() {
   if (unloaded_klass_set != NULL && unloaded_klass_set->is_nonempty()) {
     unloaded_klass_set->clear();
   }
 }
 
-static void install_blob(JfrCheckpointWriter& writer, bool copy = false) {
+// A linked list of saved type set blobs for the epoch.
+// The link consist of a reference counted handle.
+static JfrBlobHandle saved_type_set_blobs;
+
+static void release_state_for_previous_epoch() {
+  // decrements the reference count and the list is reinitialized
+  saved_type_set_blobs = JfrBlobHandle();
+  clear_unloaded_klass_set();
+}
+
+class BlobInstaller {
+ public:
+  ~BlobInstaller() {
+    release_state_for_previous_epoch();
+  }
+  void sample_do(ObjectSample* sample) {
+    if (!sample->is_dead()) {
+      sample->set_type_set(saved_type_set_blobs);
+    }
+  }
+};
+
+static void install_type_set_blobs() {
+  BlobInstaller installer;
+  iterate_samples(installer);
+}
+
+static void save_type_set_blob(JfrCheckpointWriter& writer, bool copy = false) {
   assert(writer.has_data(), "invariant");
   const JfrBlobHandle blob = copy ? writer.copy() : writer.move();
-  BlobInstaller installer(blob);
-  iterate_samples(installer);
+  if (saved_type_set_blobs.valid()) {
+    saved_type_set_blobs->set_next(blob);
+  } else {
+    saved_type_set_blobs = blob;
+  }
 }
 
 void ObjectSampleCheckpoint::on_type_set(JfrCheckpointWriter& writer) {
   assert(LeakProfiler::is_running(), "invariant");
   const ObjectSample* last = ObjectSampler::sampler()->last();
   if (writer.has_data() && last != NULL) {
-    install_blob(writer);
+    save_type_set_blob(writer);
+    install_type_set_blobs();
     ObjectSampler::sampler()->set_last_resolved(last);
   }
-  // Only happens post chunk rotation and we would not have hit another class unload safepoint.
-  // Therefore it is safe to release the set of unloaded classes tracked during the previous epoch.
-  clear_unloaded_klass_set();
 }
 
 void ObjectSampleCheckpoint::on_type_set_unload(JfrCheckpointWriter& writer) {
   assert(SafepointSynchronize::is_at_safepoint(), "invariant");
   assert(LeakProfiler::is_running(), "invariant");
   if (writer.has_data() && ObjectSampler::sampler()->last() != NULL) {
-    install_blob(writer, true);
+    save_type_set_blob(writer, true);
   }
 }