# HG changeset patch # User emc # Date 1415194624 18000 # Node ID 784414cffd9afed6dd50b74a7de9751d2e6a246d # Parent fb4a5f11831626d516042a74f3325c21221d4a48 8035259: javac, incorrect shadowing of classes vs type parameters Summary: Cause javac to look at type variables first when resolving names in an extends/implements list Reviewed-by: mcimadamore, jlahoda diff -r fb4a5f118316 -r 784414cffd9a langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java --- a/langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java Tue Nov 04 13:21:25 2014 -0800 +++ b/langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java Wed Nov 05 08:37:04 2014 -0500 @@ -2033,10 +2033,11 @@ // Return the type variable if we have it, and have no // immediate member, OR the type variable is for a method. if (tyvar != typeNotFound) { - if (sym == typeNotFound || + if (env.baseClause || sym == typeNotFound || (tyvar.kind == TYP && tyvar.exists() && - tyvar.owner.kind == MTH)) + tyvar.owner.kind == MTH)) { return tyvar; + } } // If the environment is a class def, finish up, diff -r fb4a5f118316 -r 784414cffd9a langtools/test/tools/javac/TypeVarShadow.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/langtools/test/tools/javac/TypeVarShadow.java Wed Nov 05 08:37:04 2014 -0500 @@ -0,0 +1,41 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * @test + * @summary Incorrect shadowing of classes vs type parameters + * @bug 8035259 + * @run compile TypeVarShadow.java + */ + +public class TypeVarShadow { + class T {} + + abstract class One { + abstract E foo(); + } + + abstract class Two extends One { + abstract T foo(); + } +}