# HG changeset patch # User stefank # Date 1396012503 -3600 # Node ID 6382fd0ea30346dac18c74a0d94c79f2a4e3a3b1 # Parent 2518569e1e016f92808e3e9518dff995f2bfb447 8038630: Remove ExtendedOopClosure::prefetch_style() Reviewed-by: coleenp, jmasa diff -r 2518569e1e01 -r 6382fd0ea303 hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp --- a/hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp Fri Mar 28 14:03:11 2014 +0100 +++ b/hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp Fri Mar 28 14:15:03 2014 +0100 @@ -116,10 +116,6 @@ MarkRefsIntoClosure(MemRegion span, CMSBitMap* bitMap); virtual void do_oop(oop* p); virtual void do_oop(narrowOop* p); - - Prefetch::style prefetch_style() { - return Prefetch::do_read; - } }; class Par_MarkRefsIntoClosure: public CMSOopsInGenClosure { @@ -132,10 +128,6 @@ Par_MarkRefsIntoClosure(MemRegion span, CMSBitMap* bitMap); virtual void do_oop(oop* p); virtual void do_oop(narrowOop* p); - - Prefetch::style prefetch_style() { - return Prefetch::do_read; - } }; // A variant of the above used in certain kinds of CMS @@ -152,10 +144,6 @@ CMSBitMap* cms_bm); virtual void do_oop(oop* p); virtual void do_oop(narrowOop* p); - - Prefetch::style prefetch_style() { - return Prefetch::do_read; - } }; // The non-parallel version (the parallel version appears further below). @@ -181,10 +169,6 @@ virtual void do_oop(narrowOop* p); inline void do_oop_nv(oop* p) { PushAndMarkClosure::do_oop_work(p); } inline void do_oop_nv(narrowOop* p) { PushAndMarkClosure::do_oop_work(p); } - - Prefetch::style prefetch_style() { - return Prefetch::do_read; - } }; // In the parallel case, the bit map and the @@ -211,10 +195,6 @@ virtual void do_oop(narrowOop* p); inline void do_oop_nv(oop* p) { Par_PushAndMarkClosure::do_oop_work(p); } inline void do_oop_nv(narrowOop* p) { Par_PushAndMarkClosure::do_oop_work(p); } - - Prefetch::style prefetch_style() { - return Prefetch::do_read; - } }; // The non-parallel version (the parallel version appears further below). @@ -245,9 +225,6 @@ inline void do_oop_nv(oop* p) { MarkRefsIntoAndScanClosure::do_oop_work(p); } inline void do_oop_nv(narrowOop* p) { MarkRefsIntoAndScanClosure::do_oop_work(p); } - Prefetch::style prefetch_style() { - return Prefetch::do_read; - } void set_freelistLock(Mutex* m) { _freelistLock = m; } @@ -282,9 +259,6 @@ inline void do_oop_nv(oop* p) { Par_MarkRefsIntoAndScanClosure::do_oop_work(p); } inline void do_oop_nv(narrowOop* p) { Par_MarkRefsIntoAndScanClosure::do_oop_work(p); } - Prefetch::style prefetch_style() { - return Prefetch::do_read; - } void trim_queue(uint size); }; diff -r 2518569e1e01 -r 6382fd0ea303 hotspot/src/share/vm/memory/genOopClosures.hpp --- a/hotspot/src/share/vm/memory/genOopClosures.hpp Fri Mar 28 14:03:11 2014 +0100 +++ b/hotspot/src/share/vm/memory/genOopClosures.hpp Fri Mar 28 14:15:03 2014 +0100 @@ -115,9 +115,6 @@ virtual void do_oop(narrowOop* p); inline void do_oop_nv(oop* p); inline void do_oop_nv(narrowOop* p); - Prefetch::style prefetch_style() { - return Prefetch::do_write; - } }; // Closure for scanning DefNewGeneration. @@ -137,9 +134,6 @@ virtual void do_oop(narrowOop* p); inline void do_oop_nv(oop* p); inline void do_oop_nv(narrowOop* p); - Prefetch::style prefetch_style() { - return Prefetch::do_write; - } }; class KlassScanClosure: public KlassClosure { diff -r 2518569e1e01 -r 6382fd0ea303 hotspot/src/share/vm/memory/iterator.hpp --- a/hotspot/src/share/vm/memory/iterator.hpp Fri Mar 28 14:03:11 2014 +0100 +++ b/hotspot/src/share/vm/memory/iterator.hpp Fri Mar 28 14:15:03 2014 +0100 @@ -27,7 +27,6 @@ #include "memory/allocation.hpp" #include "memory/memRegion.hpp" -#include "runtime/prefetch.hpp" #include "utilities/top.hpp" class CodeBlob; @@ -84,11 +83,6 @@ virtual void do_class_loader_data(ClassLoaderData* cld) { ShouldNotReachHere(); } - // Controls how prefetching is done for invocations of this closure. - Prefetch::style prefetch_style() { // Note that this is non-virtual. - return Prefetch::do_none; - } - // True iff this closure may be safely applied more than once to an oop // location without an intervening "major reset" (like the end of a GC). virtual bool idempotent() { return false; }