# HG changeset patch # User mhaupt # Date 1433500733 -7200 # Node ID 52472f1b56e454c97f1e135bedc97d9bd95850d1 # Parent 5b500c93ce4822d47061cd518ff3f72d9d8cb5b5 8080087: Nashorn $ENV.PWD is originally undefined Summary: On Windows, the PWD environment variable does not exist and cannot be imported in scripting mode, so it is set explicitly. Reviewed-by: lagergren, sundar diff -r 5b500c93ce48 -r 52472f1b56e4 nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/Global.java --- a/nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/Global.java Wed Jul 05 20:37:12 2017 +0200 +++ b/nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/Global.java Fri Jun 05 12:38:53 2015 +0200 @@ -2712,6 +2712,14 @@ // Retrieve current state of ENV variables. final ScriptObject env = newObject(); env.putAll(System.getenv(), scriptEnv._strict); + + // Some platforms, e.g., Windows, do not define the PWD environment + // variable, so that the $ENV.PWD property needs to be explicitly + // set. + if (!env.containsKey(ScriptingFunctions.PWD_NAME)) { + env.put(ScriptingFunctions.PWD_NAME, System.getProperty("user.dir"), scriptEnv._strict); + } + addOwnProperty(ScriptingFunctions.ENV_NAME, Attribute.NOT_ENUMERABLE, env); } else { addOwnProperty(ScriptingFunctions.ENV_NAME, Attribute.NOT_ENUMERABLE, UNDEFINED); diff -r 5b500c93ce48 -r 52472f1b56e4 nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptingFunctions.java --- a/nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptingFunctions.java Wed Jul 05 20:37:12 2017 +0200 +++ b/nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptingFunctions.java Fri Jun 05 12:38:53 2015 +0200 @@ -71,7 +71,8 @@ /** Names of special properties used by $ENV API. */ public static final String ENV_NAME = "$ENV"; - private static final String PWD_NAME = "PWD"; + /** Name of the environment variable for the current working directory. */ + public static final String PWD_NAME = "PWD"; private ScriptingFunctions() { } diff -r 5b500c93ce48 -r 52472f1b56e4 nashorn/test/script/nosecurity/JDK-8080087.js --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/nashorn/test/script/nosecurity/JDK-8080087.js Fri Jun 05 12:38:53 2015 +0200 @@ -0,0 +1,38 @@ +/* + * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8080087: Nashorn $ENV.PWD is originally undefined + * + * This is to ensure that $ENV.PWD is correctly set on Windows as well as on all + * other platforms. + * + * @test + * @option -scripting + * @run + */ + +if (typeof($ENV.PWD) === 'undefined') { + fail('$ENV.PWD is undefined') +} +