# HG changeset patch # User roland # Date 1530287984 -7200 # Node ID 3fd01bccc81f3817bd53e451fe2966ab6286871c # Parent 46ca5e6b7ed8cc9763b74efbf2aba56c4397d49e 8202123: C2 Crash in Node::in(unsigned int) const+0x14 Reviewed-by: kvn, thartmann diff -r 46ca5e6b7ed8 -r 3fd01bccc81f src/hotspot/share/opto/loopnode.cpp --- a/src/hotspot/share/opto/loopnode.cpp Tue Jul 10 03:14:55 2018 -0400 +++ b/src/hotspot/share/opto/loopnode.cpp Fri Jun 29 17:59:44 2018 +0200 @@ -616,6 +616,11 @@ } IfNode* check_iff = limit_check_proj->in(0)->as_If(); + + if (!is_dominator(get_ctrl(limit), check_iff->in(0))) { + return false; + } + Node* cmp_limit; Node* bol; diff -r 46ca5e6b7ed8 -r 3fd01bccc81f test/hotspot/jtreg/compiler/loopopts/TestLimitLoadBelowLoopLimitCheck.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/hotspot/jtreg/compiler/loopopts/TestLimitLoadBelowLoopLimitCheck.java Fri Jun 29 17:59:44 2018 +0200 @@ -0,0 +1,66 @@ +/* + * Copyright (c) 2018, Red Hat, Inc. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * @test + * @bug 8202123 + * @summary C2 Crash in Node::in(unsigned int) const+0x14 + * + * @run main/othervm TestLimitLoadBelowLoopLimitCheck + * + */ + +public class TestLimitLoadBelowLoopLimitCheck { + public static int[] run(int[] arr) { + int max = 0; + for (int i : arr) { + if (i > max) { + max = i; + } + } + + int[] counts = new int[10]; + + int i = 0; + for (i = 0; i < counts.length; i += 1) { + for (int j = 0; j < counts[i]; j += 1) { + } + } + + while (i < max) { + for (int j = 0; j < counts[i]; j += 1) { + arr[0] = i; + } + } + + return arr; + } + + public static void main(String[] args) { + int[] arr = new int[1000 * 1000]; + + for (int i = 0; i < 100; i++) { + run(arr); + } + } +}