# HG changeset patch # User mchung # Date 1486751206 28800 # Node ID 21db3870367530bf56c464ca47f9f328784c1c65 # Parent e188ba772b262befcc5844db591c39623ae1f685 8174739: Rename JMOD section name for native libraries from native to lib Reviewed-by: alanb diff -r e188ba772b26 -r 21db38703675 jdk/src/java.base/share/classes/jdk/internal/jmod/JmodFile.java --- a/jdk/src/java.base/share/classes/jdk/internal/jmod/JmodFile.java Fri Feb 10 08:17:47 2017 -0800 +++ b/jdk/src/java.base/share/classes/jdk/internal/jmod/JmodFile.java Fri Feb 10 10:26:46 2017 -0800 @@ -78,7 +78,7 @@ HEADER_FILES("include"), LEGAL_NOTICES("legal"), MAN_PAGES("man"), - NATIVE_LIBS("native"), + NATIVE_LIBS("lib"), NATIVE_CMDS("bin"); private final String jmodDir; diff -r e188ba772b26 -r 21db38703675 jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java --- a/jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java Fri Feb 10 08:17:47 2017 -0800 +++ b/jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java Fri Feb 10 10:26:46 2017 -0800 @@ -362,7 +362,7 @@ String module = "/" + entry.moduleName() + "/"; String filename = entry.path().substring(module.length()); - // Remove radical native|config|... + // Remove radical lib|config|... return filename.substring(filename.indexOf('/') + 1); } diff -r e188ba772b26 -r 21db38703675 jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/AbstractResourcePoolEntry.java --- a/jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/AbstractResourcePoolEntry.java Fri Feb 10 08:17:47 2017 -0800 +++ b/jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/AbstractResourcePoolEntry.java Fri Feb 10 10:26:46 2017 -0800 @@ -38,7 +38,7 @@ *
  • For jimage content: /{module name}/{package1}/.../{packageN}/{file * name}
  • *
  • For other files (shared lib, launchers, config, ...):/{module name}/ - * {@literal bin|conf|native}/{dir1}>/.../{dirN}/{file name}
  • + * {@literal bin|conf|lib}/{dir1}>/.../{dirN}/{file name} * */ abstract class AbstractResourcePoolEntry implements ResourcePoolEntry { diff -r e188ba772b26 -r 21db38703675 jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludeVMPlugin.java --- a/jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludeVMPlugin.java Fri Feb 10 08:17:47 2017 -0800 +++ b/jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludeVMPlugin.java Fri Feb 10 10:26:46 2017 -0800 @@ -95,9 +95,9 @@ /** * VM paths: - * /java.base/native/{architecture}/{server|client|minimal}/{shared lib} - * e.g.: /java.base/native/amd64/server/libjvm.so - * /java.base/native/server/libjvm.dylib + * /java.base/lib/{architecture}/{server|client|minimal}/{shared lib} + * e.g.: /java.base/lib/server/libjvm.so + * /java.base/lib/server/libjvm.dylib */ private List getVMs(ResourcePoolModule javaBase, String[] jvmlibs) { List ret = javaBase.entries().filter((t) -> { @@ -198,17 +198,17 @@ } case CLIENT: { target = Jvm.CLIENT; - exclude = "/java.base/native**server/**,/java.base/native**minimal/**"; + exclude = "/java.base/lib**server/**,/java.base/lib**minimal/**"; break; } case SERVER: { target = Jvm.SERVER; - exclude = "/java.base/native**client/**,/java.base/native**minimal/**"; + exclude = "/java.base/lib**client/**,/java.base/lib**minimal/**"; break; } case MINIMAL: { target = Jvm.MINIMAL; - exclude = "/java.base/native**server/**,/java.base/native**client/**"; + exclude = "/java.base/lib**server/**,/java.base/lib**client/**"; break; } default: { diff -r e188ba772b26 -r 21db38703675 jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties --- a/jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties Fri Feb 10 08:17:47 2017 -0800 +++ b/jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties Fri Feb 10 10:26:46 2017 -0800 @@ -62,7 +62,7 @@ exclude-files.argument= of files to exclude exclude-files.description=\ -Specify files to exclude. e.g.: **.java,glob:/java.base/native/client/** +Specify files to exclude. e.g.: **.java,glob:/java.base/lib/client/** exclude-resources.argument= resources to exclude diff -r e188ba772b26 -r 21db38703675 jdk/test/tools/jlink/JLinkNegativeTest.java --- a/jdk/test/tools/jlink/JLinkNegativeTest.java Fri Feb 10 08:17:47 2017 -0800 +++ b/jdk/test/tools/jlink/JLinkNegativeTest.java Fri Feb 10 10:26:46 2017 -0800 @@ -250,7 +250,7 @@ String moduleName = "hacked4"; Path jmod = helper.generateDefaultJModule(moduleName).assertSuccess(); JImageGenerator.addFiles(jmod, - new InMemoryFile("/native", new byte[0]), + new InMemoryFile("/lib", new byte[0]), new InMemoryFile("/conf", new byte[0]), new InMemoryFile("/bin", new byte[0])); try { diff -r e188ba772b26 -r 21db38703675 jdk/test/tools/jlink/plugins/ExcludeVMPluginTest.java --- a/jdk/test/tools/jlink/plugins/ExcludeVMPluginTest.java Fri Feb 10 08:17:47 2017 -0800 +++ b/jdk/test/tools/jlink/plugins/ExcludeVMPluginTest.java Fri Feb 10 10:26:46 2017 -0800 @@ -155,10 +155,10 @@ String[] winput = new String[input.length]; String[] woutput = new String[expectedOutput.length]; for (int i = 0; i < input.length; i++) { - winput[i] = "/java.base/native" + arch + input[i]; + winput[i] = "/java.base/lib" + arch + input[i]; } for (int i = 0; i < expectedOutput.length; i++) { - woutput[i] = "/java.base/native" + arch + expectedOutput[i]; + woutput[i] = "/java.base/lib" + arch + expectedOutput[i]; } doCheckVM(vm, winput, jvmcfg, woutput, expectdJvmCfg); } @@ -169,7 +169,7 @@ byte[] jvmcfgContent = jvmcfg.getBytes(); ResourcePoolManager poolMgr = new ResourcePoolManager(); poolMgr.add( - ResourcePoolEntry.create("/java.base/native/jvm.cfg", + ResourcePoolEntry.create("/java.base/lib/jvm.cfg", ResourcePoolEntry.Type.NATIVE_LIB, jvmcfgContent)); // java.base/module-info.class is used by exclude vm plugin @@ -192,7 +192,7 @@ p.configure(config); ResourcePool out = p.transform(poolMgr.resourcePool(), outMgr.resourcePoolBuilder()); - String newContent = new String(out.findEntry("/java.base/native/jvm.cfg").get().contentBytes()); + String newContent = new String(out.findEntry("/java.base/lib/jvm.cfg").get().contentBytes()); if (!expectdJvmCfg.equals(newContent)) { throw new Exception("Got content " + newContent + " expected " + expectdJvmCfg); @@ -209,7 +209,7 @@ } out.entries().forEach(md -> { - if (md.path().equals("/java.base/native/jvm.cfg") || + if (md.path().equals("/java.base/lib/jvm.cfg") || md.path().equals("/java.base/module-info.class")) { return; } diff -r e188ba772b26 -r 21db38703675 jdk/test/tools/jmod/JmodTest.java --- a/jdk/test/tools/jmod/JmodTest.java Fri Feb 10 08:17:47 2017 -0800 +++ b/jdk/test/tools/jmod/JmodTest.java Fri Feb 10 10:26:46 2017 -0800 @@ -66,7 +66,7 @@ static final String CLASSES_PREFIX = "classes/"; static final String CMDS_PREFIX = "bin/"; - static final String LIBS_PREFIX = "native/"; + static final String LIBS_PREFIX = "lib/"; static final String CONFIGS_PREFIX = "conf/"; @BeforeTest