# HG changeset patch # User brutisso # Date 1429250981 -7200 # Node ID 04d3680cd0291b95c6fff92ccb195f0a03d7b7dc # Parent faa43d41b739a36f30f5b92160e7d13fd70e5aa8 8077938: Remove TraceMarkSweep Reviewed-by: sjohanss, jmasa diff -r faa43d41b739 -r 04d3680cd029 hotspot/src/share/vm/gc_implementation/g1/g1MarkSweep.cpp --- a/hotspot/src/share/vm/gc_implementation/g1/g1MarkSweep.cpp Wed Apr 15 11:42:20 2015 -0400 +++ b/hotspot/src/share/vm/gc_implementation/g1/g1MarkSweep.cpp Fri Apr 17 08:09:41 2015 +0200 @@ -119,7 +119,6 @@ bool clear_all_softrefs) { // Recursively traverse all live objects and mark them GCTraceTime tm("phase 1", G1Log::fine() && Verbose, true, gc_timer(), gc_tracer()->gc_id()); - GenMarkSweep::trace(" 1"); G1CollectedHeap* g1h = G1CollectedHeap::heap(); @@ -199,7 +198,6 @@ // tracking expects us to do so. See comment under phase4. GCTraceTime tm("phase 2", G1Log::fine() && Verbose, true, gc_timer(), gc_tracer()->gc_id()); - GenMarkSweep::trace("2"); prepare_compaction(); } @@ -233,7 +231,6 @@ // Adjust the pointers to reflect the new locations GCTraceTime tm("phase 3", G1Log::fine() && Verbose, true, gc_timer(), gc_tracer()->gc_id()); - GenMarkSweep::trace("3"); // Need cleared claim bits for the roots processing ClassLoaderDataGraph::clear_claimed_marks(); @@ -295,7 +292,6 @@ G1CollectedHeap* g1h = G1CollectedHeap::heap(); GCTraceTime tm("phase 4", G1Log::fine() && Verbose, true, gc_timer(), gc_tracer()->gc_id()); - GenMarkSweep::trace("4"); G1SpaceCompactClosure blk; g1h->heap_region_iterate(&blk); diff -r faa43d41b739 -r 04d3680cd029 hotspot/src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp --- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp Wed Apr 15 11:42:20 2015 -0400 +++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp Fri Apr 17 08:09:41 2015 +0200 @@ -510,7 +510,6 @@ void PSMarkSweep::mark_sweep_phase1(bool clear_all_softrefs) { // Recursively traverse all live objects and mark them GCTraceTime tm("phase 1", PrintGCDetails && Verbose, true, _gc_timer, _gc_tracer->gc_id()); - trace(" 1"); ParallelScavengeHeap* heap = ParallelScavengeHeap::heap(); @@ -570,7 +569,6 @@ void PSMarkSweep::mark_sweep_phase2() { GCTraceTime tm("phase 2", PrintGCDetails && Verbose, true, _gc_timer, _gc_tracer->gc_id()); - trace("2"); // Now all live objects are marked, compute the new object addresses. @@ -598,7 +596,6 @@ void PSMarkSweep::mark_sweep_phase3() { // Adjust the pointers to reflect the new locations GCTraceTime tm("phase 3", PrintGCDetails && Verbose, true, _gc_timer, _gc_tracer->gc_id()); - trace("3"); ParallelScavengeHeap* heap = ParallelScavengeHeap::heap(); PSYoungGen* young_gen = heap->young_gen(); @@ -639,7 +636,6 @@ void PSMarkSweep::mark_sweep_phase4() { EventMark m("4 compact heap"); GCTraceTime tm("phase 4", PrintGCDetails && Verbose, true, _gc_timer, _gc_tracer->gc_id()); - trace("4"); // All pointers are now adjusted, move objects accordingly diff -r faa43d41b739 -r 04d3680cd029 hotspot/src/share/vm/gc_implementation/shared/markSweep.cpp --- a/hotspot/src/share/vm/gc_implementation/shared/markSweep.cpp Wed Apr 15 11:42:20 2015 -0400 +++ b/hotspot/src/share/vm/gc_implementation/shared/markSweep.cpp Fri Apr 17 08:09:41 2015 +0200 @@ -338,15 +338,6 @@ MarkSweep::_gc_tracer = new (ResourceObj::C_HEAP, mtGC) SerialOldTracer(); } -#ifndef PRODUCT - -void MarkSweep::trace(const char* msg) { - if (TraceMarkSweep) - gclog_or_tty->print("%s", msg); -} - -#endif - int InstanceKlass::oop_ms_adjust_pointers(oop obj) { int size = size_helper(); oop_oop_iterate_oop_maps(obj, &MarkSweep::adjust_pointer_closure); diff -r faa43d41b739 -r 04d3680cd029 hotspot/src/share/vm/gc_implementation/shared/markSweep.hpp --- a/hotspot/src/share/vm/gc_implementation/shared/markSweep.hpp Wed Apr 15 11:42:20 2015 -0400 +++ b/hotspot/src/share/vm/gc_implementation/shared/markSweep.hpp Fri Apr 17 08:09:41 2015 +0200 @@ -131,9 +131,6 @@ // Non public closures static KeepAliveClosure keep_alive; - // Debugging - static void trace(const char* msg) PRODUCT_RETURN; - public: // Public closures static IsAliveClosure is_alive; diff -r faa43d41b739 -r 04d3680cd029 hotspot/src/share/vm/memory/genMarkSweep.cpp --- a/hotspot/src/share/vm/memory/genMarkSweep.cpp Wed Apr 15 11:42:20 2015 -0400 +++ b/hotspot/src/share/vm/memory/genMarkSweep.cpp Fri Apr 17 08:09:41 2015 +0200 @@ -187,7 +187,6 @@ bool clear_all_softrefs) { // Recursively traverse all live objects and mark them GCTraceTime tm("phase 1", PrintGC && Verbose, true, _gc_timer, _gc_tracer->gc_id()); - trace(" 1"); GenCollectedHeap* gch = GenCollectedHeap::heap(); @@ -258,7 +257,6 @@ GenCollectedHeap* gch = GenCollectedHeap::heap(); GCTraceTime tm("phase 2", PrintGC && Verbose, true, _gc_timer, _gc_tracer->gc_id()); - trace("2"); gch->prepare_for_compaction(); } @@ -275,7 +273,6 @@ // Adjust the pointers to reflect the new locations GCTraceTime tm("phase 3", PrintGC && Verbose, true, _gc_timer, _gc_tracer->gc_id()); - trace("3"); // Need new claim bits for the pointer adjustment tracing. ClassLoaderDataGraph::clear_claimed_marks(); @@ -325,7 +322,6 @@ GenCollectedHeap* gch = GenCollectedHeap::heap(); GCTraceTime tm("phase 4", PrintGC && Verbose, true, _gc_timer, _gc_tracer->gc_id()); - trace("4"); GenCompactClosure blk; gch->generation_iterate(&blk, true); diff -r faa43d41b739 -r 04d3680cd029 hotspot/src/share/vm/runtime/globals.hpp --- a/hotspot/src/share/vm/runtime/globals.hpp Wed Apr 15 11:42:20 2015 -0400 +++ b/hotspot/src/share/vm/runtime/globals.hpp Fri Apr 17 08:09:41 2015 +0200 @@ -2290,9 +2290,6 @@ "If non-zero, assert that GC threads yield within this " \ "number of milliseconds") \ \ - notproduct(bool, TraceMarkSweep, false, \ - "Trace mark sweep") \ - \ product(bool, PrintReferenceGC, false, \ "Print times spent handling reference objects during GC " \ "(enabled only when PrintGCDetails)") \