Fri, 22 Feb 2013 12:22:16 +0100 8007002: Replace implicit exception throwing methods with explicit throws - simplify control flow and remove useless code
lagergren [Fri, 22 Feb 2013 12:22:16 +0100] rev 16256
8007002: Replace implicit exception throwing methods with explicit throws - simplify control flow and remove useless code Reviewed-by: attila, hannesw
Fri, 22 Feb 2013 11:27:40 +0100 8008575: Re-integrate code coverage
lagergren [Fri, 22 Feb 2013 11:27:40 +0100] rev 16255
8008575: Re-integrate code coverage Reviewed-by: attila, hannesw Contributed-by: eugene.drobitko@oracle.com, ilya.dergalin@oracle.com
Fri, 22 Feb 2013 08:57:22 +0100 8008554: load was broken for URLs
lagergren [Fri, 22 Feb 2013 08:57:22 +0100] rev 16254
8008554: load was broken for URLs Reviewed-by: attila, sundar
Thu, 21 Feb 2013 15:24:31 -0400 8008447: Tweaks to make all NEWBUILD=false round 3
jlaskey [Thu, 21 Feb 2013 15:24:31 -0400] rev 16253
8008447: Tweaks to make all NEWBUILD=false round 3 Reviewed-by: jjh, sundar Contributed-by: james.laskey@oracle.com
Thu, 21 Feb 2013 16:57:21 +0100 8008648: Lazy JIT scope and callee semantics bugfixes. Broke out wallclock timer.
lagergren [Thu, 21 Feb 2013 16:57:21 +0100] rev 16252
8008648: Lazy JIT scope and callee semantics bugfixes. Broke out wallclock timer. Reviewed-by: attila, hannesw
Wed, 20 Feb 2013 16:43:21 +0100 8008166: URL handling was broken on windows, causing "load" to malfunction
lagergren [Wed, 20 Feb 2013 16:43:21 +0100] rev 16251
8008166: URL handling was broken on windows, causing "load" to malfunction Reviewed-by: attila, jlaskey Contributed-by: klara.ward@oracle.com
Wed, 20 Feb 2013 17:08:32 +0530 8008207: Make constants array and source fields private
sundar [Wed, 20 Feb 2013 17:08:32 +0530] rev 16250
8008207: Make constants array and source fields private Reviewed-by: hannesw, lagergren
Tue, 19 Feb 2013 20:33:07 +0530 8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter
sundar [Tue, 19 Feb 2013 20:33:07 +0530] rev 16249
8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter Reviewed-by: jlaskey, attila
Tue, 19 Feb 2013 09:47:02 -0400 Merge
jlaskey [Tue, 19 Feb 2013 09:47:02 -0400] rev 16248
Merge
Tue, 19 Feb 2013 09:46:28 -0400 8008420: Tweaks to make all NEWBUILD=false round 2
jlaskey [Tue, 19 Feb 2013 09:46:28 -0400] rev 16247
8008420: Tweaks to make all NEWBUILD=false round 2 Reviewed-by: jjh Contributed-by: james.laskey@oracle.com
Mon, 18 Feb 2013 20:41:12 +0530 8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker
sundar [Mon, 18 Feb 2013 20:41:12 +0530] rev 16246
8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker Reviewed-by: lagergren, jlaskey, hannesw
Mon, 18 Feb 2013 16:00:15 +0100 8008371: Fix Dynalink compiler warnings and whitespace
attila [Mon, 18 Feb 2013 16:00:15 +0100] rev 16245
8008371: Fix Dynalink compiler warnings and whitespace Reviewed-by: jlaskey, sundar
Mon, 18 Feb 2013 10:36:18 +0100 8008351: Avoid using String.replace(String, String) in codegen
hannesw [Mon, 18 Feb 2013 10:36:18 +0100] rev 16244
8008351: Avoid using String.replace(String, String) in codegen Reviewed-by: sundar, attila
Mon, 18 Feb 2013 14:41:58 +0530 8008305: ScriptEngine.eval should offer the ability to provide a codebase
sundar [Mon, 18 Feb 2013 14:41:58 +0530] rev 16243
8008305: ScriptEngine.eval should offer the ability to provide a codebase Reviewed-by: lagergren, hannesw, attila
Fri, 15 Feb 2013 20:40:05 +0530 8008298: Add tests to cover specialized versions of Math functions.
sundar [Fri, 15 Feb 2013 20:40:05 +0530] rev 16242
8008298: Add tests to cover specialized versions of Math functions. Reviewed-by: jlaskey, lagergren
Fri, 15 Feb 2013 18:30:19 +0530 8008291: Add more tests for better coverage of objects, scripting and parser packages
sundar [Fri, 15 Feb 2013 18:30:19 +0530] rev 16241
8008291: Add more tests for better coverage of objects, scripting and parser packages Reviewed-by: lagergren, jlaskey
Fri, 15 Feb 2013 09:44:15 +0100 8008239: Unpublicized parts of the code generator package that were only package internal.
lagergren [Fri, 15 Feb 2013 09:44:15 +0100] rev 16240
8008239: Unpublicized parts of the code generator package that were only package internal. Reviewed-by: hannesw, attila
Fri, 15 Feb 2013 09:18:05 +0100 8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap
hannesw [Fri, 15 Feb 2013 09:18:05 +0100] rev 16239
8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap Reviewed-by: jlaskey, lagergren
Thu, 14 Feb 2013 11:32:49 -0400 8008231: Fix build system to accommodate integration of dynalink
jlaskey [Thu, 14 Feb 2013 11:32:49 -0400] rev 16238
8008231: Fix build system to accommodate integration of dynalink Reviewed-by: jlaskey Contributed-by: james.laskey@oracle.com
Thu, 14 Feb 2013 14:07:53 +0100 8008198: java.lang.AssertionError: Invalid break target class jdk.nashorn.internal.ir.TryNode
hannesw [Thu, 14 Feb 2013 14:07:53 +0100] rev 16237
8008198: java.lang.AssertionError: Invalid break target class jdk.nashorn.internal.ir.TryNode Reviewed-by: attila, jlaskey
Thu, 14 Feb 2013 13:51:54 +0100 8007990: No access to interface methods on a restricted class
attila [Thu, 14 Feb 2013 13:51:54 +0100] rev 16236
8007990: No access to interface methods on a restricted class Reviewed-by: jlaskey, lagergren, sundar
Thu, 14 Feb 2013 13:52:12 +0100 8008206: The allInteger case for SwitchNode generation in CodeGenerator assumes integer LITERALS only.
lagergren [Thu, 14 Feb 2013 13:52:12 +0100] rev 16235
8008206: The allInteger case for SwitchNode generation in CodeGenerator assumes integer LITERALS only. Reviewed-by: sundar, jlaskey
Thu, 14 Feb 2013 13:22:26 +0100 8008085: Integrate Dynalink source code into Nashorn codebase
attila [Thu, 14 Feb 2013 13:22:26 +0100] rev 16234
8008085: Integrate Dynalink source code into Nashorn codebase Reviewed-by: jlaskey, lagergren, sundar
Thu, 14 Feb 2013 13:01:52 +0100 8008199: Lazy compilation and trampoline implementation
lagergren [Thu, 14 Feb 2013 13:01:52 +0100] rev 16233
8008199: Lazy compilation and trampoline implementation Summary: The code pipeline now supports lazy compilation, which can be used to only compile certain FunctionNodes and leave others be, saving startup time. When these uncompiled nodes are hit, a trampoline will force them to be recompiled. This can also be used to specialize compilation fixing parameter types and return types to a callsite specific compilation. This will give performance. Reviewed-by: attila, sundar
Thu, 14 Feb 2013 14:16:58 +0530 8008197: Cross script engine function calls do not work as expected
sundar [Thu, 14 Feb 2013 14:16:58 +0530] rev 16232
8008197: Cross script engine function calls do not work as expected Reviewed-by: lagergren, hannesw
Thu, 14 Feb 2013 09:14:31 +0530 8008193: test262 tests should be run with security manager enabled
sundar [Thu, 14 Feb 2013 09:14:31 +0530] rev 16231
8008193: test262 tests should be run with security manager enabled Reviewed-by: jlaskey
Wed, 13 Feb 2013 19:59:30 +0530 8008103: Source object should maintain URL of the script source as a private field
sundar [Wed, 13 Feb 2013 19:59:30 +0530] rev 16230
8008103: Source object should maintain URL of the script source as a private field Reviewed-by: lagergren, jlaskey
Wed, 13 Feb 2013 13:30:21 +0100 8008096: TokenStream buffer should grow exponentially
hannesw [Wed, 13 Feb 2013 13:30:21 +0100] rev 16229
8008096: TokenStream buffer should grow exponentially Reviewed-by: attila, lagergren, sundar
Tue, 12 Feb 2013 12:47:51 +0100 8007900: Function binding is inefficient
attila [Tue, 12 Feb 2013 12:47:51 +0100] rev 16228
8007900: Function binding is inefficient Reviewed-by: jlaskey, lagergren
Tue, 12 Feb 2013 13:55:05 +0100 8007956: Wrong or obsolete system properties in docs/DEVELOPER_README
hannesw [Tue, 12 Feb 2013 13:55:05 +0100] rev 16227
8007956: Wrong or obsolete system properties in docs/DEVELOPER_README Reviewed-by: attila, jlaskey
Mon, 11 Feb 2013 21:26:06 +0530 8007915: Nashorn IR, codegen, parser packages and Context instance should be inaccessible to user code
sundar [Mon, 11 Feb 2013 21:26:06 +0530] rev 16226
8007915: Nashorn IR, codegen, parser packages and Context instance should be inaccessible to user code Reviewed-by: lagergren, jlaskey, attila
Sat, 09 Feb 2013 16:58:48 +0100 8006943: Fix order of function method arguments to be (callee, thisObject)
attila [Sat, 09 Feb 2013 16:58:48 +0100] rev 16225
8006943: Fix order of function method arguments to be (callee, thisObject) Reviewed-by: jlaskey, lagergren
Fri, 08 Feb 2013 09:19:38 -0400 8006222: Move slot from SpillProperty to Property
jlaskey [Fri, 08 Feb 2013 09:19:38 -0400] rev 16224
8006222: Move slot from SpillProperty to Property Reviewed-by: hannesw, lagergren Contributed-by: james.laskey@oracle.com
Thu, 07 Feb 2013 15:33:17 +0100 8007718: Make static RegExp properties fully compatible to other engines
hannesw [Thu, 07 Feb 2013 15:33:17 +0100] rev 16223
8007718: Make static RegExp properties fully compatible to other engines Reviewed-by: lagergren, sundar
Thu, 07 Feb 2013 14:58:41 +0100 8007627: Support @Getter annotation on constructor
hannesw [Thu, 07 Feb 2013 14:58:41 +0100] rev 16222
8007627: Support @Getter annotation on constructor Reviewed-by: attila, lagergren
Thu, 07 Feb 2013 17:17:29 +0530 8007715: Make sure that not all tests run with AllPermission
sundar [Thu, 07 Feb 2013 17:17:29 +0530] rev 16221
8007715: Make sure that not all tests run with AllPermission Reviewed-by: lagergren, attila
Wed, 06 Feb 2013 12:51:09 -0400 8007643: Add testing for quit and exit
jlaskey [Wed, 06 Feb 2013 12:51:09 -0400] rev 16220
8007643: Add testing for quit and exit Reviewed-by: sundar Contributed-by: james.laskey@oracle.com
Wed, 06 Feb 2013 11:57:51 -0400 8007629: Remove extraneous quit from shell.js
jlaskey [Wed, 06 Feb 2013 11:57:51 -0400] rev 16219
8007629: Remove extraneous quit from shell.js Reviewed-by: sundar, hannesw Contributed-by: james.laskey@oracle.com
Wed, 06 Feb 2013 08:42:19 -0400 8007545: jjs input evalinput need to be NOT_ENUMERABLE
jlaskey [Wed, 06 Feb 2013 08:42:19 -0400] rev 16218
8007545: jjs input evalinput need to be NOT_ENUMERABLE Reviewed-by: sundar, lagergren Contributed-by: james.laskey@oracle.com
Wed, 06 Feb 2013 17:56:12 +0530 8007619: Add support for deprecated properties of RegExp constructor
sundar [Wed, 06 Feb 2013 17:56:12 +0530] rev 16217
8007619: Add support for deprecated properties of RegExp constructor Reviewed-by: lagergren, hannesw
Wed, 06 Feb 2013 10:31:58 +0100 8007273: Creation of ScriptFunctions can be refactored
hannesw [Wed, 06 Feb 2013 10:31:58 +0100] rev 16216
8007273: Creation of ScriptFunctions can be refactored Reviewed-by: lagergren, attila
Tue, 05 Feb 2013 22:07:04 +0530 8007523: VerifyError on script that uses regular expression literals with ternary operator
sundar [Tue, 05 Feb 2013 22:07:04 +0530] rev 16215
8007523: VerifyError on script that uses regular expression literals with ternary operator Reviewed-by: lagergren
Tue, 05 Feb 2013 21:00:04 +0530 8007522: IllegalStateException thrown from String.prototype.search function
sundar [Tue, 05 Feb 2013 21:00:04 +0530] rev 16214
8007522: IllegalStateException thrown from String.prototype.search function Reviewed-by: jlaskey
Tue, 05 Feb 2013 18:44:54 +0530 8007521: $ENV should be undefined when security manager is present
sundar [Tue, 05 Feb 2013 18:44:54 +0530] rev 16213
8007521: $ENV should be undefined when security manager is present Reviewed-by: hannesw, jlaskey
Tue, 05 Feb 2013 09:11:03 +0530 8007452: add scripting programmers doc changes for nashorn
sundar [Tue, 05 Feb 2013 09:11:03 +0530] rev 16212
8007452: add scripting programmers doc changes for nashorn Reviewed-by: jlaskey, hannesw
Mon, 04 Feb 2013 14:48:35 -0400 8006191: `cmd` -> exec("cmd") in script mode
jlaskey [Mon, 04 Feb 2013 14:48:35 -0400] rev 16211
8006191: `cmd` -> exec("cmd") in script mode Reviewed-by: sundar, lagergren, hannesw Contributed-by: james.laskey@oracle.com
Mon, 04 Feb 2013 16:20:05 +0100 8007215: Varargs broken for the case of passing more than the arg limit arguments.
lagergren [Mon, 04 Feb 2013 16:20:05 +0100] rev 16210
8007215: Varargs broken for the case of passing more than the arg limit arguments. Reviewed-by: jlaskey, attila
Mon, 04 Feb 2013 15:59:44 +0100 8007460: var assignment to a parameter in a varargs method causes compilation error
attila [Mon, 04 Feb 2013 15:59:44 +0100] rev 16209
8007460: var assignment to a parameter in a varargs method causes compilation error Reviewed-by: jlaskey, lagergren
Mon, 04 Feb 2013 08:13:05 -0400 8007455: Extraneous $(ECHO) in make/Makefile
jlaskey [Mon, 04 Feb 2013 08:13:05 -0400] rev 16208
8007455: Extraneous $(ECHO) in make/Makefile Reviewed-by: sundar Contributed-by: james.laskey@oracle.com
Fri, 01 Feb 2013 02:24:15 +0100 8007060: Primitive wrap filter throws ClassCastException in test262parallel
hannesw [Fri, 01 Feb 2013 02:24:15 +0100] rev 16207
8007060: Primitive wrap filter throws ClassCastException in test262parallel Reviewed-by: sundar, jlaskey, lagergren
Thu, 31 Jan 2013 18:34:42 +0100 8006529: Methods always get callee - it should be conditional
attila [Thu, 31 Jan 2013 18:34:42 +0100] rev 16206
8006529: Methods always get callee - it should be conditional Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145. Reviewed-by: jlaskey, lagergren
Thu, 31 Jan 2013 20:07:40 +0530 8007286: Add JavaAdapter and importPackage to compatibility script
sundar [Thu, 31 Jan 2013 20:07:40 +0530] rev 16205
8007286: Add JavaAdapter and importPackage to compatibility script Reviewed-by: lagergren, jlaskey
Wed, 30 Jan 2013 21:15:14 +0530 8007140: Java.extend crashes when attempting to extend java.lang.Object
sundar [Wed, 30 Jan 2013 21:15:14 +0530] rev 16204
8007140: Java.extend crashes when attempting to extend java.lang.Object Reviewed-by: lagergren, hannesw
Wed, 30 Jan 2013 14:57:19 +0100 8007109: Regression: String(ConsString) does not flatten argument to String
hannesw [Wed, 30 Jan 2013 14:57:19 +0100] rev 16203
8007109: Regression: String(ConsString) does not flatten argument to String Reviewed-by: sundar, lagergren
Wed, 30 Jan 2013 17:52:54 +0530 8007132: Java objects returned from constructor functions are lost
sundar [Wed, 30 Jan 2013 17:52:54 +0530] rev 16202
8007132: Java objects returned from constructor functions are lost Reviewed-by: hannesw, lagergren, attila
Wed, 30 Jan 2013 12:26:45 +0100 8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes.
lagergren [Wed, 30 Jan 2013 12:26:45 +0100] rev 16201
8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes. Summary: Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate tiers. In the process I have also fixed: (1) problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) (2) copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied (3) erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) (4) splitter weighnodes - unary nodes were considered weightless (4) removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) (5) duplicate line number issues in the parser (6) convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/basic/access-specializer.js) ... Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased. Reviewed-by: jlaskey, attila
(0) -10000 -3000 -1000 -300 -100 -56 +56 +100 +300 +1000 +3000 +10000 +30000 tip