lagergren [Wed, 30 Jan 2013 12:26:45 +0100] rev 16201
8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes.
Summary: Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate tiers. In the process I have also fixed: (1) problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) (2) copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied (3) erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) (4) splitter weighnodes - unary nodes were considered weightless (4) removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) (5) duplicate line number issues in the parser (6) convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/basic/access-specializer.js) ... Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased.
Reviewed-by: jlaskey, attila
jlaskey [Tue, 29 Jan 2013 14:25:39 -0400] rev 16200
8007094: Apply version to nashorn.jar manifest
Reviewed-by: sundar
Contributed-by: james.laskey@oracle.com
sundar [Tue, 29 Jan 2013 19:57:25 +0530] rev 16199
8007091: Provide private API to pass application class loader for nashorn script engine
Reviewed-by: jlaskey, lagergren
jlaskey [Mon, 28 Jan 2013 16:22:03 -0400] rev 16198
8006676: Integrate Nashorn into new build system
Reviewed-by: jlaskey
Contributed-by: james.laskey@oracle.com
sundar [Mon, 28 Jan 2013 21:29:05 +0530] rev 16197
8007004: nashorn script engine should not use thread context class loader as script 'application loader'
Reviewed-by: attila, hannesw
sundar [Mon, 28 Jan 2013 18:10:16 +0530] rev 16196
8006983: Introduce a command line option to switch off syntactic extensions of nashorn
Reviewed-by: lagergren, attila
hannesw [Fri, 25 Jan 2013 17:35:31 +0100] rev 16195
8006766: Array-like access to characters of a string is slow
Reviewed-by: lagergren, attila
sundar [Thu, 24 Jan 2013 22:38:58 +0530] rev 16194
8006857: ClassCastException when interface implementing function uses arguments object
Reviewed-by: jlaskey, lagergren
jlaskey [Thu, 24 Jan 2013 12:15:29 -0400] rev 16193
8006852: Move tests from JIRA for prepopulated map failures
Reviewed-by: sundar
Contributed-by: james.laskey@oracle.com
hannesw [Thu, 24 Jan 2013 14:55:57 +0100] rev 16192
8006408: Clean up and specialize NativeString
Reviewed-by: jlaskey, lagergren
sundar [Thu, 24 Jan 2013 17:49:03 +0530] rev 16191
8006755: Functions inside with statements dont get correct scope
Reviewed-by: lagergren, attila
sundar [Thu, 24 Jan 2013 16:21:32 +0530] rev 16190
8006575: Error in codegen for element access on primitive value
Reviewed-by: hannesw, lagergren
sundar [Wed, 23 Jan 2013 17:04:02 +0530] rev 16189
8006736: nashorn script engine should support the usage multiple global objects with same engine instance
Reviewed-by: lagergren, jlaskey, hannesw
sundar [Tue, 22 Jan 2013 22:07:12 +0530] rev 16188
8006678: Avoid too many Context.getGlobal() calls
Reviewed-by: lagergren, jlaskey
attila [Tue, 22 Jan 2013 14:36:28 +0100] rev 16187
8006677: Remove unused FunctionNode flags
Reviewed-by: hannesw, jlaskey
hannesw [Tue, 22 Jan 2013 14:14:37 +0100] rev 16186
8006570: This-value for non-strict functions should be converted to object
Reviewed-by: jlaskey, lagergren, attila
sundar [Mon, 21 Jan 2013 21:17:38 +0530] rev 16185
8006635: Reduce access levels as much as possible
Reviewed-by: jlaskey, lagergren, attila
attila [Mon, 21 Jan 2013 11:03:56 +0100] rev 16184
8006525: Give StaticClass objects their own linker
Reviewed-by: hannesw, lagergren
sundar [Sat, 19 Jan 2013 22:35:43 +0530] rev 16183
8006557: JDK8/Lambda build clashes on Map.replace()
Reviewed-by: jlaskey
sundar [Sat, 19 Jan 2013 09:14:43 +0530] rev 16182
8006584: improve variable handling in NashornScriptEngine
Reviewed-by: jlaskey, hannesw
sundar [Fri, 18 Jan 2013 17:55:04 +0530] rev 16181
8006562: findOwnMH in nashorn "objects" package should be cleaned up
Reviewed-by: jlaskey, lagergren
sundar [Fri, 18 Jan 2013 08:45:06 +0530] rev 16180
8006527: nashorn jsr223 engine does not work in sandbox
Reviewed-by: jlaskey, attila, lagergren
jlaskey [Thu, 17 Jan 2013 10:33:39 -0400] rev 16179
8006517: PropertyHashMap.Element.equals() compares to Property
Reviewed-by: sundar
Contributed-by: james.laskey@oracle.com
sundar [Wed, 16 Jan 2013 21:26:55 +0530] rev 16178
8006424: Passing null or undefined to adapter class constructors results in NPE or ClassCastException
Reviewed-by: attila, hannesw, jlaskey
sundar [Wed, 16 Jan 2013 17:58:51 +0530] rev 16177
8006412: Improve toString method of ScriptObjectMirror class
Reviewed-by: jlaskey, lagergren
jlaskey [Wed, 16 Jan 2013 07:06:40 -0400] rev 16176
8006304: Remove pre-population of maps for constructor produced maps
Reviewed-by: sundar
Contributed-by: james.laskey@oracle.com
attila [Tue, 15 Jan 2013 18:08:50 +0100] rev 16175
8006337: Discarded arguments for INVOKESTATIC must still be evaluated for side effects
Reviewed-by: hannesw, jlaskey, sundar
attila [Tue, 15 Jan 2013 17:09:44 +0100] rev 16174
8005958: invoking a function through INVOKESTATIC with more arguments than it declares resulted in malformed bytecode being generated
Reviewed-by: lagergren, jlaskey
attila [Tue, 15 Jan 2013 13:10:20 +0100] rev 16173
8006293: Reduce ScriptObject.findCallMethodMethod
Reviewed-by: lagergren, jlaskey
sundar [Mon, 14 Jan 2013 21:30:13 +0530] rev 16172
8006181: nashorn script engine does not run jrunscript's initialization script
Reviewed-by: lagergren, jlaskey
Contributed-by: rieberandreas@gmail.com
attila [Mon, 14 Jan 2013 16:00:55 +0100] rev 16171
8006168: ability to generate multi-type Java adapters
Reviewed-by: lagergren, jlaskey
sundar [Fri, 11 Jan 2013 20:34:22 +0530] rev 16170
8006093: Add a makefile target to run all tests (test, test262, perf tests)
Reviewed-by: attila, hannesw
sundar [Fri, 11 Jan 2013 18:26:18 +0530] rev 16169
8006082: Provide option to run octane benchmarks in separate processes
Reviewed-by: lagergren, jlaskey
lagergren [Fri, 11 Jan 2013 10:40:51 +0100] rev 16168
8005976: Break out AccessSpecializer into one pass before CodeGenerator instead of iterative applications from CodeGenerator
Summary: Now scope and slot information is guaranteed to be fixed AND NOT CHANGE before CodeGeneration. We want to keep it that way to build future type specializations and bring all type work out of CodeGenerator.
Reviewed-by: attila, hannesw
attila [Thu, 10 Jan 2013 15:28:05 +0100] rev 16167
8005983: JavaAdapterFactory generated proxy classes should take extra constructor arguments at the end
Reviewed-by: lagergren, sundar
sundar [Thu, 10 Jan 2013 19:55:38 +0530] rev 16166
8005982: NASHORN-71.js failing in nightlys
Reviewed-by: attila, lagergren, jlaskey
sundar [Thu, 10 Jan 2013 19:03:25 +0530] rev 16165
8005987: ant octane tries to run non-benchmark scripts
Reviewed-by: lagergren, attila, jlaskey
lagergren [Thu, 10 Jan 2013 10:28:57 +0100] rev 16164
8005971: runsunspider.js should check results of benchmarks
Reviewed-by: attila, hannesw
sundar [Wed, 09 Jan 2013 22:32:40 +0530] rev 16163
8005940: provide ant targets to get and update external test scripts
Reviewed-by: jlaskey, lagergren
attila [Wed, 09 Jan 2013 15:02:48 +0100] rev 16162
8005777: Bug in the FacetIntrospector of Dynalink - non-public class should search super
Reviewed-by: lagergren, sundar
sundar [Tue, 08 Jan 2013 21:16:07 +0530] rev 16161
8005848: assigning to global toString variable affects Object.prototype.toString
Reviewed-by: jlaskey, lagergren
lagergren [Tue, 08 Jan 2013 15:20:40 +0100] rev 16160
8005842: Loops in ASTWriter. Corrected @Reference and @Ignore node annotation for IR nodes
Reviewed-by: hannesw, sundar
attila [Tue, 08 Jan 2013 14:14:17 +0100] rev 16159
8005801: Refactor findSetMethod
Summary: findSetMethod() was a very large single method, very unreadable and unmaintainable. It was broken into easy-to-understand pieces. The refactoring required introduction of a comand-object like entity, SetMethodCreator, to contain the nontrivial transient state of the algorithm that made the original big method so resistant to refactoring in the first place.
Reviewed-by: lagergren, sundar
attila [Tue, 08 Jan 2013 13:50:11 +0100] rev 16158
8005846: Remove Mangler in favor of Dynalink's NameCodec
Reviewed-by: jlaskey, sundar
lagergren [Tue, 08 Jan 2013 10:52:11 +0100] rev 16157
8005843: refSymbols lookup of unbound variable could cause NullPointerException in Lower
Reviewed-by: hannesw, attila
sundar [Tue, 08 Jan 2013 15:02:36 +0530] rev 16156
8005835: NASHORN-668 output fails to compare with the corresponding .EXPECTED file
Reviewed-by: lagergren, hannesw
lagergren [Tue, 08 Jan 2013 09:59:28 +0100] rev 16155
8005788: Loggers and their corresponding system properties not working correctly
Summary: 1-1 mapping now maintained. Used Context err instead of System.err in several places (after bootstrapping Context). Problematic closing of err stream replaced by @SuppressWarnings("resource")
Reviewed-by: jlaskey, sundar
sundar [Tue, 08 Jan 2013 08:51:00 +0530] rev 16154
8005782: get rid of javadoc errors, warnings in nashorn build
Reviewed-by: lagergren