lagergren [Wed, 30 Jan 2013 12:26:45 +0100] rev 16201
8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes.
Summary: Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate tiers. In the process I have also fixed: (1) problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) (2) copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied (3) erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) (4) splitter weighnodes - unary nodes were considered weightless (4) removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) (5) duplicate line number issues in the parser (6) convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/basic/access-specializer.js) ... Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased.
Reviewed-by: jlaskey, attila
jlaskey [Tue, 29 Jan 2013 14:25:39 -0400] rev 16200
8007094: Apply version to nashorn.jar manifest
Reviewed-by: sundar
Contributed-by: james.laskey@oracle.com
sundar [Tue, 29 Jan 2013 19:57:25 +0530] rev 16199
8007091: Provide private API to pass application class loader for nashorn script engine
Reviewed-by: jlaskey, lagergren
jlaskey [Mon, 28 Jan 2013 16:22:03 -0400] rev 16198
8006676: Integrate Nashorn into new build system
Reviewed-by: jlaskey
Contributed-by: james.laskey@oracle.com
sundar [Mon, 28 Jan 2013 21:29:05 +0530] rev 16197
8007004: nashorn script engine should not use thread context class loader as script 'application loader'
Reviewed-by: attila, hannesw
sundar [Mon, 28 Jan 2013 18:10:16 +0530] rev 16196
8006983: Introduce a command line option to switch off syntactic extensions of nashorn
Reviewed-by: lagergren, attila
hannesw [Fri, 25 Jan 2013 17:35:31 +0100] rev 16195
8006766: Array-like access to characters of a string is slow
Reviewed-by: lagergren, attila
sundar [Thu, 24 Jan 2013 22:38:58 +0530] rev 16194
8006857: ClassCastException when interface implementing function uses arguments object
Reviewed-by: jlaskey, lagergren
jlaskey [Thu, 24 Jan 2013 12:15:29 -0400] rev 16193
8006852: Move tests from JIRA for prepopulated map failures
Reviewed-by: sundar
Contributed-by: james.laskey@oracle.com
hannesw [Thu, 24 Jan 2013 14:55:57 +0100] rev 16192
8006408: Clean up and specialize NativeString
Reviewed-by: jlaskey, lagergren