2017-10-31 8189800: Add support for AddressSanitizer
asmotrak [Tue, 31 Oct 2017 17:03:02 +0300] rev 47479
8189800: Add support for AddressSanitizer Reviewed-by: ihse, dholmes
2017-10-31 8190382: fix small typographic errors in comments
smarks [Mon, 30 Oct 2017 17:49:33 -0700] rev 47478
8190382: fix small typographic errors in comments Reviewed-by: martin Contributed-by: christoph.dreis@freenet.de
2017-10-31 8181155: Fix lint warnings in JAXP repo: fallthrough and static
joehw [Mon, 30 Oct 2017 17:32:38 -0700] rev 47477
8181155: Fix lint warnings in JAXP repo: fallthrough and static Reviewed-by: lancea, rriggs
2017-10-30 8189319: Add a java.util.Properties constructor that takes an initial capacity
bchristi [Mon, 30 Oct 2017 16:16:01 -0700] rev 47476
8189319: Add a java.util.Properties constructor that takes an initial capacity Reviewed-by: martin, mchung, rriggs
2017-10-30 8129077: Unfix JDK-8087205
ksrini [Mon, 30 Oct 2017 07:06:49 -0700] rev 47475
8129077: Unfix JDK-8087205 Reviewed-by: jlahoda, mcimadamore, vromero
2017-10-30 8175252: Backout changeset for JDK-8176354 due to JDK-8190333
jjiang [Mon, 30 Oct 2017 03:52:38 -0700] rev 47474
8175252: Backout changeset for JDK-8176354 due to JDK-8190333 Summary: Backout changeset for JDK-8176354 Reviewed-by: asmotrak
2017-10-30 8185841: Values from getFirstDayOfWeek() are inconsistent with CLDR
rgoel [Mon, 30 Oct 2017 12:16:37 +0530] rev 47473
8185841: Values from getFirstDayOfWeek() are inconsistent with CLDR Reviewed-by: naoto
2017-10-29 8180310: TestSocketFactory null pointer when updating match bytes
rriggs [Sun, 29 Oct 2017 18:31:55 -0400] rev 47472
8180310: TestSocketFactory null pointer when updating match bytes Reviewed-by: dfuchs
2017-10-29 8190323: "the the" typos
rriggs [Sun, 29 Oct 2017 18:20:53 -0400] rev 47471
8190323: "the the" typos Reviewed-by: rriggs Contributed-by: christoph.dreis@freenet.de
2017-10-27 8176354: sun/security/ssl/X509KeyManager/PreferredKey.java failed with "Failed to get the preferable key aliases" erro
amjiang [Fri, 27 Oct 2017 09:51:48 -0700] rev 47470
8176354: sun/security/ssl/X509KeyManager/PreferredKey.java failed with "Failed to get the preferable key aliases" erro Reviewed-by: xuelei
2017-10-27 8180289: jarsigner treats timestamped signed jar invalid after the signer cert expires
weijun [Fri, 27 Oct 2017 21:11:15 +0800] rev 47469
8180289: jarsigner treats timestamped signed jar invalid after the signer cert expires Reviewed-by: mullan
2017-10-27 8159535: Mark deprecated javax.security.auth.Policy API with forRemoval=true
weijun [Fri, 27 Oct 2017 21:10:56 +0800] rev 47468
8159535: Mark deprecated javax.security.auth.Policy API with forRemoval=true Reviewed-by: mullan
2017-10-27 Merge
lana [Fri, 27 Oct 2017 08:32:45 +0000] rev 47467
Merge
2017-10-27 Added tag jdk-10+29 for changeset a6e591e12f12
lana [Fri, 27 Oct 2017 08:31:20 +0000] rev 47466
Added tag jdk-10+29 for changeset a6e591e12f12
2017-10-27 8183896: improve analyzers to allow for the generation of multiple mutations of the same tree
vromero [Thu, 26 Oct 2017 22:54:25 -0400] rev 47465
8183896: improve analyzers to allow for the generation of multiple mutations of the same tree Reviewed-by: mcimadamore, jlahoda
2017-10-27 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing
sundar [Fri, 27 Oct 2017 08:21:53 +0530] rev 47464
8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing Reviewed-by: alanb, mchung
2017-10-27 8189952: New methods on String: chars() and codePoints() should be marked since 9
darcy [Thu, 26 Oct 2017 18:04:29 -0700] rev 47463
8189952: New methods on String: chars() and codePoints() should be marked since 9 Reviewed-by: bpb
2017-10-27 8172818: Add since=9 deprecation information to javax.lang.model classes
darcy [Thu, 26 Oct 2017 17:06:52 -0700] rev 47462
8172818: Add since=9 deprecation information to javax.lang.model classes Reviewed-by: vromero
2017-10-26 8187089: StringConcatFactory.makeConcat & makeConcatWithConstants should throw StringConcatException if parameter slot count is over 200
mchung [Thu, 26 Oct 2017 16:57:35 -0700] rev 47461
8187089: StringConcatFactory.makeConcat & makeConcatWithConstants should throw StringConcatException if parameter slot count is over 200 Reviewed-by: rriggs, shade
2017-10-26 8189963: Remove version of FileChannelImpl::open without the 'direct' parameter
bpb [Thu, 26 Oct 2017 11:08:31 -0700] rev 47460
8189963: Remove version of FileChannelImpl::open without the 'direct' parameter Summary: Remove old version of FileChannelImpl::open and update call sites Reviewed-by: rriggs
2017-10-26 8189919: Update link to license in Docs.gmk jdk-10+29
iris [Thu, 26 Oct 2017 10:46:29 -0700] rev 47459
8189919: Update link to license in Docs.gmk Reviewed-by: mr
2017-10-26 8189838: Stack overflow when computing upward projection of an intersection type with fbounds
mcimadamore [Thu, 26 Oct 2017 18:42:40 +0100] rev 47458
8189838: Stack overflow when computing upward projection of an intersection type with fbounds Summary: Bad logic for detecting loop in type-variable upper bounds Reviewed-by: vromero
2017-10-26 8190217: Add a JS "static checker" sample for nashorn parser API
sundar [Thu, 26 Oct 2017 20:57:19 +0530] rev 47457
8190217: Add a JS "static checker" sample for nashorn parser API Reviewed-by: jlaskey
2017-10-26 8189955: Configuration validation is broken for some types of paths
ihse [Thu, 26 Oct 2017 13:20:47 +0200] rev 47456
8189955: Configuration validation is broken for some types of paths Reviewed-by: erikj
2017-10-26 8189376: Unsorted $(wildcard) causes instable module-deps.gmk
ihse [Thu, 26 Oct 2017 10:39:59 +0200] rev 47455
8189376: Unsorted $(wildcard) causes instable module-deps.gmk Reviewed-by: erikj, tbell Contributed-by: Martin Buchholz <martinrb@google.com>
2017-10-26 8189618: [aix] No jre image is created during images step
mbaesken [Thu, 26 Oct 2017 08:52:55 +0200] rev 47454
8189618: [aix] No jre image is created during images step Reviewed-by: erikj, stuefe
2017-10-26 8189845: Fix for 8157000 causes significant performance regression
ksrini [Wed, 25 Oct 2017 21:19:38 -0700] rev 47453
8189845: Fix for 8157000 causes significant performance regression Reviewed-by: jjg
2017-10-26 8190003: Special characters in group names should be escaped
jjg [Wed, 25 Oct 2017 18:12:15 -0700] rev 47452
8190003: Special characters in group names should be escaped Reviewed-by: ksrini, bpatel
2017-10-26 8190182: remove accidental file.
jjg [Wed, 25 Oct 2017 17:48:30 -0700] rev 47451
8190182: remove accidental file. Reviewed-by: ksrini
2017-10-26 8189843: Missing \"id\" attributes in table rows
jjg [Wed, 25 Oct 2017 17:18:00 -0700] rev 47450
8189843: Missing \"id\" attributes in table rows Reviewed-by: bpatel, ksrini
2017-10-26 8189841: Error in alternate row coloring in package-summary files
jjg [Wed, 25 Oct 2017 17:16:18 -0700] rev 47449
8189841: Error in alternate row coloring in package-summary files Reviewed-by: bpatel, ksrini
2017-10-25 8189775: java/nio/channels/FileChannel/directio/ReadDirect.java failed with NumberFormatException
bpb [Wed, 25 Oct 2017 16:13:53 -0700] rev 47448
8189775: java/nio/channels/FileChannel/directio/ReadDirect.java failed with NumberFormatException Summary: Clamp the offset so the scattering read remains within the channel. Reviewed-by: rriggs
2017-10-25 8183037: Overview summary page should have a table with tabs for groups
bpatel [Wed, 25 Oct 2017 12:29:00 -0700] rev 47447
8183037: Overview summary page should have a table with tabs for groups Reviewed-by: jjg, ksrini
2017-10-25 8062385: Remove @SuppressWarnings("cast") and casts for NIO related usages when JDK 9 becomes the bootstrap JDK
darcy [Wed, 25 Oct 2017 10:40:45 -0700] rev 47446
8062385: Remove @SuppressWarnings("cast") and casts for NIO related usages when JDK 9 becomes the bootstrap JDK Reviewed-by: mcimadamore
2017-10-17 8189431: Netbeans nb_native project needs to be adapted to new repo structure
stuefe [Tue, 17 Oct 2017 12:17:17 +0200] rev 47445
8189431: Netbeans nb_native project needs to be adapted to new repo structure Reviewed-by: ihse
2017-10-25 8183901: Fix broken links to "Package Sealing" in the JAR spec
bchristi [Wed, 25 Oct 2017 09:06:39 -0700] rev 47444
8183901: Fix broken links to "Package Sealing" in the JAR spec Reviewed-by: alanb, mchung
2017-10-25 8176891: Fix lint warnings in JAXP repo: serial
joehw [Tue, 24 Oct 2017 19:05:29 -0700] rev 47443
8176891: Fix lint warnings in JAXP repo: serial Reviewed-by: lancea
2017-10-24 8189272: CLDR and JRE LocaleProviderAdapters silently swallow exceptions
naoto [Tue, 24 Oct 2017 08:56:47 -0700] rev 47442
8189272: CLDR and JRE LocaleProviderAdapters silently swallow exceptions Reviewed-by: mchung
2017-10-24 8189291: Test policy should extend the default system policy
naoto [Tue, 24 Oct 2017 08:56:30 -0700] rev 47441
8189291: Test policy should extend the default system policy Reviewed-by: mchung
2017-10-24 8189682: JDK demos/tests should be in a separate bundle than hotspot ones
erikj [Tue, 24 Oct 2017 15:36:56 +0200] rev 47440
8189682: JDK demos/tests should be in a separate bundle than hotspot ones Reviewed-by: prr, ihse
2017-10-24 8189796: Incorrect end position for missing statement
jlahoda [Tue, 24 Oct 2017 12:07:27 +0200] rev 47439
8189796: Incorrect end position for missing statement Summary: Recording end positions for error trees representing missing statements. Reviewed-by: mcimadamore Contributed-by: dusan.balek@oracle.com, jan.lahoda@oracle.com
2017-10-23 8187247: canonical import check compares classes by simple name
cushon [Mon, 23 Oct 2017 14:11:04 +0200] rev 47438
8187247: canonical import check compares classes by simple name Reviewed-by: jlahoda
2017-10-23 8165198: Inconsistent values with JavaImporter after accessing undefined variable
hannesw [Mon, 23 Oct 2017 13:03:01 +0200] rev 47437
8165198: Inconsistent values with JavaImporter after accessing undefined variable Reviewed-by: sundar, hannesw Contributed-by: priya.lakshmi.muthuswamy@oracle.com
2017-10-23 8189266: (ann) Optimize AnnotationInvocationHandler.invoke
redestad [Mon, 23 Oct 2017 11:33:16 +0200] rev 47436
8189266: (ann) Optimize AnnotationInvocationHandler.invoke Reviewed-by: jfranck, plevart Contributed-by: christoph.dreis@freenet.de
2017-10-23 8187974: Merge Java Mission Control 6.1 3rdpartyreame with the JDK 18.3 3rdpartyreadme
erikj [Mon, 23 Oct 2017 10:43:45 +0200] rev 47435
8187974: Merge Java Mission Control 6.1 3rdpartyreame with the JDK 18.3 3rdpartyreadme Reviewed-by: ihse
2017-10-23 8189664: Stop producing ARCHIVE_BUNDLE.zip from test makefiles unless asked to
erikj [Mon, 23 Oct 2017 10:41:34 +0200] rev 47434
8189664: Stop producing ARCHIVE_BUNDLE.zip from test makefiles unless asked to Reviewed-by: ihse
2017-10-23 8189119: Devkit for Linux needs to include fontconfig-devel
erikj [Mon, 23 Oct 2017 10:39:11 +0200] rev 47433
8189119: Devkit for Linux needs to include fontconfig-devel Reviewed-by: ihse
2017-10-23 8189056: javadoc target for stable specdiff comparisons
ihse [Mon, 23 Oct 2017 10:21:13 +0200] rev 47432
8189056: javadoc target for stable specdiff comparisons Reviewed-by: erikj
2017-10-21 Merge
lana [Sat, 21 Oct 2017 00:06:31 +0000] rev 47431
Merge
2017-10-21 Added tag jdk-10+28 for changeset 92f08900cb3c
lana [Sat, 21 Oct 2017 00:04:45 +0000] rev 47430
Added tag jdk-10+28 for changeset 92f08900cb3c
2017-10-20 8189706: javadoc for the JDK APIs should summarize overridden methods with no specification changes
ksrini [Fri, 20 Oct 2017 11:42:36 -0700] rev 47429
8189706: javadoc for the JDK APIs should summarize overridden methods with no specification changes Reviewed-by: jjg, mchung, tbell
2017-10-17 8164900: Add support for O_DIRECT
bpb [Tue, 17 Oct 2017 16:51:11 -0700] rev 47428
8164900: Add support for O_DIRECT Summary: Add support for Direct I/O in FileChannel Reviewed-by: alanb, bpb, alanbur, coffeys, aph, clanger, plevart, mli, psandoz, simonis Contributed-by: Lucy Lu <yingqi.lu@intel.com>, Volker Simonis <volker.simonis@gmail.com>
2017-10-20 8189405: More cleanup in HtmlWriter
jjg [Fri, 20 Oct 2017 11:08:18 -0700] rev 47427
8189405: More cleanup in HtmlWriter Reviewed-by: bpatel, ksrini
2017-10-20 Merge
henryjen [Fri, 20 Oct 2017 09:49:02 -0700] rev 47426
Merge
2017-09-14 8187556: Backout of a fix reintroduced a dependency that had since been removed
jwilhelm [Thu, 14 Sep 2017 22:57:36 +0200] rev 47425
8187556: Backout of a fix reintroduced a dependency that had since been removed Reviewed-by: duke
2017-08-14 8184937: LCMS error 13: Couldn't link the profiles
rpatil [Mon, 14 Aug 2017 15:32:25 +0530] rev 47424
8184937: LCMS error 13: Couldn't link the profiles Reviewed-by: prr Contributed-by: sreeprakash.s@oracle.com
2017-08-02 8174109: Better queuing priorities
smarks [Wed, 02 Aug 2017 10:34:35 -0700] rev 47423
8174109: Better queuing priorities Reviewed-by: chegar, dfuchs, rriggs, alanb, robm, rhalade, jeff, ahgross
2017-07-26 8181612: More stable connection processing
prappo [Wed, 26 Jul 2017 17:44:06 +0100] rev 47422
8181612: More stable connection processing Reviewed-by: chegar, coffeys, ahgross, joehw, rhalade
2017-07-13 8181048: Refactor existing providers to refer to the same constants for default values for key length
valeriep [Thu, 13 Jul 2017 20:41:59 +0000] rev 47421
8181048: Refactor existing providers to refer to the same constants for default values for key length Reviewed-by: mullan, ahgross
2017-07-12 8182879: Add warnings to keytool when using JKS and JCEKS
weijun [Wed, 12 Jul 2017 10:55:40 +0800] rev 47420
8182879: Add warnings to keytool when using JKS and JCEKS Reviewed-by: vinnie, ahgross, mullan
2017-07-06 8183028: Improve CMS header processing
prr [Thu, 06 Jul 2017 09:43:27 -0700] rev 47419
8183028: Improve CMS header processing Reviewed-by: serb, rhalade, mschoene
2017-07-06 8181432: Better processing of unresolved permissions
weijun [Thu, 06 Jul 2017 09:20:21 +0800] rev 47418
8181432: Better processing of unresolved permissions Reviewed-by: mullan
2017-07-05 8181692: Update storage implementations
vinnie [Wed, 05 Jul 2017 17:27:46 +0100] rev 47417
8181692: Update storage implementations Reviewed-by: weijun, igerasim
2017-06-28 8181370: Better keystore handling
vinnie [Wed, 28 Jun 2017 16:52:36 +0100] rev 47416
8181370: Better keystore handling Reviewed-by: weijun, igerasim
2017-06-19 8181597: Process Proxy presentation
rriggs [Mon, 19 Jun 2017 17:38:33 -0400] rev 47415
8181597: Process Proxy presentation Reviewed-by: dfuchs, ahgross, rhalade, skoivu
2017-06-15 8181323: Better timezone processing
naoto [Thu, 15 Jun 2017 09:57:15 -0700] rev 47414
8181323: Better timezone processing Reviewed-by: rriggs
2017-05-18 8178714: PKIX validator nameConstraints check failing after change 8175940
weijun [Thu, 18 May 2017 08:52:50 +0800] rev 47413
8178714: PKIX validator nameConstraints check failing after change 8175940 Reviewed-by: mullan, ahgross
2017-03-28 8174966: Unreferenced references
smarks [Tue, 28 Mar 2017 12:10:20 -0700] rev 47412
8174966: Unreferenced references Reviewed-by: rriggs, skoivu, rhalade, robm
2017-03-23 8176751: Better URL connections
dfuchs [Thu, 23 Mar 2017 15:07:26 +0000] rev 47411
8176751: Better URL connections Reviewed-by: chegar, michaelm, rhalade, rpatil, vtewari
2017-03-15 8175940: More certificate subject checking
weijun [Wed, 15 Mar 2017 22:27:12 +0800] rev 47410
8175940: More certificate subject checking Reviewed-by: ahgross, mullan
2017-02-24 8171261: Stability fixes for lcms
prr [Fri, 24 Feb 2017 05:32:16 -0800] rev 47409
8171261: Stability fixes for lcms Reviewed-by: serb, vadim, mschoene
2017-02-23 8170218: Improved Font Metrics
prr [Thu, 23 Feb 2017 03:43:29 -0800] rev 47408
8170218: Improved Font Metrics Reviewed-by: vadim, serb, mschoene
2017-02-22 8171252: Improve exception checking
valeriep [Wed, 22 Feb 2017 00:14:32 +0000] rev 47407
8171252: Improve exception checking Reviewed-by: ascarpino, mschoene
2017-02-20 8169966: Larger AWT menus
serb [Tue, 21 Feb 2017 02:23:00 +0300] rev 47406
8169966: Larger AWT menus Reviewed-by: azvegint, prr, rhalade, mschoene
2016-11-17 8169026: Handle smartcard clean up better
igerasim [Thu, 17 Nov 2016 22:01:02 +0300] rev 47405
8169026: Handle smartcard clean up better Reviewed-by: valeriep, ahgross
2016-10-28 8165543: Better window framing
serb [Fri, 28 Oct 2016 21:33:09 +0300] rev 47404
8165543: Better window framing Reviewed-by: prr, ssadetsky, mschoene
2017-06-19 8181100: Better Base Exceptions
aefimov [Mon, 19 Jun 2017 22:51:35 +0100] rev 47403
8181100: Better Base Exceptions Reviewed-by: dfuchs, rhalade, skoivu Contributed-by: roman.grigoriadi@oracle.com
2017-06-13 8181327: Better X processing
joehw [Tue, 13 Jun 2017 11:13:56 -0700] rev 47402
8181327: Better X processing Reviewed-by: dfuchs, lancea
2017-07-26 8180711: Better invokespecial checks
hseigel [Wed, 26 Jul 2017 11:45:53 -0400] rev 47401
8180711: Better invokespecial checks Reviewed-by: acorn, ahgross, rhalade Contributed-by: harold.seigel@oracle.com
2017-05-19 8180024: Improve construction of objects during deserialization
dfuchs [Fri, 19 May 2017 11:18:49 +0100] rev 47400
8180024: Improve construction of objects during deserialization Reviewed-by: rriggs, skoivu, ahgross, rhalade
2017-10-20 8189671: jlink should clearly report error when an automatic module is used
sundar [Fri, 20 Oct 2017 17:16:05 +0530] rev 47399
8189671: jlink should clearly report error when an automatic module is used Reviewed-by: alanb, mchung
2017-10-20 8182285: Speeding up incremental build by hashing module APIs
erikj [Fri, 20 Oct 2017 13:33:35 +0200] rev 47398
8182285: Speeding up incremental build by hashing module APIs Reviewed-by: ihse Contributed-by: jan.lahoda@oracle.com, erik.joelsson@oracle.com
2017-10-20 8189619: [aix] OpenJDK local disk check not working on AIX
stuefe [Fri, 20 Oct 2017 13:10:35 +0200] rev 47397
8189619: [aix] OpenJDK local disk check not working on AIX Reviewed-by: erikj Contributed-by: sxa@uk.ibm.com
2017-08-31 8186665: [aix] buffer overflow in Java_java_nio_MappedByteBuffer_isLoaded0
stuefe [Thu, 31 Aug 2017 08:45:18 +0200] rev 47396
8186665: [aix] buffer overflow in Java_java_nio_MappedByteBuffer_isLoaded0 Reviewed-by: alanb, plevart, clanger
2017-10-20 8157000: Do not generate javadoc for overridden method with no spec change
ksrini [Thu, 19 Oct 2017 20:27:47 -0700] rev 47395
8157000: Do not generate javadoc for overridden method with no spec change Reviewed-by: jjg
2017-10-19 Merge
prr [Thu, 19 Oct 2017 11:45:23 -0700] rev 47394
Merge
2017-10-19 Merge
prr [Thu, 19 Oct 2017 10:54:40 -0700] rev 47393
Merge
2017-10-19 8163265: [macosx] numpad 0 instead of VK_0
mhalder [Thu, 19 Oct 2017 13:52:37 +0530] rev 47392
8163265: [macosx] numpad 0 instead of VK_0 Reviewed-by: serb, azvegint Contributed-by: manajit.halder@oracle.com
2017-10-19 8075255: Metal L&F has dependency on the Windows L&F
serb [Wed, 18 Oct 2017 22:06:24 -0700] rev 47391
8075255: Metal L&F has dependency on the Windows L&F Reviewed-by: psadhukhan
2017-10-17 Merge
prr [Tue, 17 Oct 2017 14:33:32 -0700] rev 47390
Merge
2017-10-16 8187599: Remove dependency of Building Nimbus L&F on JAXB
ssadetsky [Mon, 16 Oct 2017 08:47:59 -0700] rev 47389
8187599: Remove dependency of Building Nimbus L&F on JAXB Reviewed-by: serb, prr
2017-10-16 8182638: [macosx] Active modal dialog is hidden by another non-active one
ssadetsky [Mon, 16 Oct 2017 08:34:01 -0700] rev 47388
8182638: [macosx] Active modal dialog is hidden by another non-active one Reviewed-by: azvegint, dmarkov
2017-10-16 8180821: [macosx]com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java: The menu item should have been GC-ed
ssadetsky [Mon, 16 Oct 2017 08:06:56 -0700] rev 47387
8180821: [macosx]com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java: The menu item should have been GC-ed Reviewed-by: prr, psadhukhan
2017-10-13 8183978: Remove ICU layout code from OpenJDK
prr [Fri, 13 Oct 2017 08:54:00 -0700] rev 47386
8183978: Remove ICU layout code from OpenJDK Reviewed-by: srl, serb
2017-10-12 6714836: JRootPane.getMaximumSize() returns a width of 0
aghaisas [Thu, 12 Oct 2017 10:40:45 +0530] rev 47385
6714836: JRootPane.getMaximumSize() returns a width of 0 Reviewed-by: psadhukhan, serb Contributed-by: krishna.addepalli@oracle.com
2017-10-11 8166772: Touch keyboard is not shown for text components on a screen touch
alitvinov [Wed, 11 Oct 2017 15:53:25 +0100] rev 47384
8166772: Touch keyboard is not shown for text components on a screen touch Reviewed-by: serb, azvegint
(0) -30000 -10000 -3000 -1000 -300 -100 -96 +96 +100 +300 +1000 +3000 +10000 tip