alanb [Sat, 30 Nov 2019 16:21:19 +0000] rev 59329
8234805: (dc) Remove JNI upcall from DatagramChannel.receive implementation
Reviewed-by: dfuchs, chegar
iklam [Fri, 29 Nov 2019 14:11:50 -0800] rev 59328
8230385: [cds] No message is logged when shared image cannot be used due to mismatched configuration
Reviewed-by: stuefe, dholmes, ccheung
egahlin [Fri, 29 Nov 2019 17:31:01 +0100] rev 59327
8234671: JFR api/consumer/recordingstream/TestStart.java failed due to timeout at testStartTwice()
Reviewed-by: mgronlun
adinn [Fri, 29 Nov 2019 15:37:13 +0000] rev 59326
8232828: AArch64: compiler/c2/aarch64/TestVolatilesG1.java fails after JDK-8225776
Reviewed-by: aph
rehn [Fri, 29 Nov 2019 12:09:25 +0100] rev 59325
8234086: VM operation can be simplified
Reviewed-by: kbarrett, dholmes, dcubed
neliasso [Fri, 29 Nov 2019 11:26:25 +0100] rev 59324
8234520: ZGC: C2: Oop instance cloning causing skipped compiles
Reviewed-by: pliden, vlivanov
mbaesken [Thu, 28 Nov 2019 13:02:39 +0100] rev 59323
8234821: remove unused functions from libjli
Reviewed-by: clanger, alanb
michaelm [Fri, 29 Nov 2019 10:02:07 +0000] rev 59322
Merge
tschatzl [Fri, 29 Nov 2019 10:20:17 +0100] rev 59321
8233998: New young regions registered too early in collection set
Reviewed-by: sangheki, sjohanss
tschatzl [Fri, 29 Nov 2019 10:20:16 +0100] rev 59320
8227434: G1 predictions may over/underflow with high variance input
Summary: Clamp G1 prediction output to sensible values.
Reviewed-by: lkorinth, sjohanss
tschatzl [Fri, 29 Nov 2019 10:20:14 +0100] rev 59319
8227739: Merge cost predictions for scanning cards and log buffer entries
Summary: Revamp the cost predictions for the changes in JDK-8200545 and JDK-8213108.
Reviewed-by: sjohanss, kbarrett
bulasevich [Fri, 29 Nov 2019 11:28:39 +0300] rev 59318
8234893: ARM32: build failure after JDK-8234387
Reviewed-by: vlivanov
mbaesken [Thu, 28 Nov 2019 09:23:09 +0100] rev 59317
8234625: hs test serviceability/sa/ClhsdbCDSCore.java fails on macOS 10.15
Reviewed-by: clanger, iignatyev
ssahoo [Thu, 28 Nov 2019 22:29:07 -0800] rev 59316
8234723: javax/net/ssl/TLS tests support TLSv1.3
Summary: Missing TLSv1.3 test cases
Reviewed-by: xuelei
jjiang [Fri, 29 Nov 2019 14:07:16 +0800] rev 59315
8234724: javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java supports TLSv1.3
Reviewed-by: xuelei
rhalade [Thu, 28 Nov 2019 10:43:35 -0800] rev 59314
8233223: Add Amazon Root CA certificates
Reviewed-by: mullan
pconcannon [Thu, 28 Nov 2019 16:49:52 +0000] rev 59313
8233307: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set
Summary: The MulticastSocket method getOption has been changed to conform to the behavior described in StandardSocketOptions.IP_MULTICAST_IF.
Reviewed-by: chegar, dfuchs
cito [Thu, 28 Nov 2019 18:30:18 +0100] rev 59312
8232594: Make the output of the JFR command duration more user friendly
Reviewed-by: egahlin, cito
Contributed-by: chiroito107@gmail.com, erik.gahlin@oracle.com
jboes [Thu, 28 Nov 2019 13:02:30 +0000] rev 59311
8233185: HttpServer.stop() blocks indefinitely when called on dispatch thread
Summary: Skip dispatcherThread.join() if current thread is the dispatcherThread
Reviewed-by: dfuchs, msheppar, vtewari
egahlin [Thu, 28 Nov 2019 16:38:25 +0100] rev 59310
8234888: EventStream::close doesn't abort streaming thread
Reviewed-by: mgronlun, mseledtsov
lucy [Thu, 28 Nov 2019 16:28:53 +0100] rev 59309
8234583: PrintAssemblyOptions isn't passed to hsdis library
Reviewed-by: vlivanov, mdoerr
cgo [Thu, 28 Nov 2019 16:11:44 +0100] rev 59308
8234894: [TESTBUG] TestEliminateLocksOffCrash fails for client VMs due to Unrecognized VM option EliminateLocks
Reviewed-by: thartmann
fyang [Mon, 04 Nov 2019 16:10:39 +0800] rev 59307
8233466: aarch64: remove unnecessary load of mdo when profiling return and parameters type
Reviewed-by: adinn
cgo [Wed, 27 Nov 2019 10:13:41 +0100] rev 59306
8234807: [TESTBUG] LoopRotateBadNodeBudget fails for client VMs due to Unrecognized VM option PartialPeelNewPhiDelta
Reviewed-by: kvn
dfuchs [Thu, 28 Nov 2019 12:28:48 +0000] rev 59305
8223196: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java fails on Solaris SPARC
Summary: The test is fixed to use InetAddress.getLocalHost consistently, instead of a mix of getLocalHost/wildcard addresses.
Reviewed-by: chegar, vtewari
mdoerr [Thu, 28 Nov 2019 12:05:02 +0100] rev 59304
8234645: ARM32: C1: PatchingStub for field access: not enough bytes
Reviewed-by: cgo, goetz
bulasevich [Thu, 28 Nov 2019 10:57:38 +0300] rev 59303
8234891: AArch64: Fix build failure after JDK-8234387
Reviewed-by: vlivanov, smonteith
ssahoo [Wed, 27 Nov 2019 22:11:08 -0800] rev 59302
8234725: sun/security/ssl/SSLContextImpl tests support TLSv1.3
Summary: Missing TLSv1.3 test cases
Reviewed-by: xuelei
jwilhelm [Thu, 28 Nov 2019 07:05:13 +0100] rev 59301
Added tag jdk-14+25 for changeset 17d242844fc9
mli [Thu, 28 Nov 2019 13:48:25 +0800] rev 59300
8232446: logging enhancement for rmi when socket closed
Reviewed-by: rriggs, plevart
pconcannon [Wed, 27 Nov 2019 16:01:34 +0000] rev 59299
8233018: Add a new test to verify that DatagramSocket is not interruptible
Summary: Test added to check the interruptability of DatagramSocket, MulticastSocket and DatagramSocketAdaptor.
Reviewed-by: chegar, dfuchs
jboes [Wed, 27 Nov 2019 15:13:58 +0000] rev 59298
8234799: javadoc of java.util.Arrays.compare(T[] a, T[] b) misses the word "less"
Summary: Add word "less" to method-level javadoc
Reviewed-by: dfuchs, lancea
darcy [Wed, 27 Nov 2019 10:23:40 -0800] rev 59297
8234917: Explicitly discuss java.lang.Enum in Class.isEnum spec
Reviewed-by: jjg
zgu [Wed, 27 Nov 2019 11:52:57 -0500] rev 59296
8228720: Shenandoah: Implementation of concurrent class unloading
Reviewed-by: rkennke
darcy [Wed, 27 Nov 2019 06:36:41 -0800] rev 59295
8234781: Update description of InvalidClassException to include more conditions
Reviewed-by: alanb, chegar
hannesw [Wed, 27 Nov 2019 13:08:16 +0100] rev 59294
8223378: CSS solution for navbar problem with <a> elements is not ideal
Reviewed-by: jjg
sjohanss [Wed, 27 Nov 2019 12:18:40 +0100] rev 59293
8141637: Parallelize single threaded heap region iteration during Pre Evacuate Collection Set
Reviewed-by: tschatzl, lkorinth
stefank [Wed, 27 Nov 2019 11:31:46 +0100] rev 59292
8234897: 8234748: Clean up atomic and orderAccess includes - part 2
Reviewed-by: tschatzl, dholmes
phedlin [Fri, 15 Nov 2019 16:39:08 +0100] rev 59291
8220376: C2: Int >0 not recognized as !=0 for div by 0 check
Reviewed-by: neliasso, vlivanov, mdoerr
stefank [Tue, 26 Nov 2019 10:47:46 +0100] rev 59290
8234748: Clean up atomic and orderAccess includes
Reviewed-by: dholmes
tschatzl [Wed, 27 Nov 2019 10:21:22 +0100] rev 59289
Merge
tschatzl [Wed, 27 Nov 2019 10:19:45 +0100] rev 59288
8233301: Implementation of JEP 366: Deprecate the ParallelScavenge + SerialOld GC Combination
Summary: Deprecate the ParallelScavenge + SerialOld GC combinations by deprecating the UseParallelOldGC flag. Also reviewed by Bernd Eckenfels<ecki@zusammenkunft.net>.
Reviewed-by: pliden
mbaesken [Wed, 27 Nov 2019 10:07:29 +0100] rev 59287
8234525: enable link-time section-gc for linux s390x to remove unused code
Reviewed-by: erikj, mdoerr
mbaesken [Tue, 26 Nov 2019 13:55:11 +0100] rev 59286
8234809: set relro in linker flags when building with gcc
Reviewed-by: erikj, fweimer
jlahoda [Wed, 27 Nov 2019 09:00:01 +0100] rev 59285
8231826: Implement javac changes for pattern matching for instanceof
Reviewed-by: mcimadamore
Contributed-by: brian.goetz@oracle.com, gavin.bierman@oracle.com, maurizio.cimadamore@oracle.com, srikanth.adayapalam@oracle.com, vicente.romero@oracle.com, jan.lahoda@oracle.com
zgu [Mon, 09 Sep 2019 11:43:16 -0400] rev 59284
8230765: Implement nmethod barrier for x86_32 platforms
Reviewed-by: rkennke, eosterlund
zgu [Tue, 26 Nov 2019 14:33:56 -0500] rev 59283
8233500: Shenandoah: Shenandoah load barrier should save registers before calling keep alive barrier on x86
Reviewed-by: rkennke
iklam [Fri, 22 Nov 2019 17:45:48 -0800] rev 59282
8234539: ArchiveRelocationTest.java failed: Archive mapping should always succeed
Reviewed-by: ccheung
cgo [Tue, 26 Nov 2019 10:00:33 +0100] rev 59281
8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC
Reviewed-by: erikj
sviswanathan [Tue, 26 Nov 2019 19:19:39 +0300] rev 59280
8234610: MaxVectorSize set wrongly when UseAVX=3 is specified after JDK-8221092
Reviewed-by: kvn, vlivanov
vlivanov [Tue, 26 Nov 2019 19:18:07 +0300] rev 59279
Merge
jbhateja [Tue, 26 Nov 2019 16:09:25 +0300] rev 59278
8234394: C2: Dynamic register class support in ADLC
Reviewed-by: vlivanov, sviswanathan, thartmann, kvn
jbhateja [Tue, 26 Nov 2019 16:09:23 +0300] rev 59277
8234387: C2: Better support of operands with multiple match rules in AD files
Reviewed-by: vlivanov, sviswanathan, thartmann, dlong
vlivanov [Tue, 26 Nov 2019 16:09:21 +0300] rev 59276
8234403: C2: Enable CallSite.target updates in constructors
Reviewed-by: psandoz, kvn
vlivanov [Tue, 26 Nov 2019 16:09:17 +0300] rev 59275
8234401: ConstantCallSite may stuck in non-frozen state
Reviewed-by: psandoz
egahlin [Tue, 26 Nov 2019 17:00:57 +0100] rev 59274
8233870: JFR TestSetEndTime.java times out - onClose() is never called
Reviewed-by: mgronlun
pchilanomate [Tue, 26 Nov 2019 15:21:37 +0000] rev 59273
8234613: JavaThread can escape back to Java from an ongoing handshake
Summary: Check again if we have a pending/in-progress handshake operation after executing ~ThreadInVMForHandshake()
Reviewed-by: coleenp, dcubed, dholmes, rehn
stuefe [Tue, 26 Nov 2019 16:21:29 +0100] rev 59272
Metadatatype back to metaspace.hpp to reduce patch size
stuefe [Tue, 26 Nov 2019 11:29:20 +0100] rev 59271
Improve BLA and LOM tests
rkennke [Tue, 26 Nov 2019 14:48:04 +0100] rev 59270
8234768: Shenandoah: Streamline enqueueing runtime barriers
Reviewed-by: zgu
zgu [Tue, 26 Nov 2019 09:27:16 -0500] rev 59269
8234270: [REDO] JDK-8204128 NMT might report incorrect numbers for Compiler area
Reviewed-by: stuefe, minqi
stefank [Tue, 26 Nov 2019 13:50:26 +0100] rev 59268
8234798: Build failure after atomic changes in JDK-8234563
Reviewed-by: tschatzl, rkennke, zgu
pliden [Tue, 26 Nov 2019 11:57:58 +0100] rev 59267
8234619: ZGC: gc/z/TestSmallHeap.java failure with Out Of Memory
Reviewed-by: tschatzl, eosterlund
michaelm [Tue, 26 Nov 2019 10:22:13 +0000] rev 59266
Merge
sadayapalam [Tue, 26 Nov 2019 11:13:53 +0530] rev 59265
8234729: Javac should eagerly change code generation for method references to avert IllegalAccessError in future.
Reviewed-by: mcimadamore
sspitsyn [Tue, 26 Nov 2019 02:32:32 +0000] rev 59264
8221372: Test vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java times out
Summary: Update test to get rid of unneeded MethodEntry/MethodExit events
Reviewed-by: amenkov, cjplummer
bpb [Mon, 25 Nov 2019 15:30:35 -0800] rev 59263
8179320: File.getUsableSpace() returns a negative number on very large file system
Reviewed-by: alanb, rriggs, darcy
dnsimon [Mon, 25 Nov 2019 12:08:20 -0800] rev 59262
8234681: Remove UseJVMCIClassLoader logic from JVMCI code
Reviewed-by: kvn, iignatyev
mgronlun [Mon, 25 Nov 2019 20:18:54 +0100] rev 59261
8234684: JFR crashes when rotating the JFR output during assertion failure
Reviewed-by: egahlin, mseledtsov
never [Mon, 25 Nov 2019 11:13:02 -0800] rev 59260
8234359: [JVMCI] invalidate_nmethod_mirror shouldn't use a phantom reference
Reviewed-by: kvn, eosterlund
mgronlun [Mon, 25 Nov 2019 18:38:01 +0100] rev 59259
8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing
Reviewed-by: sspitsyn, egahlin
eosterlund [Mon, 25 Nov 2019 15:21:44 +0000] rev 59258
8234531: Remove CMS code from CLDG and safepoint cleanup
Reviewed-by: coleenp, zgu
stuefe [Mon, 25 Nov 2019 16:35:14 +0100] rev 59257
Improve comments
michaelm [Mon, 25 Nov 2019 15:16:29 +0000] rev 59256
Merge
stefank [Mon, 25 Nov 2019 15:00:32 +0100] rev 59255
8234602: ZGC: Windows compile error in ZHeuristic
Reviewed-by: pliden, eosterlund
stefank [Mon, 25 Nov 2019 14:57:03 +0100] rev 59254
8234009: ZGC: Move resurrection unblock to before the _unload.purge() call
Reviewed-by: pliden, eosterlund
stefank [Mon, 25 Nov 2019 14:56:15 +0100] rev 59253
8234010: ZGC: Change ZResurrection to use Atomic::load/store
Reviewed-by: pliden, eosterlund
stefank [Mon, 25 Nov 2019 12:33:15 +0100] rev 59252
8234740: Harmonize parameter order in Atomic - cmpxchg
Reviewed-by: rehn, dholmes
stefank [Mon, 25 Nov 2019 12:32:40 +0100] rev 59251
8234739: Harmonize parameter order in Atomic - xchg
Reviewed-by: rehn, dholmes
stefank [Mon, 25 Nov 2019 12:32:07 +0100] rev 59250
8234738: Harmonize parameter order in Atomic - sub
Reviewed-by: rehn, dholmes
stefank [Mon, 25 Nov 2019 12:31:39 +0100] rev 59249
8234737: Harmonize parameter order in Atomic - add
Reviewed-by: rehn, dholmes
stefank [Mon, 25 Nov 2019 12:30:24 +0100] rev 59248
8234736: Harmonize parameter order in Atomic - store
Reviewed-by: rehn, dholmes
stefank [Mon, 25 Nov 2019 12:22:13 +0100] rev 59247
8234562: Move OrderAccess::release_store*/load_acquire to Atomic
Reviewed-by: rehn, dholmes
egahlin [Mon, 25 Nov 2019 14:06:13 +0100] rev 59246
8234703: JFR TestOutOfProcessMigration.java should clean up files
Reviewed-by: mgronlun
pliden [Mon, 25 Nov 2019 12:34:43 +0100] rev 59245
8234573: ZGC: Enable ZVerifyMarking by default in debug builds
Reviewed-by: stefank, tschatzl
mgronlun [Mon, 25 Nov 2019 11:08:30 +0100] rev 59244
8234433: TestUnloadEventClassCount fails with "assert(SafepointSynchronize::is_at_safepoint()) failed: invariant"
Reviewed-by: pliden
mbaesken [Fri, 22 Nov 2019 10:29:12 +0100] rev 59243
8234629: remove unused functions from libnet
Reviewed-by: alanb, vtewari
eosterlund [Mon, 25 Nov 2019 09:10:41 +0000] rev 59242
8234509: Race in macOS os::processor_id()
Reviewed-by: dholmes, pliden, rehn
lkorinth [Mon, 25 Nov 2019 08:11:24 +0100] rev 59241
8233029: Obsolete flag GCTaskTimeStampEntries
Reviewed-by: kbarrett, tschatzl
weijun [Thu, 10 Oct 2019 17:36:38 +0300] rev 59240
8231507: Update Apache Santuario (XML Signature) to version 2.1.4
Reviewed-by: weijun
Contributed-by: fedor.burdun@azulsystems.com, weijun.wang@oracle.com
egahlin [Sun, 24 Nov 2019 01:03:33 +0100] rev 59239
8226897: Provide object age with JFR OldObjectSample event
Reviewed-by: mgronlun, mseledtsov
stuefe [Sat, 23 Nov 2019 11:05:16 +0100] rev 59238
Factor out block list array from LOM since we may use it elsewhere
dlong [Fri, 22 Nov 2019 19:23:30 -0800] rev 59237
8234432: AOT tests failing with 'used 'epsilon gc' is different from current 'g1 gc'' after CMS removal
Reviewed-by: kvn
iklam [Fri, 22 Nov 2019 15:32:00 -0800] rev 59236
8234622: [TESTBUG] ArchivedModuleCompareTest.java fails with -vmoptions:-Xlog:cds
Reviewed-by: mseledtsov
iklam [Fri, 22 Nov 2019 15:31:52 -0800] rev 59235
8233446: Improve error handling when specified dynamic archive doesn't exist
Reviewed-by: lfoltan, ccheung
iklam [Fri, 22 Nov 2019 14:48:40 -0800] rev 59234
8234429: appcds/dynamicArchive tests crashing with Graal
Reviewed-by: ccheung
manc [Fri, 22 Nov 2019 17:03:55 -0800] rev 59233
8087198: G1 card refinement: batching, sorting
Reviewed-by: tschatzl, kbarrett
jjg [Fri, 22 Nov 2019 16:26:35 -0800] rev 59232
8234687: change javap reporting on unknown attributes
Reviewed-by: mchung
mseledtsov [Fri, 22 Nov 2019 13:44:06 -0800] rev 59231
8229209: [TESTBUG] test for cross-process JFR event streaming
Summary: New test for cross-process JFR event streaming
Reviewed-by: iignatyev, egahlin
mchung [Fri, 22 Nov 2019 11:34:22 -0800] rev 59230
8233956: MethodHandles.dropArguments javadoc lists parameters in wrong order
Reviewed-by: jjg
jjg [Fri, 22 Nov 2019 10:38:35 -0800] rev 59229
8232170: FSInfo#getJarClassPath throws an exception not declared in its throws clause
Reviewed-by: jjg
Contributed-by: jai.forums2013@gmail.com
dfuchs [Fri, 22 Nov 2019 17:53:09 +0000] rev 59228
8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached"
Summary: fix the test to run in /othervm mode
Reviewed-by: chegar
bpb [Fri, 22 Nov 2019 09:00:16 -0800] rev 59227
8164993: (ch) ReadableByteChannel should note a possible IllegalArgumentException
Reviewed-by: alanb, darcy
egahlin [Fri, 22 Nov 2019 17:20:43 +0100] rev 59226
8233700: EventStream not closed
Reviewed-by: mgronlun, mseledtsov
dcubed [Fri, 22 Nov 2019 09:06:35 -0500] rev 59225
8234544: ObjectSynchronizer::FastHashCode() cleanups from Async Monitor Deflation project
Reviewed-by: dholmes
dfuchs [Fri, 22 Nov 2019 11:52:48 +0000] rev 59224
8233296: MulticastSocket getOption/setOption inverts the value of IP_MULTICAST_LOOP
Summary: MulticastSocket.getOption(StandardSocketOption.IP_MULTICAST_LOOP) now returns true if loopback mode is enabled, and MulticastSocket.setOption(StandardSocketOption.IP_MULTICAST_LOOP, true) enables loopback mode. No other behavioral changes.
Reviewed-by: alanb, chegar
sspitsyn [Fri, 22 Nov 2019 10:07:21 +0000] rev 59223
8169467: GetLocalInstance returns JVMTI_ERROR_TYPE_MISMATCH (rather than JVMTI_ERROR_INVALID_SLOT) on static method
Summary: Add necessary check to GetLocalInstance implementation
Reviewed-by: amenkov, cjplummer
tschatzl [Fri, 22 Nov 2019 10:03:38 +0100] rev 59222
8233597: Clean up code in G1Analytics::compute_pause_time_ratio
Reviewed-by: kbarrett, sjohanss
tschatzl [Fri, 22 Nov 2019 10:03:38 +0100] rev 59221
8233702: Introduce helper function to clamp value to range
Reviewed-by: sjohanss, kbarrett
tschatzl [Fri, 22 Nov 2019 10:03:38 +0100] rev 59220
8234000: Make HeapRegion::bottom/end/hrm_index const
Reviewed-by: kbarrett, sjohanss
tschatzl [Fri, 22 Nov 2019 10:03:38 +0100] rev 59219
8233997: Some members of HeapRegion are not cleared in HeapRegion::hr_clear()
Reviewed-by: sjohanss, sangheki
tschatzl [Fri, 22 Nov 2019 10:03:38 +0100] rev 59218
8233306: Sort members in G1's HeapRegion after removal of Space dependency
Reviewed-by: sangheki, sjohanss
mbaesken [Mon, 18 Nov 2019 16:49:39 +0100] rev 59217
8234339: replace JLI_StrTok in java_md_solinux.c
Reviewed-by: clanger, rriggs
clanger [Fri, 22 Nov 2019 09:25:09 +0100] rev 59216
8234089: (zipfs) Remove classes JarFileSystemProvider and JarFileSystem
Reviewed-by: lancea, alanb
dbuck [Thu, 21 Nov 2019 23:32:11 -0500] rev 59215
8230611: infinite loop in LogOutputList::wait_until_no_readers()
Summary: Add copy constructor and copy assignment operator to ensure reader count remains accurate
Reviewed-by: kbarrett, dholmes
xuelei [Thu, 21 Nov 2019 18:42:33 -0800] rev 59214
8233954: UnsatisfiedLinkError or NoSuchAlgorithmException after removing sunec.dll
Reviewed-by: ascarpino
weijun [Fri, 22 Nov 2019 09:33:03 +0800] rev 59213
8026393: jarsigner never shows a warning in badKeyUsage case
Reviewed-by: mullan
joehw [Fri, 22 Nov 2019 00:29:48 +0000] rev 59212
8233548: Update CUP to v0.11b
Reviewed-by: lancea
iignatyev [Thu, 21 Nov 2019 14:15:31 -0800] rev 59211
8234290: compiler/c2/Test6857159.java times out and fail to clean up files
Reviewed-by: thartmann
jjg [Thu, 21 Nov 2019 13:41:24 -0800] rev 59210
8234051: doclet crashes if HTML files in module doc-files directories
Reviewed-by: hannesw