Mon, 04 Feb 2013 08:13:05 -0400 8007455: Extraneous $(ECHO) in make/Makefile
jlaskey [Mon, 04 Feb 2013 08:13:05 -0400] rev 16208
8007455: Extraneous $(ECHO) in make/Makefile Reviewed-by: sundar Contributed-by: james.laskey@oracle.com
Fri, 01 Feb 2013 02:24:15 +0100 8007060: Primitive wrap filter throws ClassCastException in test262parallel
hannesw [Fri, 01 Feb 2013 02:24:15 +0100] rev 16207
8007060: Primitive wrap filter throws ClassCastException in test262parallel Reviewed-by: sundar, jlaskey, lagergren
Thu, 31 Jan 2013 18:34:42 +0100 8006529: Methods always get callee - it should be conditional
attila [Thu, 31 Jan 2013 18:34:42 +0100] rev 16206
8006529: Methods always get callee - it should be conditional Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145. Reviewed-by: jlaskey, lagergren
Thu, 31 Jan 2013 20:07:40 +0530 8007286: Add JavaAdapter and importPackage to compatibility script
sundar [Thu, 31 Jan 2013 20:07:40 +0530] rev 16205
8007286: Add JavaAdapter and importPackage to compatibility script Reviewed-by: lagergren, jlaskey
Wed, 30 Jan 2013 21:15:14 +0530 8007140: Java.extend crashes when attempting to extend java.lang.Object
sundar [Wed, 30 Jan 2013 21:15:14 +0530] rev 16204
8007140: Java.extend crashes when attempting to extend java.lang.Object Reviewed-by: lagergren, hannesw
Wed, 30 Jan 2013 14:57:19 +0100 8007109: Regression: String(ConsString) does not flatten argument to String
hannesw [Wed, 30 Jan 2013 14:57:19 +0100] rev 16203
8007109: Regression: String(ConsString) does not flatten argument to String Reviewed-by: sundar, lagergren
Wed, 30 Jan 2013 17:52:54 +0530 8007132: Java objects returned from constructor functions are lost
sundar [Wed, 30 Jan 2013 17:52:54 +0530] rev 16202
8007132: Java objects returned from constructor functions are lost Reviewed-by: hannesw, lagergren, attila
Wed, 30 Jan 2013 12:26:45 +0100 8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes.
lagergren [Wed, 30 Jan 2013 12:26:45 +0100] rev 16201
8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes. Summary: Lower suffered from being a "God class" trying to do everything at once. As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and everything else code generation related before byte code emission. I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate tiers. In the process I have also fixed: (1) problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden) (2) copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied (3) erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) (4) splitter weighnodes - unary nodes were considered weightless (4) removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) (5) duplicate line number issues in the parser (6) convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/basic/access-specializer.js) ... Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased. Reviewed-by: jlaskey, attila
(0) -10000 -3000 -1000 -300 -100 -30 -10 -8 +8 +10 +30 +100 +300 +1000 +3000 +10000 +30000 tip