8024974: Incorrect use of GC_locker::is_active() Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint. Reviewed-by: brutisso, dcubed Contributed-by: per.liden@oracle.com

README:
  
  This file should be located at the top of the Mercurial repository.

  See http://openjdk.java.net/ for more information about the OpenJDK.

  See ../README-builds.html for complete details on build machine requirements.

Simple Build Instructions:
  This repository can be loaded as a NetBeans project, built with ant, or
  built with GNU make, e.g.
    ant
       -OR-
    cd make && gnumake
     
  The built files that will be imported into the jdk build will be in the 
  "dist" directory.
  Help information is available by running "ant -projecthelp" or "make help".