8006529: Methods always get callee - it should be conditional
Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145.
Reviewed-by: jlaskey, lagergren
string
number
true
string
number
true
string
number
true
object
object
false
T,h,e, ,q,u,i,c,k, ,g,r,a,y, ,n,a,s,h,o,r,n, ,j,u,m,p,s, ,o,v,e,r, ,t,h,e, ,l,a,z,y, ,z,e,b,r,a,.
Th,e ,qu,ic,k ,gr,ay, n,as,ho,rn, j,um,ps, o,ve,r ,th,e ,la,zy, z,eb,ra,.
The ,quic,k gr,ay n,asho,rn j,umps, ove,r th,e la,zy z,ebra,.
The quic,k gray n,ashorn j,umps ove,r the la,zy zebra,.
The quick gray n,ashorn jumps ove,r the lazy zebra,.
The quick gray nashorn jumps ove,r the lazy zebra.
The quick gray nashorn jumps over the lazy zebra.
The quick gray nashorn jumps over the lazy zebra. The quick gray nashorn jumps over the lazy zebra. 49 true true false true false true
string
number
true
T,h,e, ,q,u,i,c,k, ,g,r,a,y, ,n,a,s,h,o,r,n, ,j,u,m,p,s, ,o,v,e,r, ,t,h,e, ,l,a,z,y, ,z,e,b,r,a,.
Th,e ,qu,ic,k ,gr,ay, n,as,ho,rn, j,um,ps, o,ve,r ,th,e ,la,zy, z,eb,ra,.
The ,quic,k gr,ay n,asho,rn j,umps, ove,r th,e la,zy z,ebra,.
The quic,k gray n,ashorn j,umps ove,r the la,zy zebra,.
The quick gray n,ashorn jumps ove,r the lazy zebra,.
The quick gray nashorn jumps ove,r the lazy zebra.
The quick gray nashorn jumps over the lazy zebra.
T,h,e, ,q,u,i,c,k, ,g,r,a,y, ,n,a,s,h,o,r,n, ,j,u,m,p,s, ,o,v,e,r, ,t,h,e, ,l,a,z,y, ,z,e,b,r,a,.
Th,e ,qu,ic,k ,gr,ay, n,as,ho,rn, j,um,ps, o,ve,r ,th,e ,la,zy, z,eb,ra,.
The ,quic,k gr,ay n,asho,rn j,umps, ove,r th,e la,zy z,ebra,.
The quic,k gray n,ashorn j,umps ove,r the la,zy zebra,.
The quick gray n,ashorn jumps ove,r the lazy zebra,.
The quick gray nashorn jumps ove,r the lazy zebra.
The quick gray nashorn jumps over the lazy zebra.
The quick gray nashorn jumps over the lazy zebra. 49 true true true true
string
number
true