8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException
Summary: Change implementation to use iterator instead of plain LinkedList
Reviewed-by: dfuchs, vtewari
/*
* Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.net.*;
import java.io.*;
import java.util.*;
import java.security.*;
import java.util.concurrent.CopyOnWriteArrayList;
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.Arrays.asList;
import static java.util.stream.Collectors.toList;
/**
* A minimal proxy server that supports CONNECT tunneling. It does not do
* any header transformations. In future this could be added.
* Two threads are created per client connection. So, it's not
* intended for large numbers of parallel connections.
*/
public class ProxyServer extends Thread implements Closeable {
ServerSocket listener;
int port;
volatile boolean debug;
private final Credentials credentials; // may be null
private static class Credentials {
private final String name;
private final String password;
private Credentials(String name, String password) {
this.name = name;
this.password = password;
}
public String name() { return name; }
public String password() { return password; }
}
/**
* Create proxy on port (zero means don't care). Call getPort()
* to get the assigned port.
*/
public ProxyServer(Integer port) throws IOException {
this(port, false);
}
public ProxyServer(Integer port,
Boolean debug,
String username,
String password)
throws IOException
{
this(port, debug, new Credentials(username, password));
}
public ProxyServer(Integer port,
Boolean debug)
throws IOException
{
this(port, debug, null);
}
public ProxyServer(Integer port,
Boolean debug,
Credentials credentials)
throws IOException
{
this.debug = debug;
listener = new ServerSocket();
listener.setReuseAddress(false);
listener.bind(new InetSocketAddress(InetAddress.getLoopbackAddress(), port));
this.port = listener.getLocalPort();
this.credentials = credentials;
setName("ProxyListener");
setDaemon(true);
connections = new CopyOnWriteArrayList<Connection>();
start();
}
public ProxyServer(String s) {
credentials = null;
connections = new CopyOnWriteArrayList<Connection>();
}
/**
* Returns the port number this proxy is listening on
*/
public int getPort() {
return port;
}
/**
* Shuts down the proxy, probably aborting any connections
* currently open
*/
public void close() throws IOException {
if (debug) System.out.println("Proxy: closing server");
done = true;
listener.close();
for (Connection c : connections) {
c.close();
c.awaitCompletion();
}
}
final CopyOnWriteArrayList<Connection> connections;
volatile boolean done;
public void run() {
if (System.getSecurityManager() == null) {
execute();
} else {
// so calling domain does not need to have socket permission
AccessController.doPrivileged(new PrivilegedAction<Void>() {
public Void run() {
execute();
return null;
}
});
}
}
public void execute() {
int id = 0;
try {
while (!done) {
Socket s = listener.accept();
id++;
Connection c = new Connection(s, id);
if (debug)
System.out.println("Proxy: accepted new connection: " + s);
connections.add(c);
c.init();
}
} catch(Throwable e) {
if (debug && !done) {
System.out.println("Proxy: Fatal error, listener got " + e);
e.printStackTrace();
}
}
}
/**
* Transparently forward everything, once we know what the destination is
*/
class Connection {
private final int id;
Socket clientSocket, serverSocket;
Thread out, in;
volatile InputStream clientIn, serverIn;
volatile OutputStream clientOut, serverOut;
final static int CR = 13;
final static int LF = 10;
Connection(Socket s, int id) throws IOException {
this.id = id;
this.clientSocket= s;
this.clientIn = new BufferedInputStream(s.getInputStream());
this.clientOut = s.getOutputStream();
}
byte[] readHeaders(InputStream is) throws IOException {
byte[] outbuffer = new byte[8000];
int crlfcount = 0;
int bytecount = 0;
int c;
while ((c=is.read()) != -1 && bytecount < outbuffer.length) {
outbuffer[bytecount++] = (byte)c;
if (debug) System.out.write(c);
// were looking for CRLFCRLF sequence
if (c == CR || c == LF) {
switch(crlfcount) {
case 0:
if (c == CR) crlfcount ++;
break;
case 1:
if (c == LF) crlfcount ++;
break;
case 2:
if (c == CR) crlfcount ++;
break;
case 3:
if (c == LF) crlfcount ++;
break;
}
} else {
crlfcount = 0;
}
if (crlfcount == 4) {
break;
}
}
byte[] ret = new byte[bytecount];
System.arraycopy(outbuffer, 0, ret, 0, bytecount);
return ret;
}
boolean running() {
return out.isAlive() || in.isAlive();
}
private volatile boolean closing;
public synchronized void close() throws IOException {
closing = true;
if (debug)
System.out.println("Proxy: closing connection {" + this + "}");
if (serverSocket != null)
serverSocket.close();
if (clientSocket != null)
clientSocket.close();
}
public void awaitCompletion() {
try {
if (in != null)
in.join();
if (out!= null)
out.join();
} catch (InterruptedException e) { }
}
int findCRLF(byte[] b) {
for (int i=0; i<b.length-1; i++) {
if (b[i] == CR && b[i+1] == LF) {
return i;
}
}
return -1;
}
// Checks credentials in the request against those allowable by the proxy.
private boolean authorized(Credentials credentials,
List<String> requestHeaders) {
List<String> authorization = requestHeaders.stream()
.filter(n -> n.toLowerCase(Locale.US).startsWith("proxy-authorization"))
.collect(toList());
if (authorization.isEmpty())
return false;
if (authorization.size() != 1) {
throw new IllegalStateException("Authorization unexpected count:" + authorization);
}
String value = authorization.get(0).substring("proxy-authorization".length()).trim();
if (!value.startsWith(":"))
throw new IllegalStateException("Authorization malformed: " + value);
value = value.substring(1).trim();
if (!value.startsWith("Basic "))
throw new IllegalStateException("Authorization not Basic: " + value);
value = value.substring("Basic ".length());
String values = new String(Base64.getDecoder().decode(value), UTF_8);
int sep = values.indexOf(':');
if (sep < 1) {
throw new IllegalStateException("Authorization no colon: " + values);
}
String name = values.substring(0, sep);
String password = values.substring(sep + 1);
if (name.equals(credentials.name()) && password.equals(credentials.password()))
return true;
return false;
}
public void init() {
try {
byte[] buf;
while (true) {
buf = readHeaders(clientIn);
if (findCRLF(buf) == -1) {
if (debug)
System.out.println("Proxy: no CRLF closing, buf contains:["
+ new String(buf, UTF_8) + "]" );
close();
return;
}
List<String> headers = asList(new String(buf, UTF_8).split("\r\n"));
// check authorization credentials, if required by the server
if (credentials != null && !authorized(credentials, headers)) {
String resp = "HTTP/1.1 407 Proxy Authentication Required\r\n" +
"Content-Length: 0\r\n" +
"Proxy-Authenticate: Basic realm=\"proxy realm\"\r\n\r\n";
clientOut.write(resp.getBytes(UTF_8));
} else {
break;
}
}
int p = findCRLF(buf);
String cmd = new String(buf, 0, p, "US-ASCII");
String[] params = cmd.split(" ");
if (params[0].equals("CONNECT")) {
doTunnel(params[1]);
} else {
doProxy(params[1], buf, p, cmd);
}
} catch (Throwable e) {
if (debug) {
System.out.println("Proxy: " + e);
e.printStackTrace();
}
try {close(); } catch (IOException e1) {}
}
}
void doProxy(String dest, byte[] buf, int p, String cmdLine)
throws IOException
{
try {
URI uri = new URI(dest);
if (!uri.isAbsolute()) {
throw new IOException("request URI not absolute");
}
dest = uri.getAuthority();
// now extract the path from the URI and recreate the cmd line
int sp = cmdLine.indexOf(' ');
String method = cmdLine.substring(0, sp);
cmdLine = method + " " + uri.getPath() + " HTTP/1.1";
int x = cmdLine.length() - 1;
int i = p;
while (x >=0) {
buf[i--] = (byte)cmdLine.charAt(x--);
}
i++;
commonInit(dest, 80);
OutputStream sout;
synchronized (this) {
if (closing) return;
sout = serverOut;
}
// might fail if we're closing but we don't care.
sout.write(buf, i, buf.length-i);
proxyCommon();
} catch (URISyntaxException e) {
throw new IOException(e);
}
}
synchronized void commonInit(String dest, int defaultPort) throws IOException {
if (closing) return;
int port;
String[] hostport = dest.split(":");
if (hostport.length == 1) {
port = defaultPort;
} else {
port = Integer.parseInt(hostport[1]);
}
if (debug)
System.out.printf("Proxy: connecting to (%s/%d)\n", hostport[0], port);
serverSocket = new Socket(hostport[0], port);
serverOut = serverSocket.getOutputStream();
serverIn = new BufferedInputStream(serverSocket.getInputStream());
}
synchronized void proxyCommon() throws IOException {
if (closing) return;
out = new Thread(() -> {
try {
byte[] bb = new byte[8000];
int n;
while ((n = clientIn.read(bb)) != -1) {
serverOut.write(bb, 0, n);
}
closing = true;
serverSocket.close();
clientSocket.close();
} catch (IOException e) {
if (!closing && debug) {
System.out.println("Proxy: " + e);
e.printStackTrace();
}
}
});
in = new Thread(() -> {
try {
byte[] bb = new byte[8000];
int n;
while ((n = serverIn.read(bb)) != -1) {
clientOut.write(bb, 0, n);
}
closing = true;
serverSocket.close();
clientSocket.close();
} catch (IOException e) {
if (!closing && debug) {
System.out.println("Proxy: " + e);
e.printStackTrace();
}
}
});
out.setName("Proxy-outbound");
out.setDaemon(true);
in.setDaemon(true);
in.setName("Proxy-inbound");
out.start();
in.start();
}
void doTunnel(String dest) throws IOException {
if (closing) return; // no need to go further.
commonInit(dest, 443);
// might fail if we're closing, but we don't care.
clientOut.write("HTTP/1.1 200 OK\r\n\r\n".getBytes());
proxyCommon();
}
@Override
public String toString() {
return "Proxy connection " + id + ", client sock:" + clientSocket;
}
}
public static void main(String[] args) throws Exception {
int port = Integer.parseInt(args[0]);
boolean debug = args.length > 1 && args[1].equals("-debug");
System.out.println("Debugging : " + debug);
ProxyServer ps = new ProxyServer(port, debug);
System.out.println("Proxy server listening on port " + ps.getPort());
while (true) {
Thread.sleep(5000);
}
}
}