8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException
Summary: Change implementation to use iterator instead of plain LinkedList
Reviewed-by: dfuchs, vtewari
/*
* Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8161157
* @summary Test response body handlers/subscribers when there is no body
* @library /test/lib http2/server
* @build jdk.test.lib.net.SimpleSSLContext
* @modules java.base/sun.net.www.http
* java.net.http/jdk.internal.net.http.common
* java.net.http/jdk.internal.net.http.frame
* java.net.http/jdk.internal.net.http.hpack
* @run testng/othervm
* -Djdk.internal.httpclient.debug=true
* -Djdk.httpclient.HttpClient.log=all
* NoBodyPartTwo
*/
import java.io.InputStream;
import java.net.URI;
import java.util.Optional;
import java.util.function.Consumer;
import java.net.http.HttpClient;
import java.net.http.HttpRequest;
import java.net.http.HttpRequest.BodyPublishers;
import java.net.http.HttpResponse;
import java.net.http.HttpResponse.BodyHandlers;
import org.testng.annotations.Test;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;
public class NoBodyPartTwo extends AbstractNoBody {
volatile boolean consumerHasBeenCalled;
@Test(dataProvider = "variants")
public void testAsByteArrayConsumer(String uri, boolean sameClient) throws Exception {
printStamp(START, "testAsByteArrayConsumer(\"%s\", %s)", uri, sameClient);
HttpClient client = null;
for (int i=0; i< ITERATION_COUNT; i++) {
if (!sameClient || client == null)
client = newHttpClient();
HttpRequest req = HttpRequest.newBuilder(URI.create(uri))
.PUT(BodyPublishers.ofString(SIMPLE_STRING))
.build();
Consumer<Optional<byte[]>> consumer = oba -> {
consumerHasBeenCalled = true;
oba.ifPresent(ba -> fail("Unexpected non-empty optional:" + ba));
};
consumerHasBeenCalled = false;
client.send(req, BodyHandlers.ofByteArrayConsumer(consumer));
assertTrue(consumerHasBeenCalled);
}
// We have created many clients here. Try to speed up their release.
if (!sameClient) System.gc();
}
@Test(dataProvider = "variants")
public void testAsInputStream(String uri, boolean sameClient) throws Exception {
printStamp(START, "testAsInputStream(\"%s\", %s)", uri, sameClient);
HttpClient client = null;
for (int i=0; i< ITERATION_COUNT; i++) {
if (!sameClient || client == null)
client = newHttpClient();
HttpRequest req = HttpRequest.newBuilder(URI.create(uri))
.PUT(BodyPublishers.ofString(SIMPLE_STRING))
.build();
HttpResponse<InputStream> response = client.send(req, BodyHandlers.ofInputStream());
byte[] body = response.body().readAllBytes();
assertEquals(body.length, 0);
}
// We have created many clients here. Try to speed up their release.
if (!sameClient) System.gc();
}
@Test(dataProvider = "variants")
public void testBuffering(String uri, boolean sameClient) throws Exception {
printStamp(START, "testBuffering(\"%s\", %s)", uri, sameClient);
HttpClient client = null;
for (int i=0; i< ITERATION_COUNT; i++) {
if (!sameClient || client == null)
client = newHttpClient();
HttpRequest req = HttpRequest.newBuilder(URI.create(uri))
.PUT(BodyPublishers.ofString(SIMPLE_STRING))
.build();
HttpResponse<byte[]> response = client.send(req,
BodyHandlers.buffering(BodyHandlers.ofByteArray(), 1024));
byte[] body = response.body();
assertEquals(body.length, 0);
}
// We have created many clients here. Try to speed up their release.
if (!sameClient) System.gc();
}
@Test(dataProvider = "variants")
public void testDiscard(String uri, boolean sameClient) throws Exception {
printStamp(START, "testDiscard(\"%s\", %s)", uri, sameClient);
HttpClient client = null;
for (int i=0; i< ITERATION_COUNT; i++) {
if (!sameClient || client == null)
client = newHttpClient();
HttpRequest req = HttpRequest.newBuilder(URI.create(uri))
.PUT(BodyPublishers.ofString(SIMPLE_STRING))
.build();
Object obj = new Object();
HttpResponse<Object> response = client.send(req, BodyHandlers.replacing(obj));
assertEquals(response.body(), obj);
}
// We have created many clients here. Try to speed up their release.
if (!sameClient) System.gc();
}
}