--- a/make/Main.gmk Tue Oct 29 11:13:39 2019 +0100
+++ b/make/Main.gmk Tue Oct 29 11:17:25 2019 +0100
@@ -66,33 +66,33 @@
################################################################################
# Interim/build tools targets, compiling tools used during the build
-# When creating a BUILDJDK, the buildtools and interim targets have already
-# been built and should not be built again.
-ifneq ($(CREATING_BUILDJDK), true)
- buildtools-langtools:
+buildtools-langtools:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f ToolsLangtools.gmk)
- interim-langtools:
+interim-langtools:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f CompileInterimLangtools.gmk)
- interim-rmic:
+interim-rmic:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f CompileInterimRmic.gmk)
- interim-cldrconverter:
+interim-cldrconverter:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f CopyInterimCLDRConverter.gmk)
+
+interim-tzdb:
+ +($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f CopyInterimTZDB.gmk)
- buildtools-jdk:
+
+buildtools-jdk:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f CompileToolsJdk.gmk)
- buildtools-modules:
+buildtools-modules:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f CompileModuleTools.gmk)
- buildtools-hotspot:
+buildtools-hotspot:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f CompileToolsHotspot.gmk)
-endif
ALL_TARGETS += buildtools-langtools interim-langtools \
- interim-rmic interim-cldrconverter buildtools-jdk buildtools-modules \
+ interim-rmic interim-cldrconverter interim-tzdb buildtools-jdk buildtools-modules \
buildtools-hotspot
################################################################################
@@ -106,43 +106,39 @@
################################################################################
# Gensrc targets, generating source before java compilation can be done
#
-# When creating a BUILDJDK, the java targets have already been built and copied
-# into the buildjdk so no need to generate sources.
-ifneq ($(CREATING_BUILDJDK), true)
- $(eval $(call DeclareRecipesForPhase, GENSRC, \
- TARGET_SUFFIX := gensrc-src, \
- FILE_PREFIX := Gensrc, \
- MAKE_SUBDIR := gensrc, \
- CHECK_MODULES := $(ALL_MODULES), \
- ))
+$(eval $(call DeclareRecipesForPhase, GENSRC, \
+ TARGET_SUFFIX := gensrc-src, \
+ FILE_PREFIX := Gensrc, \
+ MAKE_SUBDIR := gensrc, \
+ CHECK_MODULES := $(ALL_MODULES), \
+))
- $(foreach m, $(GENSRC_MODULES), $(eval $m-gensrc: $m-gensrc-src))
+$(foreach m, $(GENSRC_MODULES), $(eval $m-gensrc: $m-gensrc-src))
- LANGTOOLS_GENSRC_TARGETS := $(filter $(addsuffix -%, $(LANGTOOLS_MODULES)), $(GENSRC_TARGETS))
- INTERIM_LANGTOOLS_GENSRC_TARGETS := $(filter $(addsuffix -%, \
- $(INTERIM_LANGTOOLS_BASE_MODULES)), $(GENSRC_TARGETS))
- HOTSPOT_GENSRC_TARGETS := $(filter $(addsuffix -%, $(HOTSPOT_MODULES)), $(GENSRC_TARGETS))
- JDK_GENSRC_TARGETS := $(filter-out $(LANGTOOLS_GENSRC_TARGETS) \
- $(HOTSPOT_GENSRC_TARGETS), $(GENSRC_TARGETS))
+LANGTOOLS_GENSRC_TARGETS := $(filter $(addsuffix -%, $(LANGTOOLS_MODULES)), $(GENSRC_TARGETS))
+INTERIM_LANGTOOLS_GENSRC_TARGETS := $(filter $(addsuffix -%, \
+ $(INTERIM_LANGTOOLS_BASE_MODULES)), $(GENSRC_TARGETS))
+HOTSPOT_GENSRC_TARGETS := $(filter $(addsuffix -%, $(HOTSPOT_MODULES)), $(GENSRC_TARGETS))
+JDK_GENSRC_TARGETS := $(filter-out $(LANGTOOLS_GENSRC_TARGETS) \
+ $(HOTSPOT_GENSRC_TARGETS), $(GENSRC_TARGETS))
- GENSRC_MODULEINFO_MODULES := $(ALL_MODULES)
- GENSRC_MODULEINFO_TARGETS := $(addsuffix -gensrc-moduleinfo, \
- $(GENSRC_MODULEINFO_MODULES))
+GENSRC_MODULEINFO_MODULES := $(ALL_MODULES)
+GENSRC_MODULEINFO_TARGETS := $(addsuffix -gensrc-moduleinfo, \
+ $(GENSRC_MODULEINFO_MODULES))
- GENSRC_MODULES := $(GENSRC_MODULEINFO_MODULES)
- GENSRC_TARGETS += $(sort $(GENSRC_MODULEINFO_TARGETS) \
- $(addsuffix -gensrc, $(GENSRC_MODULES)))
+GENSRC_MODULES := $(GENSRC_MODULEINFO_MODULES)
+GENSRC_TARGETS += $(sort $(GENSRC_MODULEINFO_TARGETS) \
+ $(addsuffix -gensrc, $(GENSRC_MODULES)))
- define DeclareModuleInfoRecipe
- $1-gensrc-moduleinfo:
+define DeclareModuleInfoRecipe
+ $1-gensrc-moduleinfo:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) \
-f GensrcModuleInfo.gmk MODULE=$1)
- $1-gensrc: $1-gensrc-moduleinfo
- endef
+ $1-gensrc: $1-gensrc-moduleinfo
+endef
- $(foreach m, $(GENSRC_MODULEINFO_MODULES), $(eval $(call DeclareModuleInfoRecipe,$m)))
-endif
+$(foreach m, $(GENSRC_MODULEINFO_MODULES), $(eval $(call DeclareModuleInfoRecipe,$m)))
ALL_TARGETS += $(GENSRC_TARGETS)
@@ -288,6 +284,27 @@
ALL_TARGETS += compile-commands compile-commands-hotspot
################################################################################
+# VS Code projects
+vscode-project:
+ +($(CD) $(TOPDIR)/make/vscode && $(MAKE) $(MAKE_ARGS) -f CreateVSCodeProject.gmk \
+ VSCODE_INDEXER=cpptools)
+
+vscode-project-clangd:
+ +($(CD) $(TOPDIR)/make/vscode && $(MAKE) $(MAKE_ARGS) -f CreateVSCodeProject.gmk \
+ VSCODE_INDEXER=clangd)
+
+vscode-project-rtags:
+ +($(CD) $(TOPDIR)/make/vscode && $(MAKE) $(MAKE_ARGS) -f CreateVSCodeProject.gmk \
+ VSCODE_INDEXER=rtags)
+
+vscode-project-ccls:
+ +($(CD) $(TOPDIR)/make/vscode && $(MAKE) $(MAKE_ARGS) -f CreateVSCodeProject.gmk \
+ VSCODE_INDEXER=ccls)
+
+ALL_TARGETS += vscode-project vscode-project-clangd vscode-project-rtags \
+ vscode-project-ccls
+
+################################################################################
# Build demos targets
demos-jdk:
@@ -335,8 +352,9 @@
bootcycle-images:
ifneq ($(COMPILE_TYPE), cross)
$(call LogWarn, Boot cycle build step 2: Building a new JDK image using previously built image)
+ $(call MakeDir, $(OUTPUTDIR)/bootcycle-build)
+$(MAKE) $(MAKE_ARGS) -f $(TOPDIR)/make/Init.gmk PARALLEL_TARGETS=$(BOOTCYCLE_TARGET) \
- JOBS= SPEC=$(dir $(SPEC))bootcycle-spec.gmk main
+ LOG_PREFIX="[bootcycle] " JOBS= SPEC=$(dir $(SPEC))bootcycle-spec.gmk main
else
$(call LogWarn, Boot cycle build disabled when cross compiling)
endif
@@ -413,6 +431,9 @@
docs-zip:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f Docs.gmk docs-zip)
+docs-specs-zip:
+ +($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f Docs.gmk docs-specs-zip)
+
update-build-docs:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f UpdateBuildDocs.gmk)
@@ -422,7 +443,7 @@
ALL_TARGETS += docs-jdk-api-javadoc docs-jdk-api-modulegraph \
docs-javase-api-javadoc docs-javase-api-modulegraph \
docs-reference-api-javadoc docs-reference-api-modulegraph docs-jdk-specs \
- docs-jdk-index docs-zip update-build-docs update-x11wrappers
+ docs-jdk-index docs-zip docs-specs-zip update-build-docs update-x11wrappers
################################################################################
# Cross compilation support
@@ -433,15 +454,18 @@
java.base-copy jdk.jdeps-launchers
endif
-create-buildjdk-copy:
- +($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f CreateBuildJdkCopy.gmk)
+BUILDJDK_MODULES := $(sort $(foreach m, jdk.jlink $(INTERIM_IMAGE_MODULES), \
+ $(call FindTransitiveDepsForModule, $m) $m))
create-buildjdk-interim-image:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f Main.gmk \
$@-helper \
SPEC=$(dir $(SPEC))buildjdk-spec.gmk \
HOTSPOT_SPEC=$(dir $(SPEC))buildjdk-spec.gmk \
- CREATING_BUILDJDK=true)
+ CREATING_BUILDJDK=true \
+ LOG_PREFIX="[buildjdk] " \
+ JAVA_MODULES="$(BUILDJDK_MODULES)" \
+ )
ALL_TARGETS += create-buildjdk-copy create-buildjdk-interim-image
@@ -581,6 +605,9 @@
product-bundles:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f Bundles.gmk product-bundles)
+legacy-bundles:
+ +($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f Bundles.gmk legacy-bundles)
+
test-bundles:
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f Bundles.gmk test-bundles)
@@ -592,7 +619,7 @@
+($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f Bundles.gmk jcov-bundles)
endif
-ALL_TARGETS += product-bundles test-bundles docs-bundles jcov-bundles
+ALL_TARGETS += product-bundles legacy-bundles test-bundles docs-bundles jcov-bundles
################################################################################
# Install targets
@@ -625,7 +652,7 @@
interim-langtools: $(INTERIM_LANGTOOLS_GENSRC_TARGETS)
- buildtools-jdk: interim-langtools interim-cldrconverter
+ buildtools-jdk: interim-langtools interim-cldrconverter interim-tzdb
buildtools-hotspot: interim-langtools
@@ -647,7 +674,6 @@
# Declare dependencies between hotspot-<variant>* targets
$(foreach v, $(JVM_VARIANTS), \
- $(eval hotspot-$v: hotspot-$v-gensrc hotspot-$v-libs) \
$(eval hotspot-$v-gensrc: java.base-copy) \
$(eval hotspot-$v-libs: hotspot-$v-gensrc java.base-copy) \
)
@@ -671,7 +697,7 @@
# The demos are currently linking to libjvm and libjava, just like all other
# jdk libs, even though they don't need to. To avoid warnings, make sure they
# aren't built until after libjava and libjvm are available to link to.
- demos-jdk: java.base-libs exploded-image-optimize
+ demos-jdk: java.base-libs exploded-image
test-image-demos-jdk: demos-jdk
# Declare dependency from <module>-java to <module>-gensrc
@@ -681,17 +707,15 @@
$(foreach m, $(JAVA_MODULES), \
$(eval $m-java: $(addsuffix -java, $(filter $(JAVA_MODULES), \
$(call FindDepsForModule,$m)))))
+ # Declare dependencies between the module meta targets
+ $(foreach m, $(ALL_MODULES), $(eval $m: $(call FindDepsForModule,$m)))
# Declare dependencies between <module>-rmic to <module>-java
$(foreach m, $(RMIC_MODULES), $(eval $m-rmic: $m-java))
# Declare dependencies from <module>-lib to <module>-java
# Skip modules that do not have java source.
- # When creating a BUILDJDK, the java compilation has already been done by the
- # normal build and copied in.
- ifneq ($(CREATING_BUILDJDK), true)
- $(foreach m, $(filter $(JAVA_MODULES), $(LIBS_MODULES)), $(eval $m-libs: $m-java))
- endif
+ $(foreach m, $(filter $(JAVA_MODULES), $(LIBS_MODULES)), $(eval $m-libs: $m-java))
# Declare dependencies from all other <module>-lib to java.base-lib
$(foreach t, $(filter-out java.base-libs, $(LIBS_TARGETS)), \
@@ -729,7 +753,7 @@
# Declare dependencies between jmod targets.
# java.base jmod needs jrt-fs.jar and access to the other jmods to be built.
- # When creating a BUILDJDK, we don't need to add hashes to java.base, thus
+ # When creating the BUILDJDK, we don't need to add hashes to java.base, thus
# we don't need to depend on all other jmods
ifneq ($(CREATING_BUILDJDK), true)
java.base-jmod: jrtfs-jar $(filter-out java.base-jmod, $(JMOD_TARGETS))
@@ -742,11 +766,7 @@
java.base-jmod: $(JVM_MAIN_TARGETS)
# Declare dependencies from <module>-jmod to all other module targets
- # When creating a BUILDJDK, the java compilation has already been done by the
- # normal build and copied in.
- ifneq ($(CREATING_BUILDJDK), true)
- $(foreach m, $(JAVA_MODULES), $(eval $m_JMOD_DEPS += $m-java))
- endif
+ $(foreach m, $(JAVA_MODULES), $(eval $m_JMOD_DEPS += $m-java))
$(foreach m, $(GENDATA_MODULES), $(eval $m_JMOD_DEPS += $m-gendata))
$(foreach m, $(RMIC_MODULES), $(eval $m_JMOD_DEPS += $m-rmic))
$(foreach m, $(LIBS_MODULES), $(eval $m_JMOD_DEPS += $m-libs))
@@ -771,34 +791,37 @@
compile-commands-hotspot: $(COMPILE_COMMANDS_TARGETS_HOTSPOT)
compile-commands: $(COMPILE_COMMANDS_TARGETS_HOTSPOT) $(COMPILE_COMMANDS_TARGETS_JDK)
+ vscode-project: compile-commands
+ vscode-project-clangd: compile-commands
+ vscode-project-rtags: compile-commands
+ vscode-project-ccls: compile-commands
+
# Jmods cannot be created until we have the jmod tool ready to run. During
# a normal build we run it from the exploded image, but when cross compiling
# it's run from the buildjdk, which is either created at build time or user
# supplied.
- #
- # For the exploded image to be runnable, all java modules and
- # jdk.jlink-launchers need to be built. We also need to copy jvm.cfg (done
- # in java.base-copy) and tzdb.dat (done in java.base-gendata) to the
- # appropriate location otherwise jimage, jlink and jmod won't start. This
- # also applies when creating the buildjdk.
- DEFAULT_JMOD_DEPS += java.base-libs java.base-copy java.base-gendata \
- jdk.jlink-launchers
- # When cross compiling and buildjdk is to be created, depend on creating the
- # buildjdk instead of the default dependencies.
ifeq ($(CREATE_BUILDJDK), true)
- # Avoid calling create-buildjdk from within a create-buildjdk call.
ifneq ($(CREATING_BUILDJDK), true)
+ # When cross compiling and buildjdk is to be created, simply depend on
+ # creating the buildjdk.
$(JMOD_TARGETS): create-buildjdk
buildtools-modules: create-buildjdk
else
- # While actually creating the buildjdk, the default deps applies.
- $(JMOD_TARGETS) $(INTERIM_JMOD_TARGETS): $(DEFAULT_JMOD_DEPS)
+ # While actually creating the buildjdk, we need to list the bare
+ # minimum dependencies needed before running jmod, to avoid building
+ # more than necessary. This includes:
+ # * all java modules
+ # * jdk.jlink-launchers
+ # * copy jvm.cfg (done in java.base-copy)
+ # * tzdb.dat (done in java.base-gendata)
+ # Without all of these jimage, jlink and jmod won't start.
+ $(JMOD_TARGETS) $(INTERIM_JMOD_TARGETS): java.base-libs java.base-copy \
+ java.base-gendata jdk.jlink-launchers java
endif
else
- # The normal non cross compilation case uses the default deps.
- # To avoid races with the optimize target, that also needs to happen first.
- $(JMOD_TARGETS) $(INTERIM_JMOD_TARGETS): $(DEFAULT_JMOD_DEPS) \
- exploded-image-optimize
+ # The normal non cross compilation case uses needs to wait for the full
+ # exploded-image to avoid a race with the optimize target.
+ $(JMOD_TARGETS) $(INTERIM_JMOD_TARGETS): exploded-image
endif
# All modules include the main license files from java.base.
@@ -866,11 +889,13 @@
JVM_DOCS_TARGETS ?= hotspot-$(JVM_VARIANT_MAIN)-gensrc
# The gensrc steps for hotspot and jdk.jdi create html spec files.
- docs-jdk-specs: $(JVM_DOCS_TARGETS) jdk.jdi-gensrc \
+ docs-jdk-specs: buildtools-jdk $(JVM_DOCS_TARGETS) jdk.jdi-gensrc \
docs-jdk-index
docs-zip: docs-jdk
+ docs-specs-zip: docs-jdk-specs
+
# Tests
test: jdk-image test-image
@@ -886,14 +911,9 @@
$(foreach t, $(filter-out test-make%, $(ALL_TEST_TARGETS)), $(eval $t: jdk-image test-image))
$(foreach t, $(ALL_EXPLODED_TEST_TARGETS), $(eval $t: exploded-image test-image))
- create-buildjdk-copy: jdk.jlink-java java.base-gendata \
- $(addsuffix -java, $(INTERIM_IMAGE_MODULES))
-
- create-buildjdk-interim-image: create-buildjdk-copy
-
interim-image: $(INTERIM_JMOD_TARGETS)
- build-test-lib: exploded-image-optimize
+ build-test-lib: exploded-image
build-test-failure-handler: interim-langtools
@@ -904,7 +924,7 @@
build-test-jdk-jtreg-native: buildtools-jdk java.base-libs
- build-test-hotspot-jtreg-graal: exploded-image-optimize
+ build-test-hotspot-jtreg-graal: exploded-image
test-image-hotspot-jtreg-native: build-test-hotspot-jtreg-native
@@ -918,6 +938,8 @@
product-bundles: product-images
+ legacy-bundles: legacy-images
+
test-bundles: test-image
docs-bundles: docs-image
@@ -938,6 +960,10 @@
buildtools: buildtools-langtools interim-langtools interim-rmic \
buildtools-jdk $(JVM_TOOLS_TARGETS)
+# Declare dependencies from hotspot-<variant> targets
+$(foreach v, $(JVM_VARIANTS), \
+ $(eval hotspot-$v: hotspot-$v-gensrc hotspot-$v-libs) \
+)
hotspot: $(HOTSPOT_VARIANT_TARGETS)
# Create targets hotspot-libs and hotspot-gensrc.
@@ -990,7 +1016,7 @@
exploded-image: exploded-image-optimize
endif
-create-buildjdk: create-buildjdk-copy create-buildjdk-interim-image
+create-buildjdk: create-buildjdk-interim-image
docs-jdk-api: docs-jdk-api-javadoc
docs-javase-api: docs-javase-api-javadoc
@@ -1020,6 +1046,9 @@
# (and possibly other, more specific versions)
product-images: jdk-image symbols-image exploded-image
+# This target builds the legacy images, e.g. the legacy JRE image
+legacy-images: legacy-jre-image
+
# zip-security is actually a bundle, but for now it needs to be considered
# an image until this can be cleaned up properly.
product-images: zip-security
@@ -1036,6 +1065,8 @@
ifeq ($(call isTargetOs, macosx), true)
product-images: mac-jdk-bundle
+
+ legacy-images: mac-legacy-jre-bundle
endif
# This target builds the documentation image
@@ -1070,7 +1101,7 @@
jdk.jdwp.agent-gensrc $(ALL_MODULES) demos \
exploded-image-base exploded-image \
create-buildjdk docs-jdk-api docs-javase-api docs-reference-api docs-jdk \
- docs-javase docs-reference docs-javadoc mac-bundles product-images \
+ docs-javase docs-reference docs-javadoc mac-bundles product-images legacy-images \
docs-image test-image all-images \
all-bundles