author | stefank |
Tue, 02 Jul 2019 12:10:18 +0200 | |
changeset 55553 | b9171be3cf2a |
parent 55536 | 8313c42345d5 |
child 55554 | 46579c68f7f4 |
permissions | -rw-r--r-- |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
1 |
/* |
53223
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
2 |
* Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved. |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
4 |
* |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
8 |
* |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
13 |
* accompanied this code). |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
14 |
* |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
18 |
* |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
21 |
* questions. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
22 |
*/ |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
23 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
24 |
#include "precompiled.hpp" |
55307 | 25 |
#include "opto/castnode.hpp" |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
26 |
#include "opto/compile.hpp" |
52568 | 27 |
#include "opto/escape.hpp" |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
28 |
#include "opto/graphKit.hpp" |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
29 |
#include "opto/loopnode.hpp" |
55307 | 30 |
#include "opto/machnode.hpp" |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
31 |
#include "opto/macro.hpp" |
55307 | 32 |
#include "opto/memnode.hpp" |
33 |
#include "opto/movenode.hpp" |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
34 |
#include "opto/node.hpp" |
55307 | 35 |
#include "opto/phase.hpp" |
36 |
#include "opto/phaseX.hpp" |
|
37 |
#include "opto/rootnode.hpp" |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
38 |
#include "opto/type.hpp" |
55307 | 39 |
#include "utilities/copy.hpp" |
40 |
#include "utilities/growableArray.hpp" |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
41 |
#include "utilities/macros.hpp" |
53407 | 42 |
#include "gc/z/zBarrierSet.hpp" |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
43 |
#include "gc/z/c2/zBarrierSetC2.hpp" |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
44 |
#include "gc/z/zThreadLocalData.hpp" |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
45 |
#include "gc/z/zBarrierSetRuntime.hpp" |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
46 |
|
53439 | 47 |
ZBarrierSetC2State::ZBarrierSetC2State(Arena* comp_arena) : |
48 |
_load_barrier_nodes(new (comp_arena) GrowableArray<LoadBarrierNode*>(comp_arena, 8, 0, NULL)) {} |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
49 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
50 |
int ZBarrierSetC2State::load_barrier_count() const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
51 |
return _load_barrier_nodes->length(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
52 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
53 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
54 |
void ZBarrierSetC2State::add_load_barrier_node(LoadBarrierNode * n) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
55 |
assert(!_load_barrier_nodes->contains(n), " duplicate entry in expand list"); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
56 |
_load_barrier_nodes->append(n); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
57 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
58 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
59 |
void ZBarrierSetC2State::remove_load_barrier_node(LoadBarrierNode * n) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
60 |
// this function may be called twice for a node so check |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
61 |
// that the node is in the array before attempting to remove it |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
62 |
if (_load_barrier_nodes->contains(n)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
63 |
_load_barrier_nodes->remove(n); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
64 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
65 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
66 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
67 |
LoadBarrierNode* ZBarrierSetC2State::load_barrier_node(int idx) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
68 |
return _load_barrier_nodes->at(idx); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
69 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
70 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
71 |
void* ZBarrierSetC2::create_barrier_state(Arena* comp_arena) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
72 |
return new(comp_arena) ZBarrierSetC2State(comp_arena); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
73 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
74 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
75 |
ZBarrierSetC2State* ZBarrierSetC2::state() const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
76 |
return reinterpret_cast<ZBarrierSetC2State*>(Compile::current()->barrier_set_state()); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
77 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
78 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
79 |
bool ZBarrierSetC2::is_gc_barrier_node(Node* node) const { |
51485
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
80 |
// 1. This step follows potential oop projections of a load barrier before expansion |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
81 |
if (node->is_Proj()) { |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
82 |
node = node->in(0); |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
83 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
84 |
|
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
85 |
// 2. This step checks for unexpanded load barriers |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
86 |
if (node->is_LoadBarrier()) { |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
87 |
return true; |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
88 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
89 |
|
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
90 |
// 3. This step checks for the phi corresponding to an optimized load barrier expansion |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
91 |
if (node->is_Phi()) { |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
92 |
PhiNode* phi = node->as_Phi(); |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
93 |
Node* n = phi->in(1); |
55307 | 94 |
if (n != NULL && n->is_LoadBarrierSlowReg()) { |
51485
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
95 |
return true; |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
96 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
97 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
98 |
|
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
99 |
return false; |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
100 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
101 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
102 |
void ZBarrierSetC2::register_potential_barrier_node(Node* node) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
103 |
if (node->is_LoadBarrier()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
104 |
state()->add_load_barrier_node(node->as_LoadBarrier()); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
105 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
106 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
107 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
108 |
void ZBarrierSetC2::unregister_potential_barrier_node(Node* node) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
109 |
if (node->is_LoadBarrier()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
110 |
state()->remove_load_barrier_node(node->as_LoadBarrier()); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
111 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
112 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
113 |
|
52224
4f2215a00ed1
8212611: Small collection of simple changes from shenandoah
roland
parents:
52036
diff
changeset
|
114 |
void ZBarrierSetC2::eliminate_useless_gc_barriers(Unique_Node_List &useful, Compile* C) const { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
115 |
// Remove useless LoadBarrier nodes |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
116 |
ZBarrierSetC2State* s = state(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
117 |
for (int i = s->load_barrier_count()-1; i >= 0; i--) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
118 |
LoadBarrierNode* n = s->load_barrier_node(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
119 |
if (!useful.member(n)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
120 |
unregister_potential_barrier_node(n); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
121 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
122 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
123 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
124 |
|
52224
4f2215a00ed1
8212611: Small collection of simple changes from shenandoah
roland
parents:
52036
diff
changeset
|
125 |
void ZBarrierSetC2::enqueue_useful_gc_barrier(PhaseIterGVN* igvn, Node* node) const { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
126 |
if (node->is_LoadBarrier() && !node->as_LoadBarrier()->has_true_uses()) { |
52224
4f2215a00ed1
8212611: Small collection of simple changes from shenandoah
roland
parents:
52036
diff
changeset
|
127 |
igvn->_worklist.push(node); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
128 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
129 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
130 |
|
55553
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
131 |
const uint NoBarrier = 0; |
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
132 |
const uint RequireBarrier = 1; |
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
133 |
const uint WeakBarrier = 2; |
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
134 |
const uint ExpandedBarrier = 4; |
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
135 |
|
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
136 |
static bool load_require_barrier(LoadNode* load) { return (load->barrier_data() & RequireBarrier) == RequireBarrier; } |
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
137 |
static bool load_has_weak_barrier(LoadNode* load) { return (load->barrier_data() & WeakBarrier) == WeakBarrier; } |
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
138 |
static bool load_has_expanded_barrier(LoadNode* load) { return (load->barrier_data() & ExpandedBarrier) == ExpandedBarrier; } |
55307 | 139 |
static void load_set_expanded_barrier(LoadNode* load) { return load->set_barrier_data(ExpandedBarrier); } |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
140 |
|
55553
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
141 |
static void load_set_barrier(LoadNode* load, bool weak) { |
55307 | 142 |
if (weak) { |
55553
b9171be3cf2a
8225770: ZGC: C2: Generates on_weak instead of on_strong barriers
stefank
parents:
55536
diff
changeset
|
143 |
load->set_barrier_data(RequireBarrier | WeakBarrier); |
55307 | 144 |
} else { |
145 |
load->set_barrier_data(RequireBarrier); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
146 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
147 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
148 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
149 |
// == LoadBarrierNode == |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
150 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
151 |
LoadBarrierNode::LoadBarrierNode(Compile* C, |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
152 |
Node* c, |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
153 |
Node* mem, |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
154 |
Node* val, |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
155 |
Node* adr, |
55307 | 156 |
bool weak) : |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
157 |
MultiNode(Number_of_Inputs), |
55307 | 158 |
_weak(weak) { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
159 |
init_req(Control, c); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
160 |
init_req(Memory, mem); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
161 |
init_req(Oop, val); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
162 |
init_req(Address, adr); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
163 |
init_req(Similar, C->top()); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
164 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
165 |
init_class_id(Class_LoadBarrier); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
166 |
BarrierSetC2* bs = BarrierSet::barrier_set()->barrier_set_c2(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
167 |
bs->register_potential_barrier_node(this); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
168 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
169 |
|
53223
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
170 |
uint LoadBarrierNode::size_of() const { |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
171 |
return sizeof(*this); |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
172 |
} |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
173 |
|
54327 | 174 |
bool LoadBarrierNode::cmp(const Node& n) const { |
53223
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
175 |
ShouldNotReachHere(); |
54327 | 176 |
return false; |
53223
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
177 |
} |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
178 |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
179 |
const Type *LoadBarrierNode::bottom_type() const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
180 |
const Type** floadbarrier = (const Type **)(Compile::current()->type_arena()->Amalloc_4((Number_of_Outputs)*sizeof(Type*))); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
181 |
Node* in_oop = in(Oop); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
182 |
floadbarrier[Control] = Type::CONTROL; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
183 |
floadbarrier[Memory] = Type::MEMORY; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
184 |
floadbarrier[Oop] = in_oop == NULL ? Type::TOP : in_oop->bottom_type(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
185 |
return TypeTuple::make(Number_of_Outputs, floadbarrier); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
186 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
187 |
|
53223
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
188 |
const TypePtr* LoadBarrierNode::adr_type() const { |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
189 |
ShouldNotReachHere(); |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
190 |
return NULL; |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
191 |
} |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
192 |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
193 |
const Type *LoadBarrierNode::Value(PhaseGVN *phase) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
194 |
const Type** floadbarrier = (const Type **)(phase->C->type_arena()->Amalloc_4((Number_of_Outputs)*sizeof(Type*))); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
195 |
const Type* val_t = phase->type(in(Oop)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
196 |
floadbarrier[Control] = Type::CONTROL; |
55307 | 197 |
floadbarrier[Memory] = Type::MEMORY; |
198 |
floadbarrier[Oop] = val_t; |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
199 |
return TypeTuple::make(Number_of_Outputs, floadbarrier); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
200 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
201 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
202 |
bool LoadBarrierNode::is_dominator(PhaseIdealLoop* phase, bool linear_only, Node *d, Node *n) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
203 |
if (phase != NULL) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
204 |
return phase->is_dominator(d, n); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
205 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
206 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
207 |
for (int i = 0; i < 10 && n != NULL; i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
208 |
n = IfNode::up_one_dom(n, linear_only); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
209 |
if (n == d) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
210 |
return true; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
211 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
212 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
213 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
214 |
return false; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
215 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
216 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
217 |
LoadBarrierNode* LoadBarrierNode::has_dominating_barrier(PhaseIdealLoop* phase, bool linear_only, bool look_for_similar) { |
55307 | 218 |
if (is_weak()) { |
219 |
// Weak barriers can't be eliminated |
|
220 |
return NULL; |
|
221 |
} |
|
222 |
||
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
223 |
Node* val = in(LoadBarrierNode::Oop); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
224 |
if (in(Similar)->is_Proj() && in(Similar)->in(0)->is_LoadBarrier()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
225 |
LoadBarrierNode* lb = in(Similar)->in(0)->as_LoadBarrier(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
226 |
assert(lb->in(Address) == in(Address), ""); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
227 |
// Load barrier on Similar edge dominates so if it now has the Oop field it can replace this barrier. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
228 |
if (lb->in(Oop) == in(Oop)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
229 |
return lb; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
230 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
231 |
// Follow chain of load barrier through Similar edges |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
232 |
while (!lb->in(Similar)->is_top()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
233 |
lb = lb->in(Similar)->in(0)->as_LoadBarrier(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
234 |
assert(lb->in(Address) == in(Address), ""); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
235 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
236 |
if (lb != in(Similar)->in(0)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
237 |
return lb; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
238 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
239 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
240 |
for (DUIterator_Fast imax, i = val->fast_outs(imax); i < imax; i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
241 |
Node* u = val->fast_out(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
242 |
if (u != this && u->is_LoadBarrier() && u->in(Oop) == val && u->as_LoadBarrier()->has_true_uses()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
243 |
Node* this_ctrl = in(LoadBarrierNode::Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
244 |
Node* other_ctrl = u->in(LoadBarrierNode::Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
245 |
if (is_dominator(phase, linear_only, other_ctrl, this_ctrl)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
246 |
return u->as_LoadBarrier(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
247 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
248 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
249 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
250 |
|
55307 | 251 |
if (can_be_eliminated()) { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
252 |
return NULL; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
253 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
254 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
255 |
if (!look_for_similar) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
256 |
return NULL; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
257 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
258 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
259 |
Node* addr = in(LoadBarrierNode::Address); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
260 |
for (DUIterator_Fast imax, i = addr->fast_outs(imax); i < imax; i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
261 |
Node* u = addr->fast_out(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
262 |
if (u != this && u->is_LoadBarrier() && u->as_LoadBarrier()->has_true_uses()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
263 |
Node* this_ctrl = in(LoadBarrierNode::Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
264 |
Node* other_ctrl = u->in(LoadBarrierNode::Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
265 |
if (is_dominator(phase, linear_only, other_ctrl, this_ctrl)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
266 |
ResourceMark rm; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
267 |
Unique_Node_List wq; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
268 |
wq.push(in(LoadBarrierNode::Control)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
269 |
bool ok = true; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
270 |
bool dom_found = false; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
271 |
for (uint next = 0; next < wq.size(); ++next) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
272 |
Node *n = wq.at(next); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
273 |
if (n->is_top()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
274 |
return NULL; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
275 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
276 |
assert(n->is_CFG(), ""); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
277 |
if (n->is_SafePoint()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
278 |
ok = false; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
279 |
break; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
280 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
281 |
if (n == u) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
282 |
dom_found = true; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
283 |
continue; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
284 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
285 |
if (n->is_Region()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
286 |
for (uint i = 1; i < n->req(); i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
287 |
Node* m = n->in(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
288 |
if (m != NULL) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
289 |
wq.push(m); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
290 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
291 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
292 |
} else { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
293 |
Node* m = n->in(0); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
294 |
if (m != NULL) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
295 |
wq.push(m); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
296 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
297 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
298 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
299 |
if (ok) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
300 |
assert(dom_found, ""); |
55307 | 301 |
return u->as_LoadBarrier(); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
302 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
303 |
break; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
304 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
305 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
306 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
307 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
308 |
return NULL; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
309 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
310 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
311 |
void LoadBarrierNode::push_dominated_barriers(PhaseIterGVN* igvn) const { |
50875
2217b2fc29ea
8205993: ZGC: Fix typos and incorrect indentations
pliden
parents:
50803
diff
changeset
|
312 |
// Change to that barrier may affect a dominated barrier so re-push those |
55307 | 313 |
assert(!is_weak(), "sanity"); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
314 |
Node* val = in(LoadBarrierNode::Oop); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
315 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
316 |
for (DUIterator_Fast imax, i = val->fast_outs(imax); i < imax; i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
317 |
Node* u = val->fast_out(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
318 |
if (u != this && u->is_LoadBarrier() && u->in(Oop) == val) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
319 |
Node* this_ctrl = in(Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
320 |
Node* other_ctrl = u->in(Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
321 |
if (is_dominator(NULL, false, this_ctrl, other_ctrl)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
322 |
igvn->_worklist.push(u); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
323 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
324 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
325 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
326 |
Node* addr = in(LoadBarrierNode::Address); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
327 |
for (DUIterator_Fast imax, i = addr->fast_outs(imax); i < imax; i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
328 |
Node* u = addr->fast_out(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
329 |
if (u != this && u->is_LoadBarrier() && u->in(Similar)->is_top()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
330 |
Node* this_ctrl = in(Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
331 |
Node* other_ctrl = u->in(Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
332 |
if (is_dominator(NULL, false, this_ctrl, other_ctrl)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
333 |
igvn->_worklist.push(u); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
334 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
335 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
336 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
337 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
338 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
339 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
340 |
Node *LoadBarrierNode::Identity(PhaseGVN *phase) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
341 |
LoadBarrierNode* dominating_barrier = has_dominating_barrier(NULL, true, false); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
342 |
if (dominating_barrier != NULL) { |
55307 | 343 |
assert(!is_weak(), "Weak barriers cant be eliminated"); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
344 |
assert(dominating_barrier->in(Oop) == in(Oop), ""); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
345 |
return dominating_barrier; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
346 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
347 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
348 |
return this; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
349 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
350 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
351 |
Node *LoadBarrierNode::Ideal(PhaseGVN *phase, bool can_reshape) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
352 |
if (remove_dead_region(phase, can_reshape)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
353 |
return this; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
354 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
355 |
|
55307 | 356 |
Node *val = in(Oop); |
357 |
Node *mem = in(Memory); |
|
358 |
Node *ctrl = in(Control); |
|
359 |
||
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
360 |
assert(val->Opcode() != Op_LoadN, ""); |
55307 | 361 |
assert(val->Opcode() != Op_DecodeN, ""); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
362 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
363 |
if (mem->is_MergeMem()) { |
55307 | 364 |
Node *new_mem = mem->as_MergeMem()->memory_at(Compile::AliasIdxRaw); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
365 |
set_req(Memory, new_mem); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
366 |
if (mem->outcnt() == 0 && can_reshape) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
367 |
phase->is_IterGVN()->_worklist.push(mem); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
368 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
369 |
return this; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
370 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
371 |
|
55307 | 372 |
LoadBarrierNode *dominating_barrier = NULL; |
373 |
if (!is_weak()) { |
|
374 |
dominating_barrier = has_dominating_barrier(NULL, !can_reshape, !phase->C->major_progress()); |
|
375 |
if (dominating_barrier != NULL && dominating_barrier->in(Oop) != in(Oop)) { |
|
376 |
assert(in(Address) == dominating_barrier->in(Address), ""); |
|
377 |
set_req(Similar, dominating_barrier->proj_out(Oop)); |
|
378 |
return this; |
|
379 |
} |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
380 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
381 |
|
55307 | 382 |
bool eliminate = can_reshape && (dominating_barrier != NULL || !has_true_uses()); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
383 |
if (eliminate) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
384 |
if (can_reshape) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
385 |
PhaseIterGVN* igvn = phase->is_IterGVN(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
386 |
Node* out_ctrl = proj_out_or_null(Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
387 |
Node* out_res = proj_out_or_null(Oop); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
388 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
389 |
if (out_ctrl != NULL) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
390 |
igvn->replace_node(out_ctrl, ctrl); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
391 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
392 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
393 |
// That transformation may cause the Similar edge on the load barrier to be invalid |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
394 |
fix_similar_in_uses(igvn); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
395 |
if (out_res != NULL) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
396 |
if (dominating_barrier != NULL) { |
55307 | 397 |
assert(!is_weak(), "Sanity"); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
398 |
igvn->replace_node(out_res, dominating_barrier->proj_out(Oop)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
399 |
} else { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
400 |
igvn->replace_node(out_res, val); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
401 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
402 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
403 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
404 |
return new ConINode(TypeInt::ZERO); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
405 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
406 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
407 |
// If the Similar edge is no longer a load barrier, clear it |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
408 |
Node* similar = in(Similar); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
409 |
if (!similar->is_top() && !(similar->is_Proj() && similar->in(0)->is_LoadBarrier())) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
410 |
set_req(Similar, phase->C->top()); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
411 |
return this; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
412 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
413 |
|
55307 | 414 |
if (can_reshape && !is_weak()) { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
415 |
// If this barrier is linked through the Similar edge by a |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
416 |
// dominated barrier and both barriers have the same Oop field, |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
417 |
// the dominated barrier can go away, so push it for reprocessing. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
418 |
// We also want to avoid a barrier to depend on another dominating |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
419 |
// barrier through its Similar edge that itself depend on another |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
420 |
// barrier through its Similar edge and rather have the first |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
421 |
// depend on the third. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
422 |
PhaseIterGVN* igvn = phase->is_IterGVN(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
423 |
Node* out_res = proj_out(Oop); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
424 |
for (DUIterator_Fast imax, i = out_res->fast_outs(imax); i < imax; i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
425 |
Node* u = out_res->fast_out(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
426 |
if (u->is_LoadBarrier() && u->in(Similar) == out_res && |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
427 |
(u->in(Oop) == val || !u->in(Similar)->is_top())) { |
55307 | 428 |
assert(!u->as_LoadBarrier()->is_weak(), "Sanity"); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
429 |
igvn->_worklist.push(u); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
430 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
431 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
432 |
push_dominated_barriers(igvn); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
433 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
434 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
435 |
return NULL; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
436 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
437 |
|
53223
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
438 |
uint LoadBarrierNode::match_edge(uint idx) const { |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
439 |
ShouldNotReachHere(); |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
440 |
return 0; |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
441 |
} |
df6cbf676c70
8215708: ZGC: Add missing LoadBarrierNode::size_of()
pliden
parents:
52829
diff
changeset
|
442 |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
443 |
void LoadBarrierNode::fix_similar_in_uses(PhaseIterGVN* igvn) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
444 |
Node* out_res = proj_out_or_null(Oop); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
445 |
if (out_res == NULL) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
446 |
return; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
447 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
448 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
449 |
for (DUIterator_Fast imax, i = out_res->fast_outs(imax); i < imax; i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
450 |
Node* u = out_res->fast_out(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
451 |
if (u->is_LoadBarrier() && u->in(Similar) == out_res) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
452 |
igvn->replace_input_of(u, Similar, igvn->C->top()); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
453 |
--i; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
454 |
--imax; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
455 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
456 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
457 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
458 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
459 |
bool LoadBarrierNode::has_true_uses() const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
460 |
Node* out_res = proj_out_or_null(Oop); |
55307 | 461 |
if (out_res != NULL) { |
462 |
for (DUIterator_Fast imax, i = out_res->fast_outs(imax); i < imax; i++) { |
|
463 |
Node *u = out_res->fast_out(i); |
|
464 |
if (!u->is_LoadBarrier() || u->in(Similar) != out_res) { |
|
465 |
return true; |
|
466 |
} |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
467 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
468 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
469 |
return false; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
470 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
471 |
|
52424 | 472 |
static bool barrier_needed(C2Access& access) { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
473 |
return ZBarrierSet::barrier_needed(access.decorators(), access.type()); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
474 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
475 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
476 |
Node* ZBarrierSetC2::load_at_resolved(C2Access& access, const Type* val_type) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
477 |
Node* p = BarrierSetC2::load_at_resolved(access, val_type); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
478 |
if (!barrier_needed(access)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
479 |
return p; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
480 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
481 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
482 |
bool weak = (access.decorators() & ON_WEAK_OOP_REF) != 0; |
55307 | 483 |
if (p->isa_Load()) { |
484 |
load_set_barrier(p->as_Load(), weak); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
485 |
} |
55307 | 486 |
return p; |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
487 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
488 |
|
52424 | 489 |
Node* ZBarrierSetC2::atomic_cmpxchg_val_at_resolved(C2AtomicParseAccess& access, Node* expected_val, |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
490 |
Node* new_val, const Type* val_type) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
491 |
Node* result = BarrierSetC2::atomic_cmpxchg_val_at_resolved(access, expected_val, new_val, val_type); |
55307 | 492 |
LoadStoreNode* lsn = result->as_LoadStore(); |
493 |
if (barrier_needed(access)) { |
|
494 |
lsn->set_has_barrier(); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
495 |
} |
55307 | 496 |
return lsn; |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
497 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
498 |
|
52424 | 499 |
Node* ZBarrierSetC2::atomic_cmpxchg_bool_at_resolved(C2AtomicParseAccess& access, Node* expected_val, |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
500 |
Node* new_val, const Type* value_type) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
501 |
Node* result = BarrierSetC2::atomic_cmpxchg_bool_at_resolved(access, expected_val, new_val, value_type); |
55307 | 502 |
LoadStoreNode* lsn = result->as_LoadStore(); |
503 |
if (barrier_needed(access)) { |
|
504 |
lsn->set_has_barrier(); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
505 |
} |
55307 | 506 |
return lsn; |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
507 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
508 |
|
52424 | 509 |
Node* ZBarrierSetC2::atomic_xchg_at_resolved(C2AtomicParseAccess& access, Node* new_val, const Type* val_type) const { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
510 |
Node* result = BarrierSetC2::atomic_xchg_at_resolved(access, new_val, val_type); |
55307 | 511 |
LoadStoreNode* lsn = result->as_LoadStore(); |
512 |
if (barrier_needed(access)) { |
|
513 |
lsn->set_has_barrier(); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
514 |
} |
55307 | 515 |
return lsn; |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
516 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
517 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
518 |
// == Macro Expansion == |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
519 |
|
55307 | 520 |
// Optimized, low spill, loadbarrier variant using stub specialized on register used |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
521 |
void ZBarrierSetC2::expand_loadbarrier_node(PhaseMacroExpand* phase, LoadBarrierNode* barrier) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
522 |
PhaseIterGVN &igvn = phase->igvn(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
523 |
float unlikely = PROB_UNLIKELY(0.999); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
524 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
525 |
Node* in_ctrl = barrier->in(LoadBarrierNode::Control); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
526 |
Node* in_mem = barrier->in(LoadBarrierNode::Memory); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
527 |
Node* in_val = barrier->in(LoadBarrierNode::Oop); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
528 |
Node* in_adr = barrier->in(LoadBarrierNode::Address); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
529 |
|
55536
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
530 |
Node* out_ctrl = barrier->proj_out(LoadBarrierNode::Control); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
531 |
Node* out_res = barrier->proj_out(LoadBarrierNode::Oop); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
532 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
533 |
assert(barrier->in(LoadBarrierNode::Oop) != NULL, "oop to loadbarrier node cannot be null"); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
534 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
535 |
Node* jthread = igvn.transform(new ThreadLocalNode()); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
536 |
Node* adr = phase->basic_plus_adr(jthread, in_bytes(ZThreadLocalData::address_bad_mask_offset())); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
537 |
Node* bad_mask = igvn.transform(LoadNode::make(igvn, in_ctrl, in_mem, adr, |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
538 |
TypeRawPtr::BOTTOM, TypeX_X, TypeX_X->basic_type(), |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
539 |
MemNode::unordered)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
540 |
Node* cast = igvn.transform(new CastP2XNode(in_ctrl, in_val)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
541 |
Node* obj_masked = igvn.transform(new AndXNode(cast, bad_mask)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
542 |
Node* cmp = igvn.transform(new CmpXNode(obj_masked, igvn.zerocon(TypeX_X->basic_type()))); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
543 |
Node *bol = igvn.transform(new BoolNode(cmp, BoolTest::ne))->as_Bool(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
544 |
IfNode* iff = igvn.transform(new IfNode(in_ctrl, bol, unlikely, COUNT_UNKNOWN))->as_If(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
545 |
Node* then = igvn.transform(new IfTrueNode(iff)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
546 |
Node* elsen = igvn.transform(new IfFalseNode(iff)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
547 |
|
55307 | 548 |
Node* new_loadp = igvn.transform(new LoadBarrierSlowRegNode(then, in_mem, in_adr, in_val->adr_type(), |
549 |
(const TypePtr*) in_val->bottom_type(), MemNode::unordered, barrier->is_weak())); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
550 |
|
50875
2217b2fc29ea
8205993: ZGC: Fix typos and incorrect indentations
pliden
parents:
50803
diff
changeset
|
551 |
// Create the final region/phi pair to converge cntl/data paths to downstream code |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
552 |
Node* result_region = igvn.transform(new RegionNode(3)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
553 |
result_region->set_req(1, then); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
554 |
result_region->set_req(2, elsen); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
555 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
556 |
Node* result_phi = igvn.transform(new PhiNode(result_region, TypeInstPtr::BOTTOM)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
557 |
result_phi->set_req(1, new_loadp); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
558 |
result_phi->set_req(2, barrier->in(LoadBarrierNode::Oop)); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
559 |
|
55536
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
560 |
|
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
561 |
igvn.replace_node(out_ctrl, result_region); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
562 |
igvn.replace_node(out_res, result_phi); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
563 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
564 |
assert(barrier->outcnt() == 0,"LoadBarrier macro node has non-null outputs after expansion!"); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
565 |
|
55307 | 566 |
igvn.remove_dead_node(barrier); |
567 |
igvn.remove_dead_node(out_ctrl); |
|
568 |
igvn.remove_dead_node(out_res); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
569 |
|
51485
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
570 |
assert(is_gc_barrier_node(result_phi), "sanity"); |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
571 |
assert(step_over_gc_barrier(result_phi) == in_val, "sanity"); |
55307 | 572 |
|
573 |
phase->C->print_method(PHASE_BARRIER_EXPANSION, 4, barrier->_idx); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
574 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
575 |
|
52711 | 576 |
bool ZBarrierSetC2::expand_barriers(Compile* C, PhaseIterGVN& igvn) const { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
577 |
ZBarrierSetC2State* s = state(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
578 |
if (s->load_barrier_count() > 0) { |
52829
af52abc1f61e
8214541: ZGC: Refactoring from JDK-8214172 may leave PhaseIterGVN::_delay_transform set
roland
parents:
52759
diff
changeset
|
579 |
PhaseMacroExpand macro(igvn); |
55307 | 580 |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
581 |
int skipped = 0; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
582 |
while (s->load_barrier_count() > skipped) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
583 |
int load_barrier_count = s->load_barrier_count(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
584 |
LoadBarrierNode * n = s->load_barrier_node(load_barrier_count-1-skipped); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
585 |
if (igvn.type(n) == Type::TOP || (n->in(0) != NULL && n->in(0)->is_top())) { |
50875
2217b2fc29ea
8205993: ZGC: Fix typos and incorrect indentations
pliden
parents:
50803
diff
changeset
|
586 |
// Node is unreachable, so don't try to expand it |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
587 |
s->remove_load_barrier_node(n); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
588 |
continue; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
589 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
590 |
if (!n->can_be_eliminated()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
591 |
skipped++; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
592 |
continue; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
593 |
} |
52711 | 594 |
expand_loadbarrier_node(¯o, n); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
595 |
assert(s->load_barrier_count() < load_barrier_count, "must have deleted a node from load barrier list"); |
53439 | 596 |
if (C->failing()) { |
597 |
return true; |
|
598 |
} |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
599 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
600 |
while (s->load_barrier_count() > 0) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
601 |
int load_barrier_count = s->load_barrier_count(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
602 |
LoadBarrierNode* n = s->load_barrier_node(load_barrier_count - 1); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
603 |
assert(!(igvn.type(n) == Type::TOP || (n->in(0) != NULL && n->in(0)->is_top())), "should have been processed already"); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
604 |
assert(!n->can_be_eliminated(), "should have been processed already"); |
52711 | 605 |
expand_loadbarrier_node(¯o, n); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
606 |
assert(s->load_barrier_count() < load_barrier_count, "must have deleted a node from load barrier list"); |
53439 | 607 |
if (C->failing()) { |
608 |
return true; |
|
609 |
} |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
610 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
611 |
igvn.set_delay_transform(false); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
612 |
igvn.optimize(); |
53439 | 613 |
if (C->failing()) { |
614 |
return true; |
|
615 |
} |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
616 |
} |
53439 | 617 |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
618 |
return false; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
619 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
620 |
|
51485
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
621 |
Node* ZBarrierSetC2::step_over_gc_barrier(Node* c) const { |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
622 |
Node* node = c; |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
623 |
|
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
624 |
// 1. This step follows potential oop projections of a load barrier before expansion |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
625 |
if (node->is_Proj()) { |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
626 |
node = node->in(0); |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
627 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
628 |
|
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
629 |
// 2. This step checks for unexpanded load barriers |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
630 |
if (node->is_LoadBarrier()) { |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
631 |
return node->in(LoadBarrierNode::Oop); |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
632 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
633 |
|
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
634 |
// 3. This step checks for the phi corresponding to an optimized load barrier expansion |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
635 |
if (node->is_Phi()) { |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
636 |
PhiNode* phi = node->as_Phi(); |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
637 |
Node* n = phi->in(1); |
55307 | 638 |
if (n != NULL && n->is_LoadBarrierSlowReg()) { |
51485
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
639 |
assert(c == node, "projections from step 1 should only be seen before macro expansion"); |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
640 |
return phi->in(2); |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
641 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
642 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
643 |
|
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
644 |
return c; |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
645 |
} |
0c7040d1d1ca
8208601: Introduce native oop barriers in C2 for OopHandle
eosterlund
parents:
50875
diff
changeset
|
646 |
|
55536
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
647 |
Node* ZBarrierSetC2::step_over_gc_barrier_ctrl(Node* c) const { |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
648 |
Node* node = c; |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
649 |
|
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
650 |
// 1. This step follows potential ctrl projections of a load barrier before expansion |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
651 |
if (node->is_Proj()) { |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
652 |
node = node->in(0); |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
653 |
} |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
654 |
|
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
655 |
// 2. This step checks for unexpanded load barriers |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
656 |
if (node->is_LoadBarrier()) { |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
657 |
return node->in(LoadBarrierNode::Control); |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
658 |
} |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
659 |
|
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
660 |
return c; |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
661 |
} |
8313c42345d5
8226287: Make process_users_of_allocation handle gc barriers
neliasso
parents:
55326
diff
changeset
|
662 |
|
52036
5d6d636cefff
8211776: 8210887 broke arraycopy optimization when ZGC is enabled
roland
parents:
51489
diff
changeset
|
663 |
bool ZBarrierSetC2::array_copy_requires_gc_barriers(bool tightly_coupled_alloc, BasicType type, bool is_clone, ArrayCopyPhase phase) const { |
5d6d636cefff
8211776: 8210887 broke arraycopy optimization when ZGC is enabled
roland
parents:
51489
diff
changeset
|
664 |
return type == T_OBJECT || type == T_ARRAY; |
5d6d636cefff
8211776: 8210887 broke arraycopy optimization when ZGC is enabled
roland
parents:
51489
diff
changeset
|
665 |
} |
5d6d636cefff
8211776: 8210887 broke arraycopy optimization when ZGC is enabled
roland
parents:
51489
diff
changeset
|
666 |
|
52471
04d7e790aa2e
8213489: GC/C2 abstraction for Compile::final_graph_reshaping()
rkennke
parents:
52426
diff
changeset
|
667 |
bool ZBarrierSetC2::final_graph_reshaping(Compile* compile, Node* n, uint opcode) const { |
55307 | 668 |
switch (opcode) { |
669 |
case Op_LoadBarrier: |
|
670 |
assert(0, "There should be no load barriers left"); |
|
671 |
case Op_ZGetAndSetP: |
|
672 |
case Op_ZCompareAndExchangeP: |
|
673 |
case Op_ZCompareAndSwapP: |
|
674 |
case Op_ZWeakCompareAndSwapP: |
|
675 |
case Op_LoadBarrierSlowReg: |
|
52471
04d7e790aa2e
8213489: GC/C2 abstraction for Compile::final_graph_reshaping()
rkennke
parents:
52426
diff
changeset
|
676 |
#ifdef ASSERT |
55307 | 677 |
if (VerifyOptoOopOffsets) { |
678 |
MemNode *mem = n->as_Mem(); |
|
679 |
// Check to see if address types have grounded out somehow. |
|
680 |
const TypeInstPtr *tp = mem->in(MemNode::Address)->bottom_type()->isa_instptr(); |
|
681 |
ciInstanceKlass *k = tp->klass()->as_instance_klass(); |
|
682 |
bool oop_offset_is_sane = k->contains_field_offset(tp->offset()); |
|
683 |
assert(!tp || oop_offset_is_sane, ""); |
|
684 |
} |
|
685 |
#endif |
|
686 |
return true; |
|
687 |
default: |
|
688 |
return false; |
|
53439 | 689 |
} |
52471
04d7e790aa2e
8213489: GC/C2 abstraction for Compile::final_graph_reshaping()
rkennke
parents:
52426
diff
changeset
|
690 |
} |
04d7e790aa2e
8213489: GC/C2 abstraction for Compile::final_graph_reshaping()
rkennke
parents:
52426
diff
changeset
|
691 |
|
52627 | 692 |
bool ZBarrierSetC2::matcher_find_shared_visit(Matcher* matcher, Matcher::MStack& mstack, Node* n, uint opcode, bool& mem_op, int& mem_addr_idx) const { |
55307 | 693 |
switch(opcode) { |
694 |
case Op_CallLeaf: |
|
695 |
if (n->as_Call()->entry_point() == ZBarrierSetRuntime::load_barrier_on_oop_field_preloaded_addr() || |
|
696 |
n->as_Call()->entry_point() == ZBarrierSetRuntime::load_barrier_on_weak_oop_field_preloaded_addr()) { |
|
697 |
mem_op = true; |
|
698 |
mem_addr_idx = TypeFunc::Parms + 1; |
|
699 |
return true; |
|
700 |
} |
|
701 |
return false; |
|
702 |
default: |
|
703 |
return false; |
|
52627 | 704 |
} |
55307 | 705 |
} |
53439 | 706 |
|
55307 | 707 |
bool ZBarrierSetC2::matcher_find_shared_post_visit(Matcher* matcher, Node* n, uint opcode) const { |
708 |
switch(opcode) { |
|
709 |
case Op_ZCompareAndExchangeP: |
|
710 |
case Op_ZCompareAndSwapP: |
|
711 |
case Op_ZWeakCompareAndSwapP: { |
|
712 |
Node *mem = n->in(MemNode::Address); |
|
713 |
Node *keepalive = n->in(5); |
|
714 |
Node *pair1 = new BinaryNode(mem, keepalive); |
|
715 |
||
716 |
Node *newval = n->in(MemNode::ValueIn); |
|
717 |
Node *oldval = n->in(LoadStoreConditionalNode::ExpectedIn); |
|
718 |
Node *pair2 = new BinaryNode(oldval, newval); |
|
719 |
||
720 |
n->set_req(MemNode::Address, pair1); |
|
721 |
n->set_req(MemNode::ValueIn, pair2); |
|
722 |
n->del_req(5); |
|
723 |
n->del_req(LoadStoreConditionalNode::ExpectedIn); |
|
724 |
return true; |
|
725 |
} |
|
726 |
case Op_ZGetAndSetP: { |
|
727 |
Node *keepalive = n->in(4); |
|
728 |
Node *newval = n->in(MemNode::ValueIn); |
|
729 |
Node *pair = new BinaryNode(newval, keepalive); |
|
730 |
n->set_req(MemNode::ValueIn, pair); |
|
731 |
n->del_req(4); |
|
732 |
return true; |
|
733 |
} |
|
734 |
||
735 |
default: |
|
736 |
return false; |
|
737 |
} |
|
52627 | 738 |
} |
739 |
||
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
740 |
// == Verification == |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
741 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
742 |
#ifdef ASSERT |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
743 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
744 |
static bool look_for_barrier(Node* n, bool post_parse, VectorSet& visited) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
745 |
if (visited.test_set(n->_idx)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
746 |
return true; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
747 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
748 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
749 |
for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
750 |
Node* u = n->fast_out(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
751 |
if (u->is_LoadBarrier()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
752 |
} else if ((u->is_Phi() || u->is_CMove()) && !post_parse) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
753 |
if (!look_for_barrier(u, post_parse, visited)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
754 |
return false; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
755 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
756 |
} else if (u->Opcode() == Op_EncodeP || u->Opcode() == Op_DecodeN) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
757 |
if (!look_for_barrier(u, post_parse, visited)) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
758 |
return false; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
759 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
760 |
} else if (u->Opcode() != Op_SCMemProj) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
761 |
tty->print("bad use"); u->dump(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
762 |
return false; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
763 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
764 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
765 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
766 |
return true; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
767 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
768 |
|
52426
38bf0c9c4e64
8213384: Move G1/C2 barrier verification into G1BarrierSetC2
rkennke
parents:
52424
diff
changeset
|
769 |
void ZBarrierSetC2::verify_gc_barriers(Compile* compile, CompilePhase phase) const { |
55307 | 770 |
switch(phase) { |
771 |
case BarrierSetC2::BeforeOptimize: |
|
772 |
case BarrierSetC2::BeforeLateInsertion: |
|
773 |
assert(state()->load_barrier_count() == 0, "No barriers inserted yet"); |
|
774 |
break; |
|
775 |
case BarrierSetC2::BeforeMacroExpand: |
|
776 |
// Barrier placement should be set by now. |
|
777 |
verify_gc_barriers(false /*post_parse*/); |
|
778 |
break; |
|
779 |
case BarrierSetC2::BeforeCodeGen: |
|
780 |
// Barriers has been fully expanded. |
|
781 |
assert(state()->load_barrier_count() == 0, "No more macro barriers"); |
|
782 |
break; |
|
783 |
default: |
|
784 |
assert(0, "Phase without verification"); |
|
785 |
} |
|
52426
38bf0c9c4e64
8213384: Move G1/C2 barrier verification into G1BarrierSetC2
rkennke
parents:
52424
diff
changeset
|
786 |
} |
38bf0c9c4e64
8213384: Move G1/C2 barrier verification into G1BarrierSetC2
rkennke
parents:
52424
diff
changeset
|
787 |
|
55307 | 788 |
// post_parse implies that there might be load barriers without uses after parsing |
789 |
// That only applies when adding barriers at parse time. |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
790 |
void ZBarrierSetC2::verify_gc_barriers(bool post_parse) const { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
791 |
ZBarrierSetC2State* s = state(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
792 |
Compile* C = Compile::current(); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
793 |
ResourceMark rm; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
794 |
VectorSet visited(Thread::current()->resource_area()); |
55307 | 795 |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
796 |
for (int i = 0; i < s->load_barrier_count(); i++) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
797 |
LoadBarrierNode* n = s->load_barrier_node(i); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
798 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
799 |
// The dominating barrier on the same address if it exists and |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
800 |
// this barrier must not be applied on the value from the same |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
801 |
// load otherwise the value is not reloaded before it's used the |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
802 |
// second time. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
803 |
assert(n->in(LoadBarrierNode::Similar)->is_top() || |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
804 |
(n->in(LoadBarrierNode::Similar)->in(0)->is_LoadBarrier() && |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
805 |
n->in(LoadBarrierNode::Similar)->in(0)->in(LoadBarrierNode::Address) == n->in(LoadBarrierNode::Address) && |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
806 |
n->in(LoadBarrierNode::Similar)->in(0)->in(LoadBarrierNode::Oop) != n->in(LoadBarrierNode::Oop)), |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
807 |
"broken similar edge"); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
808 |
|
55307 | 809 |
assert(n->as_LoadBarrier()->has_true_uses(), |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
810 |
"found unneeded load barrier"); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
811 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
812 |
// Several load barrier nodes chained through their Similar edge |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
813 |
// break the code that remove the barriers in final graph reshape. |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
814 |
assert(n->in(LoadBarrierNode::Similar)->is_top() || |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
815 |
(n->in(LoadBarrierNode::Similar)->in(0)->is_LoadBarrier() && |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
816 |
n->in(LoadBarrierNode::Similar)->in(0)->in(LoadBarrierNode::Similar)->is_top()), |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
817 |
"chain of Similar load barriers"); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
818 |
|
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
819 |
if (!n->in(LoadBarrierNode::Similar)->is_top()) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
820 |
ResourceMark rm; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
821 |
Unique_Node_List wq; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
822 |
Node* other = n->in(LoadBarrierNode::Similar)->in(0); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
823 |
wq.push(n); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
824 |
for (uint next = 0; next < wq.size(); ++next) { |
55307 | 825 |
Node *nn = wq.at(next); |
826 |
assert(nn->is_CFG(), ""); |
|
827 |
assert(!nn->is_SafePoint(), ""); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
828 |
|
55307 | 829 |
if (nn == other) { |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
830 |
continue; |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
831 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
832 |
|
55307 | 833 |
if (nn->is_Region()) { |
834 |
for (uint i = 1; i < nn->req(); i++) { |
|
835 |
Node* m = nn->in(i); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
836 |
if (m != NULL) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
837 |
wq.push(m); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
838 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
839 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
840 |
} else { |
55307 | 841 |
Node* m = nn->in(0); |
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
842 |
if (m != NULL) { |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
843 |
wq.push(m); |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
844 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
845 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
846 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
847 |
} |
55307 | 848 |
} |
849 |
} |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
850 |
|
55307 | 851 |
#endif // end verification code |
852 |
||
853 |
static void call_catch_cleanup_one(PhaseIdealLoop* phase, LoadNode* load, Node* ctrl); |
|
854 |
||
855 |
// This code is cloning all uses of a load that is between a call and the catch blocks, |
|
856 |
// to each use. |
|
857 |
||
858 |
static bool fixup_uses_in_catch(PhaseIdealLoop *phase, Node *start_ctrl, Node *node) { |
|
859 |
||
860 |
if (!phase->has_ctrl(node)) { |
|
861 |
// This node is floating - doesn't need to be cloned. |
|
862 |
assert(node != start_ctrl, "check"); |
|
863 |
return false; |
|
864 |
} |
|
865 |
||
866 |
Node* ctrl = phase->get_ctrl(node); |
|
867 |
if (ctrl != start_ctrl) { |
|
868 |
// We are in a successor block - the node is ok. |
|
869 |
return false; // Unwind |
|
870 |
} |
|
871 |
||
872 |
// Process successor nodes |
|
873 |
int outcnt = node->outcnt(); |
|
874 |
for (int i = 0; i < outcnt; i++) { |
|
875 |
Node* n = node->raw_out(0); |
|
876 |
assert(!n->is_LoadBarrier(), "Sanity"); |
|
877 |
// Calling recursively, visiting leafs first |
|
878 |
fixup_uses_in_catch(phase, start_ctrl, n); |
|
879 |
} |
|
880 |
||
881 |
// Now all successors are outside |
|
882 |
// - Clone this node to both successors |
|
883 |
int no_succs = node->outcnt(); |
|
884 |
assert(!node->is_Store(), "Stores not expected here"); |
|
885 |
||
886 |
// In some very rare cases a load that doesn't need a barrier will end up here |
|
887 |
// Treat it as a LoadP and the insertion of phis will be done correctly. |
|
888 |
if (node->is_Load()) { |
|
889 |
call_catch_cleanup_one(phase, node->as_Load(), phase->get_ctrl(node)); |
|
890 |
} else { |
|
891 |
for (DUIterator_Fast jmax, i = node->fast_outs(jmax); i < jmax; i++) { |
|
892 |
Node* use = node->fast_out(i); |
|
893 |
Node* clone = node->clone(); |
|
894 |
assert(clone->outcnt() == 0, ""); |
|
895 |
||
896 |
assert(use->find_edge(node) != -1, "check"); |
|
897 |
phase->igvn().rehash_node_delayed(use); |
|
898 |
use->replace_edge(node, clone); |
|
899 |
||
900 |
Node* new_ctrl; |
|
901 |
if (use->is_block_start()) { |
|
902 |
new_ctrl = use; |
|
903 |
} else if (use->is_CFG()) { |
|
904 |
new_ctrl = use->in(0); |
|
905 |
assert (new_ctrl != NULL, ""); |
|
906 |
} else { |
|
907 |
new_ctrl = phase->get_ctrl(use); |
|
908 |
} |
|
909 |
||
910 |
phase->set_ctrl(clone, new_ctrl); |
|
911 |
||
912 |
if (phase->C->directive()->ZTraceLoadBarriersOption) tty->print_cr(" Clone op %i as %i to control %i", node->_idx, clone->_idx, new_ctrl->_idx); |
|
913 |
phase->igvn().register_new_node_with_optimizer(clone); |
|
914 |
--i, --jmax; |
|
915 |
} |
|
916 |
assert(node->outcnt() == 0, "must be empty now"); |
|
917 |
||
918 |
// Node node is dead. |
|
919 |
phase->igvn().remove_dead_node(node); |
|
920 |
} |
|
921 |
return true; // unwind - return if a use was processed |
|
922 |
} |
|
923 |
||
924 |
// Clone a load to a specific catch_proj |
|
925 |
static Node* clone_load_to_catchproj(PhaseIdealLoop* phase, Node* load, Node* catch_proj) { |
|
926 |
Node* cloned_load = load->clone(); |
|
927 |
cloned_load->set_req(0, catch_proj); // set explicit control |
|
928 |
phase->set_ctrl(cloned_load, catch_proj); // update |
|
929 |
if (phase->C->directive()->ZTraceLoadBarriersOption) tty->print_cr(" Clone LOAD %i as %i to control %i", load->_idx, cloned_load->_idx, catch_proj->_idx); |
|
930 |
phase->igvn().register_new_node_with_optimizer(cloned_load); |
|
931 |
return cloned_load; |
|
932 |
} |
|
933 |
||
934 |
static Node* get_dominating_region(PhaseIdealLoop* phase, Node* node, Node* stop) { |
|
935 |
Node* region = node; |
|
936 |
while (!region->isa_Region()) { |
|
937 |
Node *up = phase->idom(region); |
|
938 |
assert(up != region, "Must not loop"); |
|
939 |
assert(up != stop, "Must not find original control"); |
|
940 |
region = up; |
|
941 |
} |
|
942 |
return region; |
|
943 |
} |
|
944 |
||
945 |
// Clone this load to each catch block |
|
946 |
static void call_catch_cleanup_one(PhaseIdealLoop* phase, LoadNode* load, Node* ctrl) { |
|
947 |
bool trace = phase->C->directive()->ZTraceLoadBarriersOption; |
|
948 |
phase->igvn().set_delay_transform(true); |
|
949 |
||
950 |
// Verify pre conditions |
|
951 |
assert(ctrl->isa_Proj() && ctrl->in(0)->isa_Call(), "Must be a call proj"); |
|
952 |
assert(ctrl->raw_out(0)->isa_Catch(), "Must be a catch"); |
|
953 |
||
954 |
if (ctrl->raw_out(0)->isa_Catch()->outcnt() == 1) { |
|
955 |
if (trace) tty->print_cr("Cleaning up catch: Skipping load %i, call with single catch", load->_idx); |
|
956 |
return; |
|
957 |
} |
|
958 |
||
959 |
// Process the loads successor nodes - if any is between |
|
960 |
// the call and the catch blocks, they need to be cloned to. |
|
961 |
// This is done recursively |
|
962 |
int outcnt = load->outcnt(); |
|
963 |
uint index = 0; |
|
964 |
for (int i = 0; i < outcnt; i++) { |
|
965 |
if (index < load->outcnt()) { |
|
966 |
Node *n = load->raw_out(index); |
|
967 |
assert(!n->is_LoadBarrier(), "Sanity"); |
|
968 |
if (!fixup_uses_in_catch(phase, ctrl, n)) { |
|
969 |
// if no successor was cloned, progress to next out. |
|
970 |
index++; |
|
971 |
} |
|
972 |
} |
|
973 |
} |
|
974 |
||
975 |
// Now all the loads uses has been cloned down |
|
976 |
// Only thing left is to clone the loads, but they must end up |
|
977 |
// first in the catch blocks. |
|
978 |
||
979 |
// We clone the loads oo the catch blocks only when needed. |
|
980 |
// An array is used to map the catch blocks to each lazily cloned load. |
|
981 |
// In that way no extra unnecessary loads are cloned. |
|
982 |
||
983 |
// Any use dominated by original block must have an phi and a region added |
|
984 |
||
985 |
Node* catch_node = ctrl->raw_out(0); |
|
986 |
int number_of_catch_projs = catch_node->outcnt(); |
|
987 |
Node** proj_to_load_mapping = NEW_RESOURCE_ARRAY(Node*, number_of_catch_projs); |
|
988 |
Copy::zero_to_bytes(proj_to_load_mapping, sizeof(Node*) * number_of_catch_projs); |
|
989 |
||
990 |
// The phi_map is used to keep track of where phis have already been inserted |
|
991 |
int phi_map_len = phase->C->unique(); |
|
992 |
Node** phi_map = NEW_RESOURCE_ARRAY(Node*, phi_map_len); |
|
993 |
Copy::zero_to_bytes(phi_map, sizeof(Node*) * phi_map_len); |
|
994 |
||
995 |
for (unsigned int i = 0; i < load->outcnt(); i++) { |
|
996 |
Node* load_use_control = NULL; |
|
997 |
Node* load_use = load->raw_out(i); |
|
998 |
||
999 |
if (phase->has_ctrl(load_use)) { |
|
1000 |
load_use_control = phase->get_ctrl(load_use); |
|
1001 |
} else { |
|
1002 |
load_use_control = load_use->in(0); |
|
1003 |
} |
|
1004 |
assert(load_use_control != NULL, "sanity"); |
|
1005 |
if (trace) tty->print_cr(" Handling use: %i, with control: %i", load_use->_idx, load_use_control->_idx); |
|
1006 |
||
1007 |
// Some times the loads use is a phi. For them we need to determine from which catch block |
|
1008 |
// the use is defined. |
|
1009 |
bool load_use_is_phi = false; |
|
1010 |
unsigned int load_use_phi_index = 0; |
|
1011 |
Node* phi_ctrl = NULL; |
|
1012 |
if (load_use->is_Phi()) { |
|
1013 |
// Find phi input that matches load |
|
1014 |
for (unsigned int u = 1; u < load_use->req(); u++) { |
|
1015 |
if (load_use->in(u) == load) { |
|
1016 |
load_use_is_phi = true; |
|
1017 |
load_use_phi_index = u; |
|
1018 |
assert(load_use->in(0)->is_Region(), "Region or broken"); |
|
1019 |
phi_ctrl = load_use->in(0)->in(u); |
|
1020 |
assert(phi_ctrl->is_CFG(), "check"); |
|
1021 |
assert(phi_ctrl != load, "check"); |
|
1022 |
break; |
|
1023 |
} |
|
1024 |
} |
|
1025 |
assert(load_use_is_phi, "must find"); |
|
1026 |
assert(load_use_phi_index > 0, "sanity"); |
|
1027 |
} |
|
1028 |
||
1029 |
// For each load use, see which catch projs dominates, create load clone lazily and reconnect |
|
1030 |
bool found_dominating_catchproj = false; |
|
1031 |
for (int c = 0; c < number_of_catch_projs; c++) { |
|
1032 |
Node* catchproj = catch_node->raw_out(c); |
|
1033 |
assert(catchproj != NULL && catchproj->isa_CatchProj(), "Sanity"); |
|
1034 |
||
1035 |
if (!phase->is_dominator(catchproj, load_use_control)) { |
|
1036 |
if (load_use_is_phi && phase->is_dominator(catchproj, phi_ctrl)) { |
|
1037 |
// The loads use is local to the catchproj. |
|
1038 |
// fall out and replace load with catch-local load clone. |
|
1039 |
} else { |
|
1040 |
continue; |
|
1041 |
} |
|
1042 |
} |
|
1043 |
assert(!found_dominating_catchproj, "Max one should match"); |
|
1044 |
||
1045 |
// Clone loads to catch projs |
|
1046 |
Node* load_clone = proj_to_load_mapping[c]; |
|
1047 |
if (load_clone == NULL) { |
|
1048 |
load_clone = clone_load_to_catchproj(phase, load, catchproj); |
|
1049 |
proj_to_load_mapping[c] = load_clone; |
|
1050 |
} |
|
1051 |
phase->igvn().rehash_node_delayed(load_use); |
|
1052 |
||
1053 |
if (load_use_is_phi) { |
|
1054 |
// phis are special - the load is defined from a specific control flow |
|
1055 |
load_use->set_req(load_use_phi_index, load_clone); |
|
1056 |
} else { |
|
1057 |
// Multipe edges can be replaced at once - on calls for example |
|
1058 |
load_use->replace_edge(load, load_clone); |
|
1059 |
} |
|
1060 |
--i; // more than one edge can have been removed, but the next is in later iterations |
|
1061 |
||
1062 |
// We could break the for-loop after finding a dominating match. |
|
1063 |
// But keep iterating to catch any bad idom early. |
|
1064 |
found_dominating_catchproj = true; |
|
1065 |
} |
|
1066 |
||
1067 |
// We found no single catchproj that dominated the use - The use is at a point after |
|
1068 |
// where control flow from multiple catch projs have merged. We will have to create |
|
1069 |
// phi nodes before the use and tie the output from the cloned loads together. It |
|
1070 |
// can be a single phi or a number of chained phis, depending on control flow |
|
1071 |
if (!found_dominating_catchproj) { |
|
1072 |
||
1073 |
// Use phi-control if use is a phi |
|
1074 |
if (load_use_is_phi) { |
|
1075 |
load_use_control = phi_ctrl; |
|
1076 |
} |
|
1077 |
assert(phase->is_dominator(ctrl, load_use_control), "Common use but no dominator"); |
|
1078 |
||
1079 |
// Clone a load on all paths |
|
1080 |
for (int c = 0; c < number_of_catch_projs; c++) { |
|
1081 |
Node* catchproj = catch_node->raw_out(c); |
|
1082 |
Node* load_clone = proj_to_load_mapping[c]; |
|
1083 |
if (load_clone == NULL) { |
|
1084 |
load_clone = clone_load_to_catchproj(phase, load, catchproj); |
|
1085 |
proj_to_load_mapping[c] = load_clone; |
|
1086 |
} |
|
1087 |
} |
|
1088 |
||
1089 |
// Move up dominator tree from use until dom front is reached |
|
1090 |
Node* next_region = get_dominating_region(phase, load_use_control, ctrl); |
|
1091 |
while (phase->idom(next_region) != catch_node) { |
|
1092 |
next_region = phase->idom(next_region); |
|
1093 |
if (trace) tty->print_cr("Moving up idom to region ctrl %i", next_region->_idx); |
|
1094 |
} |
|
1095 |
assert(phase->is_dominator(catch_node, next_region), "Sanity"); |
|
1096 |
||
1097 |
// Create or reuse phi node that collect all cloned loads and feed it to the use. |
|
1098 |
Node* test_phi = phi_map[next_region->_idx]; |
|
1099 |
if ((test_phi != NULL) && test_phi->is_Phi()) { |
|
1100 |
// Reuse an already created phi |
|
1101 |
if (trace) tty->print_cr(" Using cached Phi %i on load_use %i", test_phi->_idx, load_use->_idx); |
|
1102 |
phase->igvn().rehash_node_delayed(load_use); |
|
1103 |
load_use->replace_edge(load, test_phi); |
|
1104 |
// Now this use is done |
|
1105 |
} else { |
|
1106 |
// Otherwise we need to create one or more phis |
|
1107 |
PhiNode* next_phi = new PhiNode(next_region, load->type()); |
|
1108 |
phi_map[next_region->_idx] = next_phi; // cache new phi |
|
1109 |
phase->igvn().rehash_node_delayed(load_use); |
|
1110 |
load_use->replace_edge(load, next_phi); |
|
1111 |
||
1112 |
int dominators_of_region = 0; |
|
1113 |
do { |
|
1114 |
// New phi, connect to region and add all loads as in. |
|
1115 |
Node* region = next_region; |
|
1116 |
assert(region->isa_Region() && region->req() > 2, "Catch dead region nodes"); |
|
1117 |
PhiNode* new_phi = next_phi; |
|
1118 |
||
1119 |
if (trace) tty->print_cr("Created Phi %i on load %i with control %i", new_phi->_idx, load->_idx, region->_idx); |
|
1120 |
||
1121 |
// Need to add all cloned loads to the phi, taking care that the right path is matched |
|
1122 |
dominators_of_region = 0; // reset for new region |
|
1123 |
for (unsigned int reg_i = 1; reg_i < region->req(); reg_i++) { |
|
1124 |
Node* region_pred = region->in(reg_i); |
|
1125 |
assert(region_pred->is_CFG(), "check"); |
|
1126 |
bool pred_has_dominator = false; |
|
1127 |
for (int c = 0; c < number_of_catch_projs; c++) { |
|
1128 |
Node* catchproj = catch_node->raw_out(c); |
|
1129 |
if (phase->is_dominator(catchproj, region_pred)) { |
|
1130 |
new_phi->set_req(reg_i, proj_to_load_mapping[c]); |
|
1131 |
if (trace) tty->print_cr(" - Phi in(%i) set to load %i", reg_i, proj_to_load_mapping[c]->_idx); |
|
1132 |
pred_has_dominator = true; |
|
1133 |
dominators_of_region++; |
|
1134 |
break; |
|
1135 |
} |
|
1136 |
} |
|
1137 |
||
1138 |
// Sometimes we need to chain several phis. |
|
1139 |
if (!pred_has_dominator) { |
|
1140 |
assert(dominators_of_region <= 1, "More than one region can't require extra phi"); |
|
1141 |
if (trace) tty->print_cr(" - Region %i pred %i not dominated by catch proj", region->_idx, region_pred->_idx); |
|
1142 |
// Continue search on on this region_pred |
|
1143 |
// - walk up to next region |
|
1144 |
// - create a new phi and connect to first new_phi |
|
1145 |
next_region = get_dominating_region(phase, region_pred, ctrl); |
|
1146 |
||
1147 |
// Lookup if there already is a phi, create a new otherwise |
|
1148 |
Node* test_phi = phi_map[next_region->_idx]; |
|
1149 |
if ((test_phi != NULL) && test_phi->is_Phi()) { |
|
1150 |
next_phi = test_phi->isa_Phi(); |
|
1151 |
dominators_of_region++; // record that a match was found and that we are done |
|
1152 |
if (trace) tty->print_cr(" Using cached phi Phi %i on control %i", next_phi->_idx, next_region->_idx); |
|
1153 |
} else { |
|
1154 |
next_phi = new PhiNode(next_region, load->type()); |
|
1155 |
phi_map[next_region->_idx] = next_phi; |
|
1156 |
} |
|
1157 |
new_phi->set_req(reg_i, next_phi); |
|
1158 |
} |
|
1159 |
} |
|
1160 |
||
1161 |
new_phi->set_req(0, region); |
|
1162 |
phase->igvn().register_new_node_with_optimizer(new_phi); |
|
1163 |
phase->set_ctrl(new_phi, region); |
|
1164 |
||
1165 |
assert(dominators_of_region != 0, "Must have found one this iteration"); |
|
1166 |
} while (dominators_of_region == 1); |
|
1167 |
} |
|
1168 |
--i; |
|
1169 |
} |
|
1170 |
} // end of loop over uses |
|
1171 |
||
1172 |
assert(load->outcnt() == 0, "All uses should be handled"); |
|
1173 |
phase->igvn().remove_dead_node(load); |
|
1174 |
phase->C->print_method(PHASE_CALL_CATCH_CLEANUP, 4, load->_idx); |
|
1175 |
||
1176 |
// Now we should be home |
|
1177 |
phase->igvn().set_delay_transform(false); |
|
1178 |
} |
|
1179 |
||
1180 |
// Sort out the loads that are between a call ant its catch blocks |
|
1181 |
static void process_catch_cleanup_candidate(PhaseIdealLoop* phase, LoadNode* load) { |
|
1182 |
bool trace = phase->C->directive()->ZTraceLoadBarriersOption; |
|
1183 |
||
1184 |
Node* ctrl = phase->get_ctrl(load); |
|
1185 |
if (!ctrl->is_Proj() || (ctrl->in(0) == NULL) || !ctrl->in(0)->isa_Call()) { |
|
1186 |
return; |
|
1187 |
} |
|
1188 |
||
1189 |
Node* catch_node = ctrl->isa_Proj()->raw_out(0); |
|
1190 |
if (catch_node->is_Catch()) { |
|
1191 |
if (catch_node->outcnt() > 1) { |
|
1192 |
call_catch_cleanup_one(phase, load, ctrl); |
|
1193 |
} else { |
|
1194 |
if (trace) tty->print_cr("Call catch cleanup with only one catch: load %i ", load->_idx); |
|
1195 |
} |
|
1196 |
} |
|
1197 |
} |
|
1198 |
||
1199 |
void ZBarrierSetC2::barrier_insertion_phase(Compile* C, PhaseIterGVN& igvn) const { |
|
1200 |
PhaseIdealLoop::optimize(igvn, LoopOptsZBarrierInsertion); |
|
1201 |
if (C->failing()) return; |
|
1202 |
} |
|
1203 |
||
1204 |
bool ZBarrierSetC2::optimize_loops(PhaseIdealLoop* phase, LoopOptsMode mode, VectorSet& visited, Node_Stack& nstack, Node_List& worklist) const { |
|
1205 |
||
1206 |
if (mode == LoopOptsZBarrierInsertion) { |
|
1207 |
// First make sure all loads between call and catch are moved to the catch block |
|
1208 |
clean_catch_blocks(phase); |
|
1209 |
||
1210 |
// Then expand barriers on all loads |
|
1211 |
insert_load_barriers(phase); |
|
1212 |
||
1213 |
// Handle all Unsafe that need barriers. |
|
1214 |
insert_barriers_on_unsafe(phase); |
|
1215 |
||
1216 |
phase->C->clear_major_progress(); |
|
1217 |
return true; |
|
1218 |
} else { |
|
1219 |
return false; |
|
1220 |
} |
|
1221 |
} |
|
1222 |
||
1223 |
static bool can_simplify_cas(LoadStoreNode* node) { |
|
1224 |
if (node->isa_LoadStoreConditional()) { |
|
1225 |
Node *expected_in = node->as_LoadStoreConditional()->in(LoadStoreConditionalNode::ExpectedIn); |
|
1226 |
return (expected_in->get_ptr_type() == TypePtr::NULL_PTR); |
|
1227 |
} else { |
|
1228 |
return false; |
|
1229 |
} |
|
1230 |
} |
|
1231 |
||
1232 |
static void insert_barrier_before_unsafe(PhaseIdealLoop* phase, LoadStoreNode* old_node) { |
|
1233 |
||
1234 |
Compile *C = phase->C; |
|
1235 |
PhaseIterGVN &igvn = phase->igvn(); |
|
1236 |
LoadStoreNode* zclone = NULL; |
|
1237 |
bool is_weak = false; |
|
1238 |
||
1239 |
Node *in_ctrl = old_node->in(MemNode::Control); |
|
1240 |
Node *in_mem = old_node->in(MemNode::Memory); |
|
1241 |
Node *in_adr = old_node->in(MemNode::Address); |
|
1242 |
Node *in_val = old_node->in(MemNode::ValueIn); |
|
1243 |
const TypePtr *adr_type = old_node->adr_type(); |
|
1244 |
const TypePtr* load_type = TypeOopPtr::BOTTOM; // The type for the load we are adding |
|
1245 |
||
1246 |
switch (old_node->Opcode()) { |
|
1247 |
case Op_CompareAndExchangeP: { |
|
1248 |
zclone = new ZCompareAndExchangePNode(in_ctrl, in_mem, in_adr, in_val, old_node->in(LoadStoreConditionalNode::ExpectedIn), |
|
1249 |
adr_type, old_node->get_ptr_type(), ((CompareAndExchangeNode*)old_node)->order()); |
|
1250 |
load_type = old_node->bottom_type()->is_ptr(); |
|
1251 |
break; |
|
1252 |
} |
|
1253 |
case Op_WeakCompareAndSwapP: { |
|
1254 |
if (can_simplify_cas(old_node)) { |
|
1255 |
break; |
|
1256 |
} |
|
1257 |
is_weak = true; |
|
1258 |
zclone = new ZWeakCompareAndSwapPNode(in_ctrl, in_mem, in_adr, in_val, old_node->in(LoadStoreConditionalNode::ExpectedIn), |
|
1259 |
((CompareAndSwapNode*)old_node)->order()); |
|
1260 |
adr_type = TypePtr::BOTTOM; |
|
1261 |
break; |
|
1262 |
} |
|
1263 |
case Op_CompareAndSwapP: { |
|
1264 |
if (can_simplify_cas(old_node)) { |
|
1265 |
break; |
|
1266 |
} |
|
1267 |
zclone = new ZCompareAndSwapPNode(in_ctrl, in_mem, in_adr, in_val, old_node->in(LoadStoreConditionalNode::ExpectedIn), |
|
1268 |
((CompareAndSwapNode*)old_node)->order()); |
|
1269 |
adr_type = TypePtr::BOTTOM; |
|
1270 |
break; |
|
1271 |
} |
|
1272 |
case Op_GetAndSetP: { |
|
1273 |
zclone = new ZGetAndSetPNode(in_ctrl, in_mem, in_adr, in_val, old_node->adr_type(), old_node->get_ptr_type()); |
|
1274 |
load_type = old_node->bottom_type()->is_ptr(); |
|
1275 |
break; |
|
1276 |
} |
|
1277 |
} |
|
1278 |
if (zclone != NULL) { |
|
1279 |
igvn.register_new_node_with_optimizer(zclone, old_node); |
|
1280 |
||
1281 |
// Make load |
|
1282 |
LoadPNode *load = new LoadPNode(NULL, in_mem, in_adr, adr_type, load_type, MemNode::unordered, |
|
1283 |
LoadNode::DependsOnlyOnTest); |
|
1284 |
load_set_expanded_barrier(load); |
|
1285 |
igvn.register_new_node_with_optimizer(load); |
|
1286 |
igvn.replace_node(old_node, zclone); |
|
1287 |
||
1288 |
Node *barrier = new LoadBarrierNode(C, NULL, in_mem, load, in_adr, is_weak); |
|
1289 |
Node *barrier_val = new ProjNode(barrier, LoadBarrierNode::Oop); |
|
1290 |
Node *barrier_ctrl = new ProjNode(barrier, LoadBarrierNode::Control); |
|
1291 |
||
1292 |
igvn.register_new_node_with_optimizer(barrier); |
|
1293 |
igvn.register_new_node_with_optimizer(barrier_val); |
|
1294 |
igvn.register_new_node_with_optimizer(barrier_ctrl); |
|
1295 |
||
1296 |
// loop over all of in_ctrl usages and move to barrier_ctrl |
|
1297 |
for (DUIterator_Last imin, i = in_ctrl->last_outs(imin); i >= imin; --i) { |
|
1298 |
Node *use = in_ctrl->last_out(i); |
|
1299 |
uint l; |
|
1300 |
for (l = 0; use->in(l) != in_ctrl; l++) {} |
|
1301 |
igvn.replace_input_of(use, l, barrier_ctrl); |
|
1302 |
} |
|
1303 |
||
1304 |
load->set_req(MemNode::Control, in_ctrl); |
|
1305 |
barrier->set_req(LoadBarrierNode::Control, in_ctrl); |
|
1306 |
zclone->add_req(barrier_val); // add req as keep alive. |
|
1307 |
||
1308 |
C->print_method(PHASE_ADD_UNSAFE_BARRIER, 4, zclone->_idx); |
|
1309 |
} |
|
1310 |
} |
|
1311 |
||
1312 |
void ZBarrierSetC2::insert_barriers_on_unsafe(PhaseIdealLoop* phase) const { |
|
1313 |
Compile *C = phase->C; |
|
1314 |
PhaseIterGVN &igvn = phase->igvn(); |
|
1315 |
uint new_ids = C->unique(); |
|
1316 |
VectorSet visited(Thread::current()->resource_area()); |
|
1317 |
GrowableArray<Node *> nodeStack(Thread::current()->resource_area(), 0, 0, NULL); |
|
1318 |
nodeStack.push(C->root()); |
|
1319 |
visited.test_set(C->root()->_idx); |
|
1320 |
||
1321 |
// Traverse all nodes, visit all unsafe ops that require a barrier |
|
1322 |
while (nodeStack.length() > 0) { |
|
1323 |
Node *n = nodeStack.pop(); |
|
1324 |
||
1325 |
bool is_old_node = (n->_idx < new_ids); // don't process nodes that were created during cleanup |
|
1326 |
if (is_old_node) { |
|
1327 |
if (n->is_LoadStore()) { |
|
1328 |
LoadStoreNode* lsn = n->as_LoadStore(); |
|
1329 |
if (lsn->has_barrier()) { |
|
1330 |
BasicType bt = lsn->in(MemNode::Address)->bottom_type()->basic_type(); |
|
1331 |
assert ((bt == T_OBJECT || bt == T_ARRAY), "Sanity test"); |
|
1332 |
insert_barrier_before_unsafe(phase, lsn); |
|
1333 |
} |
|
1334 |
} |
|
1335 |
} |
|
1336 |
for (uint i = 0; i < n->len(); i++) { |
|
1337 |
if (n->in(i)) { |
|
1338 |
if (!visited.test_set(n->in(i)->_idx)) { |
|
1339 |
nodeStack.push(n->in(i)); |
|
1340 |
} |
|
1341 |
} |
|
1342 |
} |
|
1343 |
} |
|
1344 |
||
1345 |
igvn.optimize(); |
|
1346 |
C->print_method(PHASE_ADD_UNSAFE_BARRIER, 2); |
|
1347 |
} |
|
1348 |
||
1349 |
// The purpose of ZBarrierSetC2::clean_catch_blocks is to prepare the IR for |
|
1350 |
// splicing in load barrier nodes. |
|
1351 |
// |
|
1352 |
// The problem is that we might have instructions between a call and its catch nodes. |
|
1353 |
// (This is usually handled in PhaseCFG:call_catch_cleanup, which clones mach nodes in |
|
1354 |
// already scheduled blocks.) We can't have loads that require barriers there, |
|
1355 |
// because we need to splice in new control flow, and that would violate the IR. |
|
1356 |
// |
|
1357 |
// clean_catch_blocks find all Loads that require a barrier and clone them and any |
|
1358 |
// dependent instructions to each use. The loads must be in the beginning of the catch block |
|
1359 |
// before any store. |
|
1360 |
// |
|
1361 |
// Sometimes the loads use will be at a place dominated by all catch blocks, then we need |
|
1362 |
// a load in each catch block, and a Phi at the dominated use. |
|
1363 |
||
1364 |
void ZBarrierSetC2::clean_catch_blocks(PhaseIdealLoop* phase) const { |
|
1365 |
||
1366 |
Compile *C = phase->C; |
|
1367 |
uint new_ids = C->unique(); |
|
1368 |
PhaseIterGVN &igvn = phase->igvn(); |
|
1369 |
VectorSet visited(Thread::current()->resource_area()); |
|
1370 |
GrowableArray<Node *> nodeStack(Thread::current()->resource_area(), 0, 0, NULL); |
|
1371 |
nodeStack.push(C->root()); |
|
1372 |
visited.test_set(C->root()->_idx); |
|
1373 |
||
1374 |
// Traverse all nodes, visit all loads that require a barrier |
|
1375 |
while(nodeStack.length() > 0) { |
|
1376 |
Node *n = nodeStack.pop(); |
|
1377 |
||
55321
ddda023e6f66
8225509: clean_catch_blocks must add preds first
neliasso
parents:
55307
diff
changeset
|
1378 |
for (uint i = 0; i < n->len(); i++) { |
ddda023e6f66
8225509: clean_catch_blocks must add preds first
neliasso
parents:
55307
diff
changeset
|
1379 |
if (n->in(i)) { |
ddda023e6f66
8225509: clean_catch_blocks must add preds first
neliasso
parents:
55307
diff
changeset
|
1380 |
if (!visited.test_set(n->in(i)->_idx)) { |
ddda023e6f66
8225509: clean_catch_blocks must add preds first
neliasso
parents:
55307
diff
changeset
|
1381 |
nodeStack.push(n->in(i)); |
ddda023e6f66
8225509: clean_catch_blocks must add preds first
neliasso
parents:
55307
diff
changeset
|
1382 |
} |
ddda023e6f66
8225509: clean_catch_blocks must add preds first
neliasso
parents:
55307
diff
changeset
|
1383 |
} |
ddda023e6f66
8225509: clean_catch_blocks must add preds first
neliasso
parents:
55307
diff
changeset
|
1384 |
} |
ddda023e6f66
8225509: clean_catch_blocks must add preds first
neliasso
parents:
55307
diff
changeset
|
1385 |
|
55307 | 1386 |
bool is_old_node = (n->_idx < new_ids); // don't process nodes that were created during cleanup |
1387 |
if (n->is_Load() && is_old_node) { |
|
1388 |
LoadNode* load = n->isa_Load(); |
|
1389 |
// only care about loads that will have a barrier |
|
1390 |
if (load_require_barrier(load)) { |
|
1391 |
process_catch_cleanup_candidate(phase, load); |
|
1392 |
} |
|
1393 |
} |
|
1394 |
} |
|
1395 |
||
1396 |
C->print_method(PHASE_CALL_CATCH_CLEANUP, 2); |
|
1397 |
} |
|
1398 |
||
1399 |
class DomDepthCompareClosure : public CompareClosure<LoadNode*> { |
|
1400 |
PhaseIdealLoop* _phase; |
|
1401 |
||
1402 |
public: |
|
1403 |
DomDepthCompareClosure(PhaseIdealLoop* phase) : _phase(phase) { } |
|
1404 |
||
1405 |
int do_compare(LoadNode* const &n1, LoadNode* const &n2) { |
|
1406 |
int d1 = _phase->dom_depth(_phase->get_ctrl(n1)); |
|
1407 |
int d2 = _phase->dom_depth(_phase->get_ctrl(n2)); |
|
1408 |
if (d1 == d2) { |
|
1409 |
// Compare index if the depth is the same, ensures all entries are unique. |
|
1410 |
return n1->_idx - n2->_idx; |
|
1411 |
} else { |
|
1412 |
return d2 - d1; |
|
1413 |
} |
|
1414 |
} |
|
1415 |
}; |
|
1416 |
||
1417 |
// Traverse graph and add all loadPs to list, sorted by dom depth |
|
1418 |
void gather_loadnodes_sorted(PhaseIdealLoop* phase, GrowableArray<LoadNode*>* loadList) { |
|
1419 |
||
1420 |
VectorSet visited(Thread::current()->resource_area()); |
|
1421 |
GrowableArray<Node *> nodeStack(Thread::current()->resource_area(), 0, 0, NULL); |
|
1422 |
DomDepthCompareClosure ddcc(phase); |
|
1423 |
||
1424 |
nodeStack.push(phase->C->root()); |
|
1425 |
while(nodeStack.length() > 0) { |
|
1426 |
Node *n = nodeStack.pop(); |
|
1427 |
if (visited.test(n->_idx)) { |
|
1428 |
continue; |
|
1429 |
} |
|
1430 |
||
1431 |
if (n->isa_Load()) { |
|
1432 |
LoadNode *load = n->as_Load(); |
|
1433 |
if (load_require_barrier(load)) { |
|
1434 |
assert(phase->get_ctrl(load) != NULL, "sanity"); |
|
1435 |
assert(phase->dom_depth(phase->get_ctrl(load)) != 0, "sanity"); |
|
1436 |
loadList->insert_sorted(&ddcc, load); |
|
1437 |
} |
|
1438 |
} |
|
1439 |
||
1440 |
visited.set(n->_idx); |
|
1441 |
for (uint i = 0; i < n->req(); i++) { |
|
1442 |
if (n->in(i)) { |
|
1443 |
if (!visited.test(n->in(i)->_idx)) { |
|
1444 |
nodeStack.push(n->in(i)); |
|
50525
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
1445 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
1446 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
1447 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
1448 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
1449 |
} |
767cdb97f103
8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)
pliden
parents:
diff
changeset
|
1450 |
|
55307 | 1451 |
// Add LoadBarriers to all LoadPs |
1452 |
void ZBarrierSetC2::insert_load_barriers(PhaseIdealLoop* phase) const { |
|
1453 |
||
1454 |
bool trace = phase->C->directive()->ZTraceLoadBarriersOption; |
|
1455 |
GrowableArray<LoadNode *> loadList(Thread::current()->resource_area(), 0, 0, NULL); |
|
1456 |
gather_loadnodes_sorted(phase, &loadList); |
|
1457 |
||
1458 |
PhaseIterGVN &igvn = phase->igvn(); |
|
1459 |
int count = 0; |
|
1460 |
||
1461 |
for (GrowableArrayIterator<LoadNode *> loadIter = loadList.begin(); loadIter != loadList.end(); ++loadIter) { |
|
1462 |
LoadNode *load = *loadIter; |
|
52568 | 1463 |
|
55307 | 1464 |
if (load_has_expanded_barrier(load)) { |
1465 |
continue; |
|
1466 |
} |
|
53439 | 1467 |
|
55307 | 1468 |
do { |
1469 |
// Insert a barrier on a loadP |
|
1470 |
// if another load is found that needs to be expanded first, retry on that one |
|
1471 |
LoadNode* result = insert_one_loadbarrier(phase, load, phase->get_ctrl(load)); |
|
1472 |
while (result != NULL) { |
|
1473 |
result = insert_one_loadbarrier(phase, result, phase->get_ctrl(result)); |
|
52568 | 1474 |
} |
55307 | 1475 |
} while (!load_has_expanded_barrier(load)); |
52568 | 1476 |
} |
53439 | 1477 |
|
55307 | 1478 |
phase->C->print_method(PHASE_INSERT_BARRIER, 2); |
1479 |
} |
|
1480 |
||
1481 |
void push_antidependent_stores(PhaseIdealLoop* phase, Node_Stack& nodestack, LoadNode* start_load) { |
|
1482 |
// push all stores on the same mem, that can_alias |
|
1483 |
// Any load found must be handled first |
|
1484 |
PhaseIterGVN &igvn = phase->igvn(); |
|
1485 |
int load_alias_idx = igvn.C->get_alias_index(start_load->adr_type()); |
|
1486 |
||
1487 |
Node *mem = start_load->in(1); |
|
1488 |
for (DUIterator_Fast imax, u = mem->fast_outs(imax); u < imax; u++) { |
|
1489 |
Node *mem_use = mem->fast_out(u); |
|
1490 |
||
1491 |
if (mem_use == start_load) continue; |
|
1492 |
if (!mem_use->is_Store()) continue; |
|
1493 |
if (!phase->has_ctrl(mem_use)) continue; |
|
1494 |
if (phase->get_ctrl(mem_use) != phase->get_ctrl(start_load)) continue; |
|
1495 |
||
1496 |
// add any aliasing store in this block |
|
1497 |
StoreNode *store = mem_use->isa_Store(); |
|
1498 |
const TypePtr *adr_type = store->adr_type(); |
|
1499 |
if (igvn.C->can_alias(adr_type, load_alias_idx)) { |
|
1500 |
nodestack.push(store, 0); |
|
1501 |
} |
|
1502 |
} |
|
1503 |
} |
|
1504 |
||
1505 |
LoadNode* ZBarrierSetC2::insert_one_loadbarrier(PhaseIdealLoop* phase, LoadNode* start_load, Node* ctrl) const { |
|
1506 |
bool trace = phase->C->directive()->ZTraceLoadBarriersOption; |
|
1507 |
PhaseIterGVN &igvn = phase->igvn(); |
|
1508 |
||
1509 |
// Check for other loadPs at the same loop depth that is reachable by a DFS |
|
1510 |
// - if found - return it. It needs to be inserted first |
|
1511 |
// - otherwise proceed and insert barrier |
|
1512 |
||
1513 |
VectorSet visited(Thread::current()->resource_area()); |
|
1514 |
Node_Stack nodestack(100); |
|
1515 |
||
1516 |
nodestack.push(start_load, 0); |
|
1517 |
push_antidependent_stores(phase, nodestack, start_load); |
|
1518 |
||
1519 |
while(!nodestack.is_empty()) { |
|
1520 |
Node* n = nodestack.node(); // peek |
|
1521 |
nodestack.pop(); |
|
1522 |
if (visited.test(n->_idx)) { |
|
1523 |
continue; |
|
1524 |
} |
|
1525 |
||
1526 |
if (n->is_Load() && n != start_load && load_require_barrier(n->as_Load()) && !load_has_expanded_barrier(n->as_Load())) { |
|
1527 |
// Found another load that needs a barrier in the same block. Must expand later loads first. |
|
1528 |
if (trace) tty->print_cr(" * Found LoadP %i on DFS", n->_idx); |
|
1529 |
return n->as_Load(); // return node that should be expanded first |
|
1530 |
} |
|
1531 |
||
1532 |
if (!phase->has_ctrl(n)) continue; |
|
1533 |
if (phase->get_ctrl(n) != phase->get_ctrl(start_load)) continue; |
|
1534 |
if (n->is_Phi()) continue; |
|
1535 |
||
1536 |
visited.set(n->_idx); |
|
1537 |
// push all children |
|
1538 |
for (DUIterator_Fast imax, ii = n->fast_outs(imax); ii < imax; ii++) { |
|
1539 |
Node* c = n->fast_out(ii); |
|
1540 |
if (c != NULL) { |
|
1541 |
nodestack.push(c, 0); |
|
1542 |
} |
|
1543 |
} |
|
1544 |
} |
|
1545 |
||
1546 |
insert_one_loadbarrier_inner(phase, start_load, ctrl, visited); |
|
1547 |
return NULL; |
|
52568 | 1548 |
} |
1549 |
||
55307 | 1550 |
void ZBarrierSetC2::insert_one_loadbarrier_inner(PhaseIdealLoop* phase, LoadNode* load, Node* ctrl, VectorSet visited2) const { |
1551 |
PhaseIterGVN &igvn = phase->igvn(); |
|
1552 |
Compile* C = igvn.C; |
|
1553 |
bool trace = C->directive()->ZTraceLoadBarriersOption; |
|
1554 |
||
1555 |
// create barrier |
|
1556 |
Node* barrier = new LoadBarrierNode(C, NULL, load->in(LoadNode::Memory), NULL, load->in(LoadNode::Address), load_has_weak_barrier(load)); |
|
1557 |
Node* barrier_val = new ProjNode(barrier, LoadBarrierNode::Oop); |
|
1558 |
Node* barrier_ctrl = new ProjNode(barrier, LoadBarrierNode::Control); |
|
1559 |
||
1560 |
if (trace) tty->print_cr("Insert load %i with barrier: %i and ctrl : %i", load->_idx, barrier->_idx, ctrl->_idx); |
|
1561 |
||
1562 |
// Splice control |
|
1563 |
// - insert barrier control diamond between loads ctrl and ctrl successor on path to block end. |
|
1564 |
// - If control successor is a catch, step over to next. |
|
1565 |
Node* ctrl_succ = NULL; |
|
1566 |
for (DUIterator_Fast imax, j = ctrl->fast_outs(imax); j < imax; j++) { |
|
1567 |
Node* tmp = ctrl->fast_out(j); |
|
53439 | 1568 |
|
55307 | 1569 |
// - CFG nodes is the ones we are going to splice (1 only!) |
1570 |
// - Phi nodes will continue to hang from the region node! |
|
1571 |
// - self loops should be skipped |
|
1572 |
if (tmp->is_Phi() || tmp == ctrl) { |
|
1573 |
continue; |
|
1574 |
} |
|
1575 |
||
1576 |
if (tmp->is_CFG()) { |
|
1577 |
assert(ctrl_succ == NULL, "There can be only one"); |
|
1578 |
ctrl_succ = tmp; |
|
1579 |
continue; |
|
1580 |
} |
|
1581 |
} |
|
1582 |
||
1583 |
// Now splice control |
|
1584 |
assert(ctrl_succ != load, "sanity"); |
|
1585 |
assert(ctrl_succ != NULL, "Broken IR"); |
|
1586 |
bool found = false; |
|
1587 |
for(uint k = 0; k < ctrl_succ->req(); k++) { |
|
1588 |
if (ctrl_succ->in(k) == ctrl) { |
|
1589 |
assert(!found, "sanity"); |
|
1590 |
if (trace) tty->print_cr(" Move CFG ctrl_succ %i to barrier_ctrl", ctrl_succ->_idx); |
|
1591 |
igvn.replace_input_of(ctrl_succ, k, barrier_ctrl); |
|
1592 |
found = true; |
|
1593 |
k--; |
|
1594 |
} |
|
52568 | 1595 |
} |
53439 | 1596 |
|
55307 | 1597 |
// For all successors of ctrl - move all visited to become successors of barrier_ctrl instead |
1598 |
for (DUIterator_Fast imax, r = ctrl->fast_outs(imax); r < imax; r++) { |
|
1599 |
Node* tmp = ctrl->fast_out(r); |
|
1600 |
if (visited2.test(tmp->_idx) && (tmp != load)) { |
|
1601 |
if (trace) tty->print_cr(" Move ctrl_succ %i to barrier_ctrl", tmp->_idx); |
|
1602 |
igvn.replace_input_of(tmp, 0, barrier_ctrl); |
|
1603 |
--r; --imax; |
|
1604 |
} |
|
1605 |
} |
|
1606 |
||
1607 |
// Move the loads user to the barrier |
|
1608 |
for (DUIterator_Fast imax, i = load->fast_outs(imax); i < imax; i++) { |
|
1609 |
Node* u = load->fast_out(i); |
|
1610 |
if (u->isa_LoadBarrier()) { |
|
1611 |
continue; |
|
1612 |
} |
|
1613 |
||
1614 |
// find correct input - replace with iterator? |
|
1615 |
for(uint j = 0; j < u->req(); j++) { |
|
1616 |
if (u->in(j) == load) { |
|
1617 |
igvn.replace_input_of(u, j, barrier_val); |
|
1618 |
--i; --imax; // Adjust the iterator of the *outer* loop |
|
1619 |
break; // some nodes (calls) might have several uses from the same node |
|
1620 |
} |
|
1621 |
} |
|
1622 |
} |
|
1623 |
||
1624 |
// Connect barrier to load and control |
|
1625 |
barrier->set_req(LoadBarrierNode::Oop, load); |
|
1626 |
barrier->set_req(LoadBarrierNode::Control, ctrl); |
|
1627 |
||
1628 |
igvn.rehash_node_delayed(load); |
|
1629 |
igvn.register_new_node_with_optimizer(barrier); |
|
1630 |
igvn.register_new_node_with_optimizer(barrier_val); |
|
1631 |
igvn.register_new_node_with_optimizer(barrier_ctrl); |
|
1632 |
load_set_expanded_barrier(load); |
|
1633 |
||
1634 |
C->print_method(PHASE_INSERT_BARRIER, 3, load->_idx); |
|
52711 | 1635 |
} |
55307 | 1636 |
|
1637 |
// The bad_mask in the ThreadLocalData shouldn't have an anti-dep-check. |
|
1638 |
// The bad_mask address if of type TypeRawPtr, but that will alias |
|
1639 |
// InitializeNodes until the type system is expanded. |
|
1640 |
bool ZBarrierSetC2::needs_anti_dependence_check(const Node* node) const { |
|
1641 |
MachNode* mnode = node->as_Mach(); |
|
1642 |
if (mnode != NULL) { |
|
1643 |
intptr_t offset = 0; |
|
1644 |
const TypePtr *adr_type2 = NULL; |
|
1645 |
const Node* base = mnode->get_base_and_disp(offset, adr_type2); |
|
1646 |
if ((base != NULL) && |
|
1647 |
(base->is_Mach() && base->as_Mach()->ideal_Opcode() == Op_ThreadLocal) && |
|
1648 |
(offset == in_bytes(ZThreadLocalData::address_bad_mask_offset()))) { |
|
1649 |
return false; |
|
1650 |
} |
|
1651 |
} |
|
1652 |
return true; |
|
1653 |
} |