author | jprovino |
Tue, 02 Aug 2016 16:39:33 -0400 | |
changeset 40328 | a2851f5f1cf6 |
parent 35879 | 9892f53e92c9 |
child 40905 | 94ffc131534f |
permissions | -rw-r--r-- |
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
1 |
/* |
35879 | 2 |
* Copyright (c) 2014, 2016, Oracle and/or its affiliates. All rights reserved. |
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
4 |
* |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
8 |
* |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
13 |
* accompanied this code). |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
14 |
* |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
18 |
* |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
21 |
* questions. |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
22 |
* |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
23 |
*/ |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
24 |
|
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
25 |
#include "precompiled.hpp" |
26422 | 26 |
#include "code/codeCache.hpp" |
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
27 |
#include "code/nmethod.hpp" |
30764 | 28 |
#include "gc/g1/g1CodeCacheRemSet.hpp" |
29 |
#include "gc/g1/heapRegion.hpp" |
|
26422 | 30 |
#include "memory/heap.hpp" |
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
31 |
#include "memory/iterator.hpp" |
26422 | 32 |
#include "oops/oop.inline.hpp" |
33 |
#include "utilities/hashtable.inline.hpp" |
|
34 |
#include "utilities/stack.inline.hpp" |
|
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
35 |
|
26422 | 36 |
class CodeRootSetTable : public Hashtable<nmethod*, mtGC> { |
37 |
friend class G1CodeRootSetTest; |
|
38 |
typedef HashtableEntry<nmethod*, mtGC> Entry; |
|
39 |
||
40 |
static CodeRootSetTable* volatile _purge_list; |
|
41 |
||
42 |
CodeRootSetTable* _purge_next; |
|
43 |
||
44 |
unsigned int compute_hash(nmethod* nm) { |
|
45 |
uintptr_t hash = (uintptr_t)nm; |
|
46 |
return hash ^ (hash >> 7); // code heap blocks are 128byte aligned |
|
47 |
} |
|
48 |
||
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
49 |
void remove_entry(Entry* e, Entry* previous); |
26422 | 50 |
Entry* new_entry(nmethod* nm); |
51 |
||
52 |
public: |
|
53 |
CodeRootSetTable(int size) : Hashtable<nmethod*, mtGC>(size, sizeof(Entry)), _purge_next(NULL) {} |
|
54 |
~CodeRootSetTable(); |
|
55 |
||
56 |
// Needs to be protected locks |
|
57 |
bool add(nmethod* nm); |
|
58 |
bool remove(nmethod* nm); |
|
59 |
||
60 |
// Can be called without locking |
|
61 |
bool contains(nmethod* nm); |
|
62 |
||
63 |
int entry_size() const { return BasicHashtable<mtGC>::entry_size(); } |
|
64 |
||
65 |
void copy_to(CodeRootSetTable* new_table); |
|
66 |
void nmethods_do(CodeBlobClosure* blk); |
|
67 |
||
68 |
template<typename CB> |
|
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
69 |
int remove_if(CB& should_remove); |
26422 | 70 |
|
71 |
static void purge_list_append(CodeRootSetTable* tbl); |
|
72 |
static void purge(); |
|
73 |
||
74 |
static size_t static_mem_size() { |
|
75 |
return sizeof(_purge_list); |
|
76 |
} |
|
35879 | 77 |
|
78 |
size_t mem_size(); |
|
26422 | 79 |
}; |
80 |
||
81 |
CodeRootSetTable* volatile CodeRootSetTable::_purge_list = NULL; |
|
82 |
||
35879 | 83 |
size_t CodeRootSetTable::mem_size() { |
84 |
return sizeof(CodeRootSetTable) + (entry_size() * number_of_entries()) + (sizeof(HashtableBucket<mtGC>) * table_size()); |
|
85 |
} |
|
86 |
||
26422 | 87 |
CodeRootSetTable::Entry* CodeRootSetTable::new_entry(nmethod* nm) { |
88 |
unsigned int hash = compute_hash(nm); |
|
89 |
Entry* entry = (Entry*) new_entry_free_list(); |
|
90 |
if (entry == NULL) { |
|
91 |
entry = (Entry*) NEW_C_HEAP_ARRAY2(char, entry_size(), mtGC, CURRENT_PC); |
|
92 |
} |
|
93 |
entry->set_next(NULL); |
|
94 |
entry->set_hash(hash); |
|
95 |
entry->set_literal(nm); |
|
96 |
return entry; |
|
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
97 |
} |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
98 |
|
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
99 |
void CodeRootSetTable::remove_entry(Entry* e, Entry* previous) { |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
100 |
int index = hash_to_index(e->hash()); |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
101 |
assert((e == bucket(index)) == (previous == NULL), "if e is the first entry then previous should be null"); |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
102 |
|
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
103 |
if (previous == NULL) { |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
104 |
set_entry(index, e->next()); |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
105 |
} else { |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
106 |
previous->set_next(e->next()); |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
107 |
} |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
108 |
free_entry(e); |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
109 |
} |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
110 |
|
26422 | 111 |
CodeRootSetTable::~CodeRootSetTable() { |
112 |
for (int index = 0; index < table_size(); ++index) { |
|
113 |
for (Entry* e = bucket(index); e != NULL; ) { |
|
114 |
Entry* to_remove = e; |
|
115 |
// read next before freeing. |
|
116 |
e = e->next(); |
|
117 |
unlink_entry(to_remove); |
|
27880
afb974a04396
8060074: os::free() takes MemoryTrackingLevel but doesn't need it
coleenp
parents:
26574
diff
changeset
|
118 |
FREE_C_HEAP_ARRAY(char, to_remove); |
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
119 |
} |
26422 | 120 |
} |
121 |
assert(number_of_entries() == 0, "should have removed all entries"); |
|
122 |
free_buckets(); |
|
123 |
for (BasicHashtableEntry<mtGC>* e = new_entry_free_list(); e != NULL; e = new_entry_free_list()) { |
|
27880
afb974a04396
8060074: os::free() takes MemoryTrackingLevel but doesn't need it
coleenp
parents:
26574
diff
changeset
|
124 |
FREE_C_HEAP_ARRAY(char, e); |
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
125 |
} |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
126 |
} |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
127 |
|
26422 | 128 |
bool CodeRootSetTable::add(nmethod* nm) { |
129 |
if (!contains(nm)) { |
|
130 |
Entry* e = new_entry(nm); |
|
131 |
int index = hash_to_index(e->hash()); |
|
132 |
add_entry(index, e); |
|
133 |
return true; |
|
134 |
} |
|
135 |
return false; |
|
136 |
} |
|
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
137 |
|
26422 | 138 |
bool CodeRootSetTable::contains(nmethod* nm) { |
139 |
int index = hash_to_index(compute_hash(nm)); |
|
140 |
for (Entry* e = bucket(index); e != NULL; e = e->next()) { |
|
141 |
if (e->literal() == nm) { |
|
142 |
return true; |
|
143 |
} |
|
144 |
} |
|
145 |
return false; |
|
146 |
} |
|
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
147 |
|
26422 | 148 |
bool CodeRootSetTable::remove(nmethod* nm) { |
149 |
int index = hash_to_index(compute_hash(nm)); |
|
150 |
Entry* previous = NULL; |
|
151 |
for (Entry* e = bucket(index); e != NULL; previous = e, e = e->next()) { |
|
152 |
if (e->literal() == nm) { |
|
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
153 |
remove_entry(e, previous); |
25492
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
154 |
return true; |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
155 |
} |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
156 |
} |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
157 |
return false; |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
158 |
} |
d27050bdfb04
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
25491
diff
changeset
|
159 |
|
26422 | 160 |
void CodeRootSetTable::copy_to(CodeRootSetTable* new_table) { |
161 |
for (int index = 0; index < table_size(); ++index) { |
|
162 |
for (Entry* e = bucket(index); e != NULL; e = e->next()) { |
|
163 |
new_table->add(e->literal()); |
|
164 |
} |
|
165 |
} |
|
166 |
new_table->copy_freelist(this); |
|
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
167 |
} |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
168 |
|
26422 | 169 |
void CodeRootSetTable::nmethods_do(CodeBlobClosure* blk) { |
170 |
for (int index = 0; index < table_size(); ++index) { |
|
171 |
for (Entry* e = bucket(index); e != NULL; e = e->next()) { |
|
172 |
blk->do_code_blob(e->literal()); |
|
173 |
} |
|
174 |
} |
|
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
175 |
} |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
176 |
|
26422 | 177 |
template<typename CB> |
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
178 |
int CodeRootSetTable::remove_if(CB& should_remove) { |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
179 |
int num_removed = 0; |
26422 | 180 |
for (int index = 0; index < table_size(); ++index) { |
181 |
Entry* previous = NULL; |
|
182 |
Entry* e = bucket(index); |
|
183 |
while (e != NULL) { |
|
184 |
Entry* next = e->next(); |
|
185 |
if (should_remove(e->literal())) { |
|
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
186 |
remove_entry(e, previous); |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
187 |
++num_removed; |
26422 | 188 |
} else { |
189 |
previous = e; |
|
190 |
} |
|
191 |
e = next; |
|
192 |
} |
|
193 |
} |
|
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
194 |
return num_removed; |
26422 | 195 |
} |
196 |
||
197 |
G1CodeRootSet::~G1CodeRootSet() { |
|
198 |
delete _table; |
|
24099
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
199 |
} |
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
200 |
|
26422 | 201 |
CodeRootSetTable* G1CodeRootSet::load_acquire_table() { |
202 |
return (CodeRootSetTable*) OrderAccess::load_ptr_acquire(&_table); |
|
203 |
} |
|
204 |
||
205 |
void G1CodeRootSet::allocate_small_table() { |
|
33093 | 206 |
CodeRootSetTable* temp = new CodeRootSetTable(SmallSize); |
207 |
||
208 |
OrderAccess::release_store_ptr(&_table, temp); |
|
26422 | 209 |
} |
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
210 |
|
26422 | 211 |
void CodeRootSetTable::purge_list_append(CodeRootSetTable* table) { |
212 |
for (;;) { |
|
213 |
table->_purge_next = _purge_list; |
|
214 |
CodeRootSetTable* old = (CodeRootSetTable*) Atomic::cmpxchg_ptr(table, &_purge_list, table->_purge_next); |
|
215 |
if (old == table->_purge_next) { |
|
216 |
break; |
|
217 |
} |
|
218 |
} |
|
219 |
} |
|
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
220 |
|
26422 | 221 |
void CodeRootSetTable::purge() { |
222 |
CodeRootSetTable* table = _purge_list; |
|
223 |
_purge_list = NULL; |
|
224 |
while (table != NULL) { |
|
225 |
CodeRootSetTable* to_purge = table; |
|
226 |
table = table->_purge_next; |
|
227 |
delete to_purge; |
|
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
228 |
} |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
229 |
} |
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
230 |
|
26422 | 231 |
void G1CodeRootSet::move_to_large() { |
232 |
CodeRootSetTable* temp = new CodeRootSetTable(LargeSize); |
|
233 |
||
234 |
_table->copy_to(temp); |
|
235 |
||
236 |
CodeRootSetTable::purge_list_append(_table); |
|
237 |
||
238 |
OrderAccess::release_store_ptr(&_table, temp); |
|
24099
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
239 |
} |
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
240 |
|
26422 | 241 |
void G1CodeRootSet::purge() { |
242 |
CodeRootSetTable::purge(); |
|
243 |
} |
|
244 |
||
245 |
size_t G1CodeRootSet::static_mem_size() { |
|
246 |
return CodeRootSetTable::static_mem_size(); |
|
247 |
} |
|
248 |
||
249 |
void G1CodeRootSet::add(nmethod* method) { |
|
250 |
bool added = false; |
|
251 |
if (is_empty()) { |
|
252 |
allocate_small_table(); |
|
253 |
} |
|
254 |
added = _table->add(method); |
|
255 |
if (added) { |
|
35879 | 256 |
if (_length == Threshold) { |
257 |
move_to_large(); |
|
258 |
} |
|
26422 | 259 |
++_length; |
260 |
} |
|
35879 | 261 |
assert(_length == (size_t)_table->number_of_entries(), "sizes should match"); |
26422 | 262 |
} |
263 |
||
264 |
bool G1CodeRootSet::remove(nmethod* method) { |
|
265 |
bool removed = false; |
|
266 |
if (_table != NULL) { |
|
267 |
removed = _table->remove(method); |
|
268 |
} |
|
269 |
if (removed) { |
|
270 |
_length--; |
|
271 |
if (_length == 0) { |
|
272 |
clear(); |
|
273 |
} |
|
274 |
} |
|
35879 | 275 |
assert((_length == 0 && _table == NULL) || |
276 |
(_length == (size_t)_table->number_of_entries()), "sizes should match"); |
|
26422 | 277 |
return removed; |
278 |
} |
|
279 |
||
280 |
bool G1CodeRootSet::contains(nmethod* method) { |
|
35879 | 281 |
CodeRootSetTable* table = load_acquire_table(); // contains() may be called outside of lock, so ensure mem sync. |
26422 | 282 |
if (table != NULL) { |
283 |
return table->contains(method); |
|
24099
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
284 |
} |
26422 | 285 |
return false; |
286 |
} |
|
287 |
||
288 |
void G1CodeRootSet::clear() { |
|
289 |
delete _table; |
|
290 |
_table = NULL; |
|
291 |
_length = 0; |
|
292 |
} |
|
293 |
||
294 |
size_t G1CodeRootSet::mem_size() { |
|
35879 | 295 |
return sizeof(*this) + (_table != NULL ? _table->mem_size() : 0); |
26422 | 296 |
} |
297 |
||
298 |
void G1CodeRootSet::nmethods_do(CodeBlobClosure* blk) const { |
|
299 |
if (_table != NULL) { |
|
300 |
_table->nmethods_do(blk); |
|
301 |
} |
|
302 |
} |
|
303 |
||
304 |
class CleanCallback : public StackObj { |
|
305 |
class PointsIntoHRDetectionClosure : public OopClosure { |
|
306 |
HeapRegion* _hr; |
|
307 |
public: |
|
308 |
bool _points_into; |
|
309 |
PointsIntoHRDetectionClosure(HeapRegion* hr) : _hr(hr), _points_into(false) {} |
|
310 |
||
311 |
void do_oop(narrowOop* o) { |
|
312 |
do_oop_work(o); |
|
313 |
} |
|
314 |
||
315 |
void do_oop(oop* o) { |
|
316 |
do_oop_work(o); |
|
317 |
} |
|
318 |
||
319 |
template <typename T> |
|
320 |
void do_oop_work(T* p) { |
|
321 |
if (_hr->is_in(oopDesc::load_decode_heap_oop(p))) { |
|
322 |
_points_into = true; |
|
323 |
} |
|
324 |
} |
|
325 |
}; |
|
326 |
||
327 |
PointsIntoHRDetectionClosure _detector; |
|
328 |
CodeBlobToOopClosure _blobs; |
|
329 |
||
330 |
public: |
|
331 |
CleanCallback(HeapRegion* hr) : _detector(hr), _blobs(&_detector, !CodeBlobToOopClosure::FixRelocations) {} |
|
332 |
||
333 |
bool operator() (nmethod* nm) { |
|
334 |
_detector._points_into = false; |
|
335 |
_blobs.do_code_blob(nm); |
|
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
336 |
return !_detector._points_into; |
26422 | 337 |
} |
338 |
}; |
|
339 |
||
340 |
void G1CodeRootSet::clean(HeapRegion* owner) { |
|
341 |
CleanCallback should_clean(owner); |
|
342 |
if (_table != NULL) { |
|
26574
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
343 |
int removed = _table->remove_if(should_clean); |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
344 |
assert((size_t)removed <= _length, "impossible"); |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
345 |
_length -= removed; |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
346 |
} |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
347 |
if (_length == 0) { |
59219d1be209
8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents:
26422
diff
changeset
|
348 |
clear(); |
26422 | 349 |
} |
24099
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
350 |
} |
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
351 |
|
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
352 |
#ifndef PRODUCT |
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
353 |
|
26422 | 354 |
class G1CodeRootSetTest { |
355 |
public: |
|
356 |
static void test() { |
|
357 |
{ |
|
358 |
G1CodeRootSet set1; |
|
359 |
assert(set1.is_empty(), "Code root set must be initially empty but is not."); |
|
360 |
||
361 |
assert(G1CodeRootSet::static_mem_size() == sizeof(void*), |
|
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
362 |
"The code root set's static memory usage is incorrect, " SIZE_FORMAT " bytes", G1CodeRootSet::static_mem_size()); |
26422 | 363 |
|
364 |
set1.add((nmethod*)1); |
|
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
365 |
assert(set1.length() == 1, "Added exactly one element, but set contains " |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
366 |
SIZE_FORMAT " elements", set1.length()); |
26422 | 367 |
|
368 |
const size_t num_to_add = (size_t)G1CodeRootSet::Threshold + 1; |
|
369 |
||
370 |
for (size_t i = 1; i <= num_to_add; i++) { |
|
371 |
set1.add((nmethod*)1); |
|
372 |
} |
|
373 |
assert(set1.length() == 1, |
|
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
374 |
"Duplicate detection should not have increased the set size but " |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
375 |
"is " SIZE_FORMAT, set1.length()); |
23451
ed2b8bb28fed
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff
changeset
|
376 |
|
26422 | 377 |
for (size_t i = 2; i <= num_to_add; i++) { |
378 |
set1.add((nmethod*)(uintptr_t)(i)); |
|
379 |
} |
|
380 |
assert(set1.length() == num_to_add, |
|
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
381 |
"After adding in total " SIZE_FORMAT " distinct code roots, they " |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
382 |
"need to be in the set, but there are only " SIZE_FORMAT, |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
383 |
num_to_add, set1.length()); |
26422 | 384 |
|
385 |
assert(CodeRootSetTable::_purge_list != NULL, "should have grown to large hashtable"); |
|
386 |
||
387 |
size_t num_popped = 0; |
|
388 |
for (size_t i = 1; i <= num_to_add; i++) { |
|
389 |
bool removed = set1.remove((nmethod*)i); |
|
390 |
if (removed) { |
|
391 |
num_popped += 1; |
|
392 |
} else { |
|
393 |
break; |
|
394 |
} |
|
395 |
} |
|
396 |
assert(num_popped == num_to_add, |
|
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
397 |
"Managed to pop " SIZE_FORMAT " code roots, but only " SIZE_FORMAT " " |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
33093
diff
changeset
|
398 |
"were added", num_popped, num_to_add); |
26422 | 399 |
assert(CodeRootSetTable::_purge_list != NULL, "should have grown to large hashtable"); |
400 |
||
401 |
G1CodeRootSet::purge(); |
|
402 |
||
403 |
assert(CodeRootSetTable::_purge_list == NULL, "should have purged old small tables"); |
|
404 |
||
405 |
} |
|
406 |
||
407 |
} |
|
408 |
}; |
|
409 |
||
410 |
void TestCodeCacheRemSet_test() { |
|
411 |
G1CodeRootSetTest::test(); |
|
24099
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
412 |
} |
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
413 |
|
9c132a88935d
8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents:
23451
diff
changeset
|
414 |
#endif |