author | pliden |
Fri, 13 Sep 2019 08:40:09 +0200 | |
changeset 58125 | 9b4717ca9bd1 |
parent 55115 | a0d4e61acb6b |
child 58679 | 9c3209ff7550 |
permissions | -rw-r--r-- |
1 | 1 |
/* |
55115
a0d4e61acb6b
8223504: Improve performance of forall loops by better inlining of "iterator()" methods
skuksenko
parents:
55110
diff
changeset
|
2 |
* Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5420
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5420
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5420
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
14477
95e66ea71f71
6830717: replay of compilations would help with debugging
minqi
parents:
13974
diff
changeset
|
26 |
#include "ci/ciReplay.hpp" |
7397 | 27 |
#include "classfile/systemDictionary.hpp" |
28 |
#include "classfile/vmSymbols.hpp" |
|
8872
36680c58660e
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
8676
diff
changeset
|
29 |
#include "compiler/compileBroker.hpp" |
7397 | 30 |
#include "compiler/compileLog.hpp" |
31 |
#include "interpreter/linkResolver.hpp" |
|
50113 | 32 |
#include "jfr/jfrEvents.hpp" |
7397 | 33 |
#include "oops/objArrayKlass.hpp" |
34 |
#include "opto/callGenerator.hpp" |
|
35 |
#include "opto/parse.hpp" |
|
36 |
#include "runtime/handles.inline.hpp" |
|
29582 | 37 |
#include "utilities/events.hpp" |
1 | 38 |
|
39 |
//============================================================================= |
|
40 |
//------------------------------InlineTree------------------------------------- |
|
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
41 |
InlineTree::InlineTree(Compile* c, |
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
42 |
const InlineTree *caller_tree, ciMethod* callee, |
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
43 |
JVMState* caller_jvms, int caller_bci, |
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
44 |
float site_invoke_ratio, int max_inline_level) : |
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
45 |
C(c), |
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
46 |
_caller_jvms(caller_jvms), |
51333
f6641fcf7b7e
8208670: Compiler changes to allow enabling -Wreorder
tschatzl
parents:
51078
diff
changeset
|
47 |
_method(callee), |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
48 |
_caller_tree((InlineTree*) caller_tree), |
51333
f6641fcf7b7e
8208670: Compiler changes to allow enabling -Wreorder
tschatzl
parents:
51078
diff
changeset
|
49 |
_count_inline_bcs(method()->code_size_for_inlining()), |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
50 |
_site_invoke_ratio(site_invoke_ratio), |
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
51 |
_max_inline_level(max_inline_level), |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
52 |
_subtrees(c->comp_arena(), 2, 0, NULL), |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
53 |
_msg(NULL) |
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
54 |
{ |
22243 | 55 |
#ifndef PRODUCT |
56 |
_count_inlines = 0; |
|
57 |
_forced_inline = false; |
|
58 |
#endif |
|
1 | 59 |
if (_caller_jvms != NULL) { |
60 |
// Keep a private copy of the caller_jvms: |
|
61 |
_caller_jvms = new (C) JVMState(caller_jvms->method(), caller_tree->caller_jvms()); |
|
62 |
_caller_jvms->set_bci(caller_jvms->bci()); |
|
3600
27aa4477d039
6833129: specjvm98 fails with NullPointerException in the compiler with -XX:DeoptimizeALot
cfang
parents:
2570
diff
changeset
|
63 |
assert(!caller_jvms->should_reexecute(), "there should be no reexecute bytecode with inlining"); |
1 | 64 |
} |
65 |
assert(_caller_jvms->same_calls_as(caller_jvms), "consistent JVMS"); |
|
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
66 |
assert((caller_tree == NULL ? 0 : caller_tree->stack_depth() + 1) == stack_depth(), "correct (redundant) depth parameter"); |
1 | 67 |
assert(caller_bci == this->caller_bci(), "correct (redundant) bci parameter"); |
22800 | 68 |
// Update hierarchical counts, count_inline_bcs() and count_inlines() |
69 |
InlineTree *caller = (InlineTree *)caller_tree; |
|
70 |
for( ; caller != NULL; caller = ((InlineTree *)(caller->caller_tree())) ) { |
|
71 |
caller->_count_inline_bcs += count_inline_bcs(); |
|
72 |
NOT_PRODUCT(caller->_count_inlines++;) |
|
1 | 73 |
} |
74 |
} |
|
75 |
||
17386
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
76 |
/** |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
77 |
* Return true when EA is ON and a java constructor is called or |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
78 |
* a super constructor is called from an inlined java constructor. |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
79 |
* Also return true for boxing methods. |
55115
a0d4e61acb6b
8223504: Improve performance of forall loops by better inlining of "iterator()" methods
skuksenko
parents:
55110
diff
changeset
|
80 |
* Also return true for methods returning Iterator (including Iterable::iterator()) |
a0d4e61acb6b
8223504: Improve performance of forall loops by better inlining of "iterator()" methods
skuksenko
parents:
55110
diff
changeset
|
81 |
* that is essential for forall-loops performance. |
17386
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
82 |
*/ |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
83 |
static bool is_init_with_ea(ciMethod* callee_method, |
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
84 |
ciMethod* caller_method, Compile* C) { |
17386
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
85 |
if (!C->do_escape_analysis() || !EliminateAllocations) { |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
86 |
return false; // EA is off |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
87 |
} |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
88 |
if (callee_method->is_initializer()) { |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
89 |
return true; // constuctor |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
90 |
} |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
91 |
if (caller_method->is_initializer() && |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
92 |
caller_method != C->method() && |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
93 |
caller_method->holder()->is_subclass_of(callee_method->holder())) { |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
94 |
return true; // super constructor is called from inlined constructor |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
95 |
} |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
96 |
if (C->eliminate_boxing() && callee_method->is_boxing_method()) { |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
97 |
return true; |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
98 |
} |
55115
a0d4e61acb6b
8223504: Improve performance of forall loops by better inlining of "iterator()" methods
skuksenko
parents:
55110
diff
changeset
|
99 |
ciType *retType = callee_method->signature()->return_type(); |
a0d4e61acb6b
8223504: Improve performance of forall loops by better inlining of "iterator()" methods
skuksenko
parents:
55110
diff
changeset
|
100 |
ciKlass *iter = C->env()->Iterator_klass(); |
a0d4e61acb6b
8223504: Improve performance of forall loops by better inlining of "iterator()" methods
skuksenko
parents:
55110
diff
changeset
|
101 |
if(retType->is_loaded() && iter->is_loaded() && retType->is_subtype_of(iter)) { |
a0d4e61acb6b
8223504: Improve performance of forall loops by better inlining of "iterator()" methods
skuksenko
parents:
55110
diff
changeset
|
102 |
return true; |
a0d4e61acb6b
8223504: Improve performance of forall loops by better inlining of "iterator()" methods
skuksenko
parents:
55110
diff
changeset
|
103 |
} |
17386
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
104 |
return false; |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
105 |
} |
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
106 |
|
17386
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
107 |
/** |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
108 |
* Force inlining unboxing accessor. |
e3b1a1af9968
8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
kvn
parents:
17383
diff
changeset
|
109 |
*/ |
17383 | 110 |
static bool is_unboxing_method(ciMethod* callee_method, Compile* C) { |
111 |
return C->eliminate_boxing() && callee_method->is_unboxing_method(); |
|
112 |
} |
|
113 |
||
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
114 |
// positive filter: should callee be inlined? |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
115 |
bool InlineTree::should_inline(ciMethod* callee_method, ciMethod* caller_method, |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
116 |
int caller_bci, ciCallProfile& profile, |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
117 |
WarmCallInfo* wci_result) { |
1 | 118 |
// Allows targeted inlining |
33451
0712796e4039
8137167: JEP165: Compiler Control: Implementation task
neliasso
parents:
33069
diff
changeset
|
119 |
if (C->directive()->should_inline(callee_method)) { |
1 | 120 |
*wci_result = *(WarmCallInfo::always_hot()); |
20073 | 121 |
if (C->print_inlining() && Verbose) { |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
122 |
CompileTask::print_inline_indent(inline_level()); |
1 | 123 |
tty->print_cr("Inlined method is hot: "); |
124 |
} |
|
33069
d8eed614f298
8135068: Extract method matchers from CompilerOracle
neliasso
parents:
30305
diff
changeset
|
125 |
set_msg("force inline by CompileCommand"); |
22243 | 126 |
_forced_inline = true; |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
127 |
return true; |
1 | 128 |
} |
129 |
||
25640
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
130 |
if (callee_method->force_inline()) { |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
131 |
set_msg("force inline by annotation"); |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
132 |
_forced_inline = true; |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
133 |
return true; |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
134 |
} |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
135 |
|
22243 | 136 |
#ifndef PRODUCT |
137 |
int inline_depth = inline_level()+1; |
|
138 |
if (ciReplay::should_inline(C->replay_inline_data(), callee_method, caller_bci, inline_depth)) { |
|
139 |
set_msg("force inline by ciReplay"); |
|
140 |
_forced_inline = true; |
|
141 |
return true; |
|
142 |
} |
|
143 |
#endif |
|
144 |
||
10506
575ad9bccff5
7078382: JSR 292: don't count method handle adapters against inlining budgets
twisti
parents:
10007
diff
changeset
|
145 |
int size = callee_method->code_size_for_inlining(); |
1 | 146 |
|
147 |
// Check for too many throws (and not too huge) |
|
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
148 |
if(callee_method->interpreter_throwout_count() > InlineThrowCount && |
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
149 |
size < InlineThrowMaxSize ) { |
1 | 150 |
wci_result->set_profit(wci_result->profit() * 100); |
20073 | 151 |
if (C->print_inlining() && Verbose) { |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
152 |
CompileTask::print_inline_indent(inline_level()); |
1 | 153 |
tty->print_cr("Inlined method with many throws (throws=%d):", callee_method->interpreter_throwout_count()); |
154 |
} |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
155 |
set_msg("many throws"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
156 |
return true; |
1 | 157 |
} |
158 |
||
9633
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
159 |
int default_max_inline_size = C->max_inline_size(); |
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
160 |
int inline_small_code_size = InlineSmallCode / 4; |
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
161 |
int max_inline_size = default_max_inline_size; |
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
162 |
|
1 | 163 |
int call_site_count = method()->scale_count(profile.count()); |
164 |
int invoke_count = method()->interpreter_invocation_count(); |
|
9633
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
165 |
|
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
166 |
assert(invoke_count != 0, "require invocation count greater than zero"); |
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
167 |
int freq = call_site_count / invoke_count; |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
168 |
|
1 | 169 |
// bump the max size if the call is frequent |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
170 |
if ((freq >= InlineFrequencyRatio) || |
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
171 |
(call_site_count >= InlineFrequencyCount) || |
17383 | 172 |
is_unboxing_method(callee_method, C) || |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
173 |
is_init_with_ea(callee_method, caller_method, C)) { |
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
174 |
|
9633
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
175 |
max_inline_size = C->freq_inline_size(); |
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
176 |
if (size <= max_inline_size && TraceFrequencyInlining) { |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
177 |
CompileTask::print_inline_indent(inline_level()); |
1 | 178 |
tty->print_cr("Inlined frequent method (freq=%d count=%d):", freq, call_site_count); |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
179 |
CompileTask::print_inline_indent(inline_level()); |
1 | 180 |
callee_method->print(); |
181 |
tty->cr(); |
|
182 |
} |
|
183 |
} else { |
|
184 |
// Not hot. Check for medium-sized pre-existing nmethod at cold sites. |
|
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
185 |
if (callee_method->has_compiled_code() && |
16373
8f8a2a1c5d09
8010222: 8007439 disabled inlining of cold accessor methods
kvn
parents:
15816
diff
changeset
|
186 |
callee_method->instructions_size() > inline_small_code_size) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
187 |
set_msg("already compiled into a medium method"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
188 |
return false; |
16373
8f8a2a1c5d09
8010222: 8007439 disabled inlining of cold accessor methods
kvn
parents:
15816
diff
changeset
|
189 |
} |
1 | 190 |
} |
9633
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
191 |
if (size > max_inline_size) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
192 |
if (max_inline_size > default_max_inline_size) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
193 |
set_msg("hot method too big"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
194 |
} else { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
195 |
set_msg("too big"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
196 |
} |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
197 |
return false; |
1 | 198 |
} |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
199 |
return true; |
1 | 200 |
} |
201 |
||
202 |
||
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
203 |
// negative filter: should callee NOT be inlined? |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
204 |
bool InlineTree::should_not_inline(ciMethod *callee_method, |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
205 |
ciMethod* caller_method, |
20689
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
206 |
JVMState* jvms, |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
207 |
WarmCallInfo* wci_result) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
208 |
|
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
209 |
const char* fail_msg = NULL; |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
210 |
|
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
211 |
// First check all inlining restrictions which are required for correctness |
55110
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
212 |
if (callee_method->is_abstract()) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
213 |
fail_msg = "abstract method"; // // note: we allow ik->is_abstract() |
53632
d620a4a1d5ed
8188133: C2: Static field accesses in clinit can trigger deoptimizations
vlivanov
parents:
52934
diff
changeset
|
214 |
} else if (!callee_method->holder()->is_initialized() && |
d620a4a1d5ed
8188133: C2: Static field accesses in clinit can trigger deoptimizations
vlivanov
parents:
52934
diff
changeset
|
215 |
// access allowed in the context of static initializer |
55110
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
216 |
C->needs_clinit_barrier(callee_method->holder(), caller_method)) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
217 |
fail_msg = "method holder not initialized"; |
55110
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
218 |
} else if (callee_method->is_native()) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
219 |
fail_msg = "native method"; |
55110
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
220 |
} else if (callee_method->dont_inline()) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
221 |
fail_msg = "don't inline by annotation"; |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
222 |
} |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
223 |
|
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
224 |
// one more inlining restriction |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
225 |
if (fail_msg == NULL && callee_method->has_unloaded_classes_in_signature()) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
226 |
fail_msg = "unloaded signature classes"; |
1 | 227 |
} |
228 |
||
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
229 |
if (fail_msg != NULL) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
230 |
set_msg(fail_msg); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
231 |
return true; |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
232 |
} |
4567
7fc02fbe5c7a
6893268: additional dynamic language related optimizations in C2
twisti
parents:
4566
diff
changeset
|
233 |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
234 |
// ignore heuristic controls on inlining |
33451
0712796e4039
8137167: JEP165: Compiler Control: Implementation task
neliasso
parents:
33069
diff
changeset
|
235 |
if (C->directive()->should_inline(callee_method)) { |
33069
d8eed614f298
8135068: Extract method matchers from CompilerOracle
neliasso
parents:
30305
diff
changeset
|
236 |
set_msg("force inline by CompileCommand"); |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
237 |
return false; |
1 | 238 |
} |
239 |
||
33451
0712796e4039
8137167: JEP165: Compiler Control: Implementation task
neliasso
parents:
33069
diff
changeset
|
240 |
if (C->directive()->should_not_inline(callee_method)) { |
33069
d8eed614f298
8135068: Extract method matchers from CompilerOracle
neliasso
parents:
30305
diff
changeset
|
241 |
set_msg("disallowed by CompileCommand"); |
17383 | 242 |
return true; |
243 |
} |
|
244 |
||
245 |
#ifndef PRODUCT |
|
22243 | 246 |
int caller_bci = jvms->bci(); |
247 |
int inline_depth = inline_level()+1; |
|
248 |
if (ciReplay::should_inline(C->replay_inline_data(), callee_method, caller_bci, inline_depth)) { |
|
249 |
set_msg("force inline by ciReplay"); |
|
250 |
return false; |
|
251 |
} |
|
252 |
||
253 |
if (ciReplay::should_not_inline(C->replay_inline_data(), callee_method, caller_bci, inline_depth)) { |
|
254 |
set_msg("disallowed by ciReplay"); |
|
255 |
return true; |
|
256 |
} |
|
257 |
||
17383 | 258 |
if (ciReplay::should_not_inline(callee_method)) { |
259 |
set_msg("disallowed by ciReplay"); |
|
260 |
return true; |
|
261 |
} |
|
262 |
#endif |
|
263 |
||
25640
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
264 |
if (callee_method->force_inline()) { |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
265 |
set_msg("force inline by annotation"); |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
266 |
return false; |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
267 |
} |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
268 |
|
1 | 269 |
// Now perform checks which are heuristic |
270 |
||
17383 | 271 |
if (is_unboxing_method(callee_method, C)) { |
272 |
// Inline unboxing methods. |
|
273 |
return false; |
|
274 |
} |
|
275 |
||
25640
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
276 |
if (callee_method->has_compiled_code() && |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
277 |
callee_method->instructions_size() > InlineSmallCode) { |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
278 |
set_msg("already compiled into a big method"); |
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
279 |
return true; |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
280 |
} |
1 | 281 |
|
282 |
// don't inline exception code unless the top method belongs to an |
|
283 |
// exception class |
|
284 |
if (caller_tree() != NULL && |
|
285 |
callee_method->holder()->is_subclass_of(C->env()->Throwable_klass())) { |
|
286 |
const InlineTree *top = this; |
|
287 |
while (top->caller_tree() != NULL) top = top->caller_tree(); |
|
288 |
ciInstanceKlass* k = top->method()->holder(); |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
289 |
if (!k->is_subclass_of(C->env()->Throwable_klass())) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
290 |
set_msg("exception method"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
291 |
return true; |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
292 |
} |
1 | 293 |
} |
294 |
||
295 |
// use frequency-based objections only for non-trivial methods |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
296 |
if (callee_method->code_size() <= MaxTrivialSize) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
297 |
return false; |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
298 |
} |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
299 |
|
52934
8deeb7bba516
8214917: CTW testlibrary shouldn't ignore errors raised by the library itself
iignatyev
parents:
51333
diff
changeset
|
300 |
// don't use counts with -Xcomp |
8deeb7bba516
8214917: CTW testlibrary shouldn't ignore errors raised by the library itself
iignatyev
parents:
51333
diff
changeset
|
301 |
if (UseInterpreter) { |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
302 |
|
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
303 |
if (!callee_method->has_compiled_code() && |
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
304 |
!callee_method->was_executed_more_than(0)) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
305 |
set_msg("never executed"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
306 |
return true; |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
307 |
} |
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
308 |
|
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
309 |
if (is_init_with_ea(callee_method, caller_method, C)) { |
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
310 |
// Escape Analysis: inline all executed constructors |
17383 | 311 |
return false; |
27148
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
312 |
} else { |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
313 |
intx counter_high_value; |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
314 |
// Tiered compilation uses a different "high value" than non-tiered compilation. |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
315 |
// Determine the right value to use. |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
316 |
if (TieredCompilation) { |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
317 |
counter_high_value = InvocationCounter::count_limit / 2; |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
318 |
} else { |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
319 |
counter_high_value = CompileThreshold / 2; |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
320 |
} |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
321 |
if (!callee_method->was_executed_more_than(MIN2(MinInliningThreshold, counter_high_value))) { |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
322 |
set_msg("executed < MinInliningThreshold times"); |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
323 |
return true; |
a4b542d56e01
8059604: Add CompileThresholdScaling flag to control when methods are first compiled (with and withour TieredCompilation)
zmajo
parents:
25640
diff
changeset
|
324 |
} |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
325 |
} |
1 | 326 |
} |
327 |
||
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
328 |
return false; |
1 | 329 |
} |
330 |
||
54723
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
331 |
bool InlineTree::is_not_reached(ciMethod* callee_method, ciMethod* caller_method, int caller_bci, ciCallProfile& profile) { |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
332 |
if (!UseInterpreter) { |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
333 |
return false; // -Xcomp |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
334 |
} |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
335 |
if (profile.count() > 0) { |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
336 |
return false; // reachable according to profile |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
337 |
} |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
338 |
if (!callee_method->was_executed_more_than(0)) { |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
339 |
return true; // callee was never executed |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
340 |
} |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
341 |
if (caller_method->is_not_reached(caller_bci)) { |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
342 |
return true; // call site not resolved |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
343 |
} |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
344 |
if (profile.count() == -1) { |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
345 |
return false; // immature profile; optimistically treat as reached |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
346 |
} |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
347 |
assert(profile.count() == 0, "sanity"); |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
348 |
|
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
349 |
// Profile info is scarce. |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
350 |
// Try to guess: check if the call site belongs to a start block. |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
351 |
// Call sites in a start block should be reachable if no exception is thrown earlier. |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
352 |
ciMethodBlocks* caller_blocks = caller_method->get_method_blocks(); |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
353 |
bool is_start_block = caller_blocks->block_containing(caller_bci)->start_bci() == 0; |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
354 |
if (is_start_block) { |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
355 |
return false; // treat the call reached as part of start block |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
356 |
} |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
357 |
return true; // give up and treat the call site as not reached |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
358 |
} |
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
359 |
|
1 | 360 |
//-----------------------------try_to_inline----------------------------------- |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
361 |
// return true if ok |
1 | 362 |
// Relocated from "InliningClosure::try_to_inline" |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
363 |
bool InlineTree::try_to_inline(ciMethod* callee_method, ciMethod* caller_method, |
20689
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
364 |
int caller_bci, JVMState* jvms, ciCallProfile& profile, |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
365 |
WarmCallInfo* wci_result, bool& should_delay) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
366 |
|
22800 | 367 |
if (ClipInlining && (int)count_inline_bcs() >= DesiredMethodLimit) { |
15113 | 368 |
if (!callee_method->force_inline() || !IncrementalInline) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
369 |
set_msg("size > DesiredMethodLimit"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
370 |
return false; |
15113 | 371 |
} else if (!C->inlining_incrementally()) { |
372 |
should_delay = true; |
|
373 |
} |
|
1 | 374 |
} |
375 |
||
22243 | 376 |
_forced_inline = false; // Reset |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
377 |
if (!should_inline(callee_method, caller_method, caller_bci, profile, |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
378 |
wci_result)) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
379 |
return false; |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
380 |
} |
20689
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
381 |
if (should_not_inline(callee_method, caller_method, jvms, wci_result)) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
382 |
return false; |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
383 |
} |
1 | 384 |
|
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
385 |
if (InlineAccessors && callee_method->is_accessor()) { |
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
386 |
// accessor methods are not subject to any of the following limits. |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
387 |
set_msg("accessor"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
388 |
return true; |
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
389 |
} |
1 | 390 |
|
391 |
// suppress a few checks for accessors and trivial methods |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
392 |
if (callee_method->code_size() > MaxTrivialSize) { |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
393 |
|
1 | 394 |
// don't inline into giant methods |
15113 | 395 |
if (C->over_inlining_cutoff()) { |
396 |
if ((!callee_method->force_inline() && !caller_method->is_compiled_lambda_form()) |
|
397 |
|| !IncrementalInline) { |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
398 |
set_msg("NodeCountInliningCutoff"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
399 |
return false; |
15113 | 400 |
} else { |
401 |
should_delay = true; |
|
402 |
} |
|
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
403 |
} |
1 | 404 |
|
52934
8deeb7bba516
8214917: CTW testlibrary shouldn't ignore errors raised by the library itself
iignatyev
parents:
51333
diff
changeset
|
405 |
if (!UseInterpreter && |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
406 |
is_init_with_ea(callee_method, caller_method, C)) { |
52934
8deeb7bba516
8214917: CTW testlibrary shouldn't ignore errors raised by the library itself
iignatyev
parents:
51333
diff
changeset
|
407 |
// Escape Analysis stress testing when running Xcomp: |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
408 |
// inline constructors even if they are not reached. |
22243 | 409 |
} else if (forced_inline()) { |
25640
eb0d8ef2f700
8049528: Method marked w/ @ForceInline isn't inlined with "executed < MinInliningThreshold times" message
vlivanov
parents:
24924
diff
changeset
|
410 |
// Inlining was forced by CompilerOracle, ciReplay or annotation |
54723
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53632
diff
changeset
|
411 |
} else if (is_not_reached(callee_method, caller_method, caller_bci, profile)) { |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
412 |
// don't inline unreached call sites |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
413 |
set_msg("call site not reached"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
414 |
return false; |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
415 |
} |
1 | 416 |
} |
417 |
||
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
418 |
if (!C->do_inlining() && InlineAccessors) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
419 |
set_msg("not an accessor"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
420 |
return false; |
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
421 |
} |
24924
f4f18b588249
8043413: REGRESSION: Hotspot causes segmentation fault in jdk8ux, but not in jdk7ux
roland
parents:
22800
diff
changeset
|
422 |
|
f4f18b588249
8043413: REGRESSION: Hotspot causes segmentation fault in jdk8ux, but not in jdk7ux
roland
parents:
22800
diff
changeset
|
423 |
// Limit inlining depth in case inlining is forced or |
f4f18b588249
8043413: REGRESSION: Hotspot causes segmentation fault in jdk8ux, but not in jdk7ux
roland
parents:
22800
diff
changeset
|
424 |
// _max_inline_level was increased to compensate for lambda forms. |
f4f18b588249
8043413: REGRESSION: Hotspot causes segmentation fault in jdk8ux, but not in jdk7ux
roland
parents:
22800
diff
changeset
|
425 |
if (inline_level() > MaxForceInlineLevel) { |
f4f18b588249
8043413: REGRESSION: Hotspot causes segmentation fault in jdk8ux, but not in jdk7ux
roland
parents:
22800
diff
changeset
|
426 |
set_msg("MaxForceInlineLevel"); |
f4f18b588249
8043413: REGRESSION: Hotspot causes segmentation fault in jdk8ux, but not in jdk7ux
roland
parents:
22800
diff
changeset
|
427 |
return false; |
f4f18b588249
8043413: REGRESSION: Hotspot causes segmentation fault in jdk8ux, but not in jdk7ux
roland
parents:
22800
diff
changeset
|
428 |
} |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
429 |
if (inline_level() > _max_inline_level) { |
15113 | 430 |
if (!callee_method->force_inline() || !IncrementalInline) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
431 |
set_msg("inlining too deep"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
432 |
return false; |
15113 | 433 |
} else if (!C->inlining_incrementally()) { |
434 |
should_delay = true; |
|
435 |
} |
|
214
c5d9b4456687
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
1
diff
changeset
|
436 |
} |
8872
36680c58660e
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
8676
diff
changeset
|
437 |
|
9435
b16821523fe3
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
8872
diff
changeset
|
438 |
// detect direct and indirect recursive inlining |
20689
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
439 |
{ |
9435
b16821523fe3
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
8872
diff
changeset
|
440 |
// count the current method and the callee |
20689
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
441 |
const bool is_compiled_lambda_form = callee_method->is_compiled_lambda_form(); |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
442 |
int inline_level = 0; |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
443 |
if (!is_compiled_lambda_form) { |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
444 |
if (method() == callee_method) { |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
445 |
inline_level++; |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
446 |
} |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
447 |
} |
9435
b16821523fe3
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
8872
diff
changeset
|
448 |
// count callers of current method and callee |
20689
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
449 |
Node* callee_argument0 = is_compiled_lambda_form ? jvms->map()->argument(jvms, 0)->uncast() : NULL; |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
450 |
for (JVMState* j = jvms->caller(); j != NULL && j->has_method(); j = j->caller()) { |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
451 |
if (j->method() == callee_method) { |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
452 |
if (is_compiled_lambda_form) { |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
453 |
// Since compiled lambda forms are heavily reused we allow recursive inlining. If it is truly |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
454 |
// a recursion (using the same "receiver") we limit inlining otherwise we can easily blow the |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
455 |
// compiler stack. |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
456 |
Node* caller_argument0 = j->map()->argument(j, 0)->uncast(); |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
457 |
if (caller_argument0 == callee_argument0) { |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
458 |
inline_level++; |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
459 |
} |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
460 |
} else { |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
461 |
inline_level++; |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
462 |
} |
8872
36680c58660e
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
8676
diff
changeset
|
463 |
} |
20689
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
464 |
} |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
465 |
if (inline_level > MaxRecursiveInlineLevel) { |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
466 |
set_msg("recursive inlining is too deep"); |
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
467 |
return false; |
8872
36680c58660e
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
8676
diff
changeset
|
468 |
} |
36680c58660e
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
8676
diff
changeset
|
469 |
} |
36680c58660e
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
8676
diff
changeset
|
470 |
|
10506
575ad9bccff5
7078382: JSR 292: don't count method handle adapters against inlining budgets
twisti
parents:
10007
diff
changeset
|
471 |
int size = callee_method->code_size_for_inlining(); |
1 | 472 |
|
22800 | 473 |
if (ClipInlining && (int)count_inline_bcs() + size >= DesiredMethodLimit) { |
15113 | 474 |
if (!callee_method->force_inline() || !IncrementalInline) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
475 |
set_msg("size > DesiredMethodLimit"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
476 |
return false; |
15113 | 477 |
} else if (!C->inlining_incrementally()) { |
478 |
should_delay = true; |
|
479 |
} |
|
1 | 480 |
} |
481 |
||
482 |
// ok, inline this method |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
483 |
return true; |
1 | 484 |
} |
485 |
||
486 |
//------------------------------pass_initial_checks---------------------------- |
|
53632
d620a4a1d5ed
8188133: C2: Static field accesses in clinit can trigger deoptimizations
vlivanov
parents:
52934
diff
changeset
|
487 |
bool InlineTree::pass_initial_checks(ciMethod* caller_method, int caller_bci, ciMethod* callee_method) { |
1 | 488 |
// Check if a callee_method was suggested |
55110
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
489 |
if (callee_method == NULL) { |
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
490 |
return false; |
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
491 |
} |
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
492 |
ciInstanceKlass *callee_holder = callee_method->holder(); |
1 | 493 |
// Check if klass of callee_method is loaded |
55110
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
494 |
if (!callee_holder->is_loaded()) { |
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
495 |
return false; |
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
496 |
} |
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
497 |
if (!callee_holder->is_initialized() && |
53632
d620a4a1d5ed
8188133: C2: Static field accesses in clinit can trigger deoptimizations
vlivanov
parents:
52934
diff
changeset
|
498 |
// access allowed in the context of static initializer |
55110
17f85a8780d5
8223216: C2: Unify class initialization checks between new, getstatic, and putstatic
vlivanov
parents:
54723
diff
changeset
|
499 |
C->needs_clinit_barrier(callee_holder, caller_method)) { |
53632
d620a4a1d5ed
8188133: C2: Static field accesses in clinit can trigger deoptimizations
vlivanov
parents:
52934
diff
changeset
|
500 |
return false; |
d620a4a1d5ed
8188133: C2: Static field accesses in clinit can trigger deoptimizations
vlivanov
parents:
52934
diff
changeset
|
501 |
} |
52934
8deeb7bba516
8214917: CTW testlibrary shouldn't ignore errors raised by the library itself
iignatyev
parents:
51333
diff
changeset
|
502 |
if( !UseInterpreter ) /* running Xcomp */ { |
1 | 503 |
// Checks that constant pool's call site has been visited |
504 |
// stricter than callee_holder->is_initialized() |
|
505 |
ciBytecodeStream iter(caller_method); |
|
506 |
iter.force_bci(caller_bci); |
|
507 |
Bytecodes::Code call_bc = iter.cur_bc(); |
|
4566
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
508 |
// An invokedynamic instruction does not have a klass. |
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
509 |
if (call_bc != Bytecodes::_invokedynamic) { |
5688 | 510 |
int index = iter.get_index_u2_cpcache(); |
4566
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
511 |
if (!caller_method->is_klass_loaded(index, true)) { |
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
512 |
return false; |
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
513 |
} |
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
514 |
// Try to do constant pool resolution if running Xcomp |
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
515 |
if( !caller_method->check_call(index, call_bc == Bytecodes::_invokestatic) ) { |
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
516 |
return false; |
b363f6ef4068
6829187: compiler optimizations required for JSR 292
twisti
parents:
3603
diff
changeset
|
517 |
} |
1 | 518 |
} |
519 |
} |
|
520 |
return true; |
|
521 |
} |
|
522 |
||
10509
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
523 |
//------------------------------check_can_parse-------------------------------- |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
524 |
const char* InlineTree::check_can_parse(ciMethod* callee) { |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
525 |
// Certain methods cannot be parsed at all: |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
526 |
if ( callee->is_native()) return "native method"; |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
527 |
if ( callee->is_abstract()) return "abstract method"; |
10509
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
528 |
if (!callee->has_balanced_monitors()) return "not compilable (unbalanced monitors)"; |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
529 |
if ( callee->get_flow_analysis()->failing()) return "not compilable (flow analysis failed)"; |
48024
6199dfaf72da
8191688: Assert failed in > 200 tests: failed dependencies, but counter didn't change
dlong
parents:
48002
diff
changeset
|
530 |
if (!callee->can_be_parsed()) return "cannot be parsed"; |
10509
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
531 |
return NULL; |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
532 |
} |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
533 |
|
50113 | 534 |
static void post_inlining_event(int compile_id,const char* msg, bool success, int bci, ciMethod* caller, ciMethod* callee) { |
535 |
assert(caller != NULL, "invariant"); |
|
536 |
assert(callee != NULL, "invariant"); |
|
537 |
EventCompilerInlining event; |
|
538 |
if (event.should_commit()) { |
|
539 |
JfrStructCalleeMethod callee_struct; |
|
540 |
callee_struct.set_type(callee->holder()->name()->as_utf8()); |
|
541 |
callee_struct.set_name(callee->name()->as_utf8()); |
|
542 |
callee_struct.set_descriptor(callee->signature()->as_symbol()->as_utf8()); |
|
543 |
event.set_compileId(compile_id); |
|
544 |
event.set_message(msg); |
|
545 |
event.set_succeeded(success); |
|
546 |
event.set_bci(bci); |
|
547 |
event.set_caller(caller->get_Method()); |
|
548 |
event.set_callee(callee_struct); |
|
549 |
event.commit(); |
|
550 |
} |
|
551 |
} |
|
552 |
||
1 | 553 |
//------------------------------print_inlining--------------------------------- |
15472
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
554 |
void InlineTree::print_inlining(ciMethod* callee_method, int caller_bci, |
29582 | 555 |
ciMethod* caller_method, bool success) const { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
556 |
const char* inline_msg = msg(); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
557 |
assert(inline_msg != NULL, "just checking"); |
15472
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
558 |
if (C->log() != NULL) { |
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
559 |
if (success) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
560 |
C->log()->inline_success(inline_msg); |
15472
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
561 |
} else { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
562 |
C->log()->inline_fail(inline_msg); |
15472
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
563 |
} |
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
564 |
} |
46270 | 565 |
CompileTask::print_inlining_ul(callee_method, inline_level(), |
566 |
caller_bci, inline_msg); |
|
20073 | 567 |
if (C->print_inlining()) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
568 |
C->print_inlining(callee_method, inline_level(), caller_bci, inline_msg); |
51078 | 569 |
guarantee(callee_method != NULL, "would crash in post_inlining_event"); |
570 |
if (Verbose) { |
|
15472
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
571 |
const InlineTree *top = this; |
51078 | 572 |
while (top->caller_tree() != NULL) { top = top->caller_tree(); } |
15472
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
573 |
//tty->print(" bcs: %d+%d invoked: %d", top->count_inline_bcs(), callee_method->code_size(), callee_method->interpreter_invocation_count()); |
ae13b6ad6c25
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
15113
diff
changeset
|
574 |
} |
1 | 575 |
} |
50113 | 576 |
post_inlining_event(C->compile_id(), inline_msg, success, caller_bci, caller_method, callee_method); |
1 | 577 |
} |
578 |
||
579 |
//------------------------------ok_to_inline----------------------------------- |
|
15113 | 580 |
WarmCallInfo* InlineTree::ok_to_inline(ciMethod* callee_method, JVMState* jvms, ciCallProfile& profile, WarmCallInfo* initial_wci, bool& should_delay) { |
1 | 581 |
assert(callee_method != NULL, "caller checks for optimized virtual!"); |
15113 | 582 |
assert(!should_delay, "should be initialized to false"); |
1 | 583 |
#ifdef ASSERT |
584 |
// Make sure the incoming jvms has the same information content as me. |
|
585 |
// This means that we can eventually make this whole class AllStatic. |
|
586 |
if (jvms->caller() == NULL) { |
|
587 |
assert(_caller_jvms == NULL, "redundant instance state"); |
|
588 |
} else { |
|
589 |
assert(_caller_jvms->same_calls_as(jvms->caller()), "redundant instance state"); |
|
590 |
} |
|
591 |
assert(_method == jvms->method(), "redundant instance state"); |
|
592 |
#endif |
|
593 |
int caller_bci = jvms->bci(); |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
594 |
ciMethod* caller_method = jvms->method(); |
1 | 595 |
|
10509
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
596 |
// Do some initial checks. |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
597 |
if (!pass_initial_checks(caller_method, caller_bci, callee_method)) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
598 |
set_msg("failed initial checks"); |
29582 | 599 |
print_inlining(callee_method, caller_bci, caller_method, false /* !success */); |
1 | 600 |
return NULL; |
601 |
} |
|
602 |
||
10509
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
603 |
// Do some parse checks. |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
604 |
set_msg(check_can_parse(callee_method)); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
605 |
if (msg() != NULL) { |
29582 | 606 |
print_inlining(callee_method, caller_bci, caller_method, false /* !success */); |
10509
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
607 |
return NULL; |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
608 |
} |
43d670e5701e
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
10506
diff
changeset
|
609 |
|
1 | 610 |
// Check if inlining policy says no. |
611 |
WarmCallInfo wci = *(initial_wci); |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
612 |
bool success = try_to_inline(callee_method, caller_method, caller_bci, |
20689
bc5805c29150
8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods
twisti
parents:
20073
diff
changeset
|
613 |
jvms, profile, &wci, should_delay); |
1 | 614 |
|
615 |
#ifndef PRODUCT |
|
22800 | 616 |
if (InlineWarmCalls && (PrintOpto || C->print_inlining())) { |
1 | 617 |
bool cold = wci.is_cold(); |
618 |
bool hot = !cold && wci.is_hot(); |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
619 |
bool old_cold = !success; |
1 | 620 |
if (old_cold != cold || (Verbose || WizardMode)) { |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
621 |
if (msg() == NULL) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
622 |
set_msg("OK"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
623 |
} |
1 | 624 |
tty->print(" OldInlining= %4s : %s\n WCI=", |
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
625 |
old_cold ? "cold" : "hot", msg()); |
1 | 626 |
wci.print(); |
627 |
} |
|
628 |
} |
|
629 |
#endif |
|
22800 | 630 |
if (success) { |
631 |
wci = *(WarmCallInfo::always_hot()); |
|
632 |
} else { |
|
633 |
wci = *(WarmCallInfo::always_cold()); |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
634 |
} |
22800 | 635 |
|
1 | 636 |
if (!InlineWarmCalls) { |
637 |
if (!wci.is_cold() && !wci.is_hot()) { |
|
638 |
// Do not inline the warm calls. |
|
639 |
wci = *(WarmCallInfo::always_cold()); |
|
640 |
} |
|
641 |
} |
|
642 |
||
643 |
if (!wci.is_cold()) { |
|
644 |
// Inline! |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
645 |
if (msg() == NULL) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
646 |
set_msg("inline (hot)"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
647 |
} |
29582 | 648 |
print_inlining(callee_method, caller_bci, caller_method, true /* success */); |
22800 | 649 |
build_inline_tree_for_callee(callee_method, jvms, caller_bci); |
29582 | 650 |
if (InlineWarmCalls && !wci.is_hot()) { |
1 | 651 |
return new (C) WarmCallInfo(wci); // copy to heap |
29582 | 652 |
} |
1 | 653 |
return WarmCallInfo::always_hot(); |
654 |
} |
|
655 |
||
656 |
// Do not inline |
|
15816
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
657 |
if (msg() == NULL) { |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
658 |
set_msg("too cold to inline"); |
33b9a6b4f9df
8007439: C2: adding successful message of inlining
iignatyev
parents:
15472
diff
changeset
|
659 |
} |
29582 | 660 |
print_inlining(callee_method, caller_bci, caller_method, false /* !success */ ); |
1 | 661 |
return NULL; |
662 |
} |
|
663 |
||
664 |
//------------------------------compute_callee_frequency----------------------- |
|
665 |
float InlineTree::compute_callee_frequency( int caller_bci ) const { |
|
666 |
int count = method()->interpreter_call_site_count(caller_bci); |
|
667 |
int invcnt = method()->interpreter_invocation_count(); |
|
668 |
float freq = (float)count/(float)invcnt; |
|
669 |
// Call-site count / interpreter invocation count, scaled recursively. |
|
670 |
// Always between 0.0 and 1.0. Represents the percentage of the method's |
|
671 |
// total execution time used at this call site. |
|
672 |
||
673 |
return freq; |
|
674 |
} |
|
675 |
||
676 |
//------------------------------build_inline_tree_for_callee------------------- |
|
677 |
InlineTree *InlineTree::build_inline_tree_for_callee( ciMethod* callee_method, JVMState* caller_jvms, int caller_bci) { |
|
678 |
float recur_frequency = _site_invoke_ratio * compute_callee_frequency(caller_bci); |
|
679 |
// Attempt inlining. |
|
680 |
InlineTree* old_ilt = callee_at(caller_bci, callee_method); |
|
681 |
if (old_ilt != NULL) { |
|
682 |
return old_ilt; |
|
683 |
} |
|
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
684 |
int max_inline_level_adjust = 0; |
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
685 |
if (caller_jvms->method() != NULL) { |
30305
b92a97e1e9cb
8068945: Use RBP register as proper frame pointer in JIT compiled code on x86
zmajo
parents:
29582
diff
changeset
|
686 |
if (caller_jvms->method()->is_compiled_lambda_form()) { |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
687 |
max_inline_level_adjust += 1; // don't count actions in MH or indy adapter frames |
30305
b92a97e1e9cb
8068945: Use RBP register as proper frame pointer in JIT compiled code on x86
zmajo
parents:
29582
diff
changeset
|
688 |
} else if (callee_method->is_method_handle_intrinsic() || |
b92a97e1e9cb
8068945: Use RBP register as proper frame pointer in JIT compiled code on x86
zmajo
parents:
29582
diff
changeset
|
689 |
callee_method->is_compiled_lambda_form()) { |
b92a97e1e9cb
8068945: Use RBP register as proper frame pointer in JIT compiled code on x86
zmajo
parents:
29582
diff
changeset
|
690 |
max_inline_level_adjust += 1; // don't count method handle calls from java.lang.invoke implementation |
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
691 |
} |
20073 | 692 |
if (max_inline_level_adjust != 0 && C->print_inlining() && (Verbose || WizardMode)) { |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
693 |
CompileTask::print_inline_indent(inline_level()); |
9633
92a7a2841a16
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
9446
diff
changeset
|
694 |
tty->print_cr(" \\-> discounting inline depth"); |
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
695 |
} |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
696 |
if (max_inline_level_adjust != 0 && C->log()) { |
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
697 |
int id1 = C->log()->identify(caller_jvms->method()); |
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
698 |
int id2 = C->log()->identify(callee_method); |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
699 |
C->log()->elem("inline_level_discount caller='%d' callee='%d'", id1, id2); |
4586
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
700 |
} |
f1c484fca023
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
4567
diff
changeset
|
701 |
} |
47551
4d034d861e13
8187780: VM crashes while generating replay compilation file
thartmann
parents:
47216
diff
changeset
|
702 |
// Allocate in the comp_arena to make sure the InlineTree is live when dumping a replay compilation file |
4d034d861e13
8187780: VM crashes while generating replay compilation file
thartmann
parents:
47216
diff
changeset
|
703 |
InlineTree* ilt = new (C->comp_arena()) InlineTree(C, this, callee_method, caller_jvms, caller_bci, recur_frequency, _max_inline_level + max_inline_level_adjust); |
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
704 |
_subtrees.append(ilt); |
1 | 705 |
|
706 |
NOT_PRODUCT( _count_inlines += 1; ) |
|
707 |
||
708 |
return ilt; |
|
709 |
} |
|
710 |
||
711 |
||
712 |
//---------------------------------------callee_at----------------------------- |
|
713 |
InlineTree *InlineTree::callee_at(int bci, ciMethod* callee) const { |
|
714 |
for (int i = 0; i < _subtrees.length(); i++) { |
|
715 |
InlineTree* sub = _subtrees.at(i); |
|
716 |
if (sub->caller_bci() == bci && callee == sub->method()) { |
|
717 |
return sub; |
|
718 |
} |
|
719 |
} |
|
720 |
return NULL; |
|
721 |
} |
|
722 |
||
723 |
||
724 |
//------------------------------build_inline_tree_root------------------------- |
|
725 |
InlineTree *InlineTree::build_inline_tree_root() { |
|
726 |
Compile* C = Compile::current(); |
|
727 |
||
728 |
// Root of inline tree |
|
10007
43d4a6542551
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
9633
diff
changeset
|
729 |
InlineTree* ilt = new InlineTree(C, NULL, C->method(), NULL, -1, 1.0F, MaxInlineLevel); |
1 | 730 |
|
731 |
return ilt; |
|
732 |
} |
|
733 |
||
734 |
||
735 |
//-------------------------find_subtree_from_root----------------------------- |
|
736 |
// Given a jvms, which determines a call chain from the root method, |
|
737 |
// find the corresponding inline tree. |
|
738 |
// Note: This method will be removed or replaced as InlineTree goes away. |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
739 |
InlineTree* InlineTree::find_subtree_from_root(InlineTree* root, JVMState* jvms, ciMethod* callee) { |
1 | 740 |
InlineTree* iltp = root; |
741 |
uint depth = jvms && jvms->has_method() ? jvms->depth() : 0; |
|
742 |
for (uint d = 1; d <= depth; d++) { |
|
743 |
JVMState* jvmsp = jvms->of_depth(d); |
|
744 |
// Select the corresponding subtree for this bci. |
|
745 |
assert(jvmsp->method() == iltp->method(), "tree still in sync"); |
|
746 |
ciMethod* d_callee = (d == depth) ? callee : jvms->of_depth(d+1)->method(); |
|
747 |
InlineTree* sub = iltp->callee_at(jvmsp->bci(), d_callee); |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
748 |
if (sub == NULL) { |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
749 |
if (d == depth) { |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
750 |
sub = iltp->build_inline_tree_for_callee(d_callee, jvmsp, jvmsp->bci()); |
1 | 751 |
} |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
752 |
guarantee(sub != NULL, "should be a sub-ilt here"); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
12160
diff
changeset
|
753 |
return sub; |
1 | 754 |
} |
755 |
iltp = sub; |
|
756 |
} |
|
757 |
return iltp; |
|
758 |
} |
|
10547 | 759 |
|
22243 | 760 |
// Count number of nodes in this subtree |
761 |
int InlineTree::count() const { |
|
762 |
int result = 1; |
|
763 |
for (int i = 0 ; i < _subtrees.length(); i++) { |
|
764 |
result += _subtrees.at(i)->count(); |
|
765 |
} |
|
766 |
return result; |
|
767 |
} |
|
768 |
||
769 |
void InlineTree::dump_replay_data(outputStream* out) { |
|
770 |
out->print(" %d %d ", inline_level(), caller_bci()); |
|
771 |
method()->dump_name_as_ascii(out); |
|
772 |
for (int i = 0 ; i < _subtrees.length(); i++) { |
|
773 |
_subtrees.at(i)->dump_replay_data(out); |
|
774 |
} |
|
775 |
} |
|
10547 | 776 |
|
777 |
||
778 |
#ifndef PRODUCT |
|
779 |
void InlineTree::print_impl(outputStream* st, int indent) const { |
|
780 |
for (int i = 0; i < indent; i++) st->print(" "); |
|
22243 | 781 |
st->print(" @ %d", caller_bci()); |
10547 | 782 |
method()->print_short_name(st); |
783 |
st->cr(); |
|
784 |
||
785 |
for (int i = 0 ; i < _subtrees.length(); i++) { |
|
786 |
_subtrees.at(i)->print_impl(st, indent + 2); |
|
787 |
} |
|
788 |
} |
|
789 |
||
790 |
void InlineTree::print_value_on(outputStream* st) const { |
|
791 |
print_impl(st, 2); |
|
792 |
} |
|
793 |
#endif |