author | vromero |
Mon, 08 Oct 2018 06:52:41 -0700 | |
changeset 52038 | 957de5be48bc |
parent 47765 | b7c7428eaab9 |
child 52934 | 8deeb7bba516 |
permissions | -rw-r--r-- |
23528 | 1 |
/* |
2 |
* Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. |
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
|
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
20 |
* or visit www.oracle.com if you need additional information or have any |
|
21 |
* questions. |
|
22 |
* |
|
23 |
*/ |
|
24 |
||
25 |
#include "precompiled.hpp" |
|
26 |
#include "opto/addnode.hpp" |
|
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
27 |
#include "opto/callnode.hpp" |
23528 | 28 |
#include "opto/castnode.hpp" |
29 |
#include "opto/connode.hpp" |
|
30 |
#include "opto/matcher.hpp" |
|
31 |
#include "opto/phaseX.hpp" |
|
32 |
#include "opto/subnode.hpp" |
|
33 |
#include "opto/type.hpp" |
|
34 |
||
35 |
//============================================================================= |
|
36 |
// If input is already higher or equal to cast type, then this is an identity. |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
37 |
Node* ConstraintCastNode::Identity(PhaseGVN* phase) { |
46532
7c122c98399d
8181741: C2 compilation fails with "assert(i<_max) failed: oob"
thartmann
parents:
46525
diff
changeset
|
38 |
Node* dom = dominating_cast(phase, phase); |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
39 |
if (dom != NULL) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
40 |
return dom; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
41 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
42 |
if (_carry_dependency) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
43 |
return this; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
44 |
} |
23528 | 45 |
return phase->type(in(1))->higher_equal_speculative(_type) ? in(1) : this; |
46 |
} |
|
47 |
||
48 |
//------------------------------Value------------------------------------------ |
|
49 |
// Take 'join' of input and cast-up type |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
50 |
const Type* ConstraintCastNode::Value(PhaseGVN* phase) const { |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
51 |
if (in(0) && phase->type(in(0)) == Type::TOP) return Type::TOP; |
23528 | 52 |
const Type* ft = phase->type(in(1))->filter_speculative(_type); |
53 |
||
54 |
#ifdef ASSERT |
|
55 |
// Previous versions of this function had some special case logic, |
|
56 |
// which is no longer necessary. Make sure of the required effects. |
|
57 |
switch (Opcode()) { |
|
58 |
case Op_CastII: |
|
59 |
{ |
|
60 |
const Type* t1 = phase->type(in(1)); |
|
61 |
if( t1 == Type::TOP ) assert(ft == Type::TOP, "special case #1"); |
|
62 |
const Type* rt = t1->join_speculative(_type); |
|
63 |
if (rt->empty()) assert(ft == Type::TOP, "special case #2"); |
|
64 |
break; |
|
65 |
} |
|
66 |
case Op_CastPP: |
|
67 |
if (phase->type(in(1)) == TypePtr::NULL_PTR && |
|
68 |
_type->isa_ptr() && _type->is_ptr()->_ptr == TypePtr::NotNull) |
|
69 |
assert(ft == Type::TOP, "special case #3"); |
|
70 |
break; |
|
71 |
} |
|
72 |
#endif //ASSERT |
|
73 |
||
74 |
return ft; |
|
75 |
} |
|
76 |
||
77 |
//------------------------------Ideal------------------------------------------ |
|
78 |
// Return a node which is more "ideal" than the current node. Strip out |
|
79 |
// control copies |
|
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
80 |
Node *ConstraintCastNode::Ideal(PhaseGVN *phase, bool can_reshape) { |
23528 | 81 |
return (in(0) && remove_dead_region(phase, can_reshape)) ? this : NULL; |
82 |
} |
|
83 |
||
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
84 |
uint ConstraintCastNode::cmp(const Node &n) const { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
85 |
return TypeNode::cmp(n) && ((ConstraintCastNode&)n)._carry_dependency == _carry_dependency; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
86 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
87 |
|
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
88 |
uint ConstraintCastNode::size_of() const { |
27708
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
89 |
return sizeof(*this); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
90 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
91 |
|
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
92 |
Node* ConstraintCastNode::make_cast(int opcode, Node* c, Node *n, const Type *t, bool carry_dependency) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
93 |
switch(opcode) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
94 |
case Op_CastII: { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
95 |
Node* cast = new CastIINode(n, t, carry_dependency); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
96 |
cast->set_req(0, c); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
97 |
return cast; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
98 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
99 |
case Op_CastPP: { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
100 |
Node* cast = new CastPPNode(n, t, carry_dependency); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
101 |
cast->set_req(0, c); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
102 |
return cast; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
103 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
104 |
case Op_CheckCastPP: return new CheckCastPPNode(c, n, t, carry_dependency); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
105 |
default: |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
106 |
fatal("Bad opcode %d", opcode); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
107 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
108 |
return NULL; |
27708
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
109 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
110 |
|
46532
7c122c98399d
8181741: C2 compilation fails with "assert(i<_max) failed: oob"
thartmann
parents:
46525
diff
changeset
|
111 |
TypeNode* ConstraintCastNode::dominating_cast(PhaseGVN* gvn, PhaseTransform* pt) const { |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
112 |
Node* val = in(1); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
113 |
Node* ctl = in(0); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
114 |
int opc = Opcode(); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
115 |
if (ctl == NULL) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
116 |
return NULL; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
117 |
} |
36065 | 118 |
// Range check CastIIs may all end up under a single range check and |
119 |
// in that case only the narrower CastII would be kept by the code |
|
120 |
// below which would be incorrect. |
|
121 |
if (is_CastII() && as_CastII()->has_range_check()) { |
|
122 |
return NULL; |
|
123 |
} |
|
46532
7c122c98399d
8181741: C2 compilation fails with "assert(i<_max) failed: oob"
thartmann
parents:
46525
diff
changeset
|
124 |
if (type()->isa_rawptr() && (gvn->type_or_null(val) == NULL || gvn->type(val)->isa_oopptr())) { |
46525
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
125 |
return NULL; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
126 |
} |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
127 |
for (DUIterator_Fast imax, i = val->fast_outs(imax); i < imax; i++) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
128 |
Node* u = val->fast_out(i); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
129 |
if (u != this && |
36072
2e822f451746
8149797: Compilation fails with "assert(in_hash) failed: node should be in igvn hash table"
roland
parents:
36065
diff
changeset
|
130 |
u->outcnt() > 0 && |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
131 |
u->Opcode() == opc && |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
132 |
u->in(0) != NULL && |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
133 |
u->bottom_type()->higher_equal(type())) { |
46532
7c122c98399d
8181741: C2 compilation fails with "assert(i<_max) failed: oob"
thartmann
parents:
46525
diff
changeset
|
134 |
if (pt->is_dominator(u->in(0), ctl)) { |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
135 |
return u->as_Type(); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
136 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
137 |
if (is_CheckCastPP() && u->in(1)->is_Proj() && u->in(1)->in(0)->is_Allocate() && |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
138 |
u->in(0)->is_Proj() && u->in(0)->in(0)->is_Initialize() && |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
139 |
u->in(1)->in(0)->as_Allocate()->initialization() == u->in(0)->in(0)) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
140 |
// CheckCastPP following an allocation always dominates all |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
141 |
// use of the allocation result |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
142 |
return u->as_Type(); |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
143 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
144 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
145 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
146 |
return NULL; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
147 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
148 |
|
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
149 |
#ifndef PRODUCT |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
150 |
void ConstraintCastNode::dump_spec(outputStream *st) const { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
151 |
TypeNode::dump_spec(st); |
27708
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
152 |
if (_carry_dependency) { |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
153 |
st->print(" carry dependency"); |
27708
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
154 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
155 |
} |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
156 |
#endif |
27708
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
157 |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
158 |
const Type* CastIINode::Value(PhaseGVN* phase) const { |
27708
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
159 |
const Type *res = ConstraintCastNode::Value(phase); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
160 |
|
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
161 |
// Try to improve the type of the CastII if we recognize a CmpI/If |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
162 |
// pattern. |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
163 |
if (_carry_dependency) { |
28041
fed7f90dc4c4
8066775: opto/node.hpp:355, assert(i < _max) failed: oob: i=1, _max=1
roland
parents:
27708
diff
changeset
|
164 |
if (in(0) != NULL && in(0)->in(0) != NULL && in(0)->in(0)->is_If()) { |
fed7f90dc4c4
8066775: opto/node.hpp:355, assert(i < _max) failed: oob: i=1, _max=1
roland
parents:
27708
diff
changeset
|
165 |
assert(in(0)->is_IfFalse() || in(0)->is_IfTrue(), "should be If proj"); |
27708
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
166 |
Node* proj = in(0); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
167 |
if (proj->in(0)->in(1)->is_Bool()) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
168 |
Node* b = proj->in(0)->in(1); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
169 |
if (b->in(1)->Opcode() == Op_CmpI) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
170 |
Node* cmp = b->in(1); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
171 |
if (cmp->in(1) == in(1) && phase->type(cmp->in(2))->isa_int()) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
172 |
const TypeInt* in2_t = phase->type(cmp->in(2))->is_int(); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
173 |
const Type* t = TypeInt::INT; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
174 |
BoolTest test = b->as_Bool()->_test; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
175 |
if (proj->is_IfFalse()) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
176 |
test = test.negate(); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
177 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
178 |
BoolTest::mask m = test._test; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
179 |
jlong lo_long = min_jint; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
180 |
jlong hi_long = max_jint; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
181 |
if (m == BoolTest::le || m == BoolTest::lt) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
182 |
hi_long = in2_t->_hi; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
183 |
if (m == BoolTest::lt) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
184 |
hi_long -= 1; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
185 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
186 |
} else if (m == BoolTest::ge || m == BoolTest::gt) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
187 |
lo_long = in2_t->_lo; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
188 |
if (m == BoolTest::gt) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
189 |
lo_long += 1; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
190 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
191 |
} else if (m == BoolTest::eq) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
192 |
lo_long = in2_t->_lo; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
193 |
hi_long = in2_t->_hi; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
194 |
} else if (m == BoolTest::ne) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
195 |
// can't do any better |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
196 |
} else { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
197 |
stringStream ss; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
198 |
test.dump_on(&ss); |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
30300
diff
changeset
|
199 |
fatal("unexpected comparison %s", ss.as_string()); |
27708
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
200 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
201 |
int lo_int = (int)lo_long; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
202 |
int hi_int = (int)hi_long; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
203 |
|
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
204 |
if (lo_long != (jlong)lo_int) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
205 |
lo_int = min_jint; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
206 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
207 |
if (hi_long != (jlong)hi_int) { |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
208 |
hi_int = max_jint; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
209 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
210 |
|
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
211 |
t = TypeInt::make(lo_int, hi_int, Type::WidenMax); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
212 |
|
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
213 |
res = res->filter_speculative(t); |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
214 |
|
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
215 |
return res; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
216 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
217 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
218 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
219 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
220 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
221 |
return res; |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
222 |
} |
8a8710cb8fc4
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
24923
diff
changeset
|
223 |
|
35549
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
224 |
Node *CastIINode::Ideal(PhaseGVN *phase, bool can_reshape) { |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
225 |
Node* progress = ConstraintCastNode::Ideal(phase, can_reshape); |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
226 |
if (progress != NULL) { |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
227 |
return progress; |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
228 |
} |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
229 |
|
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
230 |
// Similar to ConvI2LNode::Ideal() for the same reasons |
44331
61e01c0389ba
8177095: Range check dependent CastII/ConvI2L is prematurely eliminated
thartmann
parents:
42041
diff
changeset
|
231 |
// Do not narrow the type of range check dependent CastIINodes to |
61e01c0389ba
8177095: Range check dependent CastII/ConvI2L is prematurely eliminated
thartmann
parents:
42041
diff
changeset
|
232 |
// avoid corruption of the graph if a CastII is replaced by TOP but |
61e01c0389ba
8177095: Range check dependent CastII/ConvI2L is prematurely eliminated
thartmann
parents:
42041
diff
changeset
|
233 |
// the corresponding range check is not removed. |
61e01c0389ba
8177095: Range check dependent CastII/ConvI2L is prematurely eliminated
thartmann
parents:
42041
diff
changeset
|
234 |
if (can_reshape && !_range_check_dependency && !phase->C->major_progress()) { |
35549
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
235 |
const TypeInt* this_type = this->type()->is_int(); |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
236 |
const TypeInt* in_type = phase->type(in(1))->isa_int(); |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
237 |
if (in_type != NULL && this_type != NULL && |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
238 |
(in_type->_lo != this_type->_lo || |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
239 |
in_type->_hi != this_type->_hi)) { |
47765
b7c7428eaab9
8189610: Reconcile jvm.h and all jvm_md.h between java.base and hotspot
coleenp
parents:
47216
diff
changeset
|
240 |
jint lo1 = this_type->_lo; |
b7c7428eaab9
8189610: Reconcile jvm.h and all jvm_md.h between java.base and hotspot
coleenp
parents:
47216
diff
changeset
|
241 |
jint hi1 = this_type->_hi; |
35549
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
242 |
int w1 = this_type->_widen; |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
243 |
|
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
244 |
if (lo1 >= 0) { |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
245 |
// Keep a range assertion of >=0. |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
246 |
lo1 = 0; hi1 = max_jint; |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
247 |
} else if (hi1 < 0) { |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
248 |
// Keep a range assertion of <0. |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
249 |
lo1 = min_jint; hi1 = -1; |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
250 |
} else { |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
251 |
lo1 = min_jint; hi1 = max_jint; |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
252 |
} |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
253 |
const TypeInt* wtype = TypeInt::make(MAX2(in_type->_lo, lo1), |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
254 |
MIN2(in_type->_hi, hi1), |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
255 |
MAX2((int)in_type->_widen, w1)); |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
256 |
if (wtype != type()) { |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
257 |
set_type(wtype); |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
258 |
return this; |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
259 |
} |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
260 |
} |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
261 |
} |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
262 |
return NULL; |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
263 |
} |
3415401a6b6e
8145322: Code generated from unsafe loops can be slightly improved
roland
parents:
35545
diff
changeset
|
264 |
|
35574
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
265 |
uint CastIINode::cmp(const Node &n) const { |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
266 |
return ConstraintCastNode::cmp(n) && ((CastIINode&)n)._range_check_dependency == _range_check_dependency; |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
267 |
} |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
268 |
|
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
269 |
uint CastIINode::size_of() const { |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
270 |
return sizeof(*this); |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
271 |
} |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
272 |
|
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
273 |
#ifndef PRODUCT |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
274 |
void CastIINode::dump_spec(outputStream* st) const { |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
275 |
ConstraintCastNode::dump_spec(st); |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
276 |
if (_range_check_dependency) { |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
277 |
st->print(" range check dependency"); |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
278 |
} |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
279 |
} |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
280 |
#endif |
2b25eb88c8d6
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
35551
diff
changeset
|
281 |
|
23528 | 282 |
//============================================================================= |
283 |
//------------------------------Identity--------------------------------------- |
|
284 |
// If input is already higher or equal to cast type, then this is an identity. |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
285 |
Node* CheckCastPPNode::Identity(PhaseGVN* phase) { |
46532
7c122c98399d
8181741: C2 compilation fails with "assert(i<_max) failed: oob"
thartmann
parents:
46525
diff
changeset
|
286 |
Node* dom = dominating_cast(phase, phase); |
35545
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
287 |
if (dom != NULL) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
288 |
return dom; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
289 |
} |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
290 |
if (_carry_dependency) { |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
291 |
return this; |
a8f29dfd62b2
8139771: Eliminating CastPP nodes at Phis when they all come from a unique input may cause crash
roland
parents:
33105
diff
changeset
|
292 |
} |
23528 | 293 |
// Toned down to rescue meeting at a Phi 3 different oops all implementing |
294 |
// the same interface. CompileTheWorld starting at 502, kd12rc1.zip. |
|
295 |
return (phase->type(in(1)) == phase->type(this)) ? in(1) : this; |
|
296 |
} |
|
297 |
||
298 |
//------------------------------Value------------------------------------------ |
|
299 |
// Take 'join' of input and cast-up type, unless working with an Interface |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
300 |
const Type* CheckCastPPNode::Value(PhaseGVN* phase) const { |
23528 | 301 |
if( in(0) && phase->type(in(0)) == Type::TOP ) return Type::TOP; |
302 |
||
303 |
const Type *inn = phase->type(in(1)); |
|
304 |
if( inn == Type::TOP ) return Type::TOP; // No information yet |
|
305 |
||
306 |
const TypePtr *in_type = inn->isa_ptr(); |
|
307 |
const TypePtr *my_type = _type->isa_ptr(); |
|
308 |
const Type *result = _type; |
|
309 |
if( in_type != NULL && my_type != NULL ) { |
|
310 |
TypePtr::PTR in_ptr = in_type->ptr(); |
|
30213
79c4cfb7f7cf
8076094: CheckCastPPNode::Value() has outdated logic for constants
roland
parents:
28041
diff
changeset
|
311 |
if (in_ptr == TypePtr::Null) { |
23528 | 312 |
result = in_type; |
30213
79c4cfb7f7cf
8076094: CheckCastPPNode::Value() has outdated logic for constants
roland
parents:
28041
diff
changeset
|
313 |
} else if (in_ptr == TypePtr::Constant) { |
46525
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
314 |
if (my_type->isa_rawptr()) { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
315 |
result = my_type; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
316 |
} else { |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
317 |
const TypeOopPtr *jptr = my_type->isa_oopptr(); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
318 |
assert(jptr, ""); |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
319 |
result = !in_type->higher_equal(_type) |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
320 |
? my_type->cast_to_ptr_type(TypePtr::NotNull) |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
321 |
: in_type; |
3a5c833a43de
8176506: C2: loop unswitching and unsafe accesses cause crash
roland
parents:
44331
diff
changeset
|
322 |
} |
23528 | 323 |
} else { |
324 |
result = my_type->cast_to_ptr_type( my_type->join_ptr(in_ptr) ); |
|
325 |
} |
|
326 |
} |
|
327 |
||
328 |
// This is the code from TypePtr::xmeet() that prevents us from |
|
329 |
// having 2 ways to represent the same type. We have to replicate it |
|
330 |
// here because we don't go through meet/join. |
|
331 |
if (result->remove_speculative() == result->speculative()) { |
|
332 |
result = result->remove_speculative(); |
|
333 |
} |
|
334 |
||
335 |
// Same as above: because we don't go through meet/join, remove the |
|
336 |
// speculative type if we know we won't use it. |
|
337 |
return result->cleanup_speculative(); |
|
338 |
||
339 |
// JOIN NOT DONE HERE BECAUSE OF INTERFACE ISSUES. |
|
340 |
// FIX THIS (DO THE JOIN) WHEN UNION TYPES APPEAR! |
|
341 |
||
342 |
// |
|
343 |
// Remove this code after overnight run indicates no performance |
|
344 |
// loss from not performing JOIN at CheckCastPPNode |
|
345 |
// |
|
346 |
// const TypeInstPtr *in_oop = in->isa_instptr(); |
|
347 |
// const TypeInstPtr *my_oop = _type->isa_instptr(); |
|
348 |
// // If either input is an 'interface', return destination type |
|
349 |
// assert (in_oop == NULL || in_oop->klass() != NULL, ""); |
|
350 |
// assert (my_oop == NULL || my_oop->klass() != NULL, ""); |
|
351 |
// if( (in_oop && in_oop->klass()->is_interface()) |
|
352 |
// ||(my_oop && my_oop->klass()->is_interface()) ) { |
|
353 |
// TypePtr::PTR in_ptr = in->isa_ptr() ? in->is_ptr()->_ptr : TypePtr::BotPTR; |
|
354 |
// // Preserve cast away nullness for interfaces |
|
355 |
// if( in_ptr == TypePtr::NotNull && my_oop && my_oop->_ptr == TypePtr::BotPTR ) { |
|
356 |
// return my_oop->cast_to_ptr_type(TypePtr::NotNull); |
|
357 |
// } |
|
358 |
// return _type; |
|
359 |
// } |
|
360 |
// |
|
361 |
// // Neither the input nor the destination type is an interface, |
|
362 |
// |
|
363 |
// // history: JOIN used to cause weird corner case bugs |
|
364 |
// // return (in == TypeOopPtr::NULL_PTR) ? in : _type; |
|
365 |
// // JOIN picks up NotNull in common instance-of/check-cast idioms, both oops. |
|
366 |
// // JOIN does not preserve NotNull in other cases, e.g. RawPtr vs InstPtr |
|
367 |
// const Type *join = in->join(_type); |
|
368 |
// // Check if join preserved NotNull'ness for pointers |
|
369 |
// if( join->isa_ptr() && _type->isa_ptr() ) { |
|
370 |
// TypePtr::PTR join_ptr = join->is_ptr()->_ptr; |
|
371 |
// TypePtr::PTR type_ptr = _type->is_ptr()->_ptr; |
|
372 |
// // If there isn't any NotNull'ness to preserve |
|
373 |
// // OR if join preserved NotNull'ness then return it |
|
374 |
// if( type_ptr == TypePtr::BotPTR || type_ptr == TypePtr::Null || |
|
375 |
// join_ptr == TypePtr::NotNull || join_ptr == TypePtr::Constant ) { |
|
376 |
// return join; |
|
377 |
// } |
|
378 |
// // ELSE return same old type as before |
|
379 |
// return _type; |
|
380 |
// } |
|
381 |
// // Not joining two pointers |
|
382 |
// return join; |
|
383 |
} |
|
384 |
||
385 |
//============================================================================= |
|
386 |
//------------------------------Value------------------------------------------ |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
387 |
const Type* CastX2PNode::Value(PhaseGVN* phase) const { |
23528 | 388 |
const Type* t = phase->type(in(1)); |
389 |
if (t == Type::TOP) return Type::TOP; |
|
390 |
if (t->base() == Type_X && t->singleton()) { |
|
391 |
uintptr_t bits = (uintptr_t) t->is_intptr_t()->get_con(); |
|
392 |
if (bits == 0) return TypePtr::NULL_PTR; |
|
393 |
return TypeRawPtr::make((address) bits); |
|
394 |
} |
|
395 |
return CastX2PNode::bottom_type(); |
|
396 |
} |
|
397 |
||
398 |
//------------------------------Idealize--------------------------------------- |
|
399 |
static inline bool fits_in_int(const Type* t, bool but_not_min_int = false) { |
|
400 |
if (t == Type::TOP) return false; |
|
401 |
const TypeX* tl = t->is_intptr_t(); |
|
402 |
jint lo = min_jint; |
|
403 |
jint hi = max_jint; |
|
404 |
if (but_not_min_int) ++lo; // caller wants to negate the value w/o overflow |
|
405 |
return (tl->_lo >= lo) && (tl->_hi <= hi); |
|
406 |
} |
|
407 |
||
408 |
static inline Node* addP_of_X2P(PhaseGVN *phase, |
|
409 |
Node* base, |
|
410 |
Node* dispX, |
|
411 |
bool negate = false) { |
|
412 |
if (negate) { |
|
24923
9631f7d691dc
8034812: remove IDX_INIT macro hack in Node class
thartmann
parents:
23528
diff
changeset
|
413 |
dispX = new SubXNode(phase->MakeConX(0), phase->transform(dispX)); |
23528 | 414 |
} |
24923
9631f7d691dc
8034812: remove IDX_INIT macro hack in Node class
thartmann
parents:
23528
diff
changeset
|
415 |
return new AddPNode(phase->C->top(), |
9631f7d691dc
8034812: remove IDX_INIT macro hack in Node class
thartmann
parents:
23528
diff
changeset
|
416 |
phase->transform(new CastX2PNode(base)), |
9631f7d691dc
8034812: remove IDX_INIT macro hack in Node class
thartmann
parents:
23528
diff
changeset
|
417 |
phase->transform(dispX)); |
23528 | 418 |
} |
419 |
||
420 |
Node *CastX2PNode::Ideal(PhaseGVN *phase, bool can_reshape) { |
|
421 |
// convert CastX2P(AddX(x, y)) to AddP(CastX2P(x), y) if y fits in an int |
|
422 |
int op = in(1)->Opcode(); |
|
423 |
Node* x; |
|
424 |
Node* y; |
|
425 |
switch (op) { |
|
426 |
case Op_SubX: |
|
427 |
x = in(1)->in(1); |
|
428 |
// Avoid ideal transformations ping-pong between this and AddP for raw pointers. |
|
429 |
if (phase->find_intptr_t_con(x, -1) == 0) |
|
430 |
break; |
|
431 |
y = in(1)->in(2); |
|
432 |
if (fits_in_int(phase->type(y), true)) { |
|
433 |
return addP_of_X2P(phase, x, y, true); |
|
434 |
} |
|
435 |
break; |
|
436 |
case Op_AddX: |
|
437 |
x = in(1)->in(1); |
|
438 |
y = in(1)->in(2); |
|
439 |
if (fits_in_int(phase->type(y))) { |
|
440 |
return addP_of_X2P(phase, x, y); |
|
441 |
} |
|
442 |
if (fits_in_int(phase->type(x))) { |
|
443 |
return addP_of_X2P(phase, y, x); |
|
444 |
} |
|
445 |
break; |
|
446 |
} |
|
447 |
return NULL; |
|
448 |
} |
|
449 |
||
450 |
//------------------------------Identity--------------------------------------- |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
451 |
Node* CastX2PNode::Identity(PhaseGVN* phase) { |
23528 | 452 |
if (in(1)->Opcode() == Op_CastP2X) return in(1)->in(1); |
453 |
return this; |
|
454 |
} |
|
455 |
||
456 |
//============================================================================= |
|
457 |
//------------------------------Value------------------------------------------ |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
458 |
const Type* CastP2XNode::Value(PhaseGVN* phase) const { |
23528 | 459 |
const Type* t = phase->type(in(1)); |
460 |
if (t == Type::TOP) return Type::TOP; |
|
461 |
if (t->base() == Type::RawPtr && t->singleton()) { |
|
462 |
uintptr_t bits = (uintptr_t) t->is_rawptr()->get_con(); |
|
463 |
return TypeX::make(bits); |
|
464 |
} |
|
465 |
return CastP2XNode::bottom_type(); |
|
466 |
} |
|
467 |
||
468 |
Node *CastP2XNode::Ideal(PhaseGVN *phase, bool can_reshape) { |
|
469 |
return (in(0) && remove_dead_region(phase, can_reshape)) ? this : NULL; |
|
470 |
} |
|
471 |
||
472 |
//------------------------------Identity--------------------------------------- |
|
35551
36ef3841fb34
8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents:
35549
diff
changeset
|
473 |
Node* CastP2XNode::Identity(PhaseGVN* phase) { |
23528 | 474 |
if (in(1)->Opcode() == Op_CastX2P) return in(1)->in(1); |
475 |
return this; |
|
476 |
} |