8006529: Methods always get callee - it should be conditional Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145. Reviewed-by: jlaskey, lagergren

     1

10

     2

fromCharCode.length = 1

     3

ABCD

     4

concat.length = 1

     5

javascript is great!

     6

slice.length = 2

     7

 world

     8

orl

     9

substring.length = 2

    10

java

    11

script

    12

script

    13

toLowerCase.length = 0

    14

java

    15

java

    16

toUpperCase.length = 0

    17

JAVASCRIPT

    18

JAVASCRIPT

    19

localeCompare.length = 1

    20

-1

    21

0

    22

trim.length = 0

    23

java

    24

java

    25

2

    26

3

    27

true

    28

true

    29

false

    30

false

    31

h

    32

l

    33

undefined

    34

true

    35

false

    36

true

    37

false