8006529: Methods always get callee - it should be conditional Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145. Reviewed-by: jlaskey, lagergren

     1

3

     2

isArray.length = 1

     3

false

     4

true

     5

join.length = 1

     6

javascript<->is<->great

     7

every.length = 1

     8

4,56,5 every even? = false

     9

4,56,688 every even? = true

    10

some.length = 1

    11

4,56,5 some even? = true

    12

3,5,17 some even? = false

    13

forEach.length = 1

    14

java,javascript,jython,jruby[0] is java

    15

java,javascript,jython,jruby[1] is javascript

    16

java,javascript,jython,jruby[2] is jython

    17

java,javascript,jython,jruby[3] is jruby

    18

JAVA,JAVASCRIPT,JYTHON,JRUBY

    19

shifted is java, remaining is javascript,jython,jruby, length is 3

    20

java,javascript

    21

115

    22

120

    23

c++ java javascript objective c

    24

hello world from javascript

    25

indexOf.length = 1

    26

indexOf('java') = 0

    27

indexOf('javascript') = 1

    28

indexOf('javascript', 3) = -1

    29

indexOf('c++') = -1

    30

[].indexOf('any') = -1

    31

lastIndexOf.length = 1

    32

lastIndexOf('java') = 4

    33

lastIndexOf('jython') = 5

    34

lastIndexOf('c') = 6

    35

lastIndexOf('c++') = -1

    36

[].lastIndexOf('any') = -1

    37

concat.length = 1

    38

foo,bar,x,y,34,sss,3,4,2

    39

Array.length = 1

    40

NaN,NaN,NaN

    41

3

    42

1

    43

number

    44

1

    45

    46

hello,world

    47

,,,,

    48

undefined

    49

[object java.lang.Object]

    50

    51

33