nashorn/test/script/basic/NASHORN-768.js
author attila
Thu, 31 Jan 2013 18:34:42 +0100
changeset 16206 83069fa0935b
parent 16151 97c1e756ae1e
child 24778 2ff5d7041566
permissions -rw-r--r--
8006529: Methods always get callee - it should be conditional Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145. Reviewed-by: jlaskey, lagergren
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
16147
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     1
/*
16151
97c1e756ae1e 8005663: Update copyright year to 2013
jlaskey
parents: 16147
diff changeset
     2
 * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
16147
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     4
 * 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     7
 * published by the Free Software Foundation.
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     8
 * 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    13
 * accompanied this code).
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    14
 * 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    18
 * 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    21
 * questions.
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    22
 */
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    23
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    24
/**
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    25
 * NASHORN-768 :  Implement cross context property/function access and browser JSObject access by JSObject dynalink linker
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    26
 *
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    27
 * @test
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    28
 * @option -scripting
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    29
 * @run
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    30
 */
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    31
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    32
// create another nashorn engine
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    33
var m = new javax.script.ScriptEngineManager();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    34
var engine = m.getEngineByName("nashorn");
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    35
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    36
// our global var 'id'
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    37
var id = "global-id";
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    38
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    39
engine.eval(<<CODE
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    40
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    41
// code evaluated in engine
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    42
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    43
// engine code's id
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    44
var id = "engine-global-id";
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    45
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    46
// global object
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    47
var obj = {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    48
    foo: 42,
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    49
    bar: function(x) { 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    50
        if (id != "engine-global-id") {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    51
            throw "id != 'engine-global-id'";
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    52
        }
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    53
        // check this.foo is accessible
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    54
        if (this.foo != 42) {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    55
            throw "this.foo != 42";
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    56
        }
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    57
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    58
        return x;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    59
    }
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    60
};
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    61
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    62
// global function
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    63
function func(callback) {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    64
    var res = callback(id);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    65
    if (res != id) {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    66
        fail("result of callback is wrong");
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    67
    }
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    68
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    69
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    70
CODE);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    71
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    72
var obj = engine.get("obj");
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    73
if (obj.bar("hello") != "hello") {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    74
    fail("obj.bar('hello') return value is wrong");
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    75
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    76
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    77
if (obj.foo != 42) {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    78
    fail("obj.foo != 42");
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    79
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    80
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    81
var func = engine.get("func");
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    82
var inside_f = false;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    83
function f(arg) {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    84
    inside_f = true;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    85
    if (id != "global-id") {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    86
        fail("id != 'global-id'");
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    87
    }
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    88
    return arg;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    89
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    90
func(f);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    91
if (! inside_f) {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    92
    fail("function 'f' was not called");
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    93
}