nashorn/test/script/basic/NASHORN-703.js
author attila
Thu, 31 Jan 2013 18:34:42 +0100
changeset 16206 83069fa0935b
parent 16151 97c1e756ae1e
child 24778 2ff5d7041566
permissions -rw-r--r--
8006529: Methods always get callee - it should be conditional Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145. Reviewed-by: jlaskey, lagergren
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
16147
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     1
/*
16151
97c1e756ae1e 8005663: Update copyright year to 2013
jlaskey
parents: 16147
diff changeset
     2
 * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
16147
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     4
 * 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     7
 * published by the Free Software Foundation.
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     8
 * 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    13
 * accompanied this code).
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    14
 * 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    18
 * 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    21
 * questions.
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    22
 */
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    23
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    24
/**
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    25
 * NASHORN-703
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    26
 *
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    27
 * Self modifying assignments and ++/-- operators had two issues
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    28
 * 1) the base was loaded twice
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    29
 * 2) if the base was anything but an IdentNode, AccessNode or IndexNode and in the scope, it would
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    30
 *    only be evaluated once, leading to bytecode stack underflow
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    31
 *
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    32
 * This file is split into two tests as the presence of eval affects the whole script
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    33
 *
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    34
 * @test
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    35
 * @run 
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    36
 */
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    37
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    38
function template() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    39
    this.count = 17;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    40
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    41
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    42
//self assignment to accessnode in scope
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    43
function test1() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    44
    a.count++;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    45
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    46
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    47
function test2() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    48
    a2[0].count++;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    49
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    50
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    51
function test3() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    52
    a3[0]++;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    53
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    54
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    55
function test4() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    56
    a4 *= 17;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    57
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    58
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    59
function test5() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    60
    a5.count *= 17;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    61
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    62
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    63
function test6() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    64
    a6[0].count *= 17;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    65
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    66
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    67
function test7() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    68
    a7[0] *= 17;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    69
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    70
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    71
function tpl() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    72
    return new template();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    73
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    74
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    75
function count() {
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    76
    tpl().count++;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    77
}
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    78
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    79
var a = new template();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    80
test1();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    81
print(a.count);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    82
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    83
var a2 = [new template()];
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    84
test2();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    85
print(a2[0].count);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    86
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    87
var a3 = [1];
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    88
test3();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    89
print(a3);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    90
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    91
var a4 = 4711;
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    92
test4();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    93
print(a4);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    94
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    95
var a5 = new template();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    96
test5();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    97
print(a5.count);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    98
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
    99
var a6 = [new template()];
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   100
test6();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   101
print(a6[0].count);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   102
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   103
var a7 = [1];
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   104
test7();
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   105
print(a7[0]);
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   106
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   107
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   108
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   109
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   110
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   111
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   112
e63b63819133 8005403: Open-source Nashorn
jlaskey
parents:
diff changeset
   113