nashorn/test/script/basic/JDK-8006852b.js
author attila
Thu, 31 Jan 2013 18:34:42 +0100
changeset 16206 83069fa0935b
parent 16193 34f41481a840
child 24778 2ff5d7041566
permissions -rw-r--r--
8006529: Methods always get callee - it should be conditional Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145. Reviewed-by: jlaskey, lagergren
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
16193
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     1
/*
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     2
 * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     4
 * 
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     7
 * published by the Free Software Foundation.
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     8
 * 
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    13
 * accompanied this code).
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    14
 * 
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    18
 * 
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    21
 * questions.
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    22
 */
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    23
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    24
/**
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    25
 * JDK-8006852 : Move tests from JIRA for prepopulated map failures
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    26
 *
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    27
 * @test
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    28
 * @run
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    29
 */
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    30
 
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    31
function MyCons(arg) {
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    32
    if (arg == 2) {
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    33
       this.foo = 3;
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    34
    }
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    35
    this.bar = 44;
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    36
    // print(Debug.map(this));
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    37
}
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    38
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    39
MyCons.prototype.foo = "proto--foo";
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    40
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    41
var myObj = new MyCons();
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    42
if (myObj.hasOwnProperty("foo")) {
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    43
    print("FAILED: myObj should not have 'foo'");
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    44
}
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    45
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    46
if (myObj.foo !== 'proto--foo') {
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    47
    print("FAILED: myObj.foo is wrong");
34f41481a840 8006852: Move tests from JIRA for prepopulated map failures
jlaskey
parents:
diff changeset
    48
}