hotspot/src/share/vm/memory/blockOffsetTable.inline.hpp
author ysr
Mon, 16 Aug 2010 15:58:42 -0700
changeset 6258 68f252c6e825
parent 5547 f4b087cbb361
child 7397 5b173b4ca846
permissions -rw-r--r--
6948538: CMS: BOT walkers can fall into object allocation and initialization cracks Summary: GC workers now recognize an intermediate transient state of blocks which are allocated but have not yet completed initialization. blk_start() calls do not attempt to determine the size of a block in the transient state, rather waiting for the block to become initialized so that it is safe to query its size. Audited and ensured the order of initialization of object fields (klass, free bit and size) to respect block state transition protocol. Also included some new assertion checking code enabled in debug mode. Reviewed-by: chrisphi, johnc, poonam
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     1
/*
6258
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
     2
 * Copyright (c) 2000, 2010, Oracle and/or its affiliates. All rights reserved.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     4
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
489c9b5090e2 Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
489c9b5090e2 Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     8
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
489c9b5090e2 Initial load
duke
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
489c9b5090e2 Initial load
duke
parents:
diff changeset
    13
 * accompanied this code).
489c9b5090e2 Initial load
duke
parents:
diff changeset
    14
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
489c9b5090e2 Initial load
duke
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    18
 *
5547
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1
diff changeset
    21
 * questions.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    22
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    23
 */
489c9b5090e2 Initial load
duke
parents:
diff changeset
    24
489c9b5090e2 Initial load
duke
parents:
diff changeset
    25
//////////////////////////////////////////////////////////////////////////
489c9b5090e2 Initial load
duke
parents:
diff changeset
    26
// BlockOffsetTable inlines
489c9b5090e2 Initial load
duke
parents:
diff changeset
    27
//////////////////////////////////////////////////////////////////////////
489c9b5090e2 Initial load
duke
parents:
diff changeset
    28
inline HeapWord* BlockOffsetTable::block_start(const void* addr) const {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    29
  if (addr >= _bottom && addr < _end) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    30
    return block_start_unsafe(addr);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    31
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    32
    return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    33
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    34
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    35
489c9b5090e2 Initial load
duke
parents:
diff changeset
    36
//////////////////////////////////////////////////////////////////////////
489c9b5090e2 Initial load
duke
parents:
diff changeset
    37
// BlockOffsetSharedArray inlines
489c9b5090e2 Initial load
duke
parents:
diff changeset
    38
//////////////////////////////////////////////////////////////////////////
489c9b5090e2 Initial load
duke
parents:
diff changeset
    39
inline size_t BlockOffsetSharedArray::index_for(const void* p) const {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    40
  char* pc = (char*)p;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    41
  assert(pc >= (char*)_reserved.start() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
    42
         pc <  (char*)_reserved.end(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
    43
         "p not in range.");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    44
  size_t delta = pointer_delta(pc, _reserved.start(), sizeof(char));
489c9b5090e2 Initial load
duke
parents:
diff changeset
    45
  size_t result = delta >> LogN;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    46
  assert(result < _vs.committed_size(), "bad index from address");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    47
  return result;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    48
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    49
489c9b5090e2 Initial load
duke
parents:
diff changeset
    50
inline HeapWord* BlockOffsetSharedArray::address_for_index(size_t index) const {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    51
  assert(index < _vs.committed_size(), "bad index");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    52
  HeapWord* result = _reserved.start() + (index << LogN_words);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    53
  assert(result >= _reserved.start() && result < _reserved.end(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
    54
         "bad address from index");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    55
  return result;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    56
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    57
6258
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    58
inline void BlockOffsetSharedArray::check_reducing_assertion(bool reducing) {
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    59
    assert(reducing || !SafepointSynchronize::is_at_safepoint() || init_to_zero() ||
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    60
           Thread::current()->is_VM_thread() ||
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    61
           Thread::current()->is_ConcurrentGC_thread() ||
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    62
           ((!Thread::current()->is_ConcurrentGC_thread()) &&
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    63
            ParGCRareEvent_lock->owned_by_self()), "Crack");
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    64
}
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    65
489c9b5090e2 Initial load
duke
parents:
diff changeset
    66
//////////////////////////////////////////////////////////////////////////
489c9b5090e2 Initial load
duke
parents:
diff changeset
    67
// BlockOffsetArrayNonContigSpace inlines
489c9b5090e2 Initial load
duke
parents:
diff changeset
    68
//////////////////////////////////////////////////////////////////////////
6258
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    69
inline void BlockOffsetArrayNonContigSpace::freed(HeapWord* blk,
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    70
                                                  size_t size) {
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    71
  freed(blk, blk + size);
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    72
}
68f252c6e825 6948538: CMS: BOT walkers can fall into object allocation and initialization cracks
ysr
parents: 5547
diff changeset
    73
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    74
inline void BlockOffsetArrayNonContigSpace::freed(HeapWord* blk_start,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    75
                                                  HeapWord* blk_end) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    76
  // Verify that the BOT shows [blk_start, blk_end) to be one block.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    77
  verify_single_block(blk_start, blk_end);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    78
  // adjust _unallocated_block upward or downward
489c9b5090e2 Initial load
duke
parents:
diff changeset
    79
  // as appropriate
489c9b5090e2 Initial load
duke
parents:
diff changeset
    80
  if (BlockOffsetArrayUseUnallocatedBlock) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    81
    assert(_unallocated_block <= _end,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    82
           "Inconsistent value for _unallocated_block");
489c9b5090e2 Initial load
duke
parents:
diff changeset
    83
    if (blk_end >= _unallocated_block && blk_start <= _unallocated_block) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    84
      // CMS-specific note: a block abutting _unallocated_block to
489c9b5090e2 Initial load
duke
parents:
diff changeset
    85
      // its left is being freed, a new block is being added or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    86
      // we are resetting following a compaction
489c9b5090e2 Initial load
duke
parents:
diff changeset
    87
      _unallocated_block = blk_start;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    88
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    89
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    90
}