author | tschatzl |
Wed, 25 Nov 2015 14:43:29 +0100 | |
changeset 34300 | 6075c1e0e913 |
parent 33608 | 7afc768e4d62 |
child 35061 | be6025ebffea |
permissions | -rw-r--r-- |
25350
6423a57e5451
8043607: Add a GC id as a log decoration similar to PrintGCTimeStamps
brutisso
parents:
24331
diff
changeset
|
1 |
/* |
29464
02c245ad3ec9
8073545: Use shorter and more descriptive names for GC worker threads
david
parents:
27885
diff
changeset
|
2 |
* Copyright (c) 2001, 2015, Oracle and/or its affiliates. All rights reserved. |
1374 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4022
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4022
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4022
diff
changeset
|
21 |
* questions. |
1374 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
30764 | 26 |
#include "gc/g1/concurrentMarkThread.inline.hpp" |
27 |
#include "gc/g1/g1CollectedHeap.inline.hpp" |
|
28 |
#include "gc/g1/g1CollectorPolicy.hpp" |
|
29 |
#include "gc/g1/g1Log.hpp" |
|
30 |
#include "gc/g1/g1MMUTracker.hpp" |
|
30770
5ba2d9f2084d
8080585: concurrentGCThread.hpp should not include suspendibleThreadSet.hpp
pliden
parents:
30764
diff
changeset
|
31 |
#include "gc/g1/suspendibleThreadSet.hpp" |
30764 | 32 |
#include "gc/g1/vm_operations_g1.hpp" |
33107
77bf0d2069a3
8134953: Make the GC ID available in a central place
brutisso
parents:
33106
diff
changeset
|
33 |
#include "gc/shared/gcId.hpp" |
30764 | 34 |
#include "gc/shared/gcTrace.hpp" |
7397 | 35 |
#include "memory/resourceArea.hpp" |
36 |
#include "runtime/vmThread.hpp" |
|
1374 | 37 |
|
38 |
// ======= Concurrent Mark Thread ======== |
|
39 |
||
40 |
// The CM thread is created when the G1 garbage collector is used |
|
41 |
||
42 |
SurrogateLockerThread* |
|
43 |
ConcurrentMarkThread::_slt = NULL; |
|
44 |
||
45 |
ConcurrentMarkThread::ConcurrentMarkThread(ConcurrentMark* cm) : |
|
46 |
ConcurrentGCThread(), |
|
47 |
_cm(cm), |
|
31597
f63dde8cc8f7
8129626: G1: set_in_progress() and clear_started() needs a barrier on non-TSO platforms
brutisso
parents:
31397
diff
changeset
|
48 |
_state(Idle), |
1374 | 49 |
_vtime_accum(0.0), |
11583
83a7383de44c
6484965: G1: piggy-back liveness accounting phase on marking
johnc
parents:
11175
diff
changeset
|
50 |
_vtime_mark_accum(0.0) { |
24331
c0bc7e5653fb
6885993: Named Thread: introduce print() and print_on(outputStream* st) methods
zgu
parents:
24094
diff
changeset
|
51 |
|
29464
02c245ad3ec9
8073545: Use shorter and more descriptive names for GC worker threads
david
parents:
27885
diff
changeset
|
52 |
set_name("G1 Main Marker"); |
1374 | 53 |
create_and_start(); |
54 |
} |
|
55 |
||
56 |
class CMCheckpointRootsFinalClosure: public VoidClosure { |
|
57 |
||
58 |
ConcurrentMark* _cm; |
|
59 |
public: |
|
60 |
||
61 |
CMCheckpointRootsFinalClosure(ConcurrentMark* cm) : |
|
62 |
_cm(cm) {} |
|
63 |
||
64 |
void do_void(){ |
|
65 |
_cm->checkpointRootsFinal(false); // !clear_all_soft_refs |
|
66 |
} |
|
67 |
}; |
|
68 |
||
69 |
class CMCleanUp: public VoidClosure { |
|
70 |
ConcurrentMark* _cm; |
|
71 |
public: |
|
72 |
||
73 |
CMCleanUp(ConcurrentMark* cm) : |
|
74 |
_cm(cm) {} |
|
75 |
||
76 |
void do_void(){ |
|
77 |
_cm->cleanup(); |
|
78 |
} |
|
79 |
}; |
|
80 |
||
31397
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
81 |
// We want to avoid that the logging from the concurrent thread is mixed |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
82 |
// with the logging from a STW GC. So, if necessary join the STS to ensure |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
83 |
// that the logging is done either before or after the STW logging. |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
84 |
void ConcurrentMarkThread::cm_log(bool doit, bool join_sts, const char* fmt, ...) { |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
85 |
if (doit) { |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
86 |
SuspendibleThreadSetJoiner sts_joiner(join_sts); |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
87 |
va_list args; |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
88 |
va_start(args, fmt); |
33107
77bf0d2069a3
8134953: Make the GC ID available in a central place
brutisso
parents:
33106
diff
changeset
|
89 |
gclog_or_tty->gclog_stamp(); |
31397
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
90 |
gclog_or_tty->vprint_cr(fmt, args); |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
91 |
va_end(args); |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
92 |
} |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
93 |
} |
1374 | 94 |
|
33608
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
95 |
// Marking pauses can be scheduled flexibly, so we might delay marking to meet MMU. |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
96 |
void ConcurrentMarkThread::delay_to_keep_mmu(G1CollectorPolicy* g1_policy, bool remark) { |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
97 |
if (g1_policy->adaptive_young_list_length()) { |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
98 |
double now = os::elapsedTime(); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
99 |
double prediction_ms = remark ? g1_policy->predict_remark_time_ms() |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
100 |
: g1_policy->predict_cleanup_time_ms(); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
101 |
G1MMUTracker *mmu_tracker = g1_policy->mmu_tracker(); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
102 |
jlong sleep_time_ms = mmu_tracker->when_ms(now, prediction_ms); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
103 |
os::sleep(this, sleep_time_ms, false); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
104 |
} |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
105 |
} |
1374 | 106 |
void ConcurrentMarkThread::run() { |
107 |
initialize_in_thread(); |
|
33608
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
108 |
wait_for_universe_init(); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
109 |
|
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
110 |
run_service(); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
111 |
|
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
112 |
terminate(); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
113 |
} |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
114 |
|
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
115 |
void ConcurrentMarkThread::run_service() { |
1374 | 116 |
_vtime_start = os::elapsedVTime(); |
117 |
||
7923 | 118 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
119 |
G1CollectorPolicy* g1_policy = g1h->g1_policy(); |
|
1374 | 120 |
|
121 |
while (!_should_terminate) { |
|
122 |
// wait until started is set. |
|
123 |
sleepBeforeNextCycle(); |
|
24093
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
124 |
if (_should_terminate) { |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
125 |
break; |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
126 |
} |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
127 |
|
33152
6ad7fe735042
8139293: TestGCEventMixedWithG1ConcurrentMark.java fails after JDK-8134953
brutisso
parents:
33107
diff
changeset
|
128 |
assert(GCId::current() != GCId::undefined(), "GC id should have been set up by the initial mark GC."); |
1374 | 129 |
{ |
130 |
ResourceMark rm; |
|
131 |
HandleMark hm; |
|
132 |
double cycle_start = os::elapsedVTime(); |
|
133 |
||
11584
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
134 |
// We have to ensure that we finish scanning the root regions |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
135 |
// before the next GC takes place. To ensure this we have to |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
136 |
// make sure that we do not join the STS until the root regions |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
137 |
// have been scanned. If we did then it's possible that a |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
138 |
// subsequent GC could block us from joining the STS and proceed |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
139 |
// without the root regions have been scanned which would be a |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
140 |
// correctness issue. |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
141 |
|
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
142 |
if (!cm()->has_aborted()) { |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
143 |
_cm->scanRootRegions(); |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
144 |
} |
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
145 |
|
e1df4d08a1f4
7127706: G1: re-enable survivors during the initial-mark pause
tonyp
parents:
11583
diff
changeset
|
146 |
double mark_start_sec = os::elapsedTime(); |
31397
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
147 |
cm_log(G1Log::fine(), true, "[GC concurrent-mark-start]"); |
1374 | 148 |
|
149 |
int iter = 0; |
|
150 |
do { |
|
151 |
iter++; |
|
152 |
if (!cm()->has_aborted()) { |
|
153 |
_cm->markFromRoots(); |
|
154 |
} |
|
155 |
||
156 |
double mark_end_time = os::elapsedVTime(); |
|
157 |
double mark_end_sec = os::elapsedTime(); |
|
158 |
_vtime_mark_accum += (mark_end_time - cycle_start); |
|
159 |
if (!cm()->has_aborted()) { |
|
33608
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
160 |
delay_to_keep_mmu(g1_policy, true /* remark */); |
1374 | 161 |
|
31397
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
162 |
cm_log(G1Log::fine(), true, "[GC concurrent-mark-end, %1.7lf secs]", mark_end_sec - mark_start_sec); |
1374 | 163 |
|
164 |
CMCheckpointRootsFinalClosure final_cl(_cm); |
|
18025 | 165 |
VM_CGC_Operation op(&final_cl, "GC remark", true /* needs_pll */); |
1374 | 166 |
VMThread::execute(&op); |
167 |
} |
|
168 |
if (cm()->restart_for_overflow()) { |
|
31397
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
169 |
cm_log(G1TraceMarkStackOverflow, true, "Restarting conc marking because of MS overflow in remark (restart #%d).", iter); |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
170 |
cm_log(G1Log::fine(), true, "[GC concurrent-mark-restart-for-overflow]"); |
1374 | 171 |
} |
172 |
} while (cm()->restart_for_overflow()); |
|
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10745
diff
changeset
|
173 |
|
1374 | 174 |
double end_time = os::elapsedVTime(); |
175 |
// Update the total virtual time before doing this, since it will try |
|
176 |
// to measure it to get the vtime for this marking. We purposely |
|
177 |
// neglect the presumably-short "completeCleanup" phase here. |
|
178 |
_vtime_accum = (end_time - _vtime_start); |
|
11583
83a7383de44c
6484965: G1: piggy-back liveness accounting phase on marking
johnc
parents:
11175
diff
changeset
|
179 |
|
1374 | 180 |
if (!cm()->has_aborted()) { |
33608
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
181 |
delay_to_keep_mmu(g1_policy, false /* cleanup */); |
1374 | 182 |
|
183 |
CMCleanUp cl_cl(_cm); |
|
18025 | 184 |
VM_CGC_Operation op(&cl_cl, "GC cleanup", false /* needs_pll */); |
1374 | 185 |
VMThread::execute(&op); |
186 |
} else { |
|
11175
7fde26aecbe5
7114303: G1: assert(_g1->mark_in_progress()) failed: shouldn't be here otherwise
johnc
parents:
10769
diff
changeset
|
187 |
// We don't want to update the marking status if a GC pause |
7fde26aecbe5
7114303: G1: assert(_g1->mark_in_progress()) failed: shouldn't be here otherwise
johnc
parents:
10769
diff
changeset
|
188 |
// is already underway. |
30613
a7815bb05ae2
8079579: Add SuspendibleThreadSetLeaver and make SuspendibleThreadSet::joint()/leave() private
pliden
parents:
29464
diff
changeset
|
189 |
SuspendibleThreadSetJoiner sts_join; |
31331
a7c714b6cfb3
7097567: G1: abstract and encapsulate collector phases and transitions between them
drwhite
parents:
30770
diff
changeset
|
190 |
g1h->collector_state()->set_mark_in_progress(false); |
1374 | 191 |
} |
192 |
||
7923 | 193 |
// Check if cleanup set the free_regions_coming flag. If it |
194 |
// hasn't, we can just skip the next step. |
|
195 |
if (g1h->free_regions_coming()) { |
|
196 |
// The following will finish freeing up any regions that we |
|
197 |
// found to be empty during cleanup. We'll do this part |
|
198 |
// without joining the suspendible set. If an evacuation pause |
|
8680 | 199 |
// takes place, then we would carry on freeing regions in |
7923 | 200 |
// case they are needed by the pause. If a Full GC takes |
8680 | 201 |
// place, it would wait for us to process the regions |
7923 | 202 |
// reclaimed by cleanup. |
203 |
||
1374 | 204 |
double cleanup_start_sec = os::elapsedTime(); |
33106 | 205 |
cm_log(G1Log::fine(), false, "[GC concurrent-cleanup-start]"); |
1374 | 206 |
|
10745
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
207 |
// Now do the concurrent cleanup operation. |
1374 | 208 |
_cm->completeCleanup(); |
10745
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
209 |
|
8100 | 210 |
// Notify anyone who's waiting that there are no more free |
10745
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
211 |
// regions coming. We have to do this before we join the STS |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
212 |
// (in fact, we should not attempt to join the STS in the |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
213 |
// interval between finishing the cleanup pause and clearing |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
214 |
// the free_regions_coming flag) otherwise we might deadlock: |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
215 |
// a GC worker could be blocked waiting for the notification |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
216 |
// whereas this thread will be blocked for the pause to finish |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
217 |
// while it's trying to join the STS, which is conditional on |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
218 |
// the GC workers finishing. |
8100 | 219 |
g1h->reset_free_regions_coming(); |
220 |
||
7923 | 221 |
double cleanup_end_sec = os::elapsedTime(); |
31397
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
222 |
cm_log(G1Log::fine(), true, "[GC concurrent-cleanup-end, %1.7lf secs]", cleanup_end_sec - cleanup_start_sec); |
1374 | 223 |
} |
7923 | 224 |
guarantee(cm()->cleanup_list_is_empty(), |
225 |
"at this point there should be no regions on the cleanup list"); |
|
1374 | 226 |
|
10745
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
227 |
// There is a tricky race before recording that the concurrent |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
228 |
// cleanup has completed and a potential Full GC starting around |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
229 |
// the same time. We want to make sure that the Full GC calls |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
230 |
// abort() on concurrent mark after |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
231 |
// record_concurrent_mark_cleanup_completed(), since abort() is |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
232 |
// the method that will reset the concurrent mark state. If we |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
233 |
// end up calling record_concurrent_mark_cleanup_completed() |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
234 |
// after abort() then we might incorrectly undo some of the work |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
235 |
// abort() did. Checking the has_aborted() flag after joining |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
236 |
// the STS allows the correct ordering of the two methods. There |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
237 |
// are two scenarios: |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
238 |
// |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
239 |
// a) If we reach here before the Full GC, the fact that we have |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
240 |
// joined the STS means that the Full GC cannot start until we |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
241 |
// leave the STS, so record_concurrent_mark_cleanup_completed() |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
242 |
// will complete before abort() is called. |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
243 |
// |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
244 |
// b) If we reach here during the Full GC, we'll be held up from |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
245 |
// joining the STS until the Full GC is done, which means that |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
246 |
// abort() will have completed and has_aborted() will return |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
247 |
// true to prevent us from calling |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
248 |
// record_concurrent_mark_cleanup_completed() (and, in fact, it's |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
249 |
// not needed any more as the concurrent mark state has been |
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
250 |
// already reset). |
24094 | 251 |
{ |
30613
a7815bb05ae2
8079579: Add SuspendibleThreadSetLeaver and make SuspendibleThreadSet::joint()/leave() private
pliden
parents:
29464
diff
changeset
|
252 |
SuspendibleThreadSetJoiner sts_join; |
24094 | 253 |
if (!cm()->has_aborted()) { |
254 |
g1_policy->record_concurrent_mark_cleanup_completed(); |
|
31397
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
255 |
} else { |
c9cc3289b80c
8129549: G1: Make sure the concurrent thread does not mix its logging with the STW pauses
brutisso
parents:
31331
diff
changeset
|
256 |
cm_log(G1Log::fine(), false, "[GC concurrent-mark-abort]"); |
1374 | 257 |
} |
258 |
} |
|
259 |
||
10745
6b33ec421509
7098085: G1: partially-young GCs not initiated under certain circumstances
tonyp
parents:
10280
diff
changeset
|
260 |
// We now want to allow clearing of the marking bitmap to be |
1374 | 261 |
// suspended by a collection pause. |
25728
7f8a76e3baa8
8048085: Aborting marking just before remark results in useless additional clearing of the next mark bitmap
tschatzl
parents:
25350
diff
changeset
|
262 |
// We may have aborted just before the remark. Do not bother clearing the |
7f8a76e3baa8
8048085: Aborting marking just before remark results in useless additional clearing of the next mark bitmap
tschatzl
parents:
25350
diff
changeset
|
263 |
// bitmap then, as it has been done during mark abort. |
7f8a76e3baa8
8048085: Aborting marking just before remark results in useless additional clearing of the next mark bitmap
tschatzl
parents:
25350
diff
changeset
|
264 |
if (!cm()->has_aborted()) { |
24094 | 265 |
_cm->clearNextBitmap(); |
25728
7f8a76e3baa8
8048085: Aborting marking just before remark results in useless additional clearing of the next mark bitmap
tschatzl
parents:
25350
diff
changeset
|
266 |
} else { |
7f8a76e3baa8
8048085: Aborting marking just before remark results in useless additional clearing of the next mark bitmap
tschatzl
parents:
25350
diff
changeset
|
267 |
assert(!G1VerifyBitmaps || _cm->nextMarkBitmapIsClear(), "Next mark bitmap must be clear"); |
24094 | 268 |
} |
1374 | 269 |
} |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
270 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
271 |
// Update the number of full collections that have been |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
272 |
// completed. This will also notify the FullGCCount_lock in case a |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
273 |
// Java thread is waiting for a full GC to happen (e.g., it |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
274 |
// called System.gc() with +ExplicitGCInvokesConcurrent). |
24094 | 275 |
{ |
30613
a7815bb05ae2
8079579: Add SuspendibleThreadSetLeaver and make SuspendibleThreadSet::joint()/leave() private
pliden
parents:
29464
diff
changeset
|
276 |
SuspendibleThreadSetJoiner sts_join; |
24094 | 277 |
g1h->increment_old_marking_cycles_completed(true /* concurrent */); |
278 |
g1h->register_concurrent_cycle_end(); |
|
279 |
} |
|
1374 | 280 |
} |
281 |
} |
|
282 |
||
283 |
void ConcurrentMarkThread::stop() { |
|
24093
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
284 |
{ |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
285 |
MutexLockerEx ml(Terminator_lock); |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
286 |
_should_terminate = true; |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
287 |
} |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
288 |
|
33608
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
289 |
stop_service(); |
24093
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
290 |
|
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
291 |
{ |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
292 |
MutexLockerEx ml(Terminator_lock); |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
293 |
while (!_has_terminated) { |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
294 |
Terminator_lock->wait(); |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
295 |
} |
1374 | 296 |
} |
297 |
} |
|
298 |
||
33608
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
299 |
void ConcurrentMarkThread::stop_service() { |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
300 |
MutexLockerEx ml(CGC_lock, Mutex::_no_safepoint_check_flag); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
301 |
CGC_lock->notify_all(); |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
302 |
} |
7afc768e4d62
8138920: Refactor the sampling thread from ConcurrentG1RefineThread
drwhite
parents:
33152
diff
changeset
|
303 |
|
1374 | 304 |
void ConcurrentMarkThread::sleepBeforeNextCycle() { |
305 |
// We join here because we don't want to do the "shouldConcurrentMark()" |
|
306 |
// below while the world is otherwise stopped. |
|
6766
839211600ad0
6983311: G1: LoopTest hangs when run with -XX:+ExplicitInvokesConcurrent
johnc
parents:
6058
diff
changeset
|
307 |
assert(!in_progress(), "should have been cleared"); |
839211600ad0
6983311: G1: LoopTest hangs when run with -XX:+ExplicitInvokesConcurrent
johnc
parents:
6058
diff
changeset
|
308 |
|
1374 | 309 |
MutexLockerEx x(CGC_lock, Mutex::_no_safepoint_check_flag); |
24093
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
310 |
while (!started() && !_should_terminate) { |
1374 | 311 |
CGC_lock->wait(Mutex::_no_safepoint_check_flag); |
312 |
} |
|
24093
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
313 |
|
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
314 |
if (started()) { |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
315 |
set_in_progress(); |
095cc0a63ed9
8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV
pliden
parents:
18025
diff
changeset
|
316 |
} |
1374 | 317 |
} |
318 |
||
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10745
diff
changeset
|
319 |
// Note: As is the case with CMS - this method, although exported |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10745
diff
changeset
|
320 |
// by the ConcurrentMarkThread, which is a non-JavaThread, can only |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10745
diff
changeset
|
321 |
// be called by a JavaThread. Currently this is done at vm creation |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10745
diff
changeset
|
322 |
// time (post-vm-init) by the main/Primordial (Java)Thread. |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10745
diff
changeset
|
323 |
// XXX Consider changing this in the future to allow the CM thread |
1374 | 324 |
// itself to create this thread? |
325 |
void ConcurrentMarkThread::makeSurrogateLockerThread(TRAPS) { |
|
10769
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10745
diff
changeset
|
326 |
assert(UseG1GC, "SLT thread needed only for concurrent GC"); |
983d377770fd
7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents:
10745
diff
changeset
|
327 |
assert(THREAD->is_Java_thread(), "must be a Java thread"); |
1374 | 328 |
assert(_slt == NULL, "SLT already created"); |
329 |
_slt = SurrogateLockerThread::make(THREAD); |
|
330 |
} |