author | roland |
Tue, 20 Dec 2011 16:56:50 +0100 | |
changeset 11431 | 5ca3a19e559a |
parent 11198 | 34c860ff41e3 |
child 11445 | 3c768dca60f5 |
permissions | -rw-r--r-- |
1 | 1 |
/* |
8319 | 2 |
* Copyright (c) 2005, 2011, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5534
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5534
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5534
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
26 |
#include "ci/bcEscapeAnalyzer.hpp" |
|
27 |
#include "libadt/vectset.hpp" |
|
28 |
#include "memory/allocation.hpp" |
|
29 |
#include "opto/c2compiler.hpp" |
|
30 |
#include "opto/callnode.hpp" |
|
31 |
#include "opto/cfgnode.hpp" |
|
32 |
#include "opto/compile.hpp" |
|
33 |
#include "opto/escape.hpp" |
|
34 |
#include "opto/phaseX.hpp" |
|
35 |
#include "opto/rootnode.hpp" |
|
1 | 36 |
|
37 |
void PointsToNode::add_edge(uint targIdx, PointsToNode::EdgeType et) { |
|
38 |
uint v = (targIdx << EdgeShift) + ((uint) et); |
|
39 |
if (_edges == NULL) { |
|
40 |
Arena *a = Compile::current()->comp_arena(); |
|
41 |
_edges = new(a) GrowableArray<uint>(a, INITIAL_EDGE_COUNT, 0, 0); |
|
42 |
} |
|
43 |
_edges->append_if_missing(v); |
|
44 |
} |
|
45 |
||
46 |
void PointsToNode::remove_edge(uint targIdx, PointsToNode::EdgeType et) { |
|
47 |
uint v = (targIdx << EdgeShift) + ((uint) et); |
|
48 |
||
49 |
_edges->remove(v); |
|
50 |
} |
|
51 |
||
52 |
#ifndef PRODUCT |
|
250 | 53 |
static const char *node_type_names[] = { |
1 | 54 |
"UnknownType", |
55 |
"JavaObject", |
|
56 |
"LocalVar", |
|
57 |
"Field" |
|
58 |
}; |
|
59 |
||
250 | 60 |
static const char *esc_names[] = { |
1 | 61 |
"UnknownEscape", |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
62 |
"NoEscape", |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
63 |
"ArgEscape", |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
64 |
"GlobalEscape" |
1 | 65 |
}; |
66 |
||
250 | 67 |
static const char *edge_type_suffix[] = { |
1 | 68 |
"?", // UnknownEdge |
69 |
"P", // PointsToEdge |
|
70 |
"D", // DeferredEdge |
|
71 |
"F" // FieldEdge |
|
72 |
}; |
|
73 |
||
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
74 |
void PointsToNode::dump(bool print_state) const { |
1 | 75 |
NodeType nt = node_type(); |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
76 |
tty->print("%s ", node_type_names[(int) nt]); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
77 |
if (print_state) { |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
78 |
EscapeState es = escape_state(); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
79 |
tty->print("%s %s ", esc_names[(int) es], _scalar_replaceable ? "":"NSR"); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
80 |
} |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
81 |
tty->print("[["); |
1 | 82 |
for (uint i = 0; i < edge_count(); i++) { |
83 |
tty->print(" %d%s", edge_target(i), edge_type_suffix[(int) edge_type(i)]); |
|
84 |
} |
|
85 |
tty->print("]] "); |
|
86 |
if (_node == NULL) |
|
87 |
tty->print_cr("<null>"); |
|
88 |
else |
|
89 |
_node->dump(); |
|
90 |
} |
|
91 |
#endif |
|
92 |
||
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
93 |
ConnectionGraph::ConnectionGraph(Compile * C, PhaseIterGVN *igvn) : |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
94 |
_nodes(C->comp_arena(), C->unique(), C->unique(), PointsToNode()), |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
95 |
_processed(C->comp_arena()), |
8319 | 96 |
pt_ptset(C->comp_arena()), |
97 |
pt_visited(C->comp_arena()), |
|
98 |
pt_worklist(C->comp_arena(), 4, 0, 0), |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
99 |
_collecting(true), |
7122 | 100 |
_progress(false), |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
101 |
_compile(C), |
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
102 |
_igvn(igvn), |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
103 |
_node_map(C->comp_arena()) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
104 |
|
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
105 |
_phantom_object = C->top()->_idx, |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
106 |
add_node(C->top(), PointsToNode::JavaObject, PointsToNode::GlobalEscape,true); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
107 |
|
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
108 |
// Add ConP(#NULL) and ConN(#NULL) nodes. |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
109 |
Node* oop_null = igvn->zerocon(T_OBJECT); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
110 |
_oop_null = oop_null->_idx; |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
111 |
assert(_oop_null < nodes_size(), "should be created already"); |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
112 |
add_node(oop_null, PointsToNode::JavaObject, PointsToNode::NoEscape, true); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
113 |
|
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
114 |
if (UseCompressedOops) { |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
115 |
Node* noop_null = igvn->zerocon(T_NARROWOOP); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
116 |
_noop_null = noop_null->_idx; |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
117 |
assert(_noop_null < nodes_size(), "should be created already"); |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
118 |
add_node(noop_null, PointsToNode::JavaObject, PointsToNode::NoEscape, true); |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
119 |
} else { |
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
120 |
_noop_null = _oop_null; // Should be initialized |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
121 |
} |
11189 | 122 |
_pcmp_neq = NULL; // Should be initialized |
123 |
_pcmp_eq = NULL; |
|
1 | 124 |
} |
125 |
||
126 |
void ConnectionGraph::add_pointsto_edge(uint from_i, uint to_i) { |
|
127 |
PointsToNode *f = ptnode_adr(from_i); |
|
128 |
PointsToNode *t = ptnode_adr(to_i); |
|
129 |
||
130 |
assert(f->node_type() != PointsToNode::UnknownType && t->node_type() != PointsToNode::UnknownType, "node types must be set"); |
|
131 |
assert(f->node_type() == PointsToNode::LocalVar || f->node_type() == PointsToNode::Field, "invalid source of PointsTo edge"); |
|
132 |
assert(t->node_type() == PointsToNode::JavaObject, "invalid destination of PointsTo edge"); |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
133 |
if (to_i == _phantom_object) { // Quick test for most common object |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
134 |
if (f->has_unknown_ptr()) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
135 |
return; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
136 |
} else { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
137 |
f->set_has_unknown_ptr(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
138 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
139 |
} |
7122 | 140 |
add_edge(f, to_i, PointsToNode::PointsToEdge); |
1 | 141 |
} |
142 |
||
143 |
void ConnectionGraph::add_deferred_edge(uint from_i, uint to_i) { |
|
144 |
PointsToNode *f = ptnode_adr(from_i); |
|
145 |
PointsToNode *t = ptnode_adr(to_i); |
|
146 |
||
147 |
assert(f->node_type() != PointsToNode::UnknownType && t->node_type() != PointsToNode::UnknownType, "node types must be set"); |
|
148 |
assert(f->node_type() == PointsToNode::LocalVar || f->node_type() == PointsToNode::Field, "invalid source of Deferred edge"); |
|
149 |
assert(t->node_type() == PointsToNode::LocalVar || t->node_type() == PointsToNode::Field, "invalid destination of Deferred edge"); |
|
150 |
// don't add a self-referential edge, this can occur during removal of |
|
151 |
// deferred edges |
|
152 |
if (from_i != to_i) |
|
7122 | 153 |
add_edge(f, to_i, PointsToNode::DeferredEdge); |
1 | 154 |
} |
155 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
156 |
int ConnectionGraph::address_offset(Node* adr, PhaseTransform *phase) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
157 |
const Type *adr_type = phase->type(adr); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
158 |
if (adr->is_AddP() && adr_type->isa_oopptr() == NULL && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
159 |
adr->in(AddPNode::Address)->is_Proj() && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
160 |
adr->in(AddPNode::Address)->in(0)->is_Allocate()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
161 |
// We are computing a raw address for a store captured by an Initialize |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
162 |
// compute an appropriate address type. AddP cases #3 and #5 (see below). |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
163 |
int offs = (int)phase->find_intptr_t_con(adr->in(AddPNode::Offset), Type::OffsetBot); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
164 |
assert(offs != Type::OffsetBot || |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
165 |
adr->in(AddPNode::Address)->in(0)->is_AllocateArray(), |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
166 |
"offset must be a constant or it is initialization of array"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
167 |
return offs; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
168 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
169 |
const TypePtr *t_ptr = adr_type->isa_ptr(); |
1 | 170 |
assert(t_ptr != NULL, "must be a pointer type"); |
171 |
return t_ptr->offset(); |
|
172 |
} |
|
173 |
||
174 |
void ConnectionGraph::add_field_edge(uint from_i, uint to_i, int offset) { |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
175 |
// Don't add fields to NULL pointer. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
176 |
if (is_null_ptr(from_i)) |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
177 |
return; |
1 | 178 |
PointsToNode *f = ptnode_adr(from_i); |
179 |
PointsToNode *t = ptnode_adr(to_i); |
|
180 |
||
181 |
assert(f->node_type() != PointsToNode::UnknownType && t->node_type() != PointsToNode::UnknownType, "node types must be set"); |
|
182 |
assert(f->node_type() == PointsToNode::JavaObject, "invalid destination of Field edge"); |
|
183 |
assert(t->node_type() == PointsToNode::Field, "invalid destination of Field edge"); |
|
184 |
assert (t->offset() == -1 || t->offset() == offset, "conflicting field offsets"); |
|
185 |
t->set_offset(offset); |
|
186 |
||
7122 | 187 |
add_edge(f, to_i, PointsToNode::FieldEdge); |
1 | 188 |
} |
189 |
||
190 |
void ConnectionGraph::set_escape_state(uint ni, PointsToNode::EscapeState es) { |
|
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
191 |
// Don't change non-escaping state of NULL pointer. |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
192 |
if (is_null_ptr(ni)) |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
193 |
return; |
1 | 194 |
PointsToNode *npt = ptnode_adr(ni); |
195 |
PointsToNode::EscapeState old_es = npt->escape_state(); |
|
196 |
if (es > old_es) |
|
197 |
npt->set_escape_state(es); |
|
198 |
} |
|
199 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
200 |
void ConnectionGraph::add_node(Node *n, PointsToNode::NodeType nt, |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
201 |
PointsToNode::EscapeState es, bool done) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
202 |
PointsToNode* ptadr = ptnode_adr(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
203 |
ptadr->_node = n; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
204 |
ptadr->set_node_type(nt); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
205 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
206 |
// inline set_escape_state(idx, es); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
207 |
PointsToNode::EscapeState old_es = ptadr->escape_state(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
208 |
if (es > old_es) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
209 |
ptadr->set_escape_state(es); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
210 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
211 |
if (done) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
212 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
213 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
214 |
|
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
215 |
PointsToNode::EscapeState ConnectionGraph::escape_state(Node *n) { |
1 | 216 |
uint idx = n->_idx; |
217 |
PointsToNode::EscapeState es; |
|
218 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
219 |
// If we are still collecting or there were no non-escaping allocations |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
220 |
// we don't know the answer yet |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
221 |
if (_collecting) |
1 | 222 |
return PointsToNode::UnknownEscape; |
223 |
||
224 |
// if the node was created after the escape computation, return |
|
225 |
// UnknownEscape |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
226 |
if (idx >= nodes_size()) |
1 | 227 |
return PointsToNode::UnknownEscape; |
228 |
||
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
229 |
es = ptnode_adr(idx)->escape_state(); |
1 | 230 |
|
231 |
// if we have already computed a value, return it |
|
1613
be097ec639a2
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
1069
diff
changeset
|
232 |
if (es != PointsToNode::UnknownEscape && |
be097ec639a2
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
1069
diff
changeset
|
233 |
ptnode_adr(idx)->node_type() == PointsToNode::JavaObject) |
1 | 234 |
return es; |
235 |
||
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
236 |
// PointsTo() calls n->uncast() which can return a new ideal node. |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
237 |
if (n->uncast()->_idx >= nodes_size()) |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
238 |
return PointsToNode::UnknownEscape; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
239 |
|
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
240 |
PointsToNode::EscapeState orig_es = es; |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
241 |
|
1 | 242 |
// compute max escape state of anything this node could point to |
8319 | 243 |
for(VectorSetI i(PointsTo(n)); i.test() && es != PointsToNode::GlobalEscape; ++i) { |
1 | 244 |
uint pt = i.elem; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
245 |
PointsToNode::EscapeState pes = ptnode_adr(pt)->escape_state(); |
1 | 246 |
if (pes > es) |
247 |
es = pes; |
|
248 |
} |
|
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
249 |
if (orig_es != es) { |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
250 |
// cache the computed escape state |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
251 |
assert(es > orig_es, "should have computed an escape state"); |
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
252 |
set_escape_state(idx, es); |
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
253 |
} // orig_es could be PointsToNode::UnknownEscape |
1 | 254 |
return es; |
255 |
} |
|
256 |
||
8319 | 257 |
VectorSet* ConnectionGraph::PointsTo(Node * n) { |
258 |
pt_ptset.Reset(); |
|
259 |
pt_visited.Reset(); |
|
260 |
pt_worklist.clear(); |
|
1 | 261 |
|
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
262 |
#ifdef ASSERT |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
263 |
Node *orig_n = n; |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
264 |
#endif |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
265 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
266 |
n = n->uncast(); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
267 |
PointsToNode* npt = ptnode_adr(n->_idx); |
1 | 268 |
|
269 |
// If we have a JavaObject, return just that object |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
270 |
if (npt->node_type() == PointsToNode::JavaObject) { |
8319 | 271 |
pt_ptset.set(n->_idx); |
272 |
return &pt_ptset; |
|
1 | 273 |
} |
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
274 |
#ifdef ASSERT |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
275 |
if (npt->_node == NULL) { |
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
276 |
if (orig_n != n) |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
277 |
orig_n->dump(); |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
278 |
n->dump(); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
279 |
assert(npt->_node != NULL, "unregistered node"); |
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
280 |
} |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
281 |
#endif |
8319 | 282 |
pt_worklist.push(n->_idx); |
283 |
while(pt_worklist.length() > 0) { |
|
284 |
int ni = pt_worklist.pop(); |
|
285 |
if (pt_visited.test_set(ni)) |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
286 |
continue; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
287 |
|
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
288 |
PointsToNode* pn = ptnode_adr(ni); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
289 |
// ensure that all inputs of a Phi have been processed |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
290 |
assert(!_collecting || !pn->_node->is_Phi() || _processed.test(ni),""); |
1 | 291 |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
292 |
int edges_processed = 0; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
293 |
uint e_cnt = pn->edge_count(); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
294 |
for (uint e = 0; e < e_cnt; e++) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
295 |
uint etgt = pn->edge_target(e); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
296 |
PointsToNode::EdgeType et = pn->edge_type(e); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
297 |
if (et == PointsToNode::PointsToEdge) { |
8319 | 298 |
pt_ptset.set(etgt); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
299 |
edges_processed++; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
300 |
} else if (et == PointsToNode::DeferredEdge) { |
8319 | 301 |
pt_worklist.push(etgt); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
302 |
edges_processed++; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
303 |
} else { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
304 |
assert(false,"neither PointsToEdge or DeferredEdge"); |
1 | 305 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
306 |
} |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
307 |
if (edges_processed == 0) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
308 |
// no deferred or pointsto edges found. Assume the value was set |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
309 |
// outside this method. Add the phantom object to the pointsto set. |
8319 | 310 |
pt_ptset.set(_phantom_object); |
1 | 311 |
} |
312 |
} |
|
8319 | 313 |
return &pt_ptset; |
1 | 314 |
} |
315 |
||
348
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
316 |
void ConnectionGraph::remove_deferred(uint ni, GrowableArray<uint>* deferred_edges, VectorSet* visited) { |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
317 |
// This method is most expensive during ConnectionGraph construction. |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
318 |
// Reuse vectorSet and an additional growable array for deferred edges. |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
319 |
deferred_edges->clear(); |
8319 | 320 |
visited->Reset(); |
1 | 321 |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
322 |
visited->set(ni); |
1 | 323 |
PointsToNode *ptn = ptnode_adr(ni); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
324 |
assert(ptn->node_type() == PointsToNode::LocalVar || |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
325 |
ptn->node_type() == PointsToNode::Field, "sanity"); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
326 |
assert(ptn->edge_count() != 0, "should have at least phantom_object"); |
1 | 327 |
|
348
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
328 |
// Mark current edges as visited and move deferred edges to separate array. |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
329 |
for (uint i = 0; i < ptn->edge_count(); ) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
330 |
uint t = ptn->edge_target(i); |
348
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
331 |
#ifdef ASSERT |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
332 |
assert(!visited->test_set(t), "expecting no duplications"); |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
333 |
#else |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
334 |
visited->set(t); |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
335 |
#endif |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
336 |
if (ptn->edge_type(i) == PointsToNode::DeferredEdge) { |
1 | 337 |
ptn->remove_edge(t, PointsToNode::DeferredEdge); |
348
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
338 |
deferred_edges->append(t); |
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
339 |
} else { |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
340 |
i++; |
348
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
341 |
} |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
342 |
} |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
343 |
for (int next = 0; next < deferred_edges->length(); ++next) { |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
344 |
uint t = deferred_edges->at(next); |
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
345 |
PointsToNode *ptt = ptnode_adr(t); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
346 |
uint e_cnt = ptt->edge_count(); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
347 |
assert(e_cnt != 0, "should have at least phantom_object"); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
348 |
for (uint e = 0; e < e_cnt; e++) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
349 |
uint etgt = ptt->edge_target(e); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
350 |
if (visited->test_set(etgt)) |
348
905c4cbf5d6a
6681577: PIT: some VM tests fails with -XX:+AggressiveOpts in 6u5p b01
kvn
parents:
238
diff
changeset
|
351 |
continue; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
352 |
|
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
353 |
PointsToNode::EdgeType et = ptt->edge_type(e); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
354 |
if (et == PointsToNode::PointsToEdge) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
355 |
add_pointsto_edge(ni, etgt); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
356 |
} else if (et == PointsToNode::DeferredEdge) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
357 |
deferred_edges->append(etgt); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
358 |
} else { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
359 |
assert(false,"invalid connection graph"); |
1 | 360 |
} |
361 |
} |
|
362 |
} |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
363 |
if (ptn->edge_count() == 0) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
364 |
// No pointsto edges found after deferred edges are removed. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
365 |
// For example, in the next case where call is replaced |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
366 |
// with uncommon trap and as result array's load references |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
367 |
// itself through deferred edges: |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
368 |
// |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
369 |
// A a = b[i]; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
370 |
// if (c!=null) a = c.foo(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
371 |
// b[i] = a; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
372 |
// |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
373 |
// Assume the value was set outside this method and |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
374 |
// add edge to phantom object. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
375 |
add_pointsto_edge(ni, _phantom_object); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
376 |
} |
1 | 377 |
} |
378 |
||
379 |
||
380 |
// Add an edge to node given by "to_i" from any field of adr_i whose offset |
|
381 |
// matches "offset" A deferred edge is added if to_i is a LocalVar, and |
|
382 |
// a pointsto edge is added if it is a JavaObject |
|
383 |
||
384 |
void ConnectionGraph::add_edge_from_fields(uint adr_i, uint to_i, int offs) { |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
385 |
// No fields for NULL pointer. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
386 |
if (is_null_ptr(adr_i)) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
387 |
return; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
388 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
389 |
PointsToNode* an = ptnode_adr(adr_i); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
390 |
PointsToNode* to = ptnode_adr(to_i); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
391 |
bool deferred = (to->node_type() == PointsToNode::LocalVar); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
392 |
bool escaped = (to_i == _phantom_object) && (offs == Type::OffsetTop); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
393 |
if (escaped) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
394 |
// Values in fields escaped during call. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
395 |
assert(an->escape_state() >= PointsToNode::ArgEscape, "sanity"); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
396 |
offs = Type::OffsetBot; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
397 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
398 |
for (uint fe = 0; fe < an->edge_count(); fe++) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
399 |
assert(an->edge_type(fe) == PointsToNode::FieldEdge, "expecting a field edge"); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
400 |
int fi = an->edge_target(fe); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
401 |
if (escaped) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
402 |
set_escape_state(fi, PointsToNode::GlobalEscape); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
403 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
404 |
PointsToNode* pf = ptnode_adr(fi); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
405 |
int po = pf->offset(); |
1 | 406 |
if (po == offs || po == Type::OffsetBot || offs == Type::OffsetBot) { |
407 |
if (deferred) |
|
408 |
add_deferred_edge(fi, to_i); |
|
409 |
else |
|
410 |
add_pointsto_edge(fi, to_i); |
|
411 |
} |
|
412 |
} |
|
413 |
} |
|
414 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
415 |
// Add a deferred edge from node given by "from_i" to any field of adr_i |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
416 |
// whose offset matches "offset". |
1 | 417 |
void ConnectionGraph::add_deferred_edge_to_fields(uint from_i, uint adr_i, int offs) { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
418 |
// No fields for NULL pointer. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
419 |
if (is_null_ptr(adr_i)) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
420 |
return; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
421 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
422 |
if (adr_i == _phantom_object) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
423 |
// Add only one edge for unknown object. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
424 |
add_pointsto_edge(from_i, _phantom_object); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
425 |
return; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
426 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
427 |
PointsToNode* an = ptnode_adr(adr_i); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
428 |
bool is_alloc = an->_node->is_Allocate(); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
429 |
for (uint fe = 0; fe < an->edge_count(); fe++) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
430 |
assert(an->edge_type(fe) == PointsToNode::FieldEdge, "expecting a field edge"); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
431 |
int fi = an->edge_target(fe); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
432 |
PointsToNode* pf = ptnode_adr(fi); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
433 |
int offset = pf->offset(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
434 |
if (!is_alloc) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
435 |
// Assume the field was set outside this method if it is not Allocation |
1 | 436 |
add_pointsto_edge(fi, _phantom_object); |
437 |
} |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
438 |
if (offset == offs || offset == Type::OffsetBot || offs == Type::OffsetBot) { |
1 | 439 |
add_deferred_edge(from_i, fi); |
440 |
} |
|
441 |
} |
|
11189 | 442 |
// Some fields references (AddP) may still be missing |
443 |
// until Connection Graph construction is complete. |
|
444 |
// For example, loads from RAW pointers with offset 0 |
|
445 |
// which don't have AddP. |
|
446 |
// A reference to phantom_object will be added if |
|
447 |
// a field reference is still missing after completing |
|
448 |
// Connection Graph (see remove_deferred()). |
|
1 | 449 |
} |
450 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
451 |
// Helper functions |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
452 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
453 |
static Node* get_addp_base(Node *addp) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
454 |
assert(addp->is_AddP(), "must be AddP"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
455 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
456 |
// AddP cases for Base and Address inputs: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
457 |
// case #1. Direct object's field reference: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
458 |
// Allocate |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
459 |
// | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
460 |
// Proj #5 ( oop result ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
461 |
// | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
462 |
// CheckCastPP (cast to instance type) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
463 |
// | | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
464 |
// AddP ( base == address ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
465 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
466 |
// case #2. Indirect object's field reference: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
467 |
// Phi |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
468 |
// | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
469 |
// CastPP (cast to instance type) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
470 |
// | | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
471 |
// AddP ( base == address ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
472 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
473 |
// case #3. Raw object's field reference for Initialize node: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
474 |
// Allocate |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
475 |
// | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
476 |
// Proj #5 ( oop result ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
477 |
// top | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
478 |
// \ | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
479 |
// AddP ( base == top ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
480 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
481 |
// case #4. Array's element reference: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
482 |
// {CheckCastPP | CastPP} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
483 |
// | | | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
484 |
// | AddP ( array's element offset ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
485 |
// | | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
486 |
// AddP ( array's offset ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
487 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
488 |
// case #5. Raw object's field reference for arraycopy stub call: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
489 |
// The inline_native_clone() case when the arraycopy stub is called |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
490 |
// after the allocation before Initialize and CheckCastPP nodes. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
491 |
// Allocate |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
492 |
// | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
493 |
// Proj #5 ( oop result ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
494 |
// | | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
495 |
// AddP ( base == address ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
496 |
// |
250 | 497 |
// case #6. Constant Pool, ThreadLocal, CastX2P or |
498 |
// Raw object's field reference: |
|
499 |
// {ConP, ThreadLocal, CastX2P, raw Load} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
500 |
// top | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
501 |
// \ | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
502 |
// AddP ( base == top ) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
503 |
// |
250 | 504 |
// case #7. Klass's field reference. |
505 |
// LoadKlass |
|
506 |
// | | |
|
507 |
// AddP ( base == address ) |
|
508 |
// |
|
590
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
509 |
// case #8. narrow Klass's field reference. |
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
510 |
// LoadNKlass |
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
511 |
// | |
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
512 |
// DecodeN |
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
513 |
// | | |
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
514 |
// AddP ( base == address ) |
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
515 |
// |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
516 |
Node *base = addp->in(AddPNode::Base)->uncast(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
517 |
if (base->is_top()) { // The AddP case #3 and #6. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
518 |
base = addp->in(AddPNode::Address)->uncast(); |
3804 | 519 |
while (base->is_AddP()) { |
520 |
// Case #6 (unsafe access) may have several chained AddP nodes. |
|
521 |
assert(base->in(AddPNode::Base)->is_top(), "expected unsafe access address only"); |
|
522 |
base = base->in(AddPNode::Address)->uncast(); |
|
523 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
524 |
assert(base->Opcode() == Op_ConP || base->Opcode() == Op_ThreadLocal || |
594
9f4474e5dbaf
6705887: Compressed Oops: generate x64 addressing and implicit null checks with narrow oops
kvn
parents:
590
diff
changeset
|
525 |
base->Opcode() == Op_CastX2P || base->is_DecodeN() || |
250 | 526 |
(base->is_Mem() && base->bottom_type() == TypeRawPtr::NOTNULL) || |
527 |
(base->is_Proj() && base->in(0)->is_Allocate()), "sanity"); |
|
1 | 528 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
529 |
return base; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
530 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
531 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
532 |
static Node* find_second_addp(Node* addp, Node* n) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
533 |
assert(addp->is_AddP() && addp->outcnt() > 0, "Don't process dead nodes"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
534 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
535 |
Node* addp2 = addp->raw_out(0); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
536 |
if (addp->outcnt() == 1 && addp2->is_AddP() && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
537 |
addp2->in(AddPNode::Base) == n && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
538 |
addp2->in(AddPNode::Address) == addp) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
539 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
540 |
assert(addp->in(AddPNode::Base) == n, "expecting the same base"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
541 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
542 |
// Find array's offset to push it on worklist first and |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
543 |
// as result process an array's element offset first (pushed second) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
544 |
// to avoid CastPP for the array's offset. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
545 |
// Otherwise the inserted CastPP (LocalVar) will point to what |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
546 |
// the AddP (Field) points to. Which would be wrong since |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
547 |
// the algorithm expects the CastPP has the same point as |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
548 |
// as AddP's base CheckCastPP (LocalVar). |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
549 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
550 |
// ArrayAllocation |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
551 |
// | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
552 |
// CheckCastPP |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
553 |
// | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
554 |
// memProj (from ArrayAllocation CheckCastPP) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
555 |
// | || |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
556 |
// | || Int (element index) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
557 |
// | || | ConI (log(element size)) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
558 |
// | || | / |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
559 |
// | || LShift |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
560 |
// | || / |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
561 |
// | AddP (array's element offset) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
562 |
// | | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
563 |
// | | ConI (array's offset: #12(32-bits) or #24(64-bits)) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
564 |
// | / / |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
565 |
// AddP (array's offset) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
566 |
// | |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
567 |
// Load/Store (memory operation on array's element) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
568 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
569 |
return addp2; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
570 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
571 |
return NULL; |
1 | 572 |
} |
573 |
||
574 |
// |
|
575 |
// Adjust the type and inputs of an AddP which computes the |
|
576 |
// address of a field of an instance |
|
577 |
// |
|
1055
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
578 |
bool ConnectionGraph::split_AddP(Node *addp, Node *base, PhaseGVN *igvn) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
579 |
const TypeOopPtr *base_t = igvn->type(base)->isa_oopptr(); |
769 | 580 |
assert(base_t != NULL && base_t->is_known_instance(), "expecting instance oopptr"); |
1 | 581 |
const TypeOopPtr *t = igvn->type(addp)->isa_oopptr(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
582 |
if (t == NULL) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
583 |
// We are computing a raw address for a store captured by an Initialize |
1055
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
584 |
// compute an appropriate address type (cases #3 and #5). |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
585 |
assert(igvn->type(addp) == TypeRawPtr::NOTNULL, "must be raw pointer"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
586 |
assert(addp->in(AddPNode::Address)->is_Proj(), "base of raw address must be result projection from allocation"); |
1068
720698d9c89b
6741738: TypePtr::add_offset() set incorrect offset when the add overflows
kvn
parents:
1055
diff
changeset
|
587 |
intptr_t offs = (int)igvn->find_intptr_t_con(addp->in(AddPNode::Offset), Type::OffsetBot); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
588 |
assert(offs != Type::OffsetBot, "offset must be a constant"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
589 |
t = base_t->add_offset(offs)->is_oopptr(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
590 |
} |
769 | 591 |
int inst_id = base_t->instance_id(); |
592 |
assert(!t->is_known_instance() || t->instance_id() == inst_id, |
|
1 | 593 |
"old type must be non-instance or match new type"); |
1055
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
594 |
|
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
595 |
// The type 't' could be subclass of 'base_t'. |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
596 |
// As result t->offset() could be large then base_t's size and it will |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
597 |
// cause the failure in add_offset() with narrow oops since TypeOopPtr() |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
598 |
// constructor verifies correctness of the offset. |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
599 |
// |
2131 | 600 |
// It could happened on subclass's branch (from the type profiling |
1055
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
601 |
// inlining) which was not eliminated during parsing since the exactness |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
602 |
// of the allocation type was not propagated to the subclass type check. |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
603 |
// |
3907
2a567f035d5c
6879362: assert(!klass_is_exact(),"only non-exact klass")
kvn
parents:
3804
diff
changeset
|
604 |
// Or the type 't' could be not related to 'base_t' at all. |
2a567f035d5c
6879362: assert(!klass_is_exact(),"only non-exact klass")
kvn
parents:
3804
diff
changeset
|
605 |
// It could happened when CHA type is different from MDO type on a dead path |
2a567f035d5c
6879362: assert(!klass_is_exact(),"only non-exact klass")
kvn
parents:
3804
diff
changeset
|
606 |
// (for example, from instanceof check) which is not collapsed during parsing. |
2a567f035d5c
6879362: assert(!klass_is_exact(),"only non-exact klass")
kvn
parents:
3804
diff
changeset
|
607 |
// |
1055
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
608 |
// Do nothing for such AddP node and don't process its users since |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
609 |
// this code branch will go away. |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
610 |
// |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
611 |
if (!t->is_known_instance() && |
3907
2a567f035d5c
6879362: assert(!klass_is_exact(),"only non-exact klass")
kvn
parents:
3804
diff
changeset
|
612 |
!base_t->klass()->is_subtype_of(t->klass())) { |
1055
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
613 |
return false; // bail out |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
614 |
} |
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
615 |
|
1 | 616 |
const TypeOopPtr *tinst = base_t->add_offset(t->offset())->is_oopptr(); |
4432
29b057bf202d
6896352: CTW fails hotspot/src/share/vm/opto/escape.cpp:1155
kvn
parents:
3907
diff
changeset
|
617 |
// Do NOT remove the next line: ensure a new alias index is allocated |
29b057bf202d
6896352: CTW fails hotspot/src/share/vm/opto/escape.cpp:1155
kvn
parents:
3907
diff
changeset
|
618 |
// for the instance type. Note: C++ will not remove it since the call |
29b057bf202d
6896352: CTW fails hotspot/src/share/vm/opto/escape.cpp:1155
kvn
parents:
3907
diff
changeset
|
619 |
// has side effect. |
1 | 620 |
int alias_idx = _compile->get_alias_index(tinst); |
621 |
igvn->set_type(addp, tinst); |
|
622 |
// record the allocation in the node map |
|
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
623 |
assert(ptnode_adr(addp->_idx)->_node != NULL, "should be registered"); |
1 | 624 |
set_map(addp->_idx, get_map(base->_idx)); |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
625 |
|
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
626 |
// Set addp's Base and Address to 'base'. |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
627 |
Node *abase = addp->in(AddPNode::Base); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
628 |
Node *adr = addp->in(AddPNode::Address); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
629 |
if (adr->is_Proj() && adr->in(0)->is_Allocate() && |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
630 |
adr->in(0)->_idx == (uint)inst_id) { |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
631 |
// Skip AddP cases #3 and #5. |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
632 |
} else { |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
633 |
assert(!abase->is_top(), "sanity"); // AddP case #3 |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
634 |
if (abase != base) { |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
635 |
igvn->hash_delete(addp); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
636 |
addp->set_req(AddPNode::Base, base); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
637 |
if (abase == adr) { |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
638 |
addp->set_req(AddPNode::Address, base); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
639 |
} else { |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
640 |
// AddP case #4 (adr is array's element offset AddP node) |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
641 |
#ifdef ASSERT |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
642 |
const TypeOopPtr *atype = igvn->type(adr)->isa_oopptr(); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
643 |
assert(adr->is_AddP() && atype != NULL && |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
644 |
atype->instance_id() == inst_id, "array's element offset should be processed first"); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
645 |
#endif |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
646 |
} |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
647 |
igvn->hash_insert(addp); |
1 | 648 |
} |
649 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
650 |
// Put on IGVN worklist since at least addp's type was changed above. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
651 |
record_for_optimizer(addp); |
1055
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
652 |
return true; |
1 | 653 |
} |
654 |
||
655 |
// |
|
656 |
// Create a new version of orig_phi if necessary. Returns either the newly |
|
9115
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
657 |
// created phi or an existing phi. Sets create_new to indicate whether a new |
1 | 658 |
// phi was created. Cache the last newly created phi in the node map. |
659 |
// |
|
660 |
PhiNode *ConnectionGraph::create_split_phi(PhiNode *orig_phi, int alias_idx, GrowableArray<PhiNode *> &orig_phi_worklist, PhaseGVN *igvn, bool &new_created) { |
|
661 |
Compile *C = _compile; |
|
662 |
new_created = false; |
|
663 |
int phi_alias_idx = C->get_alias_index(orig_phi->adr_type()); |
|
664 |
// nothing to do if orig_phi is bottom memory or matches alias_idx |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
665 |
if (phi_alias_idx == alias_idx) { |
1 | 666 |
return orig_phi; |
667 |
} |
|
3268
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
668 |
// Have we recently created a Phi for this alias index? |
1 | 669 |
PhiNode *result = get_map_phi(orig_phi->_idx); |
670 |
if (result != NULL && C->get_alias_index(result->adr_type()) == alias_idx) { |
|
671 |
return result; |
|
672 |
} |
|
3268
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
673 |
// Previous check may fail when the same wide memory Phi was split into Phis |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
674 |
// for different memory slices. Search all Phis for this region. |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
675 |
if (result != NULL) { |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
676 |
Node* region = orig_phi->in(0); |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
677 |
for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
678 |
Node* phi = region->fast_out(i); |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
679 |
if (phi->is_Phi() && |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
680 |
C->get_alias_index(phi->as_Phi()->adr_type()) == alias_idx) { |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
681 |
assert(phi->_idx >= nodes_size(), "only new Phi per instance memory slice"); |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
682 |
return phi->as_Phi(); |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
683 |
} |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
684 |
} |
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
685 |
} |
211
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
686 |
if ((int)C->unique() + 2*NodeLimitFudgeFactor > MaxNodeLimit) { |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
687 |
if (C->do_escape_analysis() == true && !C->failing()) { |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
688 |
// Retry compilation without escape analysis. |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
689 |
// If this is the first failure, the sentinel string will "stick" |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
690 |
// to the Compile object, and the C2Compiler will see it and retry. |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
691 |
C->record_failure(C2Compiler::retry_no_escape_analysis()); |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
692 |
} |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
693 |
return NULL; |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
694 |
} |
1 | 695 |
orig_phi_worklist.append_if_missing(orig_phi); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
696 |
const TypePtr *atype = C->get_adr_type(alias_idx); |
1 | 697 |
result = PhiNode::make(orig_phi->in(0), NULL, Type::MEMORY, atype); |
3268
f034e0c86895
6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents:
2871
diff
changeset
|
698 |
C->copy_node_notes_to(result, orig_phi); |
1 | 699 |
igvn->set_type(result, result->bottom_type()); |
700 |
record_for_optimizer(result); |
|
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
701 |
|
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
702 |
debug_only(Node* pn = ptnode_adr(orig_phi->_idx)->_node;) |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
703 |
assert(pn == NULL || pn == orig_phi, "wrong node"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
704 |
set_map(orig_phi->_idx, result); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
705 |
ptnode_adr(orig_phi->_idx)->_node = orig_phi; |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
706 |
|
1 | 707 |
new_created = true; |
708 |
return result; |
|
709 |
} |
|
710 |
||
711 |
// |
|
9115
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
712 |
// Return a new version of Memory Phi "orig_phi" with the inputs having the |
1 | 713 |
// specified alias index. |
714 |
// |
|
715 |
PhiNode *ConnectionGraph::split_memory_phi(PhiNode *orig_phi, int alias_idx, GrowableArray<PhiNode *> &orig_phi_worklist, PhaseGVN *igvn) { |
|
716 |
||
717 |
assert(alias_idx != Compile::AliasIdxBot, "can't split out bottom memory"); |
|
718 |
Compile *C = _compile; |
|
719 |
bool new_phi_created; |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
720 |
PhiNode *result = create_split_phi(orig_phi, alias_idx, orig_phi_worklist, igvn, new_phi_created); |
1 | 721 |
if (!new_phi_created) { |
722 |
return result; |
|
723 |
} |
|
724 |
||
725 |
GrowableArray<PhiNode *> phi_list; |
|
726 |
GrowableArray<uint> cur_input; |
|
727 |
||
728 |
PhiNode *phi = orig_phi; |
|
729 |
uint idx = 1; |
|
730 |
bool finished = false; |
|
731 |
while(!finished) { |
|
732 |
while (idx < phi->req()) { |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
733 |
Node *mem = find_inst_mem(phi->in(idx), alias_idx, orig_phi_worklist, igvn); |
1 | 734 |
if (mem != NULL && mem->is_Phi()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
735 |
PhiNode *newphi = create_split_phi(mem->as_Phi(), alias_idx, orig_phi_worklist, igvn, new_phi_created); |
1 | 736 |
if (new_phi_created) { |
737 |
// found an phi for which we created a new split, push current one on worklist and begin |
|
738 |
// processing new one |
|
739 |
phi_list.push(phi); |
|
740 |
cur_input.push(idx); |
|
741 |
phi = mem->as_Phi(); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
742 |
result = newphi; |
1 | 743 |
idx = 1; |
744 |
continue; |
|
745 |
} else { |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
746 |
mem = newphi; |
1 | 747 |
} |
748 |
} |
|
211
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
749 |
if (C->failing()) { |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
750 |
return NULL; |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
751 |
} |
1 | 752 |
result->set_req(idx++, mem); |
753 |
} |
|
754 |
#ifdef ASSERT |
|
755 |
// verify that the new Phi has an input for each input of the original |
|
756 |
assert( phi->req() == result->req(), "must have same number of inputs."); |
|
757 |
assert( result->in(0) != NULL && result->in(0) == phi->in(0), "regions must match"); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
758 |
#endif |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
759 |
// Check if all new phi's inputs have specified alias index. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
760 |
// Otherwise use old phi. |
1 | 761 |
for (uint i = 1; i < phi->req(); i++) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
762 |
Node* in = result->in(i); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
763 |
assert((phi->in(i) == NULL) == (in == NULL), "inputs must correspond."); |
1 | 764 |
} |
765 |
// we have finished processing a Phi, see if there are any more to do |
|
766 |
finished = (phi_list.length() == 0 ); |
|
767 |
if (!finished) { |
|
768 |
phi = phi_list.pop(); |
|
769 |
idx = cur_input.pop(); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
770 |
PhiNode *prev_result = get_map_phi(phi->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
771 |
prev_result->set_req(idx++, result); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
772 |
result = prev_result; |
1 | 773 |
} |
774 |
} |
|
775 |
return result; |
|
776 |
} |
|
777 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
778 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
779 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
780 |
// The next methods are derived from methods in MemNode. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
781 |
// |
6741 | 782 |
static Node *step_through_mergemem(MergeMemNode *mmem, int alias_idx, const TypeOopPtr *toop) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
783 |
Node *mem = mmem; |
6741 | 784 |
// TypeOopPtr::NOTNULL+any is an OOP with unknown offset - generally |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
785 |
// means an array I have not precisely typed yet. Do not do any |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
786 |
// alias stuff with it any time soon. |
6741 | 787 |
if( toop->base() != Type::AnyPtr && |
788 |
!(toop->klass() != NULL && |
|
789 |
toop->klass()->is_java_lang_Object() && |
|
790 |
toop->offset() == Type::OffsetBot) ) { |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
791 |
mem = mmem->memory_at(alias_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
792 |
// Update input if it is progress over what we have now |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
793 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
794 |
return mem; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
795 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
796 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
797 |
// |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
798 |
// Move memory users to their memory slices. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
799 |
// |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
800 |
void ConnectionGraph::move_inst_mem(Node* n, GrowableArray<PhiNode *> &orig_phis, PhaseGVN *igvn) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
801 |
Compile* C = _compile; |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
802 |
|
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
803 |
const TypePtr* tp = igvn->type(n->in(MemNode::Address))->isa_ptr(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
804 |
assert(tp != NULL, "ptr type"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
805 |
int alias_idx = C->get_alias_index(tp); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
806 |
int general_idx = C->get_general_index(alias_idx); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
807 |
|
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
808 |
// Move users first |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
809 |
for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
810 |
Node* use = n->fast_out(i); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
811 |
if (use->is_MergeMem()) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
812 |
MergeMemNode* mmem = use->as_MergeMem(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
813 |
assert(n == mmem->memory_at(alias_idx), "should be on instance memory slice"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
814 |
if (n != mmem->memory_at(general_idx) || alias_idx == general_idx) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
815 |
continue; // Nothing to do |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
816 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
817 |
// Replace previous general reference to mem node. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
818 |
uint orig_uniq = C->unique(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
819 |
Node* m = find_inst_mem(n, general_idx, orig_phis, igvn); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
820 |
assert(orig_uniq == C->unique(), "no new nodes"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
821 |
mmem->set_memory_at(general_idx, m); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
822 |
--imax; |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
823 |
--i; |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
824 |
} else if (use->is_MemBar()) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
825 |
assert(!use->is_Initialize(), "initializing stores should not be moved"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
826 |
if (use->req() > MemBarNode::Precedent && |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
827 |
use->in(MemBarNode::Precedent) == n) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
828 |
// Don't move related membars. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
829 |
record_for_optimizer(use); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
830 |
continue; |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
831 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
832 |
tp = use->as_MemBar()->adr_type()->isa_ptr(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
833 |
if (tp != NULL && C->get_alias_index(tp) == alias_idx || |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
834 |
alias_idx == general_idx) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
835 |
continue; // Nothing to do |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
836 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
837 |
// Move to general memory slice. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
838 |
uint orig_uniq = C->unique(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
839 |
Node* m = find_inst_mem(n, general_idx, orig_phis, igvn); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
840 |
assert(orig_uniq == C->unique(), "no new nodes"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
841 |
igvn->hash_delete(use); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
842 |
imax -= use->replace_edge(n, m); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
843 |
igvn->hash_insert(use); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
844 |
record_for_optimizer(use); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
845 |
--i; |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
846 |
#ifdef ASSERT |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
847 |
} else if (use->is_Mem()) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
848 |
if (use->Opcode() == Op_StoreCM && use->in(MemNode::OopStore) == n) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
849 |
// Don't move related cardmark. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
850 |
continue; |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
851 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
852 |
// Memory nodes should have new memory input. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
853 |
tp = igvn->type(use->in(MemNode::Address))->isa_ptr(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
854 |
assert(tp != NULL, "ptr type"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
855 |
int idx = C->get_alias_index(tp); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
856 |
assert(get_map(use->_idx) != NULL || idx == alias_idx, |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
857 |
"Following memory nodes should have new memory input or be on the same memory slice"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
858 |
} else if (use->is_Phi()) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
859 |
// Phi nodes should be split and moved already. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
860 |
tp = use->as_Phi()->adr_type()->isa_ptr(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
861 |
assert(tp != NULL, "ptr type"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
862 |
int idx = C->get_alias_index(tp); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
863 |
assert(idx == alias_idx, "Following Phi nodes should be on the same memory slice"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
864 |
} else { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
865 |
use->dump(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
866 |
assert(false, "should not be here"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
867 |
#endif |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
868 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
869 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
870 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
871 |
|
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
872 |
// |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
873 |
// Search memory chain of "mem" to find a MemNode whose address |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
874 |
// is the specified alias index. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
875 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
876 |
Node* ConnectionGraph::find_inst_mem(Node *orig_mem, int alias_idx, GrowableArray<PhiNode *> &orig_phis, PhaseGVN *phase) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
877 |
if (orig_mem == NULL) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
878 |
return orig_mem; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
879 |
Compile* C = phase->C; |
6741 | 880 |
const TypeOopPtr *toop = C->get_adr_type(alias_idx)->isa_oopptr(); |
881 |
bool is_instance = (toop != NULL) && toop->is_known_instance(); |
|
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
882 |
Node *start_mem = C->start()->proj_out(TypeFunc::Memory); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
883 |
Node *prev = NULL; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
884 |
Node *result = orig_mem; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
885 |
while (prev != result) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
886 |
prev = result; |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
887 |
if (result == start_mem) |
2131 | 888 |
break; // hit one of our sentinels |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
889 |
if (result->is_Mem()) { |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
890 |
const Type *at = phase->type(result->in(MemNode::Address)); |
9115
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
891 |
if (at == Type::TOP) |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
892 |
break; // Dead |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
893 |
assert (at->isa_ptr() != NULL, "pointer type required."); |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
894 |
int idx = C->get_alias_index(at->is_ptr()); |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
895 |
if (idx == alias_idx) |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
896 |
break; // Found |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
897 |
if (!is_instance && (at->isa_oopptr() == NULL || |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
898 |
!at->is_oopptr()->is_known_instance())) { |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
899 |
break; // Do not skip store to general memory slice. |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
900 |
} |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
901 |
result = result->in(MemNode::Memory); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
902 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
903 |
if (!is_instance) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
904 |
continue; // don't search further for non-instance types |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
905 |
// skip over a call which does not affect this memory slice |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
906 |
if (result->is_Proj() && result->as_Proj()->_con == TypeFunc::Memory) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
907 |
Node *proj_in = result->in(0); |
6741 | 908 |
if (proj_in->is_Allocate() && proj_in->_idx == (uint)toop->instance_id()) { |
2131 | 909 |
break; // hit one of our sentinels |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
910 |
} else if (proj_in->is_Call()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
911 |
CallNode *call = proj_in->as_Call(); |
6741 | 912 |
if (!call->may_modify(toop, phase)) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
913 |
result = call->in(TypeFunc::Memory); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
914 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
915 |
} else if (proj_in->is_Initialize()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
916 |
AllocateNode* alloc = proj_in->as_Initialize()->allocation(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
917 |
// Stop if this is the initialization for the object instance which |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
918 |
// which contains this memory slice, otherwise skip over it. |
6741 | 919 |
if (alloc == NULL || alloc->_idx != (uint)toop->instance_id()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
920 |
result = proj_in->in(TypeFunc::Memory); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
921 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
922 |
} else if (proj_in->is_MemBar()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
923 |
result = proj_in->in(TypeFunc::Memory); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
924 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
925 |
} else if (result->is_MergeMem()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
926 |
MergeMemNode *mmem = result->as_MergeMem(); |
6741 | 927 |
result = step_through_mergemem(mmem, alias_idx, toop); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
928 |
if (result == mmem->base_memory()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
929 |
// Didn't find instance memory, search through general slice recursively. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
930 |
result = mmem->memory_at(C->get_general_index(alias_idx)); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
931 |
result = find_inst_mem(result, alias_idx, orig_phis, phase); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
932 |
if (C->failing()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
933 |
return NULL; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
934 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
935 |
mmem->set_memory_at(alias_idx, result); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
936 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
937 |
} else if (result->is_Phi() && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
938 |
C->get_alias_index(result->as_Phi()->adr_type()) != alias_idx) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
939 |
Node *un = result->as_Phi()->unique_input(phase); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
940 |
if (un != NULL) { |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
941 |
orig_phis.append_if_missing(result->as_Phi()); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
942 |
result = un; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
943 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
944 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
945 |
} |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
946 |
} else if (result->is_ClearArray()) { |
6741 | 947 |
if (!ClearArrayNode::step_through(&result, (uint)toop->instance_id(), phase)) { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
948 |
// Can not bypass initialization of the instance |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
949 |
// we are looking for. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
950 |
break; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
951 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
952 |
// Otherwise skip it (the call updated 'result' value). |
2110
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
953 |
} else if (result->Opcode() == Op_SCMemProj) { |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
954 |
assert(result->in(0)->is_LoadStore(), "sanity"); |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
955 |
const Type *at = phase->type(result->in(0)->in(MemNode::Address)); |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
956 |
if (at != Type::TOP) { |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
957 |
assert (at->isa_ptr() != NULL, "pointer type required."); |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
958 |
int idx = C->get_alias_index(at->is_ptr()); |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
959 |
assert(idx != alias_idx, "Object is not scalar replaceable if a LoadStore node access its field"); |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
960 |
break; |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
961 |
} |
40e42c95ac39
6802499: EA: assert(false,"unknown node on this path")
kvn
parents:
1613
diff
changeset
|
962 |
result = result->in(0)->in(MemNode::Memory); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
963 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
964 |
} |
955 | 965 |
if (result->is_Phi()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
966 |
PhiNode *mphi = result->as_Phi(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
967 |
assert(mphi->bottom_type() == Type::MEMORY, "memory phi required"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
968 |
const TypePtr *t = mphi->adr_type(); |
9115
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
969 |
if (!is_instance) { |
955 | 970 |
// Push all non-instance Phis on the orig_phis worklist to update inputs |
971 |
// during Phase 4 if needed. |
|
972 |
orig_phis.append_if_missing(mphi); |
|
9115
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
973 |
} else if (C->get_alias_index(t) != alias_idx) { |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
974 |
// Create a new Phi with the specified alias index type. |
5a28312aa393
6992789: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice
kvn
parents:
8319
diff
changeset
|
975 |
result = split_memory_phi(mphi, alias_idx, orig_phis, phase); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
976 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
977 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
978 |
// the result is either MemNode, PhiNode, InitializeNode. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
979 |
return result; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
980 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
981 |
|
1 | 982 |
// |
983 |
// Convert the types of unescaped object to instance types where possible, |
|
984 |
// propagate the new type information through the graph, and update memory |
|
985 |
// edges and MergeMem inputs to reflect the new type. |
|
986 |
// |
|
987 |
// We start with allocations (and calls which may be allocations) on alloc_worklist. |
|
988 |
// The processing is done in 4 phases: |
|
989 |
// |
|
990 |
// Phase 1: Process possible allocations from alloc_worklist. Create instance |
|
991 |
// types for the CheckCastPP for allocations where possible. |
|
992 |
// Propagate the the new types through users as follows: |
|
993 |
// casts and Phi: push users on alloc_worklist |
|
994 |
// AddP: cast Base and Address inputs to the instance type |
|
995 |
// push any AddP users on alloc_worklist and push any memnode |
|
996 |
// users onto memnode_worklist. |
|
997 |
// Phase 2: Process MemNode's from memnode_worklist. compute new address type and |
|
998 |
// search the Memory chain for a store with the appropriate type |
|
999 |
// address type. If a Phi is found, create a new version with |
|
2131 | 1000 |
// the appropriate memory slices from each of the Phi inputs. |
1 | 1001 |
// For stores, process the users as follows: |
1002 |
// MemNode: push on memnode_worklist |
|
1003 |
// MergeMem: push on mergemem_worklist |
|
1004 |
// Phase 3: Process MergeMem nodes from mergemem_worklist. Walk each memory slice |
|
1005 |
// moving the first node encountered of each instance type to the |
|
1006 |
// the input corresponding to its alias index. |
|
1007 |
// appropriate memory slice. |
|
1008 |
// Phase 4: Update the inputs of non-instance memory Phis and the Memory input of memnodes. |
|
1009 |
// |
|
1010 |
// In the following example, the CheckCastPP nodes are the cast of allocation |
|
1011 |
// results and the allocation of node 29 is unescaped and eligible to be an |
|
1012 |
// instance type. |
|
1013 |
// |
|
1014 |
// We start with: |
|
1015 |
// |
|
1016 |
// 7 Parm #memory |
|
1017 |
// 10 ConI "12" |
|
1018 |
// 19 CheckCastPP "Foo" |
|
1019 |
// 20 AddP _ 19 19 10 Foo+12 alias_index=4 |
|
1020 |
// 29 CheckCastPP "Foo" |
|
1021 |
// 30 AddP _ 29 29 10 Foo+12 alias_index=4 |
|
1022 |
// |
|
1023 |
// 40 StoreP 25 7 20 ... alias_index=4 |
|
1024 |
// 50 StoreP 35 40 30 ... alias_index=4 |
|
1025 |
// 60 StoreP 45 50 20 ... alias_index=4 |
|
1026 |
// 70 LoadP _ 60 30 ... alias_index=4 |
|
1027 |
// 80 Phi 75 50 60 Memory alias_index=4 |
|
1028 |
// 90 LoadP _ 80 30 ... alias_index=4 |
|
1029 |
// 100 LoadP _ 80 20 ... alias_index=4 |
|
1030 |
// |
|
1031 |
// |
|
1032 |
// Phase 1 creates an instance type for node 29 assigning it an instance id of 24 |
|
1033 |
// and creating a new alias index for node 30. This gives: |
|
1034 |
// |
|
1035 |
// 7 Parm #memory |
|
1036 |
// 10 ConI "12" |
|
1037 |
// 19 CheckCastPP "Foo" |
|
1038 |
// 20 AddP _ 19 19 10 Foo+12 alias_index=4 |
|
1039 |
// 29 CheckCastPP "Foo" iid=24 |
|
1040 |
// 30 AddP _ 29 29 10 Foo+12 alias_index=6 iid=24 |
|
1041 |
// |
|
1042 |
// 40 StoreP 25 7 20 ... alias_index=4 |
|
1043 |
// 50 StoreP 35 40 30 ... alias_index=6 |
|
1044 |
// 60 StoreP 45 50 20 ... alias_index=4 |
|
1045 |
// 70 LoadP _ 60 30 ... alias_index=6 |
|
1046 |
// 80 Phi 75 50 60 Memory alias_index=4 |
|
1047 |
// 90 LoadP _ 80 30 ... alias_index=6 |
|
1048 |
// 100 LoadP _ 80 20 ... alias_index=4 |
|
1049 |
// |
|
1050 |
// In phase 2, new memory inputs are computed for the loads and stores, |
|
1051 |
// And a new version of the phi is created. In phase 4, the inputs to |
|
1052 |
// node 80 are updated and then the memory nodes are updated with the |
|
1053 |
// values computed in phase 2. This results in: |
|
1054 |
// |
|
1055 |
// 7 Parm #memory |
|
1056 |
// 10 ConI "12" |
|
1057 |
// 19 CheckCastPP "Foo" |
|
1058 |
// 20 AddP _ 19 19 10 Foo+12 alias_index=4 |
|
1059 |
// 29 CheckCastPP "Foo" iid=24 |
|
1060 |
// 30 AddP _ 29 29 10 Foo+12 alias_index=6 iid=24 |
|
1061 |
// |
|
1062 |
// 40 StoreP 25 7 20 ... alias_index=4 |
|
1063 |
// 50 StoreP 35 7 30 ... alias_index=6 |
|
1064 |
// 60 StoreP 45 40 20 ... alias_index=4 |
|
1065 |
// 70 LoadP _ 50 30 ... alias_index=6 |
|
1066 |
// 80 Phi 75 40 60 Memory alias_index=4 |
|
1067 |
// 120 Phi 75 50 50 Memory alias_index=6 |
|
1068 |
// 90 LoadP _ 120 30 ... alias_index=6 |
|
1069 |
// 100 LoadP _ 80 20 ... alias_index=4 |
|
1070 |
// |
|
1071 |
void ConnectionGraph::split_unique_types(GrowableArray<Node *> &alloc_worklist) { |
|
1072 |
GrowableArray<Node *> memnode_worklist; |
|
1073 |
GrowableArray<PhiNode *> orig_phis; |
|
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1074 |
|
7122 | 1075 |
PhaseIterGVN *igvn = _igvn; |
1 | 1076 |
uint new_index_start = (uint) _compile->num_alias_types(); |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1077 |
Arena* arena = Thread::current()->resource_area(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1078 |
VectorSet visited(arena); |
1 | 1079 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1080 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1081 |
// Phase 1: Process possible allocations from alloc_worklist. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1082 |
// Create instance types for the CheckCastPP for allocations where possible. |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1083 |
// |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1084 |
// (Note: don't forget to change the order of the second AddP node on |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1085 |
// the alloc_worklist if the order of the worklist processing is changed, |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1086 |
// see the comment in find_second_addp().) |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1087 |
// |
1 | 1088 |
while (alloc_worklist.length() != 0) { |
1089 |
Node *n = alloc_worklist.pop(); |
|
1090 |
uint ni = n->_idx; |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1091 |
const TypeOopPtr* tinst = NULL; |
1 | 1092 |
if (n->is_Call()) { |
1093 |
CallNode *alloc = n->as_Call(); |
|
1094 |
// copy escape information to call node |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1095 |
PointsToNode* ptn = ptnode_adr(alloc->_idx); |
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1096 |
PointsToNode::EscapeState es = escape_state(alloc); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1097 |
// We have an allocation or call which returns a Java object, |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1098 |
// see if it is unescaped. |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1099 |
if (es != PointsToNode::NoEscape || !ptn->scalar_replaceable()) |
1 | 1100 |
continue; |
2871
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1101 |
|
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1102 |
// Find CheckCastPP for the allocate or for the return value of a call |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1103 |
n = alloc->result_cast(); |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1104 |
if (n == NULL) { // No uses except Initialize node |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1105 |
if (alloc->is_Allocate()) { |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1106 |
// Set the scalar_replaceable flag for allocation |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1107 |
// so it could be eliminated if it has no uses. |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1108 |
alloc->as_Allocate()->_is_scalar_replaceable = true; |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1109 |
} |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1110 |
continue; |
212
cd4963e67949
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
211
diff
changeset
|
1111 |
} |
2871
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1112 |
if (!n->is_CheckCastPP()) { // not unique CheckCastPP. |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1113 |
assert(!alloc->is_Allocate(), "allocation should have unique type"); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1114 |
continue; |
2871
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1115 |
} |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1116 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1117 |
// The inline code for Object.clone() casts the allocation result to |
955 | 1118 |
// java.lang.Object and then to the actual type of the allocated |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1119 |
// object. Detect this case and use the second cast. |
955 | 1120 |
// Also detect j.l.reflect.Array.newInstance(jobject, jint) case when |
1121 |
// the allocation result is cast to java.lang.Object and then |
|
1122 |
// to the actual Array type. |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1123 |
if (alloc->is_Allocate() && n->as_Type()->type() == TypeInstPtr::NOTNULL |
955 | 1124 |
&& (alloc->is_AllocateArray() || |
1125 |
igvn->type(alloc->in(AllocateNode::KlassNode)) != TypeKlassPtr::OBJECT)) { |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1126 |
Node *cast2 = NULL; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1127 |
for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1128 |
Node *use = n->fast_out(i); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1129 |
if (use->is_CheckCastPP()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1130 |
cast2 = use; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1131 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1132 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1133 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1134 |
if (cast2 != NULL) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1135 |
n = cast2; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1136 |
} else { |
2871
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1137 |
// Non-scalar replaceable if the allocation type is unknown statically |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1138 |
// (reflection allocation), the object can't be restored during |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1139 |
// deoptimization without precise type. |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1140 |
continue; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1141 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1142 |
} |
2871
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1143 |
if (alloc->is_Allocate()) { |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1144 |
// Set the scalar_replaceable flag for allocation |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1145 |
// so it could be eliminated. |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1146 |
alloc->as_Allocate()->_is_scalar_replaceable = true; |
519e22b6900d
6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
kvn
parents:
2131
diff
changeset
|
1147 |
} |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1148 |
set_escape_state(n->_idx, es); // CheckCastPP escape state |
955 | 1149 |
// in order for an object to be scalar-replaceable, it must be: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1150 |
// - a direct allocation (not a call returning an object) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1151 |
// - non-escaping |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1152 |
// - eligible to be a unique type |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1153 |
// - not determined to be ineligible by escape analysis |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1154 |
assert(ptnode_adr(alloc->_idx)->_node != NULL && |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1155 |
ptnode_adr(n->_idx)->_node != NULL, "should be registered"); |
1 | 1156 |
set_map(alloc->_idx, n); |
1157 |
set_map(n->_idx, alloc); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1158 |
const TypeOopPtr *t = igvn->type(n)->isa_oopptr(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1159 |
if (t == NULL) |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1160 |
continue; // not a TypeOopPtr |
955 | 1161 |
tinst = t->cast_to_exactness(true)->is_oopptr()->cast_to_instance_id(ni); |
1 | 1162 |
igvn->hash_delete(n); |
1163 |
igvn->set_type(n, tinst); |
|
1164 |
n->raise_bottom_type(tinst); |
|
1165 |
igvn->hash_insert(n); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1166 |
record_for_optimizer(n); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1167 |
if (alloc->is_Allocate() && (t->isa_instptr() || t->isa_aryptr())) { |
589 | 1168 |
|
1169 |
// First, put on the worklist all Field edges from Connection Graph |
|
1170 |
// which is more accurate then putting immediate users from Ideal Graph. |
|
1171 |
for (uint e = 0; e < ptn->edge_count(); e++) { |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1172 |
Node *use = ptnode_adr(ptn->edge_target(e))->_node; |
589 | 1173 |
assert(ptn->edge_type(e) == PointsToNode::FieldEdge && use->is_AddP(), |
1174 |
"only AddP nodes are Field edges in CG"); |
|
1175 |
if (use->outcnt() > 0) { // Don't process dead nodes |
|
1176 |
Node* addp2 = find_second_addp(use, use->in(AddPNode::Base)); |
|
1177 |
if (addp2 != NULL) { |
|
1178 |
assert(alloc->is_AllocateArray(),"array allocation was expected"); |
|
1179 |
alloc_worklist.append_if_missing(addp2); |
|
1180 |
} |
|
1181 |
alloc_worklist.append_if_missing(use); |
|
1182 |
} |
|
1183 |
} |
|
1184 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1185 |
// An allocation may have an Initialize which has raw stores. Scan |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1186 |
// the users of the raw allocation result and push AddP users |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1187 |
// on alloc_worklist. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1188 |
Node *raw_result = alloc->proj_out(TypeFunc::Parms); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1189 |
assert (raw_result != NULL, "must have an allocation result"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1190 |
for (DUIterator_Fast imax, i = raw_result->fast_outs(imax); i < imax; i++) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1191 |
Node *use = raw_result->fast_out(i); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1192 |
if (use->is_AddP() && use->outcnt() > 0) { // Don't process dead nodes |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1193 |
Node* addp2 = find_second_addp(use, raw_result); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1194 |
if (addp2 != NULL) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1195 |
assert(alloc->is_AllocateArray(),"array allocation was expected"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1196 |
alloc_worklist.append_if_missing(addp2); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1197 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1198 |
alloc_worklist.append_if_missing(use); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1199 |
} else if (use->is_MemBar()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1200 |
memnode_worklist.append_if_missing(use); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1201 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1202 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1203 |
} |
1 | 1204 |
} else if (n->is_AddP()) { |
8319 | 1205 |
VectorSet* ptset = PointsTo(get_addp_base(n)); |
1206 |
assert(ptset->Size() == 1, "AddP address is unique"); |
|
1207 |
uint elem = ptset->getelem(); // Allocation node's index |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1208 |
if (elem == _phantom_object) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1209 |
assert(false, "escaped allocation"); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1210 |
continue; // Assume the value was set outside this method. |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1211 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1212 |
Node *base = get_map(elem); // CheckCastPP node |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1213 |
if (!split_AddP(n, base, igvn)) continue; // wrong type from dead path |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1214 |
tinst = igvn->type(base)->isa_oopptr(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1215 |
} else if (n->is_Phi() || |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1216 |
n->is_CheckCastPP() || |
594
9f4474e5dbaf
6705887: Compressed Oops: generate x64 addressing and implicit null checks with narrow oops
kvn
parents:
590
diff
changeset
|
1217 |
n->is_EncodeP() || |
9f4474e5dbaf
6705887: Compressed Oops: generate x64 addressing and implicit null checks with narrow oops
kvn
parents:
590
diff
changeset
|
1218 |
n->is_DecodeN() || |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1219 |
(n->is_ConstraintCast() && n->Opcode() == Op_CastPP)) { |
1 | 1220 |
if (visited.test_set(n->_idx)) { |
1221 |
assert(n->is_Phi(), "loops only through Phi's"); |
|
1222 |
continue; // already processed |
|
1223 |
} |
|
8319 | 1224 |
VectorSet* ptset = PointsTo(n); |
1225 |
if (ptset->Size() == 1) { |
|
1226 |
uint elem = ptset->getelem(); // Allocation node's index |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1227 |
if (elem == _phantom_object) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1228 |
assert(false, "escaped allocation"); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1229 |
continue; // Assume the value was set outside this method. |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1230 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1231 |
Node *val = get_map(elem); // CheckCastPP node |
1 | 1232 |
TypeNode *tn = n->as_Type(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1233 |
tinst = igvn->type(val)->isa_oopptr(); |
769 | 1234 |
assert(tinst != NULL && tinst->is_known_instance() && |
1235 |
(uint)tinst->instance_id() == elem , "instance type expected."); |
|
589 | 1236 |
|
1237 |
const Type *tn_type = igvn->type(tn); |
|
769 | 1238 |
const TypeOopPtr *tn_t; |
1239 |
if (tn_type->isa_narrowoop()) { |
|
1240 |
tn_t = tn_type->make_ptr()->isa_oopptr(); |
|
1241 |
} else { |
|
1242 |
tn_t = tn_type->isa_oopptr(); |
|
1243 |
} |
|
1 | 1244 |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1245 |
if (tn_t != NULL && tinst->klass()->is_subtype_of(tn_t->klass())) { |
589 | 1246 |
if (tn_type->isa_narrowoop()) { |
1247 |
tn_type = tinst->make_narrowoop(); |
|
1248 |
} else { |
|
1249 |
tn_type = tinst; |
|
1250 |
} |
|
1 | 1251 |
igvn->hash_delete(tn); |
589 | 1252 |
igvn->set_type(tn, tn_type); |
1253 |
tn->set_type(tn_type); |
|
1 | 1254 |
igvn->hash_insert(tn); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1255 |
record_for_optimizer(n); |
1055
f4fb9fb08038
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
961
diff
changeset
|
1256 |
} else { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1257 |
assert(tn_type == TypePtr::NULL_PTR || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1258 |
tn_t != NULL && !tinst->klass()->is_subtype_of(tn_t->klass()), |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1259 |
"unexpected type"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1260 |
continue; // Skip dead path with different type |
1 | 1261 |
} |
1262 |
} |
|
1263 |
} else { |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1264 |
debug_only(n->dump();) |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1265 |
assert(false, "EA: unexpected node"); |
1 | 1266 |
continue; |
1267 |
} |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1268 |
// push allocation's users on appropriate worklist |
1 | 1269 |
for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { |
1270 |
Node *use = n->fast_out(i); |
|
1271 |
if(use->is_Mem() && use->in(MemNode::Address) == n) { |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1272 |
// Load/store to instance's field |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1273 |
memnode_worklist.append_if_missing(use); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1274 |
} else if (use->is_MemBar()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1275 |
memnode_worklist.append_if_missing(use); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1276 |
} else if (use->is_AddP() && use->outcnt() > 0) { // No dead nodes |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1277 |
Node* addp2 = find_second_addp(use, n); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1278 |
if (addp2 != NULL) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1279 |
alloc_worklist.append_if_missing(addp2); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1280 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1281 |
alloc_worklist.append_if_missing(use); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1282 |
} else if (use->is_Phi() || |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1283 |
use->is_CheckCastPP() || |
594
9f4474e5dbaf
6705887: Compressed Oops: generate x64 addressing and implicit null checks with narrow oops
kvn
parents:
590
diff
changeset
|
1284 |
use->is_EncodeP() || |
9f4474e5dbaf
6705887: Compressed Oops: generate x64 addressing and implicit null checks with narrow oops
kvn
parents:
590
diff
changeset
|
1285 |
use->is_DecodeN() || |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1286 |
(use->is_ConstraintCast() && use->Opcode() == Op_CastPP)) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1287 |
alloc_worklist.append_if_missing(use); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1288 |
#ifdef ASSERT |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1289 |
} else if (use->is_Mem()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1290 |
assert(use->in(MemNode::Address) != n, "EA: missing allocation reference path"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1291 |
} else if (use->is_MergeMem()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1292 |
assert(_mergemem_worklist.contains(use->as_MergeMem()), "EA: missing MergeMem node in the worklist"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1293 |
} else if (use->is_SafePoint()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1294 |
// Look for MergeMem nodes for calls which reference unique allocation |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1295 |
// (through CheckCastPP nodes) even for debug info. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1296 |
Node* m = use->in(TypeFunc::Memory); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1297 |
if (m->is_MergeMem()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1298 |
assert(_mergemem_worklist.contains(m->as_MergeMem()), "EA: missing MergeMem node in the worklist"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1299 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1300 |
} else { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1301 |
uint op = use->Opcode(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1302 |
if (!(op == Op_CmpP || op == Op_Conv2B || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1303 |
op == Op_CastP2X || op == Op_StoreCM || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1304 |
op == Op_FastLock || op == Op_AryEq || op == Op_StrComp || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1305 |
op == Op_StrEquals || op == Op_StrIndexOf)) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1306 |
n->dump(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1307 |
use->dump(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1308 |
assert(false, "EA: missing allocation reference path"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1309 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1310 |
#endif |
1 | 1311 |
} |
1312 |
} |
|
1313 |
||
1314 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1315 |
// New alias types were created in split_AddP(). |
1 | 1316 |
uint new_index_end = (uint) _compile->num_alias_types(); |
1317 |
||
1318 |
// Phase 2: Process MemNode's from memnode_worklist. compute new address type and |
|
1319 |
// compute new values for Memory inputs (the Memory inputs are not |
|
1320 |
// actually updated until phase 4.) |
|
1321 |
if (memnode_worklist.length() == 0) |
|
1322 |
return; // nothing to do |
|
1323 |
||
1324 |
while (memnode_worklist.length() != 0) { |
|
1325 |
Node *n = memnode_worklist.pop(); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1326 |
if (visited.test_set(n->_idx)) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1327 |
continue; |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1328 |
if (n->is_Phi() || n->is_ClearArray()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1329 |
// we don't need to do anything, but the users must be pushed |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1330 |
} else if (n->is_MemBar()) { // Initialize, MemBar nodes |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1331 |
// we don't need to do anything, but the users must be pushed |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1332 |
n = n->as_MemBar()->proj_out(TypeFunc::Memory); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1333 |
if (n == NULL) |
1 | 1334 |
continue; |
1335 |
} else { |
|
1336 |
assert(n->is_Mem(), "memory node required."); |
|
1337 |
Node *addr = n->in(MemNode::Address); |
|
1338 |
const Type *addr_t = igvn->type(addr); |
|
1339 |
if (addr_t == Type::TOP) |
|
1340 |
continue; |
|
1341 |
assert (addr_t->isa_ptr() != NULL, "pointer type required."); |
|
1342 |
int alias_idx = _compile->get_alias_index(addr_t->is_ptr()); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1343 |
assert ((uint)alias_idx < new_index_end, "wrong alias index"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1344 |
Node *mem = find_inst_mem(n->in(MemNode::Memory), alias_idx, orig_phis, igvn); |
211
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
1345 |
if (_compile->failing()) { |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
1346 |
return; |
e2b60448c234
6667610: (Escape Analysis) retry compilation without EA if it fails
kvn
parents:
1
diff
changeset
|
1347 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1348 |
if (mem != n->in(MemNode::Memory)) { |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1349 |
// We delay the memory edge update since we need old one in |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1350 |
// MergeMem code below when instances memory slices are separated. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1351 |
debug_only(Node* pn = ptnode_adr(n->_idx)->_node;) |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1352 |
assert(pn == NULL || pn == n, "wrong node"); |
1 | 1353 |
set_map(n->_idx, mem); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1354 |
ptnode_adr(n->_idx)->_node = n; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1355 |
} |
1 | 1356 |
if (n->is_Load()) { |
1357 |
continue; // don't push users |
|
1358 |
} else if (n->is_LoadStore()) { |
|
1359 |
// get the memory projection |
|
1360 |
for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { |
|
1361 |
Node *use = n->fast_out(i); |
|
1362 |
if (use->Opcode() == Op_SCMemProj) { |
|
1363 |
n = use; |
|
1364 |
break; |
|
1365 |
} |
|
1366 |
} |
|
1367 |
assert(n->Opcode() == Op_SCMemProj, "memory projection required"); |
|
1368 |
} |
|
1369 |
} |
|
1370 |
// push user on appropriate worklist |
|
1371 |
for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { |
|
1372 |
Node *use = n->fast_out(i); |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1373 |
if (use->is_Phi() || use->is_ClearArray()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1374 |
memnode_worklist.append_if_missing(use); |
1 | 1375 |
} else if(use->is_Mem() && use->in(MemNode::Memory) == n) { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1376 |
if (use->Opcode() == Op_StoreCM) // Ignore cardmark stores |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1377 |
continue; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1378 |
memnode_worklist.append_if_missing(use); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1379 |
} else if (use->is_MemBar()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1380 |
memnode_worklist.append_if_missing(use); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1381 |
#ifdef ASSERT |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1382 |
} else if(use->is_Mem()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1383 |
assert(use->in(MemNode::Memory) != n, "EA: missing memory path"); |
1 | 1384 |
} else if (use->is_MergeMem()) { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1385 |
assert(_mergemem_worklist.contains(use->as_MergeMem()), "EA: missing MergeMem node in the worklist"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1386 |
} else { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1387 |
uint op = use->Opcode(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1388 |
if (!(op == Op_StoreCM || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1389 |
(op == Op_CallLeaf && use->as_CallLeaf()->_name != NULL && |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1390 |
strcmp(use->as_CallLeaf()->_name, "g1_wb_pre") == 0) || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1391 |
op == Op_AryEq || op == Op_StrComp || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1392 |
op == Op_StrEquals || op == Op_StrIndexOf)) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1393 |
n->dump(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1394 |
use->dump(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1395 |
assert(false, "EA: missing memory path"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1396 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1397 |
#endif |
1 | 1398 |
} |
1399 |
} |
|
1400 |
} |
|
1401 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1402 |
// Phase 3: Process MergeMem nodes from mergemem_worklist. |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1403 |
// Walk each memory slice moving the first node encountered of each |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1404 |
// instance type to the the input corresponding to its alias index. |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1405 |
uint length = _mergemem_worklist.length(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1406 |
for( uint next = 0; next < length; ++next ) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1407 |
MergeMemNode* nmm = _mergemem_worklist.at(next); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1408 |
assert(!visited.test_set(nmm->_idx), "should not be visited before"); |
1 | 1409 |
// Note: we don't want to use MergeMemStream here because we only want to |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1410 |
// scan inputs which exist at the start, not ones we add during processing. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1411 |
// Note 2: MergeMem may already contains instance memory slices added |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1412 |
// during find_inst_mem() call when memory nodes were processed above. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1413 |
igvn->hash_delete(nmm); |
1 | 1414 |
uint nslices = nmm->req(); |
1415 |
for (uint i = Compile::AliasIdxRaw+1; i < nslices; i++) { |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1416 |
Node* mem = nmm->in(i); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1417 |
Node* cur = NULL; |
1 | 1418 |
if (mem == NULL || mem->is_top()) |
1419 |
continue; |
|
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1420 |
// First, update mergemem by moving memory nodes to corresponding slices |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1421 |
// if their type became more precise since this mergemem was created. |
1 | 1422 |
while (mem->is_Mem()) { |
1423 |
const Type *at = igvn->type(mem->in(MemNode::Address)); |
|
1424 |
if (at != Type::TOP) { |
|
1425 |
assert (at->isa_ptr() != NULL, "pointer type required."); |
|
1426 |
uint idx = (uint)_compile->get_alias_index(at->is_ptr()); |
|
1427 |
if (idx == i) { |
|
1428 |
if (cur == NULL) |
|
1429 |
cur = mem; |
|
1430 |
} else { |
|
1431 |
if (idx >= nmm->req() || nmm->is_empty_memory(nmm->in(idx))) { |
|
1432 |
nmm->set_memory_at(idx, mem); |
|
1433 |
} |
|
1434 |
} |
|
1435 |
} |
|
1436 |
mem = mem->in(MemNode::Memory); |
|
1437 |
} |
|
1438 |
nmm->set_memory_at(i, (cur != NULL) ? cur : mem); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1439 |
// Find any instance of the current type if we haven't encountered |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1440 |
// already a memory slice of the instance along the memory chain. |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1441 |
for (uint ni = new_index_start; ni < new_index_end; ni++) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1442 |
if((uint)_compile->get_general_index(ni) == i) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1443 |
Node *m = (ni >= nmm->req()) ? nmm->empty_memory() : nmm->in(ni); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1444 |
if (nmm->is_empty_memory(m)) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1445 |
Node* result = find_inst_mem(mem, ni, orig_phis, igvn); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1446 |
if (_compile->failing()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1447 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1448 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1449 |
nmm->set_memory_at(ni, result); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1450 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1451 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1452 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1453 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1454 |
// Find the rest of instances values |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1455 |
for (uint ni = new_index_start; ni < new_index_end; ni++) { |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1456 |
const TypeOopPtr *tinst = _compile->get_adr_type(ni)->isa_oopptr(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1457 |
Node* result = step_through_mergemem(nmm, ni, tinst); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1458 |
if (result == nmm->base_memory()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1459 |
// Didn't find instance memory, search through general slice recursively. |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1460 |
result = nmm->memory_at(_compile->get_general_index(ni)); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1461 |
result = find_inst_mem(result, ni, orig_phis, igvn); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1462 |
if (_compile->failing()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1463 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1464 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1465 |
nmm->set_memory_at(ni, result); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1466 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1467 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1468 |
igvn->hash_insert(nmm); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1469 |
record_for_optimizer(nmm); |
1 | 1470 |
} |
1471 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1472 |
// Phase 4: Update the inputs of non-instance memory Phis and |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1473 |
// the Memory input of memnodes |
1 | 1474 |
// First update the inputs of any non-instance Phi's from |
1475 |
// which we split out an instance Phi. Note we don't have |
|
1476 |
// to recursively process Phi's encounted on the input memory |
|
1477 |
// chains as is done in split_memory_phi() since they will |
|
1478 |
// also be processed here. |
|
955 | 1479 |
for (int j = 0; j < orig_phis.length(); j++) { |
1480 |
PhiNode *phi = orig_phis.at(j); |
|
1 | 1481 |
int alias_idx = _compile->get_alias_index(phi->adr_type()); |
1482 |
igvn->hash_delete(phi); |
|
1483 |
for (uint i = 1; i < phi->req(); i++) { |
|
1484 |
Node *mem = phi->in(i); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1485 |
Node *new_mem = find_inst_mem(mem, alias_idx, orig_phis, igvn); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1486 |
if (_compile->failing()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1487 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1488 |
} |
1 | 1489 |
if (mem != new_mem) { |
1490 |
phi->set_req(i, new_mem); |
|
1491 |
} |
|
1492 |
} |
|
1493 |
igvn->hash_insert(phi); |
|
1494 |
record_for_optimizer(phi); |
|
1495 |
} |
|
1496 |
||
1497 |
// Update the memory inputs of MemNodes with the value we computed |
|
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1498 |
// in Phase 2 and move stores memory users to corresponding memory slices. |
9327
23532ae85295
7026700: regression in 6u24-rev-b23: Crash in C2 compiler in PhaseIdealLoop::build_loop_late_post
kvn
parents:
9115
diff
changeset
|
1499 |
|
23532ae85295
7026700: regression in 6u24-rev-b23: Crash in C2 compiler in PhaseIdealLoop::build_loop_late_post
kvn
parents:
9115
diff
changeset
|
1500 |
// Disable memory split verification code until the fix for 6984348. |
23532ae85295
7026700: regression in 6u24-rev-b23: Crash in C2 compiler in PhaseIdealLoop::build_loop_late_post
kvn
parents:
9115
diff
changeset
|
1501 |
// Currently it produces false negative results since it does not cover all cases. |
23532ae85295
7026700: regression in 6u24-rev-b23: Crash in C2 compiler in PhaseIdealLoop::build_loop_late_post
kvn
parents:
9115
diff
changeset
|
1502 |
#if 0 // ifdef ASSERT |
8319 | 1503 |
visited.Reset(); |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1504 |
Node_Stack old_mems(arena, _compile->unique() >> 2); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1505 |
#endif |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1506 |
for (uint i = 0; i < nodes_size(); i++) { |
1 | 1507 |
Node *nmem = get_map(i); |
1508 |
if (nmem != NULL) { |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1509 |
Node *n = ptnode_adr(i)->_node; |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1510 |
assert(n != NULL, "sanity"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1511 |
if (n->is_Mem()) { |
9327
23532ae85295
7026700: regression in 6u24-rev-b23: Crash in C2 compiler in PhaseIdealLoop::build_loop_late_post
kvn
parents:
9115
diff
changeset
|
1512 |
#if 0 // ifdef ASSERT |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1513 |
Node* old_mem = n->in(MemNode::Memory); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1514 |
if (!visited.test_set(old_mem->_idx)) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1515 |
old_mems.push(old_mem, old_mem->outcnt()); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1516 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1517 |
#endif |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1518 |
assert(n->in(MemNode::Memory) != nmem, "sanity"); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1519 |
if (!n->is_Load()) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1520 |
// Move memory users of a store first. |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1521 |
move_inst_mem(n, orig_phis, igvn); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1522 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1523 |
// Now update memory input |
1 | 1524 |
igvn->hash_delete(n); |
1525 |
n->set_req(MemNode::Memory, nmem); |
|
1526 |
igvn->hash_insert(n); |
|
1527 |
record_for_optimizer(n); |
|
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1528 |
} else { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1529 |
assert(n->is_Allocate() || n->is_CheckCastPP() || |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1530 |
n->is_AddP() || n->is_Phi(), "unknown node used for set_map()"); |
1 | 1531 |
} |
1532 |
} |
|
1533 |
} |
|
9327
23532ae85295
7026700: regression in 6u24-rev-b23: Crash in C2 compiler in PhaseIdealLoop::build_loop_late_post
kvn
parents:
9115
diff
changeset
|
1534 |
#if 0 // ifdef ASSERT |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1535 |
// Verify that memory was split correctly |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1536 |
while (old_mems.is_nonempty()) { |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1537 |
Node* old_mem = old_mems.node(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1538 |
uint old_cnt = old_mems.index(); |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1539 |
old_mems.pop(); |
9327
23532ae85295
7026700: regression in 6u24-rev-b23: Crash in C2 compiler in PhaseIdealLoop::build_loop_late_post
kvn
parents:
9115
diff
changeset
|
1540 |
assert(old_cnt == old_mem->outcnt(), "old mem could be lost"); |
4471
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1541 |
} |
78c7cc2ae5dd
6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
kvn
parents:
4470
diff
changeset
|
1542 |
#endif |
1 | 1543 |
} |
1544 |
||
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1545 |
bool ConnectionGraph::has_candidates(Compile *C) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1546 |
// EA brings benefits only when the code has allocations and/or locks which |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1547 |
// are represented by ideal Macro nodes. |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1548 |
int cnt = C->macro_count(); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1549 |
for( int i=0; i < cnt; i++ ) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1550 |
Node *n = C->macro_node(i); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1551 |
if ( n->is_Allocate() ) |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1552 |
return true; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1553 |
if( n->is_Lock() ) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1554 |
Node* obj = n->as_Lock()->obj_node()->uncast(); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1555 |
if( !(obj->is_Parm() || obj->is_Con()) ) |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1556 |
return true; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1557 |
} |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1558 |
} |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1559 |
return false; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1560 |
} |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1561 |
|
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1562 |
void ConnectionGraph::do_analysis(Compile *C, PhaseIterGVN *igvn) { |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1563 |
// Add ConP#NULL and ConN#NULL nodes before ConnectionGraph construction |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1564 |
// to create space for them in ConnectionGraph::_nodes[]. |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1565 |
Node* oop_null = igvn->zerocon(T_OBJECT); |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1566 |
Node* noop_null = igvn->zerocon(T_NARROWOOP); |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1567 |
|
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1568 |
ConnectionGraph* congraph = new(C->comp_arena()) ConnectionGraph(C, igvn); |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1569 |
// Perform escape analysis |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1570 |
if (congraph->compute_escape()) { |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1571 |
// There are non escaping objects. |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1572 |
C->set_congraph(congraph); |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1573 |
} |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1574 |
|
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1575 |
// Cleanup. |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1576 |
if (oop_null->outcnt() == 0) |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1577 |
igvn->hash_delete(oop_null); |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1578 |
if (noop_null->outcnt() == 0) |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1579 |
igvn->hash_delete(noop_null); |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1580 |
} |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1581 |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1582 |
bool ConnectionGraph::compute_escape() { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1583 |
Compile* C = _compile; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1584 |
|
589 | 1585 |
// 1. Populate Connection Graph (CG) with Ideal nodes. |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1586 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1587 |
Unique_Node_List worklist_init; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1588 |
worklist_init.map(C->unique(), NULL); // preallocate space |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1589 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1590 |
// Initialize worklist |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1591 |
if (C->root() != NULL) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1592 |
worklist_init.push(C->root()); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1593 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1594 |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1595 |
GrowableArray<Node*> alloc_worklist; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1596 |
GrowableArray<Node*> addp_worklist; |
11189 | 1597 |
GrowableArray<Node*> ptr_cmp_worklist; |
11431
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1598 |
GrowableArray<Node*> storestore_worklist; |
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1599 |
PhaseGVN* igvn = _igvn; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1600 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1601 |
// Push all useful nodes onto CG list and set their type. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1602 |
for( uint next = 0; next < worklist_init.size(); ++next ) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1603 |
Node* n = worklist_init.at(next); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1604 |
record_for_escape_analysis(n, igvn); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1605 |
// Only allocations and java static calls results are checked |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1606 |
// for an escape status. See process_call_result() below. |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1607 |
if (n->is_Allocate() || n->is_CallStaticJava() && |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1608 |
ptnode_adr(n->_idx)->node_type() == PointsToNode::JavaObject) { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1609 |
alloc_worklist.append(n); |
11189 | 1610 |
} else if(n->is_AddP()) { |
7122 | 1611 |
// Collect address nodes. Use them during stage 3 below |
1612 |
// to build initial connection graph field edges. |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1613 |
addp_worklist.append(n); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1614 |
} else if (n->is_MergeMem()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1615 |
// Collect all MergeMem nodes to add memory slices for |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1616 |
// scalar replaceable objects in split_unique_types(). |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1617 |
_mergemem_worklist.append(n->as_MergeMem()); |
11189 | 1618 |
} else if (OptimizePtrCompare && n->is_Cmp() && |
1619 |
(n->Opcode() == Op_CmpP || n->Opcode() == Op_CmpN)) { |
|
1620 |
// Compare pointers nodes |
|
1621 |
ptr_cmp_worklist.append(n); |
|
11431
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1622 |
} else if (n->is_MemBarStoreStore()) { |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1623 |
// Collect all MemBarStoreStore nodes so that depending on the |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1624 |
// escape status of the associated Allocate node some of them |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1625 |
// may be eliminated. |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1626 |
storestore_worklist.append(n); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1627 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1628 |
for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1629 |
Node* m = n->fast_out(i); // Get user |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1630 |
worklist_init.push(m); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1631 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1632 |
} |
1 | 1633 |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1634 |
if (alloc_worklist.length() == 0) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1635 |
_collecting = false; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1636 |
return false; // Nothing to do. |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1637 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1638 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1639 |
// 2. First pass to create simple CG edges (doesn't require to walk CG). |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1640 |
uint delayed_size = _delayed_worklist.size(); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1641 |
for( uint next = 0; next < delayed_size; ++next ) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1642 |
Node* n = _delayed_worklist.at(next); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1643 |
build_connection_graph(n, igvn); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1644 |
} |
1 | 1645 |
|
7122 | 1646 |
// 3. Pass to create initial fields edges (JavaObject -F-> AddP) |
1647 |
// to reduce number of iterations during stage 4 below. |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1648 |
uint addp_length = addp_worklist.length(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1649 |
for( uint next = 0; next < addp_length; ++next ) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1650 |
Node* n = addp_worklist.at(next); |
7122 | 1651 |
Node* base = get_addp_base(n); |
11189 | 1652 |
if (base->is_Proj() && base->in(0)->is_Call()) |
7122 | 1653 |
base = base->in(0); |
1654 |
PointsToNode::NodeType nt = ptnode_adr(base->_idx)->node_type(); |
|
1655 |
if (nt == PointsToNode::JavaObject) { |
|
1656 |
build_connection_graph(n, igvn); |
|
1657 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1658 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1659 |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1660 |
GrowableArray<int> cg_worklist; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1661 |
cg_worklist.append(_phantom_object); |
7122 | 1662 |
GrowableArray<uint> worklist; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1663 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1664 |
// 4. Build Connection Graph which need |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1665 |
// to walk the connection graph. |
7122 | 1666 |
_progress = false; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1667 |
for (uint ni = 0; ni < nodes_size(); ni++) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1668 |
PointsToNode* ptn = ptnode_adr(ni); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1669 |
Node *n = ptn->_node; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1670 |
if (n != NULL) { // Call, AddP, LoadP, StoreP |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1671 |
build_connection_graph(n, igvn); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1672 |
if (ptn->node_type() != PointsToNode::UnknownType) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1673 |
cg_worklist.append(n->_idx); // Collect CG nodes |
7122 | 1674 |
if (!_processed.test(n->_idx)) |
1675 |
worklist.append(n->_idx); // Collect C/A/L/S nodes |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1676 |
} |
1 | 1677 |
} |
1678 |
||
7122 | 1679 |
// After IGVN user nodes may have smaller _idx than |
1680 |
// their inputs so they will be processed first in |
|
1681 |
// previous loop. Because of that not all Graph |
|
1682 |
// edges will be created. Walk over interesting |
|
1683 |
// nodes again until no new edges are created. |
|
1684 |
// |
|
1685 |
// Normally only 1-3 passes needed to build |
|
1686 |
// Connection Graph depending on graph complexity. |
|
7710
f2503940a87b
7003130: assert(iterations<CG_BUILD_ITER_LIMIT) failed: infinite EA connection graph
kvn
parents:
7397
diff
changeset
|
1687 |
// Observed 8 passes in jvm2008 compiler.compiler. |
f2503940a87b
7003130: assert(iterations<CG_BUILD_ITER_LIMIT) failed: infinite EA connection graph
kvn
parents:
7397
diff
changeset
|
1688 |
// Set limit to 20 to catch situation when something |
7122 | 1689 |
// did go wrong and recompile the method without EA. |
1690 |
||
7710
f2503940a87b
7003130: assert(iterations<CG_BUILD_ITER_LIMIT) failed: infinite EA connection graph
kvn
parents:
7397
diff
changeset
|
1691 |
#define CG_BUILD_ITER_LIMIT 20 |
7122 | 1692 |
|
1693 |
uint length = worklist.length(); |
|
1694 |
int iterations = 0; |
|
1695 |
while(_progress && (iterations++ < CG_BUILD_ITER_LIMIT)) { |
|
1696 |
_progress = false; |
|
1697 |
for( uint next = 0; next < length; ++next ) { |
|
1698 |
int ni = worklist.at(next); |
|
1699 |
PointsToNode* ptn = ptnode_adr(ni); |
|
1700 |
Node* n = ptn->_node; |
|
1701 |
assert(n != NULL, "should be known node"); |
|
1702 |
build_connection_graph(n, igvn); |
|
1703 |
} |
|
1704 |
} |
|
1705 |
if (iterations >= CG_BUILD_ITER_LIMIT) { |
|
1706 |
assert(iterations < CG_BUILD_ITER_LIMIT, |
|
1707 |
err_msg("infinite EA connection graph build with %d nodes and worklist size %d", |
|
1708 |
nodes_size(), length)); |
|
1709 |
// Possible infinite build_connection_graph loop, |
|
1710 |
// retry compilation without escape analysis. |
|
1711 |
C->record_failure(C2Compiler::retry_no_escape_analysis()); |
|
1712 |
_collecting = false; |
|
1713 |
return false; |
|
1714 |
} |
|
1715 |
#undef CG_BUILD_ITER_LIMIT |
|
1716 |
||
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1717 |
// 5. Propagate escaped states. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1718 |
worklist.clear(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1719 |
|
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1720 |
// mark all nodes reachable from GlobalEscape nodes |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1721 |
(void)propagate_escape_state(&cg_worklist, &worklist, PointsToNode::GlobalEscape); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1722 |
|
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1723 |
// mark all nodes reachable from ArgEscape nodes |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1724 |
bool has_non_escaping_obj = propagate_escape_state(&cg_worklist, &worklist, PointsToNode::ArgEscape); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1725 |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1726 |
Arena* arena = Thread::current()->resource_area(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1727 |
VectorSet visited(arena); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1728 |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1729 |
// 6. Find fields initializing values for not escaped allocations |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1730 |
uint alloc_length = alloc_worklist.length(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1731 |
for (uint next = 0; next < alloc_length; ++next) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1732 |
Node* n = alloc_worklist.at(next); |
11431
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1733 |
PointsToNode::EscapeState es = ptnode_adr(n->_idx)->escape_state(); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1734 |
if (es == PointsToNode::NoEscape) { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1735 |
has_non_escaping_obj = true; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1736 |
if (n->is_Allocate()) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1737 |
find_init_values(n, &visited, igvn); |
11431
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1738 |
// The object allocated by this Allocate node will never be |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1739 |
// seen by an other thread. Mark it so that when it is |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1740 |
// expanded no MemBarStoreStore is added. |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1741 |
n->as_Allocate()->initialization()->set_does_not_escape(); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1742 |
} |
11431
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1743 |
} else if ((es == PointsToNode::ArgEscape) && n->is_Allocate()) { |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1744 |
// Same as above. Mark this Allocate node so that when it is |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1745 |
// expanded no MemBarStoreStore is added. |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1746 |
n->as_Allocate()->initialization()->set_does_not_escape(); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1747 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1748 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1749 |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1750 |
uint cg_length = cg_worklist.length(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1751 |
|
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1752 |
// Skip the rest of code if all objects escaped. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1753 |
if (!has_non_escaping_obj) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1754 |
cg_length = 0; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1755 |
addp_length = 0; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1756 |
} |
1 | 1757 |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1758 |
for (uint next = 0; next < cg_length; ++next) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1759 |
int ni = cg_worklist.at(next); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1760 |
PointsToNode* ptn = ptnode_adr(ni); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1761 |
PointsToNode::NodeType nt = ptn->node_type(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1762 |
if (nt == PointsToNode::LocalVar || nt == PointsToNode::Field) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1763 |
if (ptn->edge_count() == 0) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1764 |
// No values were found. Assume the value was set |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1765 |
// outside this method - add edge to phantom object. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1766 |
add_pointsto_edge(ni, _phantom_object); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1767 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1768 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1769 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1770 |
|
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1771 |
// 7. Remove deferred edges from the graph. |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1772 |
for (uint next = 0; next < cg_length; ++next) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1773 |
int ni = cg_worklist.at(next); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1774 |
PointsToNode* ptn = ptnode_adr(ni); |
1 | 1775 |
PointsToNode::NodeType nt = ptn->node_type(); |
1776 |
if (nt == PointsToNode::LocalVar || nt == PointsToNode::Field) { |
|
7122 | 1777 |
remove_deferred(ni, &worklist, &visited); |
1 | 1778 |
} |
1779 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1780 |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1781 |
// 8. Adjust escape state of nonescaping objects. |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1782 |
for (uint next = 0; next < addp_length; ++next) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1783 |
Node* n = addp_worklist.at(next); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1784 |
adjust_escape_state(n); |
1 | 1785 |
} |
1786 |
||
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1787 |
// push all NoEscape nodes on the worklist |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1788 |
worklist.clear(); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1789 |
for( uint next = 0; next < cg_length; ++next ) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1790 |
int nk = cg_worklist.at(next); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1791 |
if (ptnode_adr(nk)->escape_state() == PointsToNode::NoEscape && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1792 |
!is_null_ptr(nk)) |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1793 |
worklist.push(nk); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1794 |
} |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1795 |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1796 |
alloc_worklist.clear(); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1797 |
// Propagate scalar_replaceable value. |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1798 |
while(worklist.length() > 0) { |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
1799 |
uint nk = worklist.pop(); |
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
1800 |
PointsToNode* ptn = ptnode_adr(nk); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1801 |
Node* n = ptn->_node; |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1802 |
bool scalar_replaceable = ptn->scalar_replaceable(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1803 |
if (n->is_Allocate() && scalar_replaceable) { |
2131 | 1804 |
// Push scalar replaceable allocations on alloc_worklist |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1805 |
// for processing in split_unique_types(). Note, |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1806 |
// following code may change scalar_replaceable value. |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1807 |
alloc_worklist.append(n); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1808 |
} |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1809 |
uint e_cnt = ptn->edge_count(); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1810 |
for (uint ei = 0; ei < e_cnt; ei++) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1811 |
uint npi = ptn->edge_target(ei); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1812 |
if (is_null_ptr(npi)) |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1813 |
continue; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1814 |
PointsToNode *np = ptnode_adr(npi); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1815 |
if (np->escape_state() < PointsToNode::NoEscape) { |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
1816 |
set_escape_state(npi, PointsToNode::NoEscape); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1817 |
if (!scalar_replaceable) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1818 |
np->set_scalar_replaceable(false); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1819 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1820 |
worklist.push(npi); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1821 |
} else if (np->scalar_replaceable() && !scalar_replaceable) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1822 |
np->set_scalar_replaceable(false); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1823 |
worklist.push(npi); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1824 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1825 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1826 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1827 |
|
1 | 1828 |
_collecting = false; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1829 |
assert(C->unique() == nodes_size(), "there should be no new ideal nodes during ConnectionGraph build"); |
1 | 1830 |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1831 |
assert(ptnode_adr(_oop_null)->escape_state() == PointsToNode::NoEscape && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1832 |
ptnode_adr(_oop_null)->edge_count() == 0, "sanity"); |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
1833 |
if (UseCompressedOops) { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1834 |
assert(ptnode_adr(_noop_null)->escape_state() == PointsToNode::NoEscape && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1835 |
ptnode_adr(_noop_null)->edge_count() == 0, "sanity"); |
10970
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
1836 |
} |
3767212a2b7c
7059039: EA: don't change non-escaping state of NULL pointer
kvn
parents:
9977
diff
changeset
|
1837 |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1838 |
if (EliminateLocks && has_non_escaping_obj) { |
9977
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1839 |
// Mark locks before changing ideal graph. |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1840 |
int cnt = C->macro_count(); |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1841 |
for( int i=0; i < cnt; i++ ) { |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1842 |
Node *n = C->macro_node(i); |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1843 |
if (n->is_AbstractLock()) { // Lock and Unlock nodes |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1844 |
AbstractLockNode* alock = n->as_AbstractLock(); |
11191 | 1845 |
if (!alock->is_eliminated() || alock->is_coarsened()) { |
9977
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1846 |
PointsToNode::EscapeState es = escape_state(alock->obj_node()); |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1847 |
assert(es != PointsToNode::UnknownEscape, "should know"); |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1848 |
if (es != PointsToNode::UnknownEscape && es != PointsToNode::GlobalEscape) { |
11191 | 1849 |
if (!alock->is_eliminated()) { |
1850 |
// Mark it eliminated to update any counters |
|
1851 |
alock->set_eliminated(); |
|
1852 |
} else { |
|
1853 |
// The lock could be marked eliminated by lock coarsening |
|
1854 |
// code during first IGVN before EA. Clear coarsened flag |
|
1855 |
// to eliminate all associated locks/unlocks and relock |
|
1856 |
// during deoptimization. |
|
1857 |
alock->clear_coarsened(); |
|
1858 |
} |
|
9977
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1859 |
} |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1860 |
} |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1861 |
} |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1862 |
} |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1863 |
} |
c23d1a8dcaa9
7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity
kvn
parents:
9327
diff
changeset
|
1864 |
|
11189 | 1865 |
if (OptimizePtrCompare && has_non_escaping_obj) { |
1866 |
// Add ConI(#CC_GT) and ConI(#CC_EQ). |
|
1867 |
_pcmp_neq = igvn->makecon(TypeInt::CC_GT); |
|
1868 |
_pcmp_eq = igvn->makecon(TypeInt::CC_EQ); |
|
1869 |
// Optimize objects compare. |
|
1870 |
while (ptr_cmp_worklist.length() != 0) { |
|
1871 |
Node *n = ptr_cmp_worklist.pop(); |
|
1872 |
Node *res = optimize_ptr_compare(n); |
|
1873 |
if (res != NULL) { |
|
1874 |
#ifndef PRODUCT |
|
1875 |
if (PrintOptimizePtrCompare) { |
|
1876 |
tty->print_cr("++++ Replaced: %d %s(%d,%d) --> %s", n->_idx, (n->Opcode() == Op_CmpP ? "CmpP" : "CmpN"), n->in(1)->_idx, n->in(2)->_idx, (res == _pcmp_eq ? "EQ" : "NotEQ")); |
|
1877 |
if (Verbose) { |
|
1878 |
n->dump(1); |
|
1879 |
} |
|
1880 |
} |
|
1881 |
#endif |
|
1882 |
_igvn->replace_node(n, res); |
|
1883 |
} |
|
1884 |
} |
|
1885 |
// cleanup |
|
1886 |
if (_pcmp_neq->outcnt() == 0) |
|
1887 |
igvn->hash_delete(_pcmp_neq); |
|
1888 |
if (_pcmp_eq->outcnt() == 0) |
|
1889 |
igvn->hash_delete(_pcmp_eq); |
|
1890 |
} |
|
1891 |
||
11431
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1892 |
// For MemBarStoreStore nodes added in library_call.cpp, check |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1893 |
// escape status of associated AllocateNode and optimize out |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1894 |
// MemBarStoreStore node if the allocated object never escapes. |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1895 |
while (storestore_worklist.length() != 0) { |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1896 |
Node *n = storestore_worklist.pop(); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1897 |
MemBarStoreStoreNode *storestore = n ->as_MemBarStoreStore(); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1898 |
Node *alloc = storestore->in(MemBarNode::Precedent)->in(0); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1899 |
assert (alloc->is_Allocate(), "storestore should point to AllocateNode"); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1900 |
PointsToNode::EscapeState es = ptnode_adr(alloc->_idx)->escape_state(); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1901 |
if (es == PointsToNode::NoEscape || es == PointsToNode::ArgEscape) { |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1902 |
MemBarNode* mb = MemBarNode::make(C, Op_MemBarCPUOrder, Compile::AliasIdxBot); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1903 |
mb->init_req(TypeFunc::Memory, storestore->in(TypeFunc::Memory)); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1904 |
mb->init_req(TypeFunc::Control, storestore->in(TypeFunc::Control)); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1905 |
|
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1906 |
_igvn->register_new_node_with_optimizer(mb); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1907 |
_igvn->replace_node(storestore, mb); |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1908 |
} |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1909 |
} |
5ca3a19e559a
7121140: Allocation paths require explicit memory synchronization operations for RMO systems
roland
parents:
11198
diff
changeset
|
1910 |
|
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1911 |
#ifndef PRODUCT |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1912 |
if (PrintEscapeAnalysis) { |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1913 |
dump(); // Dump ConnectionGraph |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1914 |
} |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1915 |
#endif |
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
1916 |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1917 |
bool has_scalar_replaceable_candidates = false; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1918 |
alloc_length = alloc_worklist.length(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1919 |
for (uint next = 0; next < alloc_length; ++next) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1920 |
Node* n = alloc_worklist.at(next); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1921 |
PointsToNode* ptn = ptnode_adr(n->_idx); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1922 |
assert(ptn->escape_state() == PointsToNode::NoEscape, "sanity"); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1923 |
if (ptn->scalar_replaceable()) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1924 |
has_scalar_replaceable_candidates = true; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1925 |
break; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1926 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1927 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1928 |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1929 |
if ( has_scalar_replaceable_candidates && |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1930 |
C->AliasLevel() >= 3 && EliminateAllocations ) { |
1 | 1931 |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1932 |
// Now use the escape information to create unique types for |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1933 |
// scalar replaceable objects. |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1934 |
split_unique_types(alloc_worklist); |
1 | 1935 |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1936 |
if (C->failing()) return false; |
1 | 1937 |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1938 |
C->print_method("After Escape Analysis", 2); |
1 | 1939 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1940 |
#ifdef ASSERT |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1941 |
} else if (Verbose && (PrintEscapeAnalysis || PrintEliminateAllocations)) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1942 |
tty->print("=== No allocations eliminated for "); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1943 |
C->method()->print_short_name(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1944 |
if(!EliminateAllocations) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1945 |
tty->print(" since EliminateAllocations is off ==="); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1946 |
} else if(!has_scalar_replaceable_candidates) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1947 |
tty->print(" since there are no scalar replaceable candidates ==="); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1948 |
} else if(C->AliasLevel() < 3) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1949 |
tty->print(" since AliasLevel < 3 ==="); |
1 | 1950 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1951 |
tty->cr(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
1952 |
#endif |
1 | 1953 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
1954 |
return has_non_escaping_obj; |
1 | 1955 |
} |
1956 |
||
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1957 |
// Find fields initializing values for allocations. |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1958 |
void ConnectionGraph::find_init_values(Node* alloc, VectorSet* visited, PhaseTransform* phase) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1959 |
assert(alloc->is_Allocate(), "Should be called for Allocate nodes only"); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1960 |
PointsToNode* pta = ptnode_adr(alloc->_idx); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1961 |
assert(pta->escape_state() == PointsToNode::NoEscape, "Not escaped Allocate nodes only"); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1962 |
InitializeNode* ini = alloc->as_Allocate()->initialization(); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1963 |
|
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1964 |
Compile* C = _compile; |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1965 |
visited->Reset(); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1966 |
// Check if a oop field's initializing value is recorded and add |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1967 |
// a corresponding NULL field's value if it is not recorded. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1968 |
// Connection Graph does not record a default initialization by NULL |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1969 |
// captured by Initialize node. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1970 |
// |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1971 |
uint null_idx = UseCompressedOops ? _noop_null : _oop_null; |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1972 |
uint ae_cnt = pta->edge_count(); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1973 |
bool visited_bottom_offset = false; |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1974 |
for (uint ei = 0; ei < ae_cnt; ei++) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1975 |
uint nidx = pta->edge_target(ei); // Field (AddP) |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1976 |
PointsToNode* ptn = ptnode_adr(nidx); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1977 |
assert(ptn->_node->is_AddP(), "Should be AddP nodes only"); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1978 |
int offset = ptn->offset(); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1979 |
if (offset == Type::OffsetBot) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1980 |
if (!visited_bottom_offset) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1981 |
visited_bottom_offset = true; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1982 |
// Check only oop fields. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1983 |
const Type* adr_type = ptn->_node->as_AddP()->bottom_type(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1984 |
if (!adr_type->isa_aryptr() || |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1985 |
(adr_type->isa_aryptr()->klass() == NULL) || |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1986 |
adr_type->isa_aryptr()->klass()->is_obj_array_klass()) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1987 |
// OffsetBot is used to reference array's element, |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1988 |
// always add reference to NULL since we don't |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1989 |
// known which element is referenced. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1990 |
add_edge_from_fields(alloc->_idx, null_idx, offset); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1991 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1992 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1993 |
} else if (offset != oopDesc::klass_offset_in_bytes() && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
1994 |
!visited->test_set(offset)) { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1995 |
|
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1996 |
// Check only oop fields. |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
1997 |
const Type* adr_type = ptn->_node->as_AddP()->bottom_type(); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1998 |
BasicType basic_field_type = T_INT; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
1999 |
if (adr_type->isa_instptr()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2000 |
ciField* field = C->alias_type(adr_type->isa_instptr())->field(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2001 |
if (field != NULL) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2002 |
basic_field_type = field->layout_type(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2003 |
} else { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2004 |
// Ignore non field load (for example, klass load) |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2005 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2006 |
} else if (adr_type->isa_aryptr()) { |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2007 |
if (offset != arrayOopDesc::length_offset_in_bytes()) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2008 |
const Type* elemtype = adr_type->isa_aryptr()->elem(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2009 |
basic_field_type = elemtype->array_element_basic_type(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2010 |
} else { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2011 |
// Ignore array length load |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2012 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2013 |
#ifdef ASSERT |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2014 |
} else { |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2015 |
// Raw pointers are used for initializing stores so skip it |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2016 |
// since it should be recorded already |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2017 |
Node* base = get_addp_base(ptn->_node); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2018 |
assert(adr_type->isa_rawptr() && base->is_Proj() && |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2019 |
(base->in(0) == alloc),"unexpected pointer type"); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2020 |
#endif |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2021 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2022 |
if (basic_field_type == T_OBJECT || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2023 |
basic_field_type == T_NARROWOOP || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2024 |
basic_field_type == T_ARRAY) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2025 |
Node* value = NULL; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2026 |
if (ini != NULL) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2027 |
BasicType ft = UseCompressedOops ? T_NARROWOOP : T_OBJECT; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2028 |
Node* store = ini->find_captured_store(offset, type2aelembytes(ft), phase); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2029 |
if (store != NULL && store->is_Store()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2030 |
value = store->in(MemNode::ValueIn); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2031 |
} else if (ptn->edge_count() > 0) { // Are there oop stores? |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2032 |
// Check for a store which follows allocation without branches. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2033 |
// For example, a volatile field store is not collected |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2034 |
// by Initialize node. TODO: it would be nice to use idom() here. |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2035 |
// |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2036 |
// Search all references to the same field which use different |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2037 |
// AddP nodes, for example, in the next case: |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2038 |
// |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2039 |
// Point p[] = new Point[1]; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2040 |
// if ( x ) { p[0] = new Point(); p[0].x = x; } |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2041 |
// if ( p[0] != null ) { y = p[0].x; } // has CastPP |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2042 |
// |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2043 |
for (uint next = ei; (next < ae_cnt) && (value == NULL); next++) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2044 |
uint fpi = pta->edge_target(next); // Field (AddP) |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2045 |
PointsToNode *ptf = ptnode_adr(fpi); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2046 |
if (ptf->offset() == offset) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2047 |
Node* nf = ptf->_node; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2048 |
for (DUIterator_Fast imax, i = nf->fast_outs(imax); i < imax; i++) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2049 |
store = nf->fast_out(i); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2050 |
if (store->is_Store() && store->in(0) != NULL) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2051 |
Node* ctrl = store->in(0); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2052 |
while(!(ctrl == ini || ctrl == alloc || ctrl == NULL || |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2053 |
ctrl == C->root() || ctrl == C->top() || ctrl->is_Region() || |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2054 |
ctrl->is_IfTrue() || ctrl->is_IfFalse())) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2055 |
ctrl = ctrl->in(0); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2056 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2057 |
if (ctrl == ini || ctrl == alloc) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2058 |
value = store->in(MemNode::ValueIn); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2059 |
break; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2060 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2061 |
} |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2062 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2063 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2064 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2065 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2066 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2067 |
if (value == NULL || value != ptnode_adr(value->_idx)->_node) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2068 |
// A field's initializing value was not recorded. Add NULL. |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2069 |
add_edge_from_fields(alloc->_idx, null_idx, offset); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2070 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2071 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2072 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2073 |
} |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2074 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2075 |
|
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2076 |
// Adjust escape state after Connection Graph is built. |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2077 |
void ConnectionGraph::adjust_escape_state(Node* n) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2078 |
PointsToNode* ptn = ptnode_adr(n->_idx); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2079 |
assert(n->is_AddP(), "Should be called for AddP nodes only"); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2080 |
// Search for objects which are not scalar replaceable |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2081 |
// and mark them to propagate the state to referenced objects. |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2082 |
// |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2083 |
|
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2084 |
int offset = ptn->offset(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2085 |
Node* base = get_addp_base(n); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2086 |
VectorSet* ptset = PointsTo(base); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2087 |
int ptset_size = ptset->Size(); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2088 |
|
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2089 |
// An object is not scalar replaceable if the field which may point |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2090 |
// to it has unknown offset (unknown element of an array of objects). |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2091 |
// |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2092 |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2093 |
if (offset == Type::OffsetBot) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2094 |
uint e_cnt = ptn->edge_count(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2095 |
for (uint ei = 0; ei < e_cnt; ei++) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2096 |
uint npi = ptn->edge_target(ei); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2097 |
ptnode_adr(npi)->set_scalar_replaceable(false); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2098 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2099 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2100 |
|
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2101 |
// Currently an object is not scalar replaceable if a LoadStore node |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2102 |
// access its field since the field value is unknown after it. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2103 |
// |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2104 |
bool has_LoadStore = false; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2105 |
for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2106 |
Node *use = n->fast_out(i); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2107 |
if (use->is_LoadStore()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2108 |
has_LoadStore = true; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2109 |
break; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2110 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2111 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2112 |
// An object is not scalar replaceable if the address points |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2113 |
// to unknown field (unknown element for arrays, offset is OffsetBot). |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2114 |
// |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2115 |
// Or the address may point to more then one object. This may produce |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2116 |
// the false positive result (set not scalar replaceable) |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2117 |
// since the flow-insensitive escape analysis can't separate |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2118 |
// the case when stores overwrite the field's value from the case |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2119 |
// when stores happened on different control branches. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2120 |
// |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2121 |
// Note: it will disable scalar replacement in some cases: |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2122 |
// |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2123 |
// Point p[] = new Point[1]; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2124 |
// p[0] = new Point(); // Will be not scalar replaced |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2125 |
// |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2126 |
// but it will save us from incorrect optimizations in next cases: |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2127 |
// |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2128 |
// Point p[] = new Point[1]; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2129 |
// if ( x ) p[0] = new Point(); // Will be not scalar replaced |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2130 |
// |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2131 |
if (ptset_size > 1 || ptset_size != 0 && |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2132 |
(has_LoadStore || offset == Type::OffsetBot)) { |
8319 | 2133 |
for( VectorSetI j(ptset); j.test(); ++j ) { |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2134 |
ptnode_adr(j.elem)->set_scalar_replaceable(false); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2135 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2136 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2137 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2138 |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2139 |
// Propagate escape states to referenced nodes. |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2140 |
bool ConnectionGraph::propagate_escape_state(GrowableArray<int>* cg_worklist, |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2141 |
GrowableArray<uint>* worklist, |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2142 |
PointsToNode::EscapeState esc_state) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2143 |
bool has_java_obj = false; |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2144 |
|
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2145 |
// push all nodes with the same escape state on the worklist |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2146 |
uint cg_length = cg_worklist->length(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2147 |
for (uint next = 0; next < cg_length; ++next) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2148 |
int nk = cg_worklist->at(next); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2149 |
if (ptnode_adr(nk)->escape_state() == esc_state) |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2150 |
worklist->push(nk); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2151 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2152 |
// mark all reachable nodes |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2153 |
while (worklist->length() > 0) { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2154 |
int pt = worklist->pop(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2155 |
PointsToNode* ptn = ptnode_adr(pt); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2156 |
if (ptn->node_type() == PointsToNode::JavaObject && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2157 |
!is_null_ptr(pt)) { |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2158 |
has_java_obj = true; |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2159 |
if (esc_state > PointsToNode::NoEscape) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2160 |
// fields values are unknown if object escapes |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2161 |
add_edge_from_fields(pt, _phantom_object, Type::OffsetBot); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2162 |
} |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2163 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2164 |
uint e_cnt = ptn->edge_count(); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2165 |
for (uint ei = 0; ei < e_cnt; ei++) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2166 |
uint npi = ptn->edge_target(ei); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2167 |
if (is_null_ptr(npi)) |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2168 |
continue; |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2169 |
PointsToNode *np = ptnode_adr(npi); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2170 |
if (np->escape_state() < esc_state) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2171 |
set_escape_state(npi, esc_state); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2172 |
worklist->push(npi); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2173 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2174 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2175 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2176 |
// Has not escaping java objects |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2177 |
return has_java_obj && (esc_state < PointsToNode::GlobalEscape); |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2178 |
} |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2179 |
|
11189 | 2180 |
// Optimize objects compare. |
2181 |
Node* ConnectionGraph::optimize_ptr_compare(Node* n) { |
|
2182 |
assert(OptimizePtrCompare, "sanity"); |
|
2183 |
// Clone returned Set since PointsTo() returns pointer |
|
2184 |
// to the same structure ConnectionGraph.pt_ptset. |
|
2185 |
VectorSet ptset1 = *PointsTo(n->in(1)); |
|
2186 |
VectorSet ptset2 = *PointsTo(n->in(2)); |
|
2187 |
||
2188 |
// Check simple cases first. |
|
2189 |
if (ptset1.Size() == 1) { |
|
2190 |
uint pt1 = ptset1.getelem(); |
|
2191 |
PointsToNode* ptn1 = ptnode_adr(pt1); |
|
2192 |
if (ptn1->escape_state() == PointsToNode::NoEscape) { |
|
2193 |
if (ptset2.Size() == 1 && ptset2.getelem() == pt1) { |
|
2194 |
// Comparing the same not escaping object. |
|
2195 |
return _pcmp_eq; |
|
2196 |
} |
|
2197 |
Node* obj = ptn1->_node; |
|
2198 |
// Comparing not escaping allocation. |
|
2199 |
if ((obj->is_Allocate() || obj->is_CallStaticJava()) && |
|
2200 |
!ptset2.test(pt1)) { |
|
2201 |
return _pcmp_neq; // This includes nullness check. |
|
2202 |
} |
|
2203 |
} |
|
2204 |
} else if (ptset2.Size() == 1) { |
|
2205 |
uint pt2 = ptset2.getelem(); |
|
2206 |
PointsToNode* ptn2 = ptnode_adr(pt2); |
|
2207 |
if (ptn2->escape_state() == PointsToNode::NoEscape) { |
|
2208 |
Node* obj = ptn2->_node; |
|
2209 |
// Comparing not escaping allocation. |
|
2210 |
if ((obj->is_Allocate() || obj->is_CallStaticJava()) && |
|
2211 |
!ptset1.test(pt2)) { |
|
2212 |
return _pcmp_neq; // This includes nullness check. |
|
2213 |
} |
|
2214 |
} |
|
2215 |
} |
|
2216 |
||
2217 |
if (!ptset1.disjoint(ptset2)) { |
|
2218 |
return NULL; // Sets are not disjoint |
|
2219 |
} |
|
2220 |
||
2221 |
// Sets are disjoint. |
|
2222 |
bool set1_has_unknown_ptr = ptset1.test(_phantom_object) != 0; |
|
2223 |
bool set2_has_unknown_ptr = ptset2.test(_phantom_object) != 0; |
|
2224 |
bool set1_has_null_ptr = (ptset1.test(_oop_null) | ptset1.test(_noop_null)) != 0; |
|
2225 |
bool set2_has_null_ptr = (ptset2.test(_oop_null) | ptset2.test(_noop_null)) != 0; |
|
2226 |
||
2227 |
if (set1_has_unknown_ptr && set2_has_null_ptr || |
|
2228 |
set2_has_unknown_ptr && set1_has_null_ptr) { |
|
2229 |
// Check nullness of unknown object. |
|
2230 |
return NULL; |
|
2231 |
} |
|
2232 |
||
2233 |
// Disjointness by itself is not sufficient since |
|
2234 |
// alias analysis is not complete for escaped objects. |
|
2235 |
// Disjoint sets are definitely unrelated only when |
|
2236 |
// at least one set has only not escaping objects. |
|
2237 |
if (!set1_has_unknown_ptr && !set1_has_null_ptr) { |
|
2238 |
bool has_only_non_escaping_alloc = true; |
|
2239 |
for (VectorSetI i(&ptset1); i.test(); ++i) { |
|
2240 |
uint pt = i.elem; |
|
2241 |
PointsToNode* ptn = ptnode_adr(pt); |
|
2242 |
Node* obj = ptn->_node; |
|
2243 |
if (ptn->escape_state() != PointsToNode::NoEscape || |
|
2244 |
!(obj->is_Allocate() || obj->is_CallStaticJava())) { |
|
2245 |
has_only_non_escaping_alloc = false; |
|
2246 |
break; |
|
2247 |
} |
|
2248 |
} |
|
2249 |
if (has_only_non_escaping_alloc) { |
|
2250 |
return _pcmp_neq; |
|
2251 |
} |
|
2252 |
} |
|
2253 |
if (!set2_has_unknown_ptr && !set2_has_null_ptr) { |
|
2254 |
bool has_only_non_escaping_alloc = true; |
|
2255 |
for (VectorSetI i(&ptset2); i.test(); ++i) { |
|
2256 |
uint pt = i.elem; |
|
2257 |
PointsToNode* ptn = ptnode_adr(pt); |
|
2258 |
Node* obj = ptn->_node; |
|
2259 |
if (ptn->escape_state() != PointsToNode::NoEscape || |
|
2260 |
!(obj->is_Allocate() || obj->is_CallStaticJava())) { |
|
2261 |
has_only_non_escaping_alloc = false; |
|
2262 |
break; |
|
2263 |
} |
|
2264 |
} |
|
2265 |
if (has_only_non_escaping_alloc) { |
|
2266 |
return _pcmp_neq; |
|
2267 |
} |
|
2268 |
} |
|
2269 |
return NULL; |
|
2270 |
} |
|
2271 |
||
1 | 2272 |
void ConnectionGraph::process_call_arguments(CallNode *call, PhaseTransform *phase) { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2273 |
bool is_arraycopy = false; |
1 | 2274 |
switch (call->Opcode()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2275 |
#ifdef ASSERT |
1 | 2276 |
case Op_Allocate: |
2277 |
case Op_AllocateArray: |
|
2278 |
case Op_Lock: |
|
2279 |
case Op_Unlock: |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2280 |
assert(false, "should be done already"); |
1 | 2281 |
break; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2282 |
#endif |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2283 |
case Op_CallLeafNoFP: |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2284 |
is_arraycopy = (call->as_CallLeaf()->_name != NULL && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2285 |
strstr(call->as_CallLeaf()->_name, "arraycopy") != 0); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2286 |
// fall through |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2287 |
case Op_CallLeaf: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2288 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2289 |
// Stub calls, objects do not escape but they are not scale replaceable. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2290 |
// Adjust escape state for outgoing arguments. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2291 |
const TypeTuple * d = call->tf()->domain(); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2292 |
bool src_has_oops = false; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2293 |
for (uint i = TypeFunc::Parms; i < d->cnt(); i++) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2294 |
const Type* at = d->field_at(i); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2295 |
Node *arg = call->in(i)->uncast(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2296 |
const Type *aat = phase->type(arg); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2297 |
PointsToNode::EscapeState arg_esc = ptnode_adr(arg->_idx)->escape_state(); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2298 |
if (!arg->is_top() && at->isa_ptr() && aat->isa_ptr() && |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2299 |
(is_arraycopy || arg_esc < PointsToNode::ArgEscape)) { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2300 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2301 |
assert(aat == Type::TOP || aat == TypePtr::NULL_PTR || |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2302 |
aat->isa_ptr() != NULL, "expecting an Ptr"); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2303 |
bool arg_has_oops = aat->isa_oopptr() && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2304 |
(aat->isa_oopptr()->klass() == NULL || aat->isa_instptr() || |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2305 |
(aat->isa_aryptr() && aat->isa_aryptr()->klass()->is_obj_array_klass())); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2306 |
if (i == TypeFunc::Parms) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2307 |
src_has_oops = arg_has_oops; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2308 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2309 |
// |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2310 |
// src or dst could be j.l.Object when other is basic type array: |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2311 |
// |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2312 |
// arraycopy(char[],0,Object*,0,size); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2313 |
// arraycopy(Object*,0,char[],0,size); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2314 |
// |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2315 |
// Don't add edges from dst's fields in such cases. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2316 |
// |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2317 |
bool arg_is_arraycopy_dest = src_has_oops && is_arraycopy && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2318 |
arg_has_oops && (i > TypeFunc::Parms); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2319 |
#ifdef ASSERT |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2320 |
if (!(is_arraycopy || |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2321 |
call->as_CallLeaf()->_name != NULL && |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2322 |
(strcmp(call->as_CallLeaf()->_name, "g1_wb_pre") == 0 || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2323 |
strcmp(call->as_CallLeaf()->_name, "g1_wb_post") == 0 )) |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2324 |
) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2325 |
call->dump(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2326 |
assert(false, "EA: unexpected CallLeaf"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2327 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2328 |
#endif |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2329 |
// Always process arraycopy's destination object since |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2330 |
// we need to add all possible edges to references in |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2331 |
// source object. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2332 |
if (arg_esc >= PointsToNode::ArgEscape && |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2333 |
!arg_is_arraycopy_dest) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2334 |
continue; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2335 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2336 |
set_escape_state(arg->_idx, PointsToNode::ArgEscape); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2337 |
Node* arg_base = arg; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2338 |
if (arg->is_AddP()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2339 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2340 |
// The inline_native_clone() case when the arraycopy stub is called |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2341 |
// after the allocation before Initialize and CheckCastPP nodes. |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2342 |
// Or normal arraycopy for object arrays case. |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2343 |
// |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2344 |
// Set AddP's base (Allocate) as not scalar replaceable since |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2345 |
// pointer to the base (with offset) is passed as argument. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2346 |
// |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2347 |
arg_base = get_addp_base(arg); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2348 |
} |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2349 |
VectorSet argset = *PointsTo(arg_base); // Clone set |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2350 |
for( VectorSetI j(&argset); j.test(); ++j ) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2351 |
uint pd = j.elem; // Destination object |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2352 |
set_escape_state(pd, PointsToNode::ArgEscape); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2353 |
|
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2354 |
if (arg_is_arraycopy_dest) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2355 |
PointsToNode* ptd = ptnode_adr(pd); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2356 |
// Conservatively reference an unknown object since |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2357 |
// not all source's fields/elements may be known. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2358 |
add_edge_from_fields(pd, _phantom_object, Type::OffsetBot); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2359 |
|
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2360 |
Node *src = call->in(TypeFunc::Parms)->uncast(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2361 |
Node* src_base = src; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2362 |
if (src->is_AddP()) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2363 |
src_base = get_addp_base(src); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2364 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2365 |
// Create edges from destination's fields to |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2366 |
// everything known source's fields could point to. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2367 |
for( VectorSetI s(PointsTo(src_base)); s.test(); ++s ) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2368 |
uint ps = s.elem; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2369 |
bool has_bottom_offset = false; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2370 |
for (uint fd = 0; fd < ptd->edge_count(); fd++) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2371 |
assert(ptd->edge_type(fd) == PointsToNode::FieldEdge, "expecting a field edge"); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2372 |
int fdi = ptd->edge_target(fd); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2373 |
PointsToNode* pfd = ptnode_adr(fdi); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2374 |
int offset = pfd->offset(); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2375 |
if (offset == Type::OffsetBot) |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2376 |
has_bottom_offset = true; |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2377 |
assert(offset != -1, "offset should be set"); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2378 |
add_deferred_edge_to_fields(fdi, ps, offset); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2379 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2380 |
// Destination object may not have access (no field edge) |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2381 |
// to fields which are accessed in source object. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2382 |
// As result no edges will be created to those source's |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2383 |
// fields and escape state of destination object will |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2384 |
// not be propagated to those fields. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2385 |
// |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2386 |
// Mark source object as global escape except in |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2387 |
// the case with Type::OffsetBot field (which is |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2388 |
// common case for array elements access) when |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2389 |
// edges are created to all source's fields. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2390 |
if (!has_bottom_offset) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2391 |
set_escape_state(ps, PointsToNode::GlobalEscape); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2392 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2393 |
} |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2394 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2395 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2396 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2397 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2398 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2399 |
} |
1 | 2400 |
|
2401 |
case Op_CallStaticJava: |
|
2402 |
// For a static call, we know exactly what method is being called. |
|
2403 |
// Use bytecode estimator to record the call's escape affects |
|
2404 |
{ |
|
2405 |
ciMethod *meth = call->as_CallJava()->method(); |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2406 |
BCEscapeAnalyzer *call_analyzer = (meth !=NULL) ? meth->get_bcea() : NULL; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2407 |
// fall-through if not a Java method or no analyzer information |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2408 |
if (call_analyzer != NULL) { |
1 | 2409 |
const TypeTuple * d = call->tf()->domain(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2410 |
bool copy_dependencies = false; |
1 | 2411 |
for (uint i = TypeFunc::Parms; i < d->cnt(); i++) { |
2412 |
const Type* at = d->field_at(i); |
|
2413 |
int k = i - TypeFunc::Parms; |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2414 |
Node *arg = call->in(i)->uncast(); |
1 | 2415 |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2416 |
if (at->isa_oopptr() != NULL && |
4565
cbb3fed38514
6913075: EA identifies escape state incorrectly after 6895383 fix
kvn
parents:
4471
diff
changeset
|
2417 |
ptnode_adr(arg->_idx)->escape_state() < PointsToNode::GlobalEscape) { |
1 | 2418 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2419 |
bool global_escapes = false; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2420 |
bool fields_escapes = false; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2421 |
if (!call_analyzer->is_arg_stack(k)) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2422 |
// The argument global escapes, mark everything it could point to |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2423 |
set_escape_state(arg->_idx, PointsToNode::GlobalEscape); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2424 |
global_escapes = true; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2425 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2426 |
if (!call_analyzer->is_arg_local(k)) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2427 |
// The argument itself doesn't escape, but any fields might |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2428 |
fields_escapes = true; |
1 | 2429 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2430 |
set_escape_state(arg->_idx, PointsToNode::ArgEscape); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2431 |
copy_dependencies = true; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2432 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2433 |
|
8319 | 2434 |
for( VectorSetI j(PointsTo(arg)); j.test(); ++j ) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2435 |
uint pt = j.elem; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2436 |
if (global_escapes) { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2437 |
// The argument global escapes, mark everything it could point to |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2438 |
set_escape_state(pt, PointsToNode::GlobalEscape); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2439 |
add_edge_from_fields(pt, _phantom_object, Type::OffsetBot); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2440 |
} else { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2441 |
set_escape_state(pt, PointsToNode::ArgEscape); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2442 |
if (fields_escapes) { |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2443 |
// The argument itself doesn't escape, but any fields might. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2444 |
// Use OffsetTop to indicate such case. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2445 |
add_edge_from_fields(pt, _phantom_object, Type::OffsetTop); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2446 |
} |
1 | 2447 |
} |
2448 |
} |
|
2449 |
} |
|
2450 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2451 |
if (copy_dependencies) |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2452 |
call_analyzer->copy_dependencies(_compile->dependencies()); |
1 | 2453 |
break; |
2454 |
} |
|
2455 |
} |
|
2456 |
||
2457 |
default: |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2458 |
// Fall-through here if not a Java method or no analyzer information |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2459 |
// or some other type of call, assume the worst case: all arguments |
1 | 2460 |
// globally escape. |
2461 |
{ |
|
2462 |
// adjust escape state for outgoing arguments |
|
2463 |
const TypeTuple * d = call->tf()->domain(); |
|
2464 |
for (uint i = TypeFunc::Parms; i < d->cnt(); i++) { |
|
2465 |
const Type* at = d->field_at(i); |
|
2466 |
if (at->isa_oopptr() != NULL) { |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2467 |
Node *arg = call->in(i)->uncast(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2468 |
set_escape_state(arg->_idx, PointsToNode::GlobalEscape); |
8319 | 2469 |
for( VectorSetI j(PointsTo(arg)); j.test(); ++j ) { |
1 | 2470 |
uint pt = j.elem; |
2471 |
set_escape_state(pt, PointsToNode::GlobalEscape); |
|
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2472 |
add_edge_from_fields(pt, _phantom_object, Type::OffsetBot); |
1 | 2473 |
} |
2474 |
} |
|
2475 |
} |
|
2476 |
} |
|
2477 |
} |
|
2478 |
} |
|
2479 |
void ConnectionGraph::process_call_result(ProjNode *resproj, PhaseTransform *phase) { |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2480 |
CallNode *call = resproj->in(0)->as_Call(); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2481 |
uint call_idx = call->_idx; |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2482 |
uint resproj_idx = resproj->_idx; |
1 | 2483 |
|
2484 |
switch (call->Opcode()) { |
|
2485 |
case Op_Allocate: |
|
2486 |
{ |
|
2487 |
Node *k = call->in(AllocateNode::KlassNode); |
|
5534
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2488 |
const TypeKlassPtr *kt = k->bottom_type()->isa_klassptr(); |
1 | 2489 |
assert(kt != NULL, "TypeKlassPtr required."); |
2490 |
ciKlass* cik = kt->klass(); |
|
2491 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2492 |
PointsToNode::EscapeState es; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2493 |
uint edge_to; |
5534
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2494 |
if (cik->is_subclass_of(_compile->env()->Thread_klass()) || |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2495 |
!cik->is_instance_klass() || // StressReflectiveCode |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2496 |
cik->as_instance_klass()->has_finalizer()) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2497 |
es = PointsToNode::GlobalEscape; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2498 |
edge_to = _phantom_object; // Could not be worse |
1 | 2499 |
} else { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2500 |
es = PointsToNode::NoEscape; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2501 |
edge_to = call_idx; |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2502 |
assert(ptnode_adr(call_idx)->scalar_replaceable(), "sanity"); |
1 | 2503 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2504 |
set_escape_state(call_idx, es); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2505 |
add_pointsto_edge(resproj_idx, edge_to); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2506 |
_processed.set(resproj_idx); |
1 | 2507 |
break; |
2508 |
} |
|
2509 |
||
2510 |
case Op_AllocateArray: |
|
2511 |
{ |
|
5534
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2512 |
|
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2513 |
Node *k = call->in(AllocateNode::KlassNode); |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2514 |
const TypeKlassPtr *kt = k->bottom_type()->isa_klassptr(); |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2515 |
assert(kt != NULL, "TypeKlassPtr required."); |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2516 |
ciKlass* cik = kt->klass(); |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2517 |
|
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2518 |
PointsToNode::EscapeState es; |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2519 |
uint edge_to; |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2520 |
if (!cik->is_array_klass()) { // StressReflectiveCode |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2521 |
es = PointsToNode::GlobalEscape; |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2522 |
edge_to = _phantom_object; |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2523 |
} else { |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2524 |
es = PointsToNode::NoEscape; |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2525 |
edge_to = call_idx; |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2526 |
assert(ptnode_adr(call_idx)->scalar_replaceable(), "sanity"); |
5534
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2527 |
int length = call->in(AllocateNode::ALength)->find_int_con(-1); |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2528 |
if (length < 0 || length > EliminateAllocationArraySizeLimit) { |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2529 |
// Not scalar replaceable if the length is not constant or too big. |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2530 |
ptnode_adr(call_idx)->set_scalar_replaceable(false); |
5534
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2531 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2532 |
} |
5534
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2533 |
set_escape_state(call_idx, es); |
9bea9ee28dfc
6953267: assert in EA code with -XX:+StressReflectiveCode
kvn
parents:
4565
diff
changeset
|
2534 |
add_pointsto_edge(resproj_idx, edge_to); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2535 |
_processed.set(resproj_idx); |
1 | 2536 |
break; |
2537 |
} |
|
2538 |
||
2539 |
case Op_CallStaticJava: |
|
2540 |
// For a static call, we know exactly what method is being called. |
|
2541 |
// Use bytecode estimator to record whether the call's return value escapes |
|
2542 |
{ |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2543 |
bool done = true; |
1 | 2544 |
const TypeTuple *r = call->tf()->range(); |
2545 |
const Type* ret_type = NULL; |
|
2546 |
||
2547 |
if (r->cnt() > TypeFunc::Parms) |
|
2548 |
ret_type = r->field_at(TypeFunc::Parms); |
|
2549 |
||
2550 |
// Note: we use isa_ptr() instead of isa_oopptr() here because the |
|
2551 |
// _multianewarray functions return a TypeRawPtr. |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2552 |
if (ret_type == NULL || ret_type->isa_ptr() == NULL) { |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2553 |
_processed.set(resproj_idx); |
1 | 2554 |
break; // doesn't return a pointer type |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2555 |
} |
1 | 2556 |
ciMethod *meth = call->as_CallJava()->method(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2557 |
const TypeTuple * d = call->tf()->domain(); |
1 | 2558 |
if (meth == NULL) { |
2559 |
// not a Java method, assume global escape |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2560 |
set_escape_state(call_idx, PointsToNode::GlobalEscape); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2561 |
add_pointsto_edge(resproj_idx, _phantom_object); |
1 | 2562 |
} else { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2563 |
BCEscapeAnalyzer *call_analyzer = meth->get_bcea(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2564 |
bool copy_dependencies = false; |
1 | 2565 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2566 |
if (call_analyzer->is_return_allocated()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2567 |
// Returns a newly allocated unescaped object, simply |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2568 |
// update dependency information. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2569 |
// Mark it as NoEscape so that objects referenced by |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2570 |
// it's fields will be marked as NoEscape at least. |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2571 |
set_escape_state(call_idx, PointsToNode::NoEscape); |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2572 |
ptnode_adr(call_idx)->set_scalar_replaceable(false); |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2573 |
// Fields values are unknown |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2574 |
add_edge_from_fields(call_idx, _phantom_object, Type::OffsetBot); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2575 |
add_pointsto_edge(resproj_idx, call_idx); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2576 |
copy_dependencies = true; |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2577 |
} else { |
1 | 2578 |
// determine whether any arguments are returned |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2579 |
set_escape_state(call_idx, PointsToNode::ArgEscape); |
1069
ef51f81ebe0f
6732732: CTW with EA: assert(n != 0L,"Bad immediate dominator info.")
kvn
parents:
1068
diff
changeset
|
2580 |
bool ret_arg = false; |
1 | 2581 |
for (uint i = TypeFunc::Parms; i < d->cnt(); i++) { |
2582 |
const Type* at = d->field_at(i); |
|
2583 |
if (at->isa_oopptr() != NULL) { |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2584 |
Node *arg = call->in(i)->uncast(); |
1 | 2585 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2586 |
if (call_analyzer->is_arg_returned(i - TypeFunc::Parms)) { |
1069
ef51f81ebe0f
6732732: CTW with EA: assert(n != 0L,"Bad immediate dominator info.")
kvn
parents:
1068
diff
changeset
|
2587 |
ret_arg = true; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2588 |
PointsToNode *arg_esp = ptnode_adr(arg->_idx); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2589 |
if (arg_esp->node_type() == PointsToNode::UnknownType) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2590 |
done = false; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2591 |
else if (arg_esp->node_type() == PointsToNode::JavaObject) |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2592 |
add_pointsto_edge(resproj_idx, arg->_idx); |
1 | 2593 |
else |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2594 |
add_deferred_edge(resproj_idx, arg->_idx); |
1 | 2595 |
} |
2596 |
} |
|
2597 |
} |
|
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2598 |
if (done) { |
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2599 |
copy_dependencies = true; |
11198
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2600 |
// is_return_local() is true when only arguments are returned. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2601 |
if (!ret_arg || !call_analyzer->is_return_local()) { |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2602 |
// Returns unknown object. |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2603 |
add_pointsto_edge(resproj_idx, _phantom_object); |
34c860ff41e3
7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE
kvn
parents:
11191
diff
changeset
|
2604 |
} |
10982
85bcf8ef9cc8
7059047: EA: can't find initializing store with several CheckCastPP
kvn
parents:
10970
diff
changeset
|
2605 |
} |
1 | 2606 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2607 |
if (copy_dependencies) |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2608 |
call_analyzer->copy_dependencies(_compile->dependencies()); |
1 | 2609 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2610 |
if (done) |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2611 |
_processed.set(resproj_idx); |
1 | 2612 |
break; |
2613 |
} |
|
2614 |
||
2615 |
default: |
|
2616 |
// Some other type of call, assume the worst case that the |
|
2617 |
// returned value, if any, globally escapes. |
|
2618 |
{ |
|
2619 |
const TypeTuple *r = call->tf()->range(); |
|
2620 |
if (r->cnt() > TypeFunc::Parms) { |
|
2621 |
const Type* ret_type = r->field_at(TypeFunc::Parms); |
|
2622 |
||
2623 |
// Note: we use isa_ptr() instead of isa_oopptr() here because the |
|
2624 |
// _multianewarray functions return a TypeRawPtr. |
|
2625 |
if (ret_type->isa_ptr() != NULL) { |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2626 |
set_escape_state(call_idx, PointsToNode::GlobalEscape); |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2627 |
add_pointsto_edge(resproj_idx, _phantom_object); |
1 | 2628 |
} |
2629 |
} |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2630 |
_processed.set(resproj_idx); |
1 | 2631 |
} |
2632 |
} |
|
2633 |
} |
|
2634 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2635 |
// Populate Connection Graph with Ideal nodes and create simple |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2636 |
// connection graph edges (do not need to check the node_type of inputs |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2637 |
// or to call PointsTo() to walk the connection graph). |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2638 |
void ConnectionGraph::record_for_escape_analysis(Node *n, PhaseTransform *phase) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2639 |
if (_processed.test(n->_idx)) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2640 |
return; // No need to redefine node's state. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2641 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2642 |
if (n->is_Call()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2643 |
// Arguments to allocation and locking don't escape. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2644 |
if (n->is_Allocate()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2645 |
add_node(n, PointsToNode::JavaObject, PointsToNode::UnknownEscape, true); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2646 |
record_for_optimizer(n); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2647 |
} else if (n->is_Lock() || n->is_Unlock()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2648 |
// Put Lock and Unlock nodes on IGVN worklist to process them during |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2649 |
// the first IGVN optimization when escape information is still available. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2650 |
record_for_optimizer(n); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2651 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2652 |
} else { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2653 |
// Don't mark as processed since call's arguments have to be processed. |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2654 |
PointsToNode::NodeType nt = PointsToNode::UnknownType; |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2655 |
PointsToNode::EscapeState es = PointsToNode::UnknownEscape; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2656 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2657 |
// Check if a call returns an object. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2658 |
const TypeTuple *r = n->as_Call()->tf()->range(); |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2659 |
if (r->cnt() > TypeFunc::Parms && |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2660 |
r->field_at(TypeFunc::Parms)->isa_ptr() && |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2661 |
n->as_Call()->proj_out(TypeFunc::Parms) != NULL) { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2662 |
nt = PointsToNode::JavaObject; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2663 |
if (!n->is_CallStaticJava()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2664 |
// Since the called mathod is statically unknown assume |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2665 |
// the worst case that the returned value globally escapes. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2666 |
es = PointsToNode::GlobalEscape; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2667 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2668 |
} |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2669 |
add_node(n, nt, es, false); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2670 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2671 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2672 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2673 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2674 |
// Using isa_ptr() instead of isa_oopptr() for LoadP and Phi because |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2675 |
// ThreadLocal has RawPrt type. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2676 |
switch (n->Opcode()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2677 |
case Op_AddP: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2678 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2679 |
add_node(n, PointsToNode::Field, PointsToNode::UnknownEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2680 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2681 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2682 |
case Op_CastX2P: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2683 |
{ // "Unsafe" memory access. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2684 |
add_node(n, PointsToNode::JavaObject, PointsToNode::GlobalEscape, true); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2685 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2686 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2687 |
case Op_CastPP: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2688 |
case Op_CheckCastPP: |
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2689 |
case Op_EncodeP: |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2690 |
case Op_DecodeN: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2691 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2692 |
add_node(n, PointsToNode::LocalVar, PointsToNode::UnknownEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2693 |
int ti = n->in(1)->_idx; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2694 |
PointsToNode::NodeType nt = ptnode_adr(ti)->node_type(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2695 |
if (nt == PointsToNode::UnknownType) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2696 |
_delayed_worklist.push(n); // Process it later. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2697 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2698 |
} else if (nt == PointsToNode::JavaObject) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2699 |
add_pointsto_edge(n->_idx, ti); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2700 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2701 |
add_deferred_edge(n->_idx, ti); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2702 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2703 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2704 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2705 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2706 |
case Op_ConP: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2707 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2708 |
// assume all pointer constants globally escape except for null |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2709 |
PointsToNode::EscapeState es; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2710 |
if (phase->type(n) == TypePtr::NULL_PTR) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2711 |
es = PointsToNode::NoEscape; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2712 |
else |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2713 |
es = PointsToNode::GlobalEscape; |
1 | 2714 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2715 |
add_node(n, PointsToNode::JavaObject, es, true); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2716 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2717 |
} |
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2718 |
case Op_ConN: |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2719 |
{ |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2720 |
// assume all narrow oop constants globally escape except for null |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2721 |
PointsToNode::EscapeState es; |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2722 |
if (phase->type(n) == TypeNarrowOop::NULL_PTR) |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2723 |
es = PointsToNode::NoEscape; |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2724 |
else |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2725 |
es = PointsToNode::GlobalEscape; |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2726 |
|
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2727 |
add_node(n, PointsToNode::JavaObject, es, true); |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2728 |
break; |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2729 |
} |
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2730 |
case Op_CreateEx: |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2731 |
{ |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2732 |
// assume that all exception objects globally escape |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2733 |
add_node(n, PointsToNode::JavaObject, PointsToNode::GlobalEscape, true); |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2734 |
break; |
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2735 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2736 |
case Op_LoadKlass: |
590
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
2737 |
case Op_LoadNKlass: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2738 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2739 |
add_node(n, PointsToNode::JavaObject, PointsToNode::GlobalEscape, true); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2740 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2741 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2742 |
case Op_LoadP: |
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2743 |
case Op_LoadN: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2744 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2745 |
const Type *t = phase->type(n); |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
2746 |
if (t->make_ptr() == NULL) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2747 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2748 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2749 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2750 |
add_node(n, PointsToNode::LocalVar, PointsToNode::UnknownEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2751 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2752 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2753 |
case Op_Parm: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2754 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2755 |
_processed.set(n->_idx); // No need to redefine it state. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2756 |
uint con = n->as_Proj()->_con; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2757 |
if (con < TypeFunc::Parms) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2758 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2759 |
const Type *t = n->in(0)->as_Start()->_domain->field_at(con); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2760 |
if (t->isa_ptr() == NULL) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2761 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2762 |
// We have to assume all input parameters globally escape |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2763 |
// (Note: passing 'false' since _processed is already set). |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2764 |
add_node(n, PointsToNode::JavaObject, PointsToNode::GlobalEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2765 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2766 |
} |
11189 | 2767 |
case Op_PartialSubtypeCheck: |
2768 |
{ // Produces Null or notNull and is used in CmpP. |
|
2769 |
add_node(n, PointsToNode::JavaObject, PointsToNode::ArgEscape, true); |
|
2770 |
break; |
|
2771 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2772 |
case Op_Phi: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2773 |
{ |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
2774 |
const Type *t = n->as_Phi()->type(); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
2775 |
if (t->make_ptr() == NULL) { |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
2776 |
// nothing to do if not an oop or narrow oop |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2777 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2778 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2779 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2780 |
add_node(n, PointsToNode::LocalVar, PointsToNode::UnknownEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2781 |
uint i; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2782 |
for (i = 1; i < n->req() ; i++) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2783 |
Node* in = n->in(i); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2784 |
if (in == NULL) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2785 |
continue; // ignore NULL |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2786 |
in = in->uncast(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2787 |
if (in->is_top() || in == n) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2788 |
continue; // ignore top or inputs which go back this node |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2789 |
int ti = in->_idx; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2790 |
PointsToNode::NodeType nt = ptnode_adr(ti)->node_type(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2791 |
if (nt == PointsToNode::UnknownType) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2792 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2793 |
} else if (nt == PointsToNode::JavaObject) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2794 |
add_pointsto_edge(n->_idx, ti); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2795 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2796 |
add_deferred_edge(n->_idx, ti); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2797 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2798 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2799 |
if (i >= n->req()) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2800 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2801 |
else |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2802 |
_delayed_worklist.push(n); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2803 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2804 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2805 |
case Op_Proj: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2806 |
{ |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2807 |
// we are only interested in the oop result projection from a call |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2808 |
if (n->as_Proj()->_con == TypeFunc::Parms && n->in(0)->is_Call() ) { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2809 |
const TypeTuple *r = n->in(0)->as_Call()->tf()->range(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2810 |
assert(r->cnt() > TypeFunc::Parms, "sanity"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2811 |
if (r->field_at(TypeFunc::Parms)->isa_ptr() != NULL) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2812 |
add_node(n, PointsToNode::LocalVar, PointsToNode::UnknownEscape, false); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2813 |
int ti = n->in(0)->_idx; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2814 |
// The call may not be registered yet (since not all its inputs are registered) |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2815 |
// if this is the projection from backbranch edge of Phi. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2816 |
if (ptnode_adr(ti)->node_type() != PointsToNode::UnknownType) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2817 |
process_call_result(n->as_Proj(), phase); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2818 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2819 |
if (!_processed.test(n->_idx)) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2820 |
// The call's result may need to be processed later if the call |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2821 |
// returns it's argument and the argument is not processed yet. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2822 |
_delayed_worklist.push(n); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2823 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2824 |
break; |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2825 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2826 |
} |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2827 |
_processed.set(n->_idx); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2828 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2829 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2830 |
case Op_Return: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2831 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2832 |
if( n->req() > TypeFunc::Parms && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2833 |
phase->type(n->in(TypeFunc::Parms))->isa_oopptr() ) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2834 |
// Treat Return value as LocalVar with GlobalEscape escape state. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2835 |
add_node(n, PointsToNode::LocalVar, PointsToNode::GlobalEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2836 |
int ti = n->in(TypeFunc::Parms)->_idx; |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2837 |
PointsToNode::NodeType nt = ptnode_adr(ti)->node_type(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2838 |
if (nt == PointsToNode::UnknownType) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2839 |
_delayed_worklist.push(n); // Process it later. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2840 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2841 |
} else if (nt == PointsToNode::JavaObject) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2842 |
add_pointsto_edge(n->_idx, ti); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2843 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2844 |
add_deferred_edge(n->_idx, ti); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2845 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2846 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2847 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2848 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2849 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2850 |
case Op_StoreP: |
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2851 |
case Op_StoreN: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2852 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2853 |
const Type *adr_type = phase->type(n->in(MemNode::Address)); |
767
64fb1fd7186d
6710487: More than half of JDI Regression tests hang with COOPs in -Xcomp mode
kvn
parents:
594
diff
changeset
|
2854 |
adr_type = adr_type->make_ptr(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2855 |
if (adr_type->isa_oopptr()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2856 |
add_node(n, PointsToNode::UnknownType, PointsToNode::UnknownEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2857 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2858 |
Node* adr = n->in(MemNode::Address); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2859 |
if (adr->is_AddP() && phase->type(adr) == TypeRawPtr::NOTNULL && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2860 |
adr->in(AddPNode::Address)->is_Proj() && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2861 |
adr->in(AddPNode::Address)->in(0)->is_Allocate()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2862 |
add_node(n, PointsToNode::UnknownType, PointsToNode::UnknownEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2863 |
// We are computing a raw address for a store captured |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2864 |
// by an Initialize compute an appropriate address type. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2865 |
int offs = (int)phase->find_intptr_t_con(adr->in(AddPNode::Offset), Type::OffsetBot); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2866 |
assert(offs != Type::OffsetBot, "offset must be a constant"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2867 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2868 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2869 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2870 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2871 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2872 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2873 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2874 |
case Op_StorePConditional: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2875 |
case Op_CompareAndSwapP: |
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2876 |
case Op_CompareAndSwapN: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2877 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2878 |
const Type *adr_type = phase->type(n->in(MemNode::Address)); |
767
64fb1fd7186d
6710487: More than half of JDI Regression tests hang with COOPs in -Xcomp mode
kvn
parents:
594
diff
changeset
|
2879 |
adr_type = adr_type->make_ptr(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2880 |
if (adr_type->isa_oopptr()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2881 |
add_node(n, PointsToNode::UnknownType, PointsToNode::UnknownEscape, false); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2882 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2883 |
_processed.set(n->_idx); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2884 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2885 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2886 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2887 |
} |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2888 |
case Op_AryEq: |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2889 |
case Op_StrComp: |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2890 |
case Op_StrEquals: |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2891 |
case Op_StrIndexOf: |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2892 |
{ |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2893 |
// char[] arrays passed to string intrinsics are not scalar replaceable. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2894 |
add_node(n, PointsToNode::UnknownType, PointsToNode::UnknownEscape, false); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2895 |
break; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2896 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2897 |
case Op_ThreadLocal: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2898 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2899 |
add_node(n, PointsToNode::JavaObject, PointsToNode::ArgEscape, true); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2900 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2901 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2902 |
default: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2903 |
; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2904 |
// nothing to do |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2905 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2906 |
return; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2907 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2908 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2909 |
void ConnectionGraph::build_connection_graph(Node *n, PhaseTransform *phase) { |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2910 |
uint n_idx = n->_idx; |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2911 |
assert(ptnode_adr(n_idx)->_node != NULL, "node should be registered"); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2912 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2913 |
// Don't set processed bit for AddP, LoadP, StoreP since |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2914 |
// they may need more then one pass to process. |
7122 | 2915 |
// Also don't mark as processed Call nodes since their |
2916 |
// arguments may need more then one pass to process. |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2917 |
if (_processed.test(n_idx)) |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2918 |
return; // No need to redefine node's state. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2919 |
|
1 | 2920 |
if (n->is_Call()) { |
2921 |
CallNode *call = n->as_Call(); |
|
2922 |
process_call_arguments(call, phase); |
|
2923 |
return; |
|
2924 |
} |
|
2925 |
||
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2926 |
switch (n->Opcode()) { |
1 | 2927 |
case Op_AddP: |
2928 |
{ |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2929 |
Node *base = get_addp_base(n); |
11189 | 2930 |
int offset = address_offset(n, phase); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2931 |
// Create a field edge to this node from everything base could point to. |
8319 | 2932 |
for( VectorSetI i(PointsTo(base)); i.test(); ++i ) { |
1 | 2933 |
uint pt = i.elem; |
11189 | 2934 |
add_field_edge(pt, n_idx, offset); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2935 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2936 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2937 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2938 |
case Op_CastX2P: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2939 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2940 |
assert(false, "Op_CastX2P"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2941 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2942 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2943 |
case Op_CastPP: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2944 |
case Op_CheckCastPP: |
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2945 |
case Op_EncodeP: |
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
349
diff
changeset
|
2946 |
case Op_DecodeN: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2947 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2948 |
int ti = n->in(1)->_idx; |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
2949 |
assert(ptnode_adr(ti)->node_type() != PointsToNode::UnknownType, "all nodes should be registered"); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2950 |
if (ptnode_adr(ti)->node_type() == PointsToNode::JavaObject) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2951 |
add_pointsto_edge(n_idx, ti); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2952 |
} else { |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2953 |
add_deferred_edge(n_idx, ti); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2954 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
2955 |
_processed.set(n_idx); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2956 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2957 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2958 |
case Op_ConP: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2959 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2960 |
assert(false, "Op_ConP"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2961 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2962 |
} |
589 | 2963 |
case Op_ConN: |
2964 |
{ |
|
2965 |
assert(false, "Op_ConN"); |
|
2966 |
break; |
|
2967 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2968 |
case Op_CreateEx: |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2969 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2970 |
assert(false, "Op_CreateEx"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2971 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2972 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2973 |
case Op_LoadKlass: |
590
2954744d7bba
6703890: Compressed Oops: add LoadNKlass node to generate narrow oops (32-bits) compare instructions
kvn
parents:
589
diff
changeset
|
2974 |
case Op_LoadNKlass: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2975 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2976 |
assert(false, "Op_LoadKlass"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2977 |
break; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2978 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2979 |
case Op_LoadP: |
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
2980 |
case Op_LoadN: |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2981 |
{ |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2982 |
const Type *t = phase->type(n); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2983 |
#ifdef ASSERT |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
2984 |
if (t->make_ptr() == NULL) |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2985 |
assert(false, "Op_LoadP"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2986 |
#endif |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2987 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2988 |
Node* adr = n->in(MemNode::Address)->uncast(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2989 |
Node* adr_base; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2990 |
if (adr->is_AddP()) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2991 |
adr_base = get_addp_base(adr); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2992 |
} else { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2993 |
adr_base = adr; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2994 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2995 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2996 |
// For everything "adr_base" could point to, create a deferred edge from |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2997 |
// this node to each field with the same offset. |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
2998 |
int offset = address_offset(adr, phase); |
8319 | 2999 |
for( VectorSetI i(PointsTo(adr_base)); i.test(); ++i ) { |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3000 |
uint pt = i.elem; |
11189 | 3001 |
if (adr->is_AddP()) { |
3002 |
// Add field edge if it is missing. |
|
3003 |
add_field_edge(pt, adr->_idx, offset); |
|
3004 |
} |
|
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3005 |
add_deferred_edge_to_fields(n_idx, pt, offset); |
1 | 3006 |
} |
3007 |
break; |
|
3008 |
} |
|
3009 |
case Op_Parm: |
|
3010 |
{ |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3011 |
assert(false, "Op_Parm"); |
1 | 3012 |
break; |
3013 |
} |
|
11189 | 3014 |
case Op_PartialSubtypeCheck: |
3015 |
{ |
|
3016 |
assert(false, "Op_PartialSubtypeCheck"); |
|
3017 |
break; |
|
3018 |
} |
|
1 | 3019 |
case Op_Phi: |
3020 |
{ |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3021 |
#ifdef ASSERT |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
3022 |
const Type *t = n->as_Phi()->type(); |
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
3023 |
if (t->make_ptr() == NULL) |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3024 |
assert(false, "Op_Phi"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3025 |
#endif |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3026 |
for (uint i = 1; i < n->req() ; i++) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3027 |
Node* in = n->in(i); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3028 |
if (in == NULL) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3029 |
continue; // ignore NULL |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3030 |
in = in->uncast(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3031 |
if (in->is_top() || in == n) |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3032 |
continue; // ignore top or inputs which go back this node |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3033 |
int ti = in->_idx; |
1069
ef51f81ebe0f
6732732: CTW with EA: assert(n != 0L,"Bad immediate dominator info.")
kvn
parents:
1068
diff
changeset
|
3034 |
PointsToNode::NodeType nt = ptnode_adr(ti)->node_type(); |
ef51f81ebe0f
6732732: CTW with EA: assert(n != 0L,"Bad immediate dominator info.")
kvn
parents:
1068
diff
changeset
|
3035 |
assert(nt != PointsToNode::UnknownType, "all nodes should be known"); |
ef51f81ebe0f
6732732: CTW with EA: assert(n != 0L,"Bad immediate dominator info.")
kvn
parents:
1068
diff
changeset
|
3036 |
if (nt == PointsToNode::JavaObject) { |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3037 |
add_pointsto_edge(n_idx, ti); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3038 |
} else { |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3039 |
add_deferred_edge(n_idx, ti); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3040 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3041 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3042 |
_processed.set(n_idx); |
1 | 3043 |
break; |
3044 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3045 |
case Op_Proj: |
1 | 3046 |
{ |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3047 |
// we are only interested in the oop result projection from a call |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3048 |
if (n->as_Proj()->_con == TypeFunc::Parms && n->in(0)->is_Call() ) { |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3049 |
assert(ptnode_adr(n->in(0)->_idx)->node_type() != PointsToNode::UnknownType, |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3050 |
"all nodes should be registered"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3051 |
const TypeTuple *r = n->in(0)->as_Call()->tf()->range(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3052 |
assert(r->cnt() > TypeFunc::Parms, "sanity"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3053 |
if (r->field_at(TypeFunc::Parms)->isa_ptr() != NULL) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3054 |
process_call_result(n->as_Proj(), phase); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3055 |
assert(_processed.test(n_idx), "all call results should be processed"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3056 |
break; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3057 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3058 |
} |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3059 |
assert(false, "Op_Proj"); |
1 | 3060 |
break; |
3061 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3062 |
case Op_Return: |
1 | 3063 |
{ |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3064 |
#ifdef ASSERT |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3065 |
if( n->req() <= TypeFunc::Parms || |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3066 |
!phase->type(n->in(TypeFunc::Parms))->isa_oopptr() ) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3067 |
assert(false, "Op_Return"); |
1 | 3068 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3069 |
#endif |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3070 |
int ti = n->in(TypeFunc::Parms)->_idx; |
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3071 |
assert(ptnode_adr(ti)->node_type() != PointsToNode::UnknownType, "node should be registered"); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3072 |
if (ptnode_adr(ti)->node_type() == PointsToNode::JavaObject) { |
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3073 |
add_pointsto_edge(n_idx, ti); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3074 |
} else { |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3075 |
add_deferred_edge(n_idx, ti); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3076 |
} |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3077 |
_processed.set(n_idx); |
1 | 3078 |
break; |
3079 |
} |
|
3080 |
case Op_StoreP: |
|
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
3081 |
case Op_StoreN: |
1 | 3082 |
case Op_StorePConditional: |
3083 |
case Op_CompareAndSwapP: |
|
371
1aacedc9db7c
6689060: Escape Analysis does not work with Compressed Oops
kvn
parents:
360
diff
changeset
|
3084 |
case Op_CompareAndSwapN: |
1 | 3085 |
{ |
3086 |
Node *adr = n->in(MemNode::Address); |
|
767
64fb1fd7186d
6710487: More than half of JDI Regression tests hang with COOPs in -Xcomp mode
kvn
parents:
594
diff
changeset
|
3087 |
const Type *adr_type = phase->type(adr)->make_ptr(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3088 |
#ifdef ASSERT |
1 | 3089 |
if (!adr_type->isa_oopptr()) |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3090 |
assert(phase->type(adr) == TypeRawPtr::NOTNULL, "Op_StoreP"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3091 |
#endif |
1 | 3092 |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3093 |
assert(adr->is_AddP(), "expecting an AddP"); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3094 |
Node *adr_base = get_addp_base(adr); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3095 |
Node *val = n->in(MemNode::ValueIn)->uncast(); |
11189 | 3096 |
int offset = address_offset(adr, phase); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3097 |
// For everything "adr_base" could point to, create a deferred edge |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3098 |
// to "val" from each field with the same offset. |
8319 | 3099 |
for( VectorSetI i(PointsTo(adr_base)); i.test(); ++i ) { |
1 | 3100 |
uint pt = i.elem; |
11189 | 3101 |
// Add field edge if it is missing. |
3102 |
add_field_edge(pt, adr->_idx, offset); |
|
3103 |
add_edge_from_fields(pt, val->_idx, offset); |
|
1 | 3104 |
} |
3105 |
break; |
|
3106 |
} |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3107 |
case Op_AryEq: |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3108 |
case Op_StrComp: |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3109 |
case Op_StrEquals: |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3110 |
case Op_StrIndexOf: |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3111 |
{ |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3112 |
// char[] arrays passed to string intrinsic do not escape but |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3113 |
// they are not scalar replaceable. Adjust escape state for them. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3114 |
// Start from in(2) edge since in(1) is memory edge. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3115 |
for (uint i = 2; i < n->req(); i++) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3116 |
Node* adr = n->in(i)->uncast(); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3117 |
const Type *at = phase->type(adr); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3118 |
if (!adr->is_top() && at->isa_ptr()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3119 |
assert(at == Type::TOP || at == TypePtr::NULL_PTR || |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3120 |
at->isa_ptr() != NULL, "expecting an Ptr"); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3121 |
if (adr->is_AddP()) { |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3122 |
adr = get_addp_base(adr); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3123 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3124 |
// Mark as ArgEscape everything "adr" could point to. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3125 |
set_escape_state(adr->_idx, PointsToNode::ArgEscape); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3126 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3127 |
} |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3128 |
_processed.set(n_idx); |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3129 |
break; |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3130 |
} |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3131 |
case Op_ThreadLocal: |
1 | 3132 |
{ |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3133 |
assert(false, "Op_ThreadLocal"); |
1 | 3134 |
break; |
3135 |
} |
|
3136 |
default: |
|
4470
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3137 |
// This method should be called only for EA specific nodes. |
1e6edcab3109
6895383: JCK test throws NPE for method compiled with Escape Analysis
kvn
parents:
4442
diff
changeset
|
3138 |
ShouldNotReachHere(); |
1 | 3139 |
} |
3140 |
} |
|
3141 |
||
3142 |
#ifndef PRODUCT |
|
3143 |
void ConnectionGraph::dump() { |
|
3144 |
bool first = true; |
|
3145 |
||
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3146 |
uint size = nodes_size(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3147 |
for (uint ni = 0; ni < size; ni++) { |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3148 |
PointsToNode *ptn = ptnode_adr(ni); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3149 |
PointsToNode::NodeType ptn_type = ptn->node_type(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3150 |
|
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3151 |
if (ptn_type != PointsToNode::JavaObject || ptn->_node == NULL) |
1 | 3152 |
continue; |
5914
8363e7e6915a
6966411: escape.cpp:450 assert(base->Opcode() == Op_ConP
kvn
parents:
5547
diff
changeset
|
3153 |
PointsToNode::EscapeState es = escape_state(ptn->_node); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3154 |
if (ptn->_node->is_Allocate() && (es == PointsToNode::NoEscape || Verbose)) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3155 |
if (first) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3156 |
tty->cr(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3157 |
tty->print("======== Connection graph for "); |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3158 |
_compile->method()->print_short_name(); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3159 |
tty->cr(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3160 |
first = false; |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3161 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3162 |
tty->print("%6d ", ni); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3163 |
ptn->dump(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3164 |
// Print all locals which reference this allocation |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3165 |
for (uint li = ni; li < size; li++) { |
952
38812d18eec0
6684714: Optimize EA Connection Graph build performance
kvn
parents:
769
diff
changeset
|
3166 |
PointsToNode *ptn_loc = ptnode_adr(li); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3167 |
PointsToNode::NodeType ptn_loc_type = ptn_loc->node_type(); |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3168 |
if ( ptn_loc_type == PointsToNode::LocalVar && ptn_loc->_node != NULL && |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3169 |
ptn_loc->edge_count() == 1 && ptn_loc->edge_target(0) == ni ) { |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
3170 |
ptnode_adr(li)->dump(false); |
1 | 3171 |
} |
3172 |
} |
|
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3173 |
if (Verbose) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3174 |
// Print all fields which reference this allocation |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3175 |
for (uint i = 0; i < ptn->edge_count(); i++) { |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3176 |
uint ei = ptn->edge_target(i); |
961
7fb3b13d4205
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
955
diff
changeset
|
3177 |
ptnode_adr(ei)->dump(false); |
238
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3178 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3179 |
} |
803c80713999
6674588: (Escape Analysis) Improve Escape Analysis code
kvn
parents:
212
diff
changeset
|
3180 |
tty->cr(); |
1 | 3181 |
} |
3182 |
} |
|
3183 |
} |
|
3184 |
#endif |