author | tschatzl |
Wed, 18 Apr 2018 11:36:48 +0200 | |
changeset 49806 | 2d62570a615c |
parent 49659 | 0ed1370f52bb |
child 51332 | c25572739e7c |
permissions | -rw-r--r-- |
1374 | 1 |
/* |
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
2 |
* Copyright (c) 2001, 2018, Oracle and/or its affiliates. All rights reserved. |
1374 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4458
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4458
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4458
diff
changeset
|
21 |
* questions. |
1374 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
30764 | 26 |
#include "gc/g1/g1CollectedHeap.inline.hpp" |
49659
0ed1370f52bb
8200371: In g1, rename ConcurrentMarkThread to G1ConcurrentMarkThread
lkorinth
parents:
49449
diff
changeset
|
27 |
#include "gc/g1/g1ConcurrentMarkThread.inline.hpp" |
37985
539c597ee0fa
8154154: Separate G1 specific policy code from the CollectorPolicy class hierarchy
mgerdin
parents:
37235
diff
changeset
|
28 |
#include "gc/g1/g1Policy.hpp" |
33107
77bf0d2069a3
8134953: Make the GC ID available in a central place
brutisso
parents:
33105
diff
changeset
|
29 |
#include "gc/shared/gcId.hpp" |
30764 | 30 |
#include "gc/g1/vm_operations_g1.hpp" |
31 |
#include "gc/shared/gcTimer.hpp" |
|
35061 | 32 |
#include "gc/shared/gcTraceTime.inline.hpp" |
30764 | 33 |
#include "gc/shared/isGCActiveMark.hpp" |
49449
ef5d5d343e2a
8199263: Split interfaceSupport.hpp to not require including .inline.hpp files
coleenp
parents:
49377
diff
changeset
|
34 |
#include "runtime/interfaceSupport.inline.hpp" |
1374 | 35 |
|
36 |
void VM_G1CollectFull::doit() { |
|
37 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
|
38 |
GCCauseSetter x(g1h, _gc_cause); |
|
39 |
g1h->do_full_collection(false /* clear_all_soft_refs */); |
|
40 |
} |
|
41 |
||
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
42 |
VM_G1CollectForAllocation::VM_G1CollectForAllocation(size_t word_size, |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
43 |
uint gc_count_before, |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
44 |
GCCause::Cause gc_cause, |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
45 |
bool should_initiate_conc_mark, |
49323 | 46 |
double target_pause_time_ms) |
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
47 |
: VM_CollectForAllocation(word_size, gc_count_before, gc_cause), |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
48 |
_pause_succeeded(false), |
7398 | 49 |
_should_initiate_conc_mark(should_initiate_conc_mark), |
50 |
_target_pause_time_ms(target_pause_time_ms), |
|
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
51 |
_should_retry_gc(false), |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
52 |
_old_marking_cycles_completed_before(0) { |
7398 | 53 |
guarantee(target_pause_time_ms > 0.0, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32185
diff
changeset
|
54 |
"target_pause_time_ms = %1.6lf should be positive", |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32185
diff
changeset
|
55 |
target_pause_time_ms); |
7398 | 56 |
_gc_cause = gc_cause; |
57 |
} |
|
58 |
||
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
59 |
bool VM_G1CollectForAllocation::doit_prologue() { |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
60 |
bool res = VM_CollectForAllocation::doit_prologue(); |
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
61 |
if (!res) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
62 |
if (_should_initiate_conc_mark) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
63 |
// The prologue can fail for a couple of reasons. The first is that another GC |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
64 |
// got scheduled and prevented the scheduling of the initial mark GC. The |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
65 |
// second is that the GC locker may be active and the heap can't be expanded. |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
66 |
// In both cases we want to retry the GC so that the initial mark pause is |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
67 |
// actually scheduled. In the second case, however, we should stall until |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
68 |
// until the GC locker is no longer active and then retry the initial mark GC. |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
69 |
_should_retry_gc = true; |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
70 |
} |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
71 |
} |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
72 |
return res; |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
73 |
} |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
74 |
|
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
75 |
void VM_G1CollectForAllocation::doit() { |
1374 | 76 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
27900
d24cd7a1ed38
8065579: WB method to start G1 concurrent mark cycle should be introduced
tschatzl
parents:
27887
diff
changeset
|
77 |
assert(!_should_initiate_conc_mark || g1h->should_do_concurrent_full_gc(_gc_cause), |
d24cd7a1ed38
8065579: WB method to start G1 concurrent mark cycle should be introduced
tschatzl
parents:
27887
diff
changeset
|
78 |
"only a GC locker, a System.gc(), stats update, whitebox, or a hum allocation induced GC should start a cycle"); |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
79 |
|
7398 | 80 |
if (_word_size > 0) { |
81 |
// An allocation has been requested. So, try to do that first. |
|
32185
49a57ff2c3cb
8073052: Rename and clean up the allocation manager hierarchy in g1Allocator.?pp
tschatzl
parents:
31032
diff
changeset
|
82 |
_result = g1h->attempt_allocation_at_safepoint(_word_size, |
49a57ff2c3cb
8073052: Rename and clean up the allocation manager hierarchy in g1Allocator.?pp
tschatzl
parents:
31032
diff
changeset
|
83 |
false /* expect_null_cur_alloc_region */); |
7398 | 84 |
if (_result != NULL) { |
85 |
// If we can successfully allocate before we actually do the |
|
86 |
// pause then we will consider this pause successful. |
|
87 |
_pause_succeeded = true; |
|
88 |
return; |
|
89 |
} |
|
90 |
} |
|
91 |
||
4458
075a9ef4e467
6902303: G1: ScavengeALot should cause an incremental, rather than a full, collection
ysr
parents:
3261
diff
changeset
|
92 |
GCCauseSetter x(g1h, _gc_cause); |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
93 |
if (_should_initiate_conc_mark) { |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
94 |
// It's safer to read old_marking_cycles_completed() here, given |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
95 |
// that noone else will be updating it concurrently. Since we'll |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
96 |
// only need it if we're initiating a marking cycle, no point in |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
97 |
// setting it earlier. |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
98 |
_old_marking_cycles_completed_before = g1h->old_marking_cycles_completed(); |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
99 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
100 |
// At this point we are supposed to start a concurrent cycle. We |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
101 |
// will do so if one is not already in progress. |
10523
cdb54c167ab0
7050392: G1: Introduce flag to generate a log of the G1 ergonomic decisions
tonyp
parents:
9996
diff
changeset
|
102 |
bool res = g1h->g1_policy()->force_initial_mark_if_outside_cycle(_gc_cause); |
9996
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
103 |
|
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
104 |
// The above routine returns true if we were able to force the |
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
105 |
// next GC pause to be an initial mark; it returns false if a |
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
106 |
// marking cycle is already in progress. |
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
107 |
// |
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
108 |
// If a marking cycle is already in progress just return and skip the |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
109 |
// pause below - if the reason for requesting this initial mark pause |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
110 |
// was due to a System.gc() then the requesting thread should block in |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
111 |
// doit_epilogue() until the marking cycle is complete. |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
112 |
// |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
113 |
// If this initial mark pause was requested as part of a humongous |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
114 |
// allocation then we know that the marking cycle must just have |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
115 |
// been started by another thread (possibly also allocating a humongous |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
116 |
// object) as there was no active marking cycle when the requesting |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
117 |
// thread checked before calling collect() in |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
118 |
// attempt_allocation_humongous(). Retrying the GC, in this case, |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
119 |
// will cause the requesting thread to spin inside collect() until the |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
120 |
// just started marking cycle is complete - which may be a while. So |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
121 |
// we do NOT retry the GC. |
9996
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
122 |
if (!res) { |
12227
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
123 |
assert(_word_size == 0, "Concurrent Full GC/Humongous Object IM shouldn't be allocating"); |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
124 |
if (_gc_cause != GCCause::_g1_humongous_allocation) { |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
125 |
_should_retry_gc = true; |
371690c4f281
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents:
11576
diff
changeset
|
126 |
} |
9996
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
127 |
return; |
3851e45f93e7
7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents:
8921
diff
changeset
|
128 |
} |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
129 |
} |
7398 | 130 |
|
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
131 |
// Try a partial collection of some kind. |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
132 |
_pause_succeeded = g1h->do_collection_pause_at_safepoint(_target_pause_time_ms); |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
133 |
|
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
134 |
if (_pause_succeeded) { |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
135 |
if (_word_size > 0) { |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
136 |
// An allocation had been requested. Do it, eventually trying a stronger |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
137 |
// kind of GC. |
49323 | 138 |
_result = g1h->satisfy_failed_allocation(_word_size, &_pause_succeeded); |
48638
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
139 |
} else { |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
140 |
bool should_upgrade_to_full = !g1h->should_do_concurrent_full_gc(_gc_cause) && |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
141 |
!g1h->has_regions_left_for_allocation(); |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
142 |
if (should_upgrade_to_full) { |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
143 |
// There has been a request to perform a GC to free some space. We have no |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
144 |
// information on how much memory has been asked for. In case there are |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
145 |
// absolutely no regions left to allocate into, do a maximally compacting full GC. |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
146 |
log_info(gc, ergo)("Attempting maximally compacting collection"); |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
147 |
_pause_succeeded = g1h->do_full_collection(false, /* explicit gc */ |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
148 |
true /* clear_all_soft_refs */); |
01094f78d990
8195158: Concurrent System.gc() is "upgraded" to stop-the-world System.gc()
ehelin
parents:
48631
diff
changeset
|
149 |
} |
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
150 |
} |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
151 |
guarantee(_pause_succeeded, "Elevated collections during the safepoint must always succeed."); |
7398 | 152 |
} else { |
153 |
assert(_result == NULL, "invariant"); |
|
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
154 |
// The only reason for the pause to not be successful is that, the GC locker is |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
155 |
// active (or has become active since the prologue was executed). In this case |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
156 |
// we should retry the pause after waiting for the GC locker to become inactive. |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
157 |
_should_retry_gc = true; |
7398 | 158 |
} |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
159 |
} |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
160 |
|
48631
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
161 |
void VM_G1CollectForAllocation::doit_epilogue() { |
862c41cf1c7f
8137099: G1 needs to "upgrade" GC within the safepoint if it can't allocate during that safepoint to avoid OoME
tschatzl
parents:
47216
diff
changeset
|
162 |
VM_CollectForAllocation::doit_epilogue(); |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
163 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
164 |
// If the pause was initiated by a System.gc() and |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
165 |
// +ExplicitGCInvokesConcurrent, we have to wait here for the cycle |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
166 |
// that just started (or maybe one that was already in progress) to |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
167 |
// finish. |
31032
8e72621ca186
8072913: [REDO] GCCause should distinguish jcmd GC.run from System.gc()
ysuenaga
parents:
30764
diff
changeset
|
168 |
if (GCCause::is_user_requested_gc(_gc_cause) && |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
169 |
_should_initiate_conc_mark) { |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
170 |
assert(ExplicitGCInvokesConcurrent, |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
171 |
"the only way to be here is if ExplicitGCInvokesConcurrent is set"); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
172 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
173 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
174 |
|
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
175 |
// In the doit() method we saved g1h->old_marking_cycles_completed() |
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
176 |
// in the _old_marking_cycles_completed_before field. We have to |
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
177 |
// wait until we observe that g1h->old_marking_cycles_completed() |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
178 |
// has increased by at least one. This can happen if a) we started |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
179 |
// a cycle and it completes, b) a cycle already in progress |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
180 |
// completes, or c) a Full GC happens. |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
181 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
182 |
// If the condition has already been reached, there's no point in |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
183 |
// actually taking the lock and doing the wait. |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
184 |
if (g1h->old_marking_cycles_completed() <= |
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
185 |
_old_marking_cycles_completed_before) { |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
186 |
// The following is largely copied from CMS |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
187 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
188 |
Thread* thr = Thread::current(); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
189 |
assert(thr->is_Java_thread(), "invariant"); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
190 |
JavaThread* jt = (JavaThread*)thr; |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
191 |
ThreadToNativeFromVM native(jt); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
192 |
|
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
193 |
MutexLockerEx x(FullGCCount_lock, Mutex::_no_safepoint_check_flag); |
12934
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
194 |
while (g1h->old_marking_cycles_completed() <= |
f9bc0e664918
7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents:
12628
diff
changeset
|
195 |
_old_marking_cycles_completed_before) { |
6058
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
196 |
FullGCCount_lock->wait(Mutex::_no_safepoint_check_flag); |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
197 |
} |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
198 |
} |
9c9aec6ab47d
6944166: G1: explicit GCs are not always handled correctly
tonyp
parents:
5547
diff
changeset
|
199 |
} |
1374 | 200 |
} |
201 |
||
202 |
void VM_CGC_Operation::doit() { |
|
35061 | 203 |
GCIdMark gc_id_mark(_gc_id); |
204 |
GCTraceCPUTime tcpu; |
|
30147
af9a41999c6e
8076314: Remove the static instance variable SharedHeap:: _sh
brutisso
parents:
29079
diff
changeset
|
205 |
G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
37137
62fd3fb4b1b1
8151085: Change G1 concurrent timer and tracer measuring time
sangheki
parents:
37129
diff
changeset
|
206 |
GCTraceTime(Info, gc) t(_printGCMessage, g1h->concurrent_mark()->gc_timer_cm(), GCCause::_no_gc, true); |
49377
ecd91135d645
8153333: [REDO] STW phases at Concurrent GC should count in PerfCounte
ysuenaga
parents:
49323
diff
changeset
|
207 |
TraceCollectorStats tcs(g1h->g1mm()->conc_collection_counters()); |
ecd91135d645
8153333: [REDO] STW phases at Concurrent GC should count in PerfCounte
ysuenaga
parents:
49323
diff
changeset
|
208 |
SvcGCMarker sgcm(SvcGCMarker::CONCURRENT); |
30147
af9a41999c6e
8076314: Remove the static instance variable SharedHeap:: _sh
brutisso
parents:
29079
diff
changeset
|
209 |
IsGCActiveMark x; |
af9a41999c6e
8076314: Remove the static instance variable SharedHeap:: _sh
brutisso
parents:
29079
diff
changeset
|
210 |
_cl->do_void(); |
1374 | 211 |
} |
212 |
||
213 |
bool VM_CGC_Operation::doit_prologue() { |
|
214 |
Heap_lock->lock(); |
|
215 |
return true; |
|
216 |
} |
|
217 |
||
218 |
void VM_CGC_Operation::doit_epilogue() { |
|
40892
330a02d935ad
8156500: Move Reference pending list into VM to prevent deadlocks
kbarrett
parents:
37985
diff
changeset
|
219 |
if (Universe::has_reference_pending_list()) { |
330a02d935ad
8156500: Move Reference pending list into VM to prevent deadlocks
kbarrett
parents:
37985
diff
changeset
|
220 |
Heap_lock->notify_all(); |
330a02d935ad
8156500: Move Reference pending list into VM to prevent deadlocks
kbarrett
parents:
37985
diff
changeset
|
221 |
} |
1374 | 222 |
Heap_lock->unlock(); |
223 |
} |