author | tschatzl |
Wed, 24 Jul 2019 11:49:39 +0200 | |
changeset 57508 | 28ab01c06755 |
parent 47216 | 71c04702a3d5 |
permissions | -rw-r--r-- |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
1 |
/* |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
2 |
* Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
4 |
* |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
8 |
* |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
13 |
* accompanied this code). |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
14 |
* |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
18 |
* |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
21 |
* questions. |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
22 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
23 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
24 |
/* |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
25 |
* @test |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
26 |
* @bug 7105952 6322678 7082769 |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
27 |
* @summary Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
28 |
* @run main/othervm Sharing |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
29 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
30 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
31 |
import java.io.*; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
32 |
import java.nio.channels.FileChannel; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
33 |
import java.nio.channels.FileLock; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
34 |
import java.util.concurrent.CountDownLatch; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
35 |
|
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
36 |
public class Sharing { |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
37 |
|
32649
2ee9017c7597
8136583: Core libraries should use blessed modifier order
martin
parents:
11017
diff
changeset
|
38 |
static final int numFiles = 10; |
2ee9017c7597
8136583: Core libraries should use blessed modifier order
martin
parents:
11017
diff
changeset
|
39 |
static volatile boolean fail; |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
40 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
41 |
public static void main(String[] args) throws Exception { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
42 |
TestFinalizer(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
43 |
TestMultipleFD(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
44 |
TestIsValid(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
45 |
MultiThreadedFD(); |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
46 |
TestCloseAll(); |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
47 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
48 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
49 |
/** |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
50 |
* Finalizer shouldn't discard a file descriptor until all streams have |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
51 |
* finished with it. |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
52 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
53 |
private static void TestFinalizer() throws Exception { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
54 |
FileDescriptor fd = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
55 |
File tempFile = new File("TestFinalizer1.txt"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
56 |
tempFile.deleteOnExit(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
57 |
try (Writer writer = new FileWriter(tempFile)) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
58 |
for (int i=0; i<5; i++) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
59 |
writer.write("test file content test file content"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
60 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
61 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
62 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
63 |
FileInputStream fis1 = new FileInputStream(tempFile); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
64 |
fd = fis1.getFD(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
65 |
// Create a new FIS based on the existing FD (so the two FIS's share the same native fd) |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
66 |
try (FileInputStream fis2 = new FileInputStream(fd)) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
67 |
// allow fis1 to be gc'ed |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
68 |
fis1 = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
69 |
int ret = 0; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
70 |
while(ret >= 0) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
71 |
// encourage gc |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
72 |
System.gc(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
73 |
// read from fis2 - when fis1 is gc'ed and finalizer is run, read will fail |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
74 |
System.out.print("."); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
75 |
ret = fis2.read(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
76 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
77 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
78 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
79 |
// variation of above. Use RandomAccessFile to obtain a filedescriptor |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
80 |
File testFinalizerFile = new File("TestFinalizer"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
81 |
RandomAccessFile raf = new RandomAccessFile(testFinalizerFile, "rw"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
82 |
raf.writeBytes("test file content test file content"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
83 |
raf.seek(0L); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
84 |
fd = raf.getFD(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
85 |
try (FileInputStream fis3 = new FileInputStream(fd)) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
86 |
// allow raf to be gc'ed |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
87 |
raf = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
88 |
int ret = 0; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
89 |
while (ret >= 0) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
90 |
// encourage gc |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
91 |
System.gc(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
92 |
/* |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
93 |
* read from fis3 - when raf is gc'ed and finalizer is run, |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
94 |
* fd should still be valid. |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
95 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
96 |
System.out.print("."); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
97 |
ret = fis3.read(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
98 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
99 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
100 |
testFinalizerFile.delete(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
101 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
102 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
103 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
104 |
/** |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
105 |
* Exercise FileDispatcher close()/preClose() |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
106 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
107 |
private static void TestMultipleFD() throws Exception { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
108 |
RandomAccessFile raf = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
109 |
FileOutputStream fos = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
110 |
FileInputStream fis = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
111 |
FileChannel fc = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
112 |
FileLock fileLock = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
113 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
114 |
File test1 = new File("test1"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
115 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
116 |
raf = new RandomAccessFile(test1, "rw"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
117 |
fos = new FileOutputStream(raf.getFD()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
118 |
fis = new FileInputStream(raf.getFD()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
119 |
fc = raf.getChannel(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
120 |
fileLock = fc.lock(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
121 |
raf.setLength(0L); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
122 |
fos.flush(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
123 |
fos.write("TEST".getBytes()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
124 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
125 |
if (fileLock != null) fileLock.release(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
126 |
if (fis != null) fis.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
127 |
if (fos != null) fos.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
128 |
if (raf != null) raf.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
129 |
test1.delete(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
130 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
131 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
132 |
/* |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
133 |
* Close out in different order to ensure FD is not |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
134 |
* closed out too early |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
135 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
136 |
File test2 = new File("test2"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
137 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
138 |
raf = new RandomAccessFile(test2, "rw"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
139 |
fos = new FileOutputStream(raf.getFD()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
140 |
fis = new FileInputStream(raf.getFD()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
141 |
fc = raf.getChannel(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
142 |
fileLock = fc.lock(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
143 |
raf.setLength(0L); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
144 |
fos.flush(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
145 |
fos.write("TEST".getBytes()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
146 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
147 |
if (fileLock != null) fileLock.release(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
148 |
if (raf != null) raf.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
149 |
if (fos != null) fos.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
150 |
if (fis != null) fis.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
151 |
test2.delete(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
152 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
153 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
154 |
// one more time, fos first this time |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
155 |
File test3 = new File("test3"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
156 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
157 |
raf = new RandomAccessFile(test3, "rw"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
158 |
fos = new FileOutputStream(raf.getFD()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
159 |
fis = new FileInputStream(raf.getFD()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
160 |
fc = raf.getChannel(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
161 |
fileLock = fc.lock(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
162 |
raf.setLength(0L); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
163 |
fos.flush(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
164 |
fos.write("TEST".getBytes()); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
165 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
166 |
if (fileLock != null) fileLock.release(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
167 |
if (fos != null) fos.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
168 |
if (raf != null) raf.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
169 |
if (fis != null) fis.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
170 |
test3.delete(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
171 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
172 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
173 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
174 |
/** |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
175 |
* Similar to TestMultipleFD() but this time we |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
176 |
* just get and use FileDescriptor.valid() for testing. |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
177 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
178 |
private static void TestIsValid() throws Exception { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
179 |
FileDescriptor fd = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
180 |
RandomAccessFile raf = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
181 |
FileOutputStream fos = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
182 |
FileInputStream fis = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
183 |
FileChannel fc = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
184 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
185 |
File test1 = new File("test1"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
186 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
187 |
raf = new RandomAccessFile(test1, "rw"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
188 |
fd = raf.getFD(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
189 |
fos = new FileOutputStream(fd); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
190 |
fis = new FileInputStream(fd); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
191 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
192 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
193 |
if (fis != null) fis.close(); |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
194 |
if (fd.valid()) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
195 |
throw new RuntimeException("[FIS close()] FileDescriptor shouldn't be valid"); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
196 |
} |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
197 |
if (fos != null) fos.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
198 |
if (raf != null) raf.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
199 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
200 |
test1.delete(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
201 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
202 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
203 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
204 |
/* |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
205 |
* Close out in different order to ensure FD is |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
206 |
* closed correctly. |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
207 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
208 |
File test2 = new File("test2"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
209 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
210 |
raf = new RandomAccessFile(test2, "rw"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
211 |
fd = raf.getFD(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
212 |
fos = new FileOutputStream(fd); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
213 |
fis = new FileInputStream(fd); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
214 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
215 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
216 |
if (raf != null) raf.close(); |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
217 |
if (fd.valid()) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
218 |
throw new RuntimeException("[RAF close()] FileDescriptor shouldn't be valid"); |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
219 |
} |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
220 |
if (fos != null) fos.close(); |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
221 |
if (fis != null) fis.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
222 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
223 |
test2.delete(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
224 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
225 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
226 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
227 |
// one more time, fos first this time |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
228 |
File test3 = new File("test3"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
229 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
230 |
raf = new RandomAccessFile(test3, "rw"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
231 |
fd = raf.getFD(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
232 |
fos = new FileOutputStream(fd); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
233 |
fis = new FileInputStream(fd); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
234 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
235 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
236 |
if (fos != null) fos.close(); |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
237 |
if (fd.valid()) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
238 |
throw new RuntimeException("[FOS close()] FileDescriptor shouldn't be valid"); |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
239 |
} |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
240 |
if (raf != null) raf.close(); |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
241 |
if (fis != null) fis.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
242 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
243 |
test3.delete(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
244 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
245 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
246 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
247 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
248 |
/** |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
249 |
* Test concurrent access to the same FileDescriptor |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
250 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
251 |
private static void MultiThreadedFD() throws Exception { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
252 |
RandomAccessFile raf = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
253 |
FileDescriptor fd = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
254 |
int numThreads = 2; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
255 |
CountDownLatch done = new CountDownLatch(numThreads); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
256 |
OpenClose[] fileOpenClose = new OpenClose[numThreads]; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
257 |
File MultipleThreadedFD = new File("MultipleThreadedFD"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
258 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
259 |
raf = new RandomAccessFile(MultipleThreadedFD, "rw"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
260 |
fd = raf.getFD(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
261 |
for(int count=0;count<numThreads;count++) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
262 |
fileOpenClose[count] = new OpenClose(fd, done); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
263 |
fileOpenClose[count].start(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
264 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
265 |
done.await(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
266 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
267 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
268 |
if(raf != null) raf.close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
269 |
// fd should now no longer be valid |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
270 |
if(fd.valid()) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
271 |
throw new RuntimeException("FileDescriptor should not be valid"); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
272 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
273 |
// OpenClose thread tests failed |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
274 |
if(fail) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
275 |
throw new RuntimeException("OpenClose thread tests failed."); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
276 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
277 |
} finally { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
278 |
MultipleThreadedFD.delete(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
279 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
280 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
281 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
282 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
283 |
/** |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
284 |
* Test closeAll handling in FileDescriptor |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
285 |
*/ |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
286 |
private static void TestCloseAll() throws Exception { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
287 |
File testFile = new File("test"); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
288 |
testFile.deleteOnExit(); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
289 |
RandomAccessFile raf = new RandomAccessFile(testFile, "rw"); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
290 |
FileInputStream fis = new FileInputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
291 |
fis.close(); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
292 |
if (raf.getFD().valid()) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
293 |
throw new RuntimeException("FD should not be valid."); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
294 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
295 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
296 |
// Test the suppressed exception handling - FileInputStream |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
297 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
298 |
raf = new RandomAccessFile(testFile, "rw"); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
299 |
fis = new FileInputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
300 |
BadFileInputStream bfis1 = new BadFileInputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
301 |
BadFileInputStream bfis2 = new BadFileInputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
302 |
BadFileInputStream bfis3 = new BadFileInputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
303 |
// extra test - set bfis3 to null |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
304 |
bfis3 = null; |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
305 |
try { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
306 |
fis.close(); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
307 |
} catch (IOException ioe) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
308 |
ioe.printStackTrace(); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
309 |
if (ioe.getSuppressed().length != 2) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
310 |
throw new RuntimeException("[FIS]Incorrect number of suppressed " + |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
311 |
"exceptions received : " + ioe.getSuppressed().length); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
312 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
313 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
314 |
if (raf.getFD().valid()) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
315 |
// we should still have closed the FD |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
316 |
// even with the exception. |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
317 |
throw new RuntimeException("[FIS]TestCloseAll : FD still valid."); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
318 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
319 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
320 |
// Now test with FileOutputStream |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
321 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
322 |
raf = new RandomAccessFile(testFile, "rw"); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
323 |
FileOutputStream fos = new FileOutputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
324 |
BadFileOutputStream bfos1 = new BadFileOutputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
325 |
BadFileOutputStream bfos2 = new BadFileOutputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
326 |
BadFileOutputStream bfos3 = new BadFileOutputStream(raf.getFD()); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
327 |
// extra test - set bfos3 to null |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
328 |
bfos3 = null; |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
329 |
try { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
330 |
fos.close(); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
331 |
} catch (IOException ioe) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
332 |
ioe.printStackTrace(); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
333 |
if (ioe.getSuppressed().length != 2) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
334 |
throw new RuntimeException("[FOS]Incorrect number of suppressed " + |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
335 |
"exceptions received : " + ioe.getSuppressed().length); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
336 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
337 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
338 |
if (raf.getFD().valid()) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
339 |
// we should still have closed the FD |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
340 |
// even with the exception. |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
341 |
throw new RuntimeException("[FOS]TestCloseAll : FD still valid."); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
342 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
343 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
344 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
345 |
/** |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
346 |
* A thread which will open and close a number of FileInputStreams and |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
347 |
* FileOutputStreams referencing the same native file descriptor. |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
348 |
*/ |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
349 |
private static class OpenClose extends Thread { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
350 |
private FileDescriptor fd = null; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
351 |
private CountDownLatch done; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
352 |
FileInputStream[] fisArray = new FileInputStream[numFiles]; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
353 |
FileOutputStream[] fosArray = new FileOutputStream[numFiles]; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
354 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
355 |
OpenClose(FileDescriptor filedescriptor, CountDownLatch done) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
356 |
this.fd = filedescriptor; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
357 |
this.done = done; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
358 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
359 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
360 |
public void run() { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
361 |
try { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
362 |
for(int i=0;i<numFiles;i++) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
363 |
fisArray[i] = new FileInputStream(fd); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
364 |
fosArray[i] = new FileOutputStream(fd); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
365 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
366 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
367 |
// Now close out |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
368 |
for(int i=0;i<numFiles;i++) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
369 |
if(fisArray[i] != null) fisArray[i].close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
370 |
if(fosArray[i] != null) fosArray[i].close(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
371 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
372 |
|
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
373 |
} catch(IOException ioe) { |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
374 |
System.out.println("OpenClose encountered IO issue :" + ioe); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
375 |
fail = true; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
376 |
} finally { |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
377 |
if (fd.valid()) { // fd should not be valid after first close() call |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
378 |
System.out.println("OpenClose: FileDescriptor shouldn't be valid"); |
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
379 |
fail = true; |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
380 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
381 |
done.countDown(); |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
382 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
383 |
} |
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
384 |
} |
11017
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
385 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
386 |
private static class BadFileInputStream extends FileInputStream { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
387 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
388 |
BadFileInputStream(FileDescriptor fd) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
389 |
super(fd); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
390 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
391 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
392 |
public void close() throws IOException { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
393 |
throw new IOException("Bad close operation"); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
394 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
395 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
396 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
397 |
private static class BadFileOutputStream extends FileOutputStream { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
398 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
399 |
BadFileOutputStream(FileDescriptor fd) { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
400 |
super(fd); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
401 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
402 |
|
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
403 |
public void close() throws IOException { |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
404 |
throw new IOException("Bad close operation"); |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
405 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
406 |
} |
353f81426721
7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
coffeys
parents:
10586
diff
changeset
|
407 |
|
10586
6e20ecfec8ed
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
coffeys
parents:
diff
changeset
|
408 |
} |