author | coleenp |
Wed, 24 Jul 2019 10:22:11 -0400 | |
changeset 57511 | 00ae3b739184 |
parent 55105 | 9ad765641e8f |
child 58447 | 319173c62caa |
permissions | -rw-r--r-- |
1 | 1 |
/* |
53584
f72661ff0294
8212949: Remove ConstantPoolCache::is_constantPoolCache
coleenp
parents:
53315
diff
changeset
|
2 |
* Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5420
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5420
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5420
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
47684
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
26 |
#include "classfile/resolutionErrors.hpp" |
47103
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
27 |
#include "interpreter/bytecodeStream.hpp" |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
28 |
#include "interpreter/bytecodes.hpp" |
7397 | 29 |
#include "interpreter/interpreter.hpp" |
49593
4dd58ecc9912
8200105: Remove cyclic dependency between oop.inline.hpp and collectedHeap.inline.hpp
stefank
parents:
49359
diff
changeset
|
30 |
#include "interpreter/linkResolver.hpp" |
7397 | 31 |
#include "interpreter/rewriter.hpp" |
38259
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
38033
diff
changeset
|
32 |
#include "logging/log.hpp" |
52062
8dbf1a13af49
8206009: Move CDS java heap object archiving code to heapShared.hpp and heapShared.cpp
jiangli
parents:
51491
diff
changeset
|
33 |
#include "memory/heapShared.hpp" |
47095
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
34 |
#include "memory/metadataFactory.hpp" |
46746
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46727
diff
changeset
|
35 |
#include "memory/metaspaceClosure.hpp" |
50532 | 36 |
#include "memory/metaspaceShared.hpp" |
37248 | 37 |
#include "memory/resourceArea.hpp" |
48784
899b522ed65c
8194741: Refactor oops in constant pool from CDS to use the Access API
eosterlund
parents:
48463
diff
changeset
|
38 |
#include "oops/access.inline.hpp" |
54780
f8d182aedc92
8223136: Move compressed oops functions to CompressedOops class
stefank
parents:
54752
diff
changeset
|
39 |
#include "oops/compressedOops.hpp" |
49340
4e82736053ae
8191102: Incorrect include file use in classLoader.hpp
hseigel
parents:
48819
diff
changeset
|
40 |
#include "oops/constantPool.inline.hpp" |
4e82736053ae
8191102: Incorrect include file use in classLoader.hpp
hseigel
parents:
48819
diff
changeset
|
41 |
#include "oops/cpCache.inline.hpp" |
29081
c61eb4914428
8072911: Remove includes of oop.inline.hpp from .hpp files
stefank
parents:
28019
diff
changeset
|
42 |
#include "oops/objArrayOop.inline.hpp" |
7397 | 43 |
#include "oops/oop.inline.hpp" |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
44 |
#include "prims/methodHandles.hpp" |
40655
9f644073d3a0
8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp
dholmes
parents:
38259
diff
changeset
|
45 |
#include "runtime/atomic.hpp" |
7397 | 46 |
#include "runtime/handles.inline.hpp" |
50429
83aec1d357d4
8204301: Make OrderAccess functions available to hpp rather than inline.hpp files
coleenp
parents:
49773
diff
changeset
|
47 |
#include "runtime/orderAccess.hpp" |
15482
470d0b0c09f1
8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS
jprovino
parents:
14490
diff
changeset
|
48 |
#include "utilities/macros.hpp" |
1 | 49 |
|
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
24351
diff
changeset
|
50 |
// Implementation of ConstantPoolCacheEntry |
1 | 51 |
|
4429
d7eb4e2099aa
6858164: invokedynamic code needs some cleanup (post-6655638)
jrose
parents:
3261
diff
changeset
|
52 |
void ConstantPoolCacheEntry::initialize_entry(int index) { |
2570
ecc7862946d4
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
670
diff
changeset
|
53 |
assert(0 < index && index < 0x10000, "sanity check"); |
1 | 54 |
_indices = index; |
15928
f9d5c6e4107f
8003553: NPG: metaspace objects should be zeroed in constructors
coleenp
parents:
15595
diff
changeset
|
55 |
_f1 = NULL; |
f9d5c6e4107f
8003553: NPG: metaspace objects should be zeroed in constructors
coleenp
parents:
15595
diff
changeset
|
56 |
_f2 = _flags = 0; |
2570
ecc7862946d4
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
670
diff
changeset
|
57 |
assert(constant_pool_index() == index, ""); |
1 | 58 |
} |
59 |
||
47103
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
60 |
void ConstantPoolCacheEntry::verify_just_initialized(bool f2_used) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
61 |
assert((_indices & (~cp_index_mask)) == 0, "sanity"); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
62 |
assert(_f1 == NULL, "sanity"); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
63 |
assert(_flags == 0, "sanity"); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
64 |
if (!f2_used) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
65 |
assert(_f2 == 0, "sanity"); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
66 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
67 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
68 |
|
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
69 |
void ConstantPoolCacheEntry::reinitialize(bool f2_used) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
70 |
_indices &= cp_index_mask; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
71 |
_f1 = NULL; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
72 |
_flags = 0; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
73 |
if (!f2_used) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
74 |
_f2 = 0; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
75 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
76 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
77 |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
78 |
int ConstantPoolCacheEntry::make_flags(TosState state, |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
79 |
int option_bits, |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
80 |
int field_index_or_method_params) { |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
81 |
assert(state < number_of_states, "Invalid state in make_flags"); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
82 |
int f = ((int)state << tos_state_shift) | option_bits | field_index_or_method_params; |
1 | 83 |
// Preserve existing flag bit values |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
84 |
// The low bits are a field offset, or else the method parameter size. |
1 | 85 |
#ifdef ASSERT |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
86 |
TosState old_state = flag_state(); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
87 |
assert(old_state == (TosState)0 || old_state == state, |
1 | 88 |
"inconsistent cpCache flags state"); |
89 |
#endif |
|
90 |
return (_flags | f) ; |
|
91 |
} |
|
92 |
||
93 |
void ConstantPoolCacheEntry::set_bytecode_1(Bytecodes::Code code) { |
|
94 |
#ifdef ASSERT |
|
95 |
// Read once. |
|
96 |
volatile Bytecodes::Code c = bytecode_1(); |
|
97 |
assert(c == 0 || c == code || code == 0, "update must be consistent"); |
|
98 |
#endif |
|
99 |
// Need to flush pending stores here before bytecode is written. |
|
47634
6a0c42c40cd1
8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents:
47216
diff
changeset
|
100 |
OrderAccess::release_store(&_indices, _indices | ((u_char)code << bytecode_1_shift)); |
1 | 101 |
} |
102 |
||
103 |
void ConstantPoolCacheEntry::set_bytecode_2(Bytecodes::Code code) { |
|
104 |
#ifdef ASSERT |
|
105 |
// Read once. |
|
106 |
volatile Bytecodes::Code c = bytecode_2(); |
|
107 |
assert(c == 0 || c == code || code == 0, "update must be consistent"); |
|
108 |
#endif |
|
109 |
// Need to flush pending stores here before bytecode is written. |
|
47634
6a0c42c40cd1
8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents:
47216
diff
changeset
|
110 |
OrderAccess::release_store(&_indices, _indices | ((u_char)code << bytecode_2_shift)); |
1 | 111 |
} |
112 |
||
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
113 |
// Sets f1, ordering with previous writes. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
114 |
void ConstantPoolCacheEntry::release_set_f1(Metadata* f1) { |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
115 |
assert(f1 != NULL, ""); |
47634
6a0c42c40cd1
8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents:
47216
diff
changeset
|
116 |
OrderAccess::release_store(&_f1, f1); |
8316
0816329cc3ee
7012339: JSR 292 crash in G1SATBCardTableModRefBS::write_ref_field_pre_work()
twisti
parents:
7397
diff
changeset
|
117 |
} |
7104 | 118 |
|
47684
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
119 |
void ConstantPoolCacheEntry::set_indy_resolution_failed() { |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
120 |
OrderAccess::release_store(&_flags, _flags | (1 << indy_resolution_failed_shift)); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
121 |
} |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
122 |
|
1 | 123 |
// Note that concurrent update of both bytecodes can leave one of them |
124 |
// reset to zero. This is harmless; the interpreter will simply re-resolve |
|
125 |
// the damaged entry. More seriously, the memory synchronization is needed |
|
126 |
// to flush other fields (f1, f2) completely to memory before the bytecodes |
|
127 |
// are updated, lest other processors see a non-zero bytecode but zero f1/f2. |
|
128 |
void ConstantPoolCacheEntry::set_field(Bytecodes::Code get_code, |
|
129 |
Bytecodes::Code put_code, |
|
46329
53ccc37bda19
8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents:
46271
diff
changeset
|
130 |
Klass* field_holder, |
10546 | 131 |
int field_index, |
1 | 132 |
int field_offset, |
133 |
TosState field_type, |
|
134 |
bool is_final, |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
135 |
bool is_volatile, |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
136 |
Klass* root_klass) { |
46329
53ccc37bda19
8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents:
46271
diff
changeset
|
137 |
set_f1(field_holder); |
1 | 138 |
set_f2(field_offset); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
139 |
assert((field_index & field_index_mask) == field_index, |
1 | 140 |
"field index does not fit in low flag bits"); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
141 |
set_field_flags(field_type, |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
142 |
((is_volatile ? 1 : 0) << is_volatile_shift) | |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
143 |
((is_final ? 1 : 0) << is_final_shift), |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
144 |
field_index); |
1 | 145 |
set_bytecode_1(get_code); |
146 |
set_bytecode_2(put_code); |
|
147 |
NOT_PRODUCT(verify(tty)); |
|
148 |
} |
|
149 |
||
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
150 |
void ConstantPoolCacheEntry::set_parameter_size(int value) { |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
151 |
// This routine is called only in corner cases where the CPCE is not yet initialized. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
152 |
// See AbstractInterpreter::deopt_continue_after_entry. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
153 |
assert(_flags == 0 || parameter_size() == 0 || parameter_size() == value, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31592
diff
changeset
|
154 |
"size must not change: parameter_size=%d, value=%d", parameter_size(), value); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
155 |
// Setting the parameter size by itself is only safe if the |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
156 |
// current value of _flags is 0, otherwise another thread may have |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
157 |
// updated it and we don't want to overwrite that value. Don't |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
158 |
// bother trying to update it once it's nonzero but always make |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
159 |
// sure that the final parameter size agrees with what was passed. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
160 |
if (_flags == 0) { |
47634
6a0c42c40cd1
8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents:
47216
diff
changeset
|
161 |
intx newflags = (value & parameter_size_mask); |
6a0c42c40cd1
8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents:
47216
diff
changeset
|
162 |
Atomic::cmpxchg(newflags, &_flags, (intx)0); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
163 |
} |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
164 |
guarantee(parameter_size() == value, |
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
31592
diff
changeset
|
165 |
"size must not change: parameter_size=%d, value=%d", parameter_size(), value); |
1 | 166 |
} |
167 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
168 |
void ConstantPoolCacheEntry::set_direct_or_vtable_call(Bytecodes::Code invoke_code, |
46727
6e4a84748e2c
8183039: Re-examine methodHandle methods uninlined by 8144256
coleenp
parents:
46630
diff
changeset
|
169 |
const methodHandle& method, |
44738 | 170 |
int vtable_index, |
54752
3fbaea4b1f1c
8223437: Backout JDK-8219974 Restore static callsite resolution for the current class
dholmes
parents:
54723
diff
changeset
|
171 |
bool sender_is_interface) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
172 |
bool is_vtable_call = (vtable_index >= 0); // FIXME: split this method on this boolean |
1 | 173 |
assert(method->interpreter_entry() != NULL, "should have been set at this point"); |
174 |
assert(!method->is_obsolete(), "attempt to write obsolete method to cpCache"); |
|
175 |
||
176 |
int byte_no = -1; |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
177 |
bool change_to_virtual = false; |
50735
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
178 |
InstanceKlass* holder = NULL; // have to declare this outside the switch |
1 | 179 |
switch (invoke_code) { |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
180 |
case Bytecodes::_invokeinterface: |
50735
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
181 |
holder = method->method_holder(); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
182 |
// check for private interface method invocations |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
183 |
if (vtable_index == Method::nonvirtual_vtable_index && holder->is_interface() ) { |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
184 |
assert(method->is_private(), "unexpected non-private method"); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
185 |
assert(method->can_be_statically_bound(), "unexpected non-statically-bound method"); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
186 |
// set_f2_as_vfinal_method checks if is_vfinal flag is true. |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
187 |
set_method_flags(as_TosState(method->result_type()), |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
188 |
( 1 << is_vfinal_shift) | |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
189 |
((method->is_final_method() ? 1 : 0) << is_final_shift), |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
190 |
method()->size_of_parameters()); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
191 |
set_f2_as_vfinal_method(method()); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
192 |
byte_no = 2; |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
193 |
set_f1(holder); // interface klass* |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
194 |
break; |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
195 |
} |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
196 |
else { |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
197 |
// We get here from InterpreterRuntime::resolve_invoke when an invokeinterface |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
198 |
// instruction links to a non-interface method (in Object). This can happen when |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
199 |
// an interface redeclares an Object method (like CharSequence declaring toString()) |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
200 |
// or when invokeinterface is used explicitly. |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
201 |
// In that case, the method has no itable index and must be invoked as a virtual. |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
202 |
// Set a flag to keep track of this corner case. |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
203 |
assert(holder->is_interface() || holder == SystemDictionary::Object_klass(), "unexpected holder class"); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
204 |
assert(method->is_public(), "Calling non-public method in Object with invokeinterface"); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
205 |
change_to_virtual = true; |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
206 |
|
50735
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
207 |
// ...and fall through as if we were handling invokevirtual: |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
208 |
} |
1 | 209 |
case Bytecodes::_invokevirtual: |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
210 |
{ |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
211 |
if (!is_vtable_call) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
212 |
assert(method->can_be_statically_bound(), ""); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
213 |
// set_f2_as_vfinal_method checks if is_vfinal flag is true. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
214 |
set_method_flags(as_TosState(method->result_type()), |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
215 |
( 1 << is_vfinal_shift) | |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
216 |
((method->is_final_method() ? 1 : 0) << is_final_shift) | |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
217 |
((change_to_virtual ? 1 : 0) << is_forced_virtual_shift), |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
218 |
method()->size_of_parameters()); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
219 |
set_f2_as_vfinal_method(method()); |
1 | 220 |
} else { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
221 |
assert(!method->can_be_statically_bound(), ""); |
1 | 222 |
assert(vtable_index >= 0, "valid index"); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
223 |
assert(!method->is_final_method(), "sanity"); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
224 |
set_method_flags(as_TosState(method->result_type()), |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
225 |
((change_to_virtual ? 1 : 0) << is_forced_virtual_shift), |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
226 |
method()->size_of_parameters()); |
1 | 227 |
set_f2(vtable_index); |
228 |
} |
|
229 |
byte_no = 2; |
|
230 |
break; |
|
6062
bab93afe9df7
6964498: JSR 292 invokedynamic sites need local bootstrap methods
jrose
parents:
5547
diff
changeset
|
231 |
} |
bab93afe9df7
6964498: JSR 292 invokedynamic sites need local bootstrap methods
jrose
parents:
5547
diff
changeset
|
232 |
|
1 | 233 |
case Bytecodes::_invokespecial: |
234 |
case Bytecodes::_invokestatic: |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
235 |
assert(!is_vtable_call, ""); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
236 |
// Note: Read and preserve the value of the is_vfinal flag on any |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
237 |
// invokevirtual bytecode shared with this constant pool cache entry. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
238 |
// It is cheap and safe to consult is_vfinal() at all times. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
239 |
// Once is_vfinal is set, it must stay that way, lest we get a dangling oop. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
240 |
set_method_flags(as_TosState(method->result_type()), |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
241 |
((is_vfinal() ? 1 : 0) << is_vfinal_shift) | |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
242 |
((method->is_final_method() ? 1 : 0) << is_final_shift), |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
243 |
method()->size_of_parameters()); |
1 | 244 |
set_f1(method()); |
245 |
byte_no = 1; |
|
246 |
break; |
|
247 |
default: |
|
248 |
ShouldNotReachHere(); |
|
249 |
break; |
|
250 |
} |
|
251 |
||
252 |
// Note: byte_no also appears in TemplateTable::resolve. |
|
253 |
if (byte_no == 1) { |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
254 |
assert(invoke_code != Bytecodes::_invokevirtual && |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
255 |
invoke_code != Bytecodes::_invokeinterface, ""); |
53315 | 256 |
bool do_resolve = true; |
44738 | 257 |
// Don't mark invokespecial to method as resolved if sender is an interface. The receiver |
258 |
// has to be checked that it is a subclass of the current class every time this bytecode |
|
259 |
// is executed. |
|
53315 | 260 |
if (invoke_code == Bytecodes::_invokespecial && sender_is_interface && |
261 |
method->name() != vmSymbols::object_initializer_name()) { |
|
262 |
do_resolve = false; |
|
263 |
} |
|
55105
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
264 |
if (invoke_code == Bytecodes::_invokestatic) { |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
265 |
assert(method->method_holder()->is_initialized() || |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
266 |
method->method_holder()->is_reentrant_initialization(Thread::current()), |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
267 |
"invalid class initialization state for invoke_static"); |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
268 |
|
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
269 |
if (!VM_Version::supports_fast_class_init_checks() && method->needs_clinit_barrier()) { |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
270 |
// Don't mark invokestatic to method as resolved if the holder class has not yet completed |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
271 |
// initialization. An invokestatic must only proceed if the class is initialized, but if |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
272 |
// we resolve it before then that class initialization check is skipped. |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
273 |
// |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
274 |
// When fast class initialization checks are supported (VM_Version::supports_fast_class_init_checks() == true), |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
275 |
// template interpreter supports fast class initialization check for |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
276 |
// invokestatic which doesn't require call site re-resolution to |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
277 |
// enforce class initialization barrier. |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
278 |
do_resolve = false; |
9ad765641e8f
8223213: Implement fast class initialization checks on x86-64
vlivanov
parents:
54927
diff
changeset
|
279 |
} |
53315 | 280 |
} |
281 |
if (do_resolve) { |
|
50735
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
282 |
set_bytecode_1(invoke_code); |
44738 | 283 |
} |
1 | 284 |
} else if (byte_no == 2) { |
285 |
if (change_to_virtual) { |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
286 |
assert(invoke_code == Bytecodes::_invokeinterface, ""); |
1 | 287 |
// NOTE: THIS IS A HACK - BE VERY CAREFUL!!! |
288 |
// |
|
289 |
// Workaround for the case where we encounter an invokeinterface, but we |
|
290 |
// should really have an _invokevirtual since the resolved method is a |
|
291 |
// virtual method in java.lang.Object. This is a corner case in the spec |
|
292 |
// but is presumably legal. javac does not generate this code. |
|
293 |
// |
|
49773 | 294 |
// We do not set bytecode_1() to _invokeinterface, because that is the |
295 |
// bytecode # used by the interpreter to see if it is resolved. In this |
|
296 |
// case, the method gets reresolved with caller for each interface call |
|
297 |
// because the actual selected method may not be public. |
|
298 |
// |
|
1 | 299 |
// We set bytecode_2() to _invokevirtual. |
300 |
// See also interpreterRuntime.cpp. (8/25/2000) |
|
301 |
} else { |
|
50735
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
302 |
assert(invoke_code == Bytecodes::_invokevirtual || |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
303 |
(invoke_code == Bytecodes::_invokeinterface && |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
304 |
((method->is_private() || |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
305 |
(method->is_final() && method->method_holder() == SystemDictionary::Object_klass())))), |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
306 |
"unexpected invocation mode"); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
307 |
if (invoke_code == Bytecodes::_invokeinterface && |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
308 |
(method->is_private() || method->is_final())) { |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
309 |
// We set bytecode_1() to _invokeinterface, because that is the |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
310 |
// bytecode # used by the interpreter to see if it is resolved. |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
311 |
// We set bytecode_2() to _invokevirtual. |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
312 |
set_bytecode_1(invoke_code); |
2f2af62dfac7
8010319: Implementation of JEP 181: Nest-Based Access Control
dholmes
parents:
50532
diff
changeset
|
313 |
} |
1 | 314 |
} |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
315 |
// set up for invokevirtual, even if linking for invokeinterface also: |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
316 |
set_bytecode_2(Bytecodes::_invokevirtual); |
1 | 317 |
} else { |
318 |
ShouldNotReachHere(); |
|
319 |
} |
|
320 |
NOT_PRODUCT(verify(tty)); |
|
321 |
} |
|
322 |
||
46727
6e4a84748e2c
8183039: Re-examine methodHandle methods uninlined by 8144256
coleenp
parents:
46630
diff
changeset
|
323 |
void ConstantPoolCacheEntry::set_direct_call(Bytecodes::Code invoke_code, const methodHandle& method, |
54752
3fbaea4b1f1c
8223437: Backout JDK-8219974 Restore static callsite resolution for the current class
dholmes
parents:
54723
diff
changeset
|
324 |
bool sender_is_interface) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
325 |
int index = Method::nonvirtual_vtable_index; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
326 |
// index < 0; FIXME: inline and customize set_direct_or_vtable_call |
54752
3fbaea4b1f1c
8223437: Backout JDK-8219974 Restore static callsite resolution for the current class
dholmes
parents:
54723
diff
changeset
|
327 |
set_direct_or_vtable_call(invoke_code, method, index, sender_is_interface); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
328 |
} |
1 | 329 |
|
46727
6e4a84748e2c
8183039: Re-examine methodHandle methods uninlined by 8144256
coleenp
parents:
46630
diff
changeset
|
330 |
void ConstantPoolCacheEntry::set_vtable_call(Bytecodes::Code invoke_code, const methodHandle& method, int index) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
331 |
// either the method is a miranda or its holder should accept the given index |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
332 |
assert(method->method_holder()->is_interface() || method->method_holder()->verify_vtable_index(index), ""); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
333 |
// index >= 0; FIXME: inline and customize set_direct_or_vtable_call |
54752
3fbaea4b1f1c
8223437: Backout JDK-8219974 Restore static callsite resolution for the current class
dholmes
parents:
54723
diff
changeset
|
334 |
set_direct_or_vtable_call(invoke_code, method, index, false); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
335 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
336 |
|
48557 | 337 |
void ConstantPoolCacheEntry::set_itable_call(Bytecodes::Code invoke_code, |
338 |
Klass* referenced_klass, |
|
339 |
const methodHandle& method, int index) { |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
340 |
assert(method->method_holder()->verify_itable_index(index), ""); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17858
diff
changeset
|
341 |
assert(invoke_code == Bytecodes::_invokeinterface, ""); |
14391
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
13929
diff
changeset
|
342 |
InstanceKlass* interf = method->method_holder(); |
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
13929
diff
changeset
|
343 |
assert(interf->is_interface(), "must be an interface"); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
344 |
assert(!method->is_final_method(), "interfaces do not have final methods; cannot link to one here"); |
48557 | 345 |
set_f1(referenced_klass); |
346 |
set_f2((intx)method()); |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
347 |
set_method_flags(as_TosState(method->result_type()), |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
348 |
0, // no option bits |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
349 |
method()->size_of_parameters()); |
1 | 350 |
set_bytecode_1(Bytecodes::_invokeinterface); |
351 |
} |
|
352 |
||
353 |
||
33593
60764a78fa5c
8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents:
33148
diff
changeset
|
354 |
void ConstantPoolCacheEntry::set_method_handle(const constantPoolHandle& cpool, const CallInfo &call_info) { |
14393
93a4dcdbebfd
8001658: No need to pass resolved_references as argument to ConstantPoolCacheEntry::set_method_handle_common
twisti
parents:
13929
diff
changeset
|
355 |
set_method_handle_common(cpool, Bytecodes::_invokehandle, call_info); |
6062
bab93afe9df7
6964498: JSR 292 invokedynamic sites need local bootstrap methods
jrose
parents:
5547
diff
changeset
|
356 |
} |
bab93afe9df7
6964498: JSR 292 invokedynamic sites need local bootstrap methods
jrose
parents:
5547
diff
changeset
|
357 |
|
33593
60764a78fa5c
8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents:
33148
diff
changeset
|
358 |
void ConstantPoolCacheEntry::set_dynamic_call(const constantPoolHandle& cpool, const CallInfo &call_info) { |
14393
93a4dcdbebfd
8001658: No need to pass resolved_references as argument to ConstantPoolCacheEntry::set_method_handle_common
twisti
parents:
13929
diff
changeset
|
359 |
set_method_handle_common(cpool, Bytecodes::_invokedynamic, call_info); |
6062
bab93afe9df7
6964498: JSR 292 invokedynamic sites need local bootstrap methods
jrose
parents:
5547
diff
changeset
|
360 |
} |
bab93afe9df7
6964498: JSR 292 invokedynamic sites need local bootstrap methods
jrose
parents:
5547
diff
changeset
|
361 |
|
33593
60764a78fa5c
8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents:
33148
diff
changeset
|
362 |
void ConstantPoolCacheEntry::set_method_handle_common(const constantPoolHandle& cpool, |
13740
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
363 |
Bytecodes::Code invoke_code, |
14393
93a4dcdbebfd
8001658: No need to pass resolved_references as argument to ConstantPoolCacheEntry::set_method_handle_common
twisti
parents:
13929
diff
changeset
|
364 |
const CallInfo &call_info) { |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
365 |
// NOTE: This CPCE can be the subject of data races. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
366 |
// There are three words to update: flags, refs[f2], f1 (in that order). |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
367 |
// Writers must store all other values before f1. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
368 |
// Readers must test f1 first for non-null before reading other fields. |
13740
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
369 |
// Competing writers must acquire exclusive access via a lock. |
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
370 |
// A losing writer waits on the lock until the winner writes f1 and leaves |
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
371 |
// the lock, so that when the losing writer returns, he can use the linked |
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
372 |
// cache entry. |
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
373 |
|
46271
979ebd346ecf
8169881: Remove implicit Handle conversions oop->Handle
coleenp
parents:
40655
diff
changeset
|
374 |
objArrayHandle resolved_references(Thread::current(), cpool->resolved_references()); |
28019
a6303ff71902
8066171: Out of order with Metaspace allocation lock
coleenp
parents:
25354
diff
changeset
|
375 |
// Use the resolved_references() lock for this cpCache entry. |
a6303ff71902
8066171: Out of order with Metaspace allocation lock
coleenp
parents:
25354
diff
changeset
|
376 |
// resolved_references are created for all classes with Invokedynamic, MethodHandle |
a6303ff71902
8066171: Out of order with Metaspace allocation lock
coleenp
parents:
25354
diff
changeset
|
377 |
// or MethodType constant pool cache entries. |
a6303ff71902
8066171: Out of order with Metaspace allocation lock
coleenp
parents:
25354
diff
changeset
|
378 |
assert(resolved_references() != NULL, |
a6303ff71902
8066171: Out of order with Metaspace allocation lock
coleenp
parents:
25354
diff
changeset
|
379 |
"a resolved_references array should have been created for this class"); |
a6303ff71902
8066171: Out of order with Metaspace allocation lock
coleenp
parents:
25354
diff
changeset
|
380 |
ObjectLocker ol(resolved_references, Thread::current()); |
13740
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
381 |
if (!is_f1_null()) { |
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
382 |
return; |
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
383 |
} |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
384 |
|
47684
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
385 |
if (indy_resolution_failed()) { |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
386 |
// Before we got here, another thread got a LinkageError exception during |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
387 |
// resolution. Ignore our success and throw their exception. |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
388 |
ConstantPoolCache* cpCache = cpool->cache(); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
389 |
int index = -1; |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
390 |
for (int i = 0; i < cpCache->length(); i++) { |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
391 |
if (cpCache->entry_at(i) == this) { |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
392 |
index = i; |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
393 |
break; |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
394 |
} |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
395 |
} |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
396 |
guarantee(index >= 0, "Didn't find cpCache entry!"); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
397 |
int encoded_index = ResolutionErrorTable::encode_cpcache_index( |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
398 |
ConstantPool::encode_invokedynamic_index(index)); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
399 |
Thread* THREAD = Thread::current(); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
400 |
ConstantPool::throw_resolution_error(cpool, encoded_index, THREAD); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
401 |
return; |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
402 |
} |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
403 |
|
14393
93a4dcdbebfd
8001658: No need to pass resolved_references as argument to ConstantPoolCacheEntry::set_method_handle_common
twisti
parents:
13929
diff
changeset
|
404 |
const methodHandle adapter = call_info.resolved_method(); |
93a4dcdbebfd
8001658: No need to pass resolved_references as argument to ConstantPoolCacheEntry::set_method_handle_common
twisti
parents:
13929
diff
changeset
|
405 |
const Handle appendix = call_info.resolved_appendix(); |
13929
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
406 |
const bool has_appendix = appendix.not_null(); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
407 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
408 |
// Write the flags. |
53746
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
409 |
// MHs and indy are always sig-poly and have a local signature. |
13740
ae6179641137
7196242: vm/mlvm/indy/stress/java/loopsAndThreads crashed
twisti
parents:
13728
diff
changeset
|
410 |
set_method_flags(as_TosState(adapter->result_type()), |
53746
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
411 |
((has_appendix ? 1 : 0) << has_appendix_shift ) | |
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
412 |
( 1 << has_local_signature_shift ) | |
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
413 |
( 1 << is_final_shift ), |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
414 |
adapter->size_of_parameters()); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
415 |
|
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
416 |
if (TraceInvokeDynamic) { |
35543
0961315f4016
8140659: C1: invokedynamic call patching violates JVMS-6.5.invokedynamic
vlivanov
parents:
33611
diff
changeset
|
417 |
ttyLocker ttyl; |
53746
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
418 |
tty->print_cr("set_method_handle bc=%d appendix=" PTR_FORMAT "%s method=" PTR_FORMAT " (local signature) ", |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
419 |
invoke_code, |
53746
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
420 |
p2i(appendix()), |
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
421 |
(has_appendix ? "" : " (unused)"), |
33148
68fa8b6c4340
8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
david
parents:
33105
diff
changeset
|
422 |
p2i(adapter())); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
423 |
adapter->print(); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
424 |
if (has_appendix) appendix()->print(); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
425 |
} |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
426 |
|
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
427 |
// Method handle invokes and invokedynamic sites use both cp cache words. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
428 |
// refs[f2], if not null, contains a value passed as a trailing argument to the adapter. |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
429 |
// In the general case, this could be the call site's MethodType, |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
430 |
// for use with java.lang.Invokers.checkExactType, or else a CallSite object. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
431 |
// f1 contains the adapter method which manages the actual call. |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
432 |
// In the general case, this is a compiled LambdaForm. |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
433 |
// (The Java code is free to optimize these calls by binding other |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
434 |
// sorts of methods and appendices to call sites.) |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
435 |
// JVM-level linking is via f1, as if for invokespecial, and signatures are erased. |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
436 |
// The appendix argument (if any) is added to the signature, and is counted in the parameter_size bits. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
437 |
// Even with the appendix, the method will never take more than 255 parameter slots. |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
438 |
// |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
439 |
// This means that given a call site like (List)mh.invoke("foo"), |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
440 |
// the f1 method has signature '(Ljl/Object;Ljl/invoke/MethodType;)Ljl/Object;', |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
441 |
// not '(Ljava/lang/String;)Ljava/util/List;'. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
442 |
// The fact that String and List are involved is encoded in the MethodType in refs[f2]. |
23515
f4872ef5df09
8031820: NPG: Fix remaining references to metadata as oops in comments
coleenp
parents:
22859
diff
changeset
|
443 |
// This allows us to create fewer Methods, while keeping type safety. |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
444 |
// |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
445 |
|
13929
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
446 |
// Store appendix, if any. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
447 |
if (has_appendix) { |
53746
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
448 |
const int appendix_index = f2_as_index(); |
13929
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
449 |
assert(appendix_index >= 0 && appendix_index < resolved_references->length(), "oob"); |
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
450 |
assert(resolved_references->obj_at(appendix_index) == NULL, "init just once"); |
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
451 |
resolved_references->obj_at_put(appendix_index, appendix()); |
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
452 |
} |
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
453 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
454 |
release_set_f1(adapter()); // This must be the last one to set (see NOTE above)! |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
455 |
|
13929
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
456 |
// The interpreter assembly code does not check byte_2, |
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
457 |
// but it is used by is_resolved, method_if_resolved, etc. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
458 |
set_bytecode_1(invoke_code); |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
459 |
NOT_PRODUCT(verify(tty)); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
460 |
if (TraceInvokeDynamic) { |
35543
0961315f4016
8140659: C1: invokedynamic call patching violates JVMS-6.5.invokedynamic
vlivanov
parents:
33611
diff
changeset
|
461 |
ttyLocker ttyl; |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
462 |
this->print(tty, 0); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
463 |
} |
53746
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
464 |
|
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
465 |
assert(has_appendix == this->has_appendix(), "proper storage of appendix flag"); |
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
466 |
assert(this->has_local_signature(), "proper storage of signature flag"); |
2570
ecc7862946d4
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
670
diff
changeset
|
467 |
} |
ecc7862946d4
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
670
diff
changeset
|
468 |
|
47684
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
469 |
bool ConstantPoolCacheEntry::save_and_throw_indy_exc( |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
470 |
const constantPoolHandle& cpool, int cpool_index, int index, constantTag tag, TRAPS) { |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
471 |
|
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
472 |
assert(HAS_PENDING_EXCEPTION, "No exception got thrown!"); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
473 |
assert(PENDING_EXCEPTION->is_a(SystemDictionary::LinkageError_klass()), |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
474 |
"No LinkageError exception"); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
475 |
|
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
476 |
// Use the resolved_references() lock for this cpCache entry. |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
477 |
// resolved_references are created for all classes with Invokedynamic, MethodHandle |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
478 |
// or MethodType constant pool cache entries. |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
479 |
objArrayHandle resolved_references(Thread::current(), cpool->resolved_references()); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
480 |
assert(resolved_references() != NULL, |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
481 |
"a resolved_references array should have been created for this class"); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
482 |
ObjectLocker ol(resolved_references, THREAD); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
483 |
|
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
484 |
// if f1 is not null or the indy_resolution_failed flag is set then another |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
485 |
// thread either succeeded in resolving the method or got a LinkageError |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
486 |
// exception, before this thread was able to record its failure. So, clear |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
487 |
// this thread's exception and return false so caller can use the earlier |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
488 |
// thread's result. |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
489 |
if (!is_f1_null() || indy_resolution_failed()) { |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
490 |
CLEAR_PENDING_EXCEPTION; |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
491 |
return false; |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
492 |
} |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
493 |
|
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
494 |
Symbol* error = PENDING_EXCEPTION->klass()->name(); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
495 |
Symbol* message = java_lang_Throwable::detail_message(PENDING_EXCEPTION); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
496 |
|
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
497 |
SystemDictionary::add_resolution_error(cpool, index, error, message); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
498 |
set_indy_resolution_failed(); |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
499 |
return true; |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
500 |
} |
c3c04b6e14f8
8174954: Parameter target type is allowed access after a module read edge or a package export has occurred after failed resolution
hseigel
parents:
47634
diff
changeset
|
501 |
|
33593
60764a78fa5c
8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents:
33148
diff
changeset
|
502 |
Method* ConstantPoolCacheEntry::method_if_resolved(const constantPoolHandle& cpool) { |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
503 |
// Decode the action of set_method and set_interface_call |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
504 |
Bytecodes::Code invoke_code = bytecode_1(); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
505 |
if (invoke_code != (Bytecodes::Code)0) { |
22859
7b88983393b7
8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
goetz
parents:
21557
diff
changeset
|
506 |
Metadata* f1 = f1_ord(); |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
507 |
if (f1 != NULL) { |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
508 |
switch (invoke_code) { |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
509 |
case Bytecodes::_invokeinterface: |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
510 |
assert(f1->is_klass(), ""); |
54723
1abca1170080
8221542: ~15% performance degradation due to less optimized inline decision
jiefu
parents:
53994
diff
changeset
|
511 |
return f2_as_interface_method(); |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
512 |
case Bytecodes::_invokestatic: |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
513 |
case Bytecodes::_invokespecial: |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
514 |
assert(!has_appendix(), ""); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
515 |
case Bytecodes::_invokehandle: |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
516 |
case Bytecodes::_invokedynamic: |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
517 |
assert(f1->is_method(), ""); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
518 |
return (Method*)f1; |
46630
75aa3e39d02c
8182299: Enable disabled clang warnings, build on OSX 10 + Xcode 8
jwilhelm
parents:
46458
diff
changeset
|
519 |
default: |
75aa3e39d02c
8182299: Enable disabled clang warnings, build on OSX 10 + Xcode 8
jwilhelm
parents:
46458
diff
changeset
|
520 |
break; |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
521 |
} |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
522 |
} |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
523 |
} |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
524 |
invoke_code = bytecode_2(); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
525 |
if (invoke_code != (Bytecodes::Code)0) { |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
526 |
switch (invoke_code) { |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
527 |
case Bytecodes::_invokevirtual: |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
528 |
if (is_vfinal()) { |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
529 |
// invokevirtual |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
530 |
Method* m = f2_as_vfinal_method(); |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
531 |
assert(m->is_method(), ""); |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
532 |
return m; |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
533 |
} else { |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
534 |
int holder_index = cpool->uncached_klass_ref_index_at(constant_pool_index()); |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
535 |
if (cpool->tag_at(holder_index).is_klass()) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
536 |
Klass* klass = cpool->resolved_klass_at(holder_index); |
35900 | 537 |
return klass->method_at_vtable(f2_as_index()); |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
538 |
} |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
539 |
} |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
540 |
break; |
46630
75aa3e39d02c
8182299: Enable disabled clang warnings, build on OSX 10 + Xcode 8
jwilhelm
parents:
46458
diff
changeset
|
541 |
default: |
75aa3e39d02c
8182299: Enable disabled clang warnings, build on OSX 10 + Xcode 8
jwilhelm
parents:
46458
diff
changeset
|
542 |
break; |
10008
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
543 |
} |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
544 |
} |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
545 |
return NULL; |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
546 |
} |
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
547 |
|
d84de97ad847
7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path
jrose
parents:
9328
diff
changeset
|
548 |
|
33593
60764a78fa5c
8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents:
33148
diff
changeset
|
549 |
oop ConstantPoolCacheEntry::appendix_if_resolved(const constantPoolHandle& cpool) { |
24926
5ea835dfafaa
8029381: assert(is_method_type()) failed: bad cast
drchase
parents:
24459
diff
changeset
|
550 |
if (!has_appendix()) |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
551 |
return NULL; |
53746
bdccafc038a2
8217998: Remove method_type field associated with the appendix field of an indy or method handle call
lfoltan
parents:
53584
diff
changeset
|
552 |
const int ref_index = f2_as_index(); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
553 |
objArrayOop resolved_references = cpool->resolved_references(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
554 |
return resolved_references->obj_at(ref_index); |
1 | 555 |
} |
556 |
||
557 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
558 |
#if INCLUDE_JVMTI |
48557 | 559 |
|
560 |
void log_adjust(const char* entry_type, Method* old_method, Method* new_method, bool* trace_name_printed) { |
|
561 |
if (log_is_enabled(Info, redefine, class, update)) { |
|
562 |
ResourceMark rm; |
|
563 |
if (!(*trace_name_printed)) { |
|
564 |
log_info(redefine, class, update)("adjust: name=%s", old_method->method_holder()->external_name()); |
|
565 |
*trace_name_printed = true; |
|
566 |
} |
|
567 |
log_debug(redefine, class, update, constantpool) |
|
568 |
("cpc %s entry update: %s(%s)", entry_type, new_method->name()->as_C_string(), new_method->signature()->as_C_string()); |
|
569 |
} |
|
570 |
} |
|
571 |
||
1 | 572 |
// RedefineClasses() API support: |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
573 |
// If this ConstantPoolCacheEntry refers to old_method then update it |
1 | 574 |
// to refer to new_method. |
48557 | 575 |
void ConstantPoolCacheEntry::adjust_method_entry(Method* old_method, |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
576 |
Method* new_method, bool * trace_name_printed) { |
1 | 577 |
|
578 |
if (is_vfinal()) { |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
579 |
// virtual and final so _f2 contains method ptr instead of vtable index |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
580 |
if (f2_as_vfinal_method() == old_method) { |
1 | 581 |
// match old_method so need an update |
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
582 |
// NOTE: can't use set_f2_as_vfinal_method as it asserts on different values |
1 | 583 |
_f2 = (intptr_t)new_method; |
48557 | 584 |
log_adjust("vfinal", old_method, new_method, trace_name_printed); |
1 | 585 |
} |
48557 | 586 |
return; |
1 | 587 |
} |
588 |
||
48557 | 589 |
assert (_f1 != NULL, "should not call with uninteresting entry"); |
1 | 590 |
|
48557 | 591 |
if (!(_f1->is_method())) { |
592 |
// _f1 is a Klass* for an interface, _f2 is the method |
|
593 |
if (f2_as_interface_method() == old_method) { |
|
594 |
_f2 = (intptr_t)new_method; |
|
595 |
log_adjust("interface", old_method, new_method, trace_name_printed); |
|
596 |
} |
|
597 |
} else if (_f1 == old_method) { |
|
1 | 598 |
_f1 = new_method; |
48557 | 599 |
log_adjust("special, static or dynamic", old_method, new_method, trace_name_printed); |
1 | 600 |
} |
601 |
} |
|
602 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
603 |
// a constant pool cache entry should never contain old or obsolete methods |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
604 |
bool ConstantPoolCacheEntry::check_no_old_or_obsolete_entries() { |
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
53746
diff
changeset
|
605 |
Method* m = get_interesting_method_entry(); |
48557 | 606 |
// return false if m refers to a non-deleted old or obsolete method |
607 |
if (m != NULL) { |
|
608 |
assert(m->is_valid() && m->is_method(), "m is a valid method"); |
|
609 |
return !m->is_old() && !m->is_obsolete(); // old is always set for old and obsolete |
|
610 |
} else { |
|
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
611 |
return true; |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
612 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
613 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
614 |
|
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
53746
diff
changeset
|
615 |
Method* ConstantPoolCacheEntry::get_interesting_method_entry() { |
1 | 616 |
if (!is_method_entry()) { |
617 |
// not a method entry so not interesting by default |
|
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
618 |
return NULL; |
1 | 619 |
} |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
620 |
Method* m = NULL; |
1 | 621 |
if (is_vfinal()) { |
622 |
// virtual and final so _f2 contains method ptr instead of vtable index |
|
13391
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
623 |
m = f2_as_vfinal_method(); |
30245956af37
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
11956
diff
changeset
|
624 |
} else if (is_f1_null()) { |
1 | 625 |
// NULL _f1 means this is a virtual entry so also not interesting |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
626 |
return NULL; |
1 | 627 |
} else { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
628 |
if (!(_f1->is_method())) { |
48557 | 629 |
// _f1 is a Klass* for an interface |
630 |
m = f2_as_interface_method(); |
|
631 |
} else { |
|
632 |
m = f1_as_method(); |
|
1 | 633 |
} |
634 |
} |
|
635 |
assert(m != NULL && m->is_method(), "sanity check"); |
|
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
53746
diff
changeset
|
636 |
if (m == NULL || !m->is_method()) { |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
637 |
return NULL; |
1 | 638 |
} |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
639 |
return m; |
1 | 640 |
} |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
641 |
#endif // INCLUDE_JVMTI |
1 | 642 |
|
643 |
void ConstantPoolCacheEntry::print(outputStream* st, int index) const { |
|
644 |
// print separator |
|
11956
c363dc1ac4b7
7148126: ConstantPoolCacheEntry::print prints to wrong stream
dholmes
parents:
10546
diff
changeset
|
645 |
if (index == 0) st->print_cr(" -------------"); |
1 | 646 |
// print entry |
31592
43f48e165466
8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents:
30289
diff
changeset
|
647 |
st->print("%3d (" PTR_FORMAT ") ", index, (intptr_t)this); |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
648 |
st->print_cr("[%02x|%02x|%5d]", bytecode_2(), bytecode_1(), |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
649 |
constant_pool_index()); |
31592
43f48e165466
8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents:
30289
diff
changeset
|
650 |
st->print_cr(" [ " PTR_FORMAT "]", (intptr_t)_f1); |
43f48e165466
8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents:
30289
diff
changeset
|
651 |
st->print_cr(" [ " PTR_FORMAT "]", (intptr_t)_f2); |
43f48e165466
8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents:
30289
diff
changeset
|
652 |
st->print_cr(" [ " PTR_FORMAT "]", (intptr_t)_flags); |
11956
c363dc1ac4b7
7148126: ConstantPoolCacheEntry::print prints to wrong stream
dholmes
parents:
10546
diff
changeset
|
653 |
st->print_cr(" -------------"); |
1 | 654 |
} |
655 |
||
656 |
void ConstantPoolCacheEntry::verify(outputStream* st) const { |
|
657 |
// not implemented yet |
|
658 |
} |
|
659 |
||
660 |
// Implementation of ConstantPoolCache |
|
661 |
||
15928
f9d5c6e4107f
8003553: NPG: metaspace objects should be zeroed in constructors
coleenp
parents:
15595
diff
changeset
|
662 |
ConstantPoolCache* ConstantPoolCache::allocate(ClassLoaderData* loader_data, |
f9d5c6e4107f
8003553: NPG: metaspace objects should be zeroed in constructors
coleenp
parents:
15595
diff
changeset
|
663 |
const intStack& index_map, |
21557
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
664 |
const intStack& invokedynamic_index_map, |
15928
f9d5c6e4107f
8003553: NPG: metaspace objects should be zeroed in constructors
coleenp
parents:
15595
diff
changeset
|
665 |
const intStack& invokedynamic_map, TRAPS) { |
21557
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
666 |
|
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
667 |
const int length = index_map.length() + invokedynamic_index_map.length(); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
668 |
int size = ConstantPoolCache::size(length); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
669 |
|
46746
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46727
diff
changeset
|
670 |
return new (loader_data, size, MetaspaceObj::ConstantPoolCacheType, THREAD) |
21557
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
671 |
ConstantPoolCache(length, index_map, invokedynamic_index_map, invokedynamic_map); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
672 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
673 |
|
15928
f9d5c6e4107f
8003553: NPG: metaspace objects should be zeroed in constructors
coleenp
parents:
15595
diff
changeset
|
674 |
void ConstantPoolCache::initialize(const intArray& inverse_index_map, |
21557
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
675 |
const intArray& invokedynamic_inverse_index_map, |
15928
f9d5c6e4107f
8003553: NPG: metaspace objects should be zeroed in constructors
coleenp
parents:
15595
diff
changeset
|
676 |
const intArray& invokedynamic_references_map) { |
21557
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
677 |
for (int i = 0; i < inverse_index_map.length(); i++) { |
4429
d7eb4e2099aa
6858164: invokedynamic code needs some cleanup (post-6655638)
jrose
parents:
3261
diff
changeset
|
678 |
ConstantPoolCacheEntry* e = entry_at(i); |
38031
e0b822facc03
8149374: Replace C1-specific collection classes with universal collection classes
fzhinkin
parents:
35913
diff
changeset
|
679 |
int original_index = inverse_index_map.at(i); |
13929
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
680 |
e->initialize_entry(original_index); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
681 |
assert(entry_at(i) == e, "sanity"); |
13929
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
682 |
} |
21557
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
683 |
|
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
684 |
// Append invokedynamic entries at the end |
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
685 |
int invokedynamic_offset = inverse_index_map.length(); |
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
686 |
for (int i = 0; i < invokedynamic_inverse_index_map.length(); i++) { |
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
687 |
int offset = i + invokedynamic_offset; |
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
688 |
ConstantPoolCacheEntry* e = entry_at(offset); |
38031
e0b822facc03
8149374: Replace C1-specific collection classes with universal collection classes
fzhinkin
parents:
35913
diff
changeset
|
689 |
int original_index = invokedynamic_inverse_index_map.at(i); |
21557
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
690 |
e->initialize_entry(original_index); |
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
691 |
assert(entry_at(offset) == e, "sanity"); |
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
692 |
} |
55115e0708f1
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change
coleenp
parents:
21079
diff
changeset
|
693 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
694 |
for (int ref = 0; ref < invokedynamic_references_map.length(); ref++) { |
38031
e0b822facc03
8149374: Replace C1-specific collection classes with universal collection classes
fzhinkin
parents:
35913
diff
changeset
|
695 |
const int cpci = invokedynamic_references_map.at(ref); |
13929
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
696 |
if (cpci >= 0) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
697 |
entry_at(cpci)->initialize_resolved_reference_index(ref); |
13929
8da0dc50a6e4
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
13740
diff
changeset
|
698 |
} |
4429
d7eb4e2099aa
6858164: invokedynamic code needs some cleanup (post-6655638)
jrose
parents:
3261
diff
changeset
|
699 |
} |
1 | 700 |
} |
701 |
||
47103
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
702 |
void ConstantPoolCache::verify_just_initialized() { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
703 |
DEBUG_ONLY(walk_entries_for_initialization(/*check_only = */ true)); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
704 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
705 |
|
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
706 |
void ConstantPoolCache::remove_unshareable_info() { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
707 |
walk_entries_for_initialization(/*check_only = */ false); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
708 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
709 |
|
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
710 |
void ConstantPoolCache::walk_entries_for_initialization(bool check_only) { |
54927 | 711 |
assert(DumpSharedSpaces || DynamicDumpSharedSpaces, "sanity"); |
47103
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
712 |
// When dumping the archive, we want to clean up the ConstantPoolCache |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
713 |
// to remove any effect of linking due to the execution of Java code -- |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
714 |
// each ConstantPoolCacheEntry will have the same contents as if |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
715 |
// ConstantPoolCache::initialize has just returned: |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
716 |
// |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
717 |
// - We keep the ConstantPoolCache::constant_pool_index() bits for all entries. |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
718 |
// - We keep the "f2" field for entries used by invokedynamic and invokehandle |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
719 |
// - All other bits in the entries are cleared to zero. |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
720 |
ResourceMark rm; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
721 |
|
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
722 |
InstanceKlass* ik = constant_pool()->pool_holder(); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
723 |
bool* f2_used = NEW_RESOURCE_ARRAY(bool, length()); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
724 |
memset(f2_used, 0, sizeof(bool) * length()); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
725 |
|
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
726 |
// Find all the slots that we need to preserve f2 |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
727 |
for (int i = 0; i < ik->methods()->length(); i++) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
728 |
Method* m = ik->methods()->at(i); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
729 |
RawBytecodeStream bcs(m); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
730 |
while (!bcs.is_last_bytecode()) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
731 |
Bytecodes::Code opcode = bcs.raw_next(); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
732 |
switch (opcode) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
733 |
case Bytecodes::_invokedynamic: { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
734 |
int index = Bytes::get_native_u4(bcs.bcp() + 1); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
735 |
int cp_cache_index = constant_pool()->invokedynamic_cp_cache_index(index); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
736 |
f2_used[cp_cache_index] = 1; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
737 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
738 |
break; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
739 |
case Bytecodes::_invokehandle: { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
740 |
int cp_cache_index = Bytes::get_native_u2(bcs.bcp() + 1); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
741 |
f2_used[cp_cache_index] = 1; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
742 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
743 |
break; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
744 |
default: |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
745 |
break; |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
746 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
747 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
748 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
749 |
|
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
750 |
if (check_only) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
751 |
DEBUG_ONLY( |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
752 |
for (int i=0; i<length(); i++) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
753 |
entry_at(i)->verify_just_initialized(f2_used[i]); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
754 |
}) |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
755 |
} else { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
756 |
for (int i=0; i<length(); i++) { |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
757 |
entry_at(i)->reinitialize(f2_used[i]); |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
758 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
759 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
760 |
} |
a993ec29ec75
8186842: Use Java class loaders for creating the CDS archive
ccheung
parents:
47095
diff
changeset
|
761 |
|
47095
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
762 |
void ConstantPoolCache::deallocate_contents(ClassLoaderData* data) { |
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
763 |
assert(!is_shared(), "shared caches are not deallocated"); |
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
764 |
data->remove_handle(_resolved_references); |
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
765 |
set_resolved_references(NULL); |
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
766 |
MetadataFactory::free_array<u2>(data, _reference_map); |
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
767 |
set_reference_map(NULL); |
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
768 |
} |
9d21da6fe729
8181170: resolved_references array leaks for RedefineClasses
coleenp
parents:
46810
diff
changeset
|
769 |
|
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
770 |
#if INCLUDE_CDS_JAVA_HEAP |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
771 |
oop ConstantPoolCache::archived_references() { |
50532 | 772 |
if (CompressedOops::is_null(_archived_references)) { |
773 |
return NULL; |
|
774 |
} |
|
52062
8dbf1a13af49
8206009: Move CDS java heap object archiving code to heapShared.hpp and heapShared.cpp
jiangli
parents:
51491
diff
changeset
|
775 |
return HeapShared::materialize_archived_object(_archived_references); |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
776 |
} |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
777 |
|
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
778 |
void ConstantPoolCache::set_archived_references(oop o) { |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
779 |
assert(DumpSharedSpaces, "called only during runtime"); |
50532 | 780 |
_archived_references = CompressedOops::encode(o); |
46810
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
781 |
} |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
782 |
#endif |
7dad333205cd
8179302: Pre-resolve constant pool string entries and cache resolved_reference arrays in CDS archive.
jiangli
parents:
46746
diff
changeset
|
783 |
|
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
784 |
#if INCLUDE_JVMTI |
1 | 785 |
// RedefineClasses() API support: |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
786 |
// If any entry of this ConstantPoolCache points to any of |
1 | 787 |
// old_methods, replace it with the corresponding new_method. |
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
53746
diff
changeset
|
788 |
void ConstantPoolCache::adjust_method_entries(bool * trace_name_printed) { |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
789 |
for (int i = 0; i < length(); i++) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
790 |
ConstantPoolCacheEntry* entry = entry_at(i); |
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
53746
diff
changeset
|
791 |
Method* old_method = entry->get_interesting_method_entry(); |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
792 |
if (old_method == NULL || !old_method->is_old()) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
793 |
continue; // skip uninteresting entries |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
794 |
} |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
795 |
if (old_method->is_deleted()) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
796 |
// clean up entries with deleted methods |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
797 |
entry->initialize_entry(entry->constant_pool_index()); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
798 |
continue; |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
799 |
} |
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
53746
diff
changeset
|
800 |
Method* new_method = old_method->get_new_method(); |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
801 |
entry_at(i)->adjust_method_entry(old_method, new_method, trace_name_printed); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
802 |
} |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
803 |
} |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
29081
diff
changeset
|
804 |
|
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
805 |
// the constant pool cache should never contain old or obsolete methods |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
806 |
bool ConstantPoolCache::check_no_old_or_obsolete_entries() { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
807 |
for (int i = 1; i < length(); i++) { |
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
53746
diff
changeset
|
808 |
if (entry_at(i)->get_interesting_method_entry() != NULL && |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
809 |
!entry_at(i)->check_no_old_or_obsolete_entries()) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
810 |
return false; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
811 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
812 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
813 |
return true; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
814 |
} |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
815 |
|
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
816 |
void ConstantPoolCache::dump_cache() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
817 |
for (int i = 1; i < length(); i++) { |
53904
9c3fe09f69bc
8078725: method adjustments can be done just once for all classes involved into redefinition
coleenp
parents:
53746
diff
changeset
|
818 |
if (entry_at(i)->get_interesting_method_entry() != NULL) { |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
819 |
entry_at(i)->print(tty, i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
820 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
821 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
822 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14490
diff
changeset
|
823 |
#endif // INCLUDE_JVMTI |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
824 |
|
46746
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46727
diff
changeset
|
825 |
void ConstantPoolCache::metaspace_pointers_do(MetaspaceClosure* it) { |
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46727
diff
changeset
|
826 |
log_trace(cds)("Iter(ConstantPoolCache): %p", this); |
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46727
diff
changeset
|
827 |
it->push(&_constant_pool); |
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46727
diff
changeset
|
828 |
it->push(&_reference_map); |
ea379ebb9447
8072061: Automatically determine optimal sizes for the CDS regions
iklam
parents:
46727
diff
changeset
|
829 |
} |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
830 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
831 |
// Printing |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
832 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
833 |
void ConstantPoolCache::print_on(outputStream* st) const { |
24424
2658d7834c6e
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
24351
diff
changeset
|
834 |
st->print_cr("%s", internal_name()); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
835 |
// print constant pool cache entries |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
836 |
for (int i = 0; i < length(); i++) entry_at(i)->print(st, i); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
837 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
838 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
839 |
void ConstantPoolCache::print_value_on(outputStream* st) const { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
840 |
st->print("cache [%d]", length()); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
841 |
print_address_on(st); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
842 |
st->print(" for "); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
843 |
constant_pool()->print_value_on(st); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
844 |
} |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
845 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
846 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
847 |
// Verification |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
848 |
|
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
849 |
void ConstantPoolCache::verify_on(outputStream* st) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
850 |
// print constant pool cache entries |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
851 |
for (int i = 0; i < length(); i++) entry_at(i)->verify(st); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13391
diff
changeset
|
852 |
} |