# HG changeset patch
# User František Kučera <franta-hg@frantovo.cz>
# Date 1617304790 -7200
# Node ID 6f5616572273589ad9d619359f8444d92f1b4f28
# Parent  93d9c4fce58510e5b374c8976e78fef5567e6337
clean-up, comments

diff -r 93d9c4fce585 -r 6f5616572273 src/X11Handler.h
--- a/src/X11Handler.h	Thu Apr 01 21:09:58 2021 +0200
+++ b/src/X11Handler.h	Thu Apr 01 21:19:50 2021 +0200
@@ -22,7 +22,6 @@
 #include <iostream>
 #include <sstream>
 #include <locale>
-#include <codecvt>
 #include <stdexcept>
 
 #include <X11/extensions/XTest.h>
@@ -79,7 +78,6 @@
 
 	Display display;
 	Configuration& configuration;
-	std::wstring_convert<std::codecvt_utf8<wchar_t>> convertor; // TODO: probably not needed
 	std::vector<relpipe::reader::handlers::AttributeMetadata> attributes;
 	relpipe::common::type::Integer attributeIndex = 0;
 public:
@@ -89,6 +87,7 @@
 	}
 
 	void startRelation(relpipe::common::type::StringX name, std::vector<relpipe::reader::handlers::AttributeMetadata> attributes) override {
+		// TODO: check relation name, print waring if it does not match
 		if (display.display) {
 			if (this->attributes.empty()) {
 				this->attributes = attributes;
@@ -102,6 +101,8 @@
 	}
 
 	void attribute(const relpipe::common::type::StringX& value) override {
+		// TODO: strictly expect correct data types (integers)?
+		// TODO: shorter codes (k/b/m, p/r) instead of names or both?
 		if (attributes[attributeIndex].getAttributeName() == L"device") {
 			// TODO: maybe add some filtering based on device ID
 		} else if (attributes[attributeIndex].getAttributeName() == L"type") {
@@ -155,7 +156,6 @@
 	}
 
 	void endOfPipe() {
-		// XTestDiscard(display.display); // TODO: wait before discard?
 	}
 
 };