6895788: G1: SATB and update buffer allocation code allocates too much space
authorjohnc
Fri, 06 Nov 2009 11:10:05 -0800
changeset 4454 d27c981064b4
parent 4106 30919106db1d
child 4455 3f46ab998f18
6895788: G1: SATB and update buffer allocation code allocates too much space Summary: The type in the NEW_C_HEAP_ARRRY and FREE_C_HEAP_ARRAY calls in the buffer allocation code was changed from void* to char as the size argument had already been mulitipled by the byte size of an object pointer. Reviewed-by: ysr, tonyp
hotspot/src/share/vm/gc_implementation/g1/ptrQueue.cpp
--- a/hotspot/src/share/vm/gc_implementation/g1/ptrQueue.cpp	Tue Nov 03 16:43:16 2009 -0800
+++ b/hotspot/src/share/vm/gc_implementation/g1/ptrQueue.cpp	Fri Nov 06 11:10:05 2009 -0800
@@ -107,7 +107,7 @@
     res[0] = NULL;
     return res;
   } else {
-    return NEW_C_HEAP_ARRAY(void*, _sz);
+    return (void**) NEW_C_HEAP_ARRAY(char, _sz);
   }
 }
 
@@ -127,7 +127,8 @@
     assert(_buf_free_list != NULL, "_buf_free_list_sz must be wrong.");
     void** head = _buf_free_list;
     _buf_free_list = (void**)_buf_free_list[0];
-    FREE_C_HEAP_ARRAY(void*,head);
+    FREE_C_HEAP_ARRAY(char, head);
+    _buf_free_list_sz --;
     n--;
   }
 }