8026143: [macosx] Maximized state could be inconsistent between peer and frame
Reviewed-by: anthony, serb
--- a/jdk/src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Thu Oct 10 19:27:21 2013 +0400
+++ b/jdk/src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Fri Oct 11 11:48:52 2013 +0400
@@ -538,6 +538,8 @@
updateIconImages();
updateFocusabilityForAutoRequestFocus(false);
+ boolean wasMaximized = isMaximized();
+
// Actually show or hide the window
LWWindowPeer blocker = (peer == null)? null : peer.getBlocker();
if (blocker == null || !visible) {
@@ -571,16 +573,21 @@
if (visible) {
// Apply the extended state as expected in shared code
if (target instanceof Frame) {
- switch (((Frame)target).getExtendedState()) {
- case Frame.ICONIFIED:
- CWrapper.NSWindow.miniaturize(nsWindowPtr);
- break;
- case Frame.MAXIMIZED_BOTH:
- maximize();
- break;
- default: // NORMAL
- unmaximize(); // in case it was maximized, otherwise this is a no-op
- break;
+ if (!wasMaximized && isMaximized()) {
+ // setVisible could have changed the native maximized state
+ deliverZoom(true);
+ } else {
+ switch (((Frame)target).getExtendedState()) {
+ case Frame.ICONIFIED:
+ CWrapper.NSWindow.miniaturize(nsWindowPtr);
+ break;
+ case Frame.MAXIMIZED_BOTH:
+ maximize();
+ break;
+ default: // NORMAL
+ unmaximize(); // in case it was maximized, otherwise this is a no-op
+ break;
+ }
}
}
}
@@ -927,6 +934,8 @@
return;
}
+ checkZoom();
+
final Rectangle oldB = nativeBounds;
nativeBounds = new Rectangle(x, y, width, height);
if (peer != null) {
@@ -957,6 +966,17 @@
}
}
+ private void checkZoom() {
+ if (target instanceof Frame && isVisible()) {
+ Frame targetFrame = (Frame)target;
+ if (targetFrame.getExtendedState() != Frame.MAXIMIZED_BOTH && isMaximized()) {
+ deliverZoom(true);
+ } else if (targetFrame.getExtendedState() == Frame.MAXIMIZED_BOTH && !isMaximized()) {
+ deliverZoom(false);
+ }
+ }
+ }
+
private void deliverNCMouseDown() {
if (peer != null) {
peer.notifyNCMouseDown();
--- a/jdk/src/macosx/native/sun/awt/AWTWindow.m Thu Oct 10 19:27:21 2013 +0400
+++ b/jdk/src/macosx/native/sun/awt/AWTWindow.m Fri Oct 11 11:48:52 2013 +0400
@@ -501,20 +501,6 @@
// window exposing in _setVisible:(BOOL)
}
-- (BOOL)windowShouldZoom:(NSWindow *)window toFrame:(NSRect)proposedFrame {
-AWT_ASSERT_APPKIT_THREAD;
-
- [AWTToolkit eventCountPlusPlus];
- JNIEnv *env = [ThreadUtilities getJNIEnv];
- jobject platformWindow = [self.javaPlatformWindow jObjectWithEnv:env];
- if (platformWindow != NULL) {
- static JNF_MEMBER_CACHE(jm_deliverZoom, jc_CPlatformWindow, "deliverZoom", "(Z)V");
- JNFCallVoidMethod(env, platformWindow, jm_deliverZoom, ![window isZoomed]);
- (*env)->DeleteLocalRef(env, platformWindow);
- }
- return YES;
-}
-
- (void) _deliverIconify:(BOOL)iconify {
AWT_ASSERT_APPKIT_THREAD;
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/java/awt/Frame/MaximizedByPlatform/MaximizedByPlatform.java Fri Oct 11 11:48:52 2013 +0400
@@ -0,0 +1,105 @@
+/*
+ * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/* @test
+ * @bug 8026143
+ * @summary [macosx] Maximized state could be inconsistent between peer and frame
+ * @author Petr Pchelko
+ * @run main MaximizedByPlatform
+ */
+
+import sun.awt.OSInfo;
+import sun.awt.SunToolkit;
+
+import java.awt.*;
+
+public class MaximizedByPlatform {
+ private static Frame frame;
+ private static Rectangle availableScreenBounds;
+
+ public static void main(String[] args) {
+ if (OSInfo.getOSType() != OSInfo.OSType.MACOSX) {
+ // Test only for macosx. Pass
+ return;
+ }
+
+ availableScreenBounds = getAvailableScreenBounds();
+
+ // Test 1. The maximized state is set in setBounds
+ try {
+ frame = new Frame();
+ frame.setBounds(100, 100, 100, 100);
+ frame.setVisible(true);
+
+ ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
+
+ frame.setBounds(availableScreenBounds.x, availableScreenBounds.y,
+ availableScreenBounds.width, availableScreenBounds.height);
+
+ ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
+
+ if (frame.getExtendedState() != Frame.MAXIMIZED_BOTH) {
+ throw new RuntimeException("Maximized state was not set for frame in setBounds");
+ }
+ } finally {
+ frame.dispose();
+ }
+
+
+ // Test 2. The maximized state is set in setVisible
+ try {
+ frame = new Frame();
+ frame.setBounds(availableScreenBounds.x, availableScreenBounds.y,
+ availableScreenBounds.width + 100, availableScreenBounds.height);
+ frame.setVisible(true);
+
+ ((SunToolkit)Toolkit.getDefaultToolkit()).realSync();
+
+ if (frame.getExtendedState() != Frame.MAXIMIZED_BOTH) {
+ throw new RuntimeException("Maximized state was not set for frame in setVisible");
+ }
+ } finally {
+ frame.dispose();
+ }
+ }
+
+ private static Rectangle getAvailableScreenBounds() {
+ final Toolkit toolkit = Toolkit.getDefaultToolkit();
+ final GraphicsEnvironment graphicsEnvironment =
+ GraphicsEnvironment.getLocalGraphicsEnvironment();
+ final GraphicsDevice graphicsDevice =
+ graphicsEnvironment.getDefaultScreenDevice();
+
+ final Dimension screenSize = toolkit.getScreenSize();
+ final Insets screenInsets = toolkit.getScreenInsets(
+ graphicsDevice.getDefaultConfiguration());
+
+ final Rectangle availableScreenBounds = new Rectangle(screenSize);
+
+ availableScreenBounds.x += screenInsets.left;
+ availableScreenBounds.y += screenInsets.top;
+ availableScreenBounds.width -= (screenInsets.left + screenInsets.right);
+ availableScreenBounds.height -= (screenInsets.top + screenInsets.bottom);
+ return availableScreenBounds;
+ }
+}