8032788: ImageIcon constructor throws an NPE and hangs when passed a null String parameter
Reviewed-by: pchelko, serb
--- a/jdk/src/share/classes/sun/awt/image/FileImageSource.java Thu May 29 17:31:41 2014 +0400
+++ b/jdk/src/share/classes/sun/awt/image/FileImageSource.java Fri May 30 11:20:03 2014 +0400
@@ -48,6 +48,10 @@
}
protected ImageDecoder getDecoder() {
+ if (imagefile == null) {
+ return null;
+ }
+
InputStream is;
try {
is = new BufferedInputStream(new FileInputStream(imagefile));
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/java/awt/image/ImageIconHang.java Fri May 30 11:20:03 2014 +0400
@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+import java.awt.*;
+
+/*
+ * @test
+ * @bug 8032788
+ * @summary Checks that null filename argument is processed correctly
+ *
+ * @run main ImageIconHang
+ */
+public class ImageIconHang {
+ public static void main(String[] args) throws Exception {
+ Image image = Toolkit.getDefaultToolkit().getImage((String) null);
+ MediaTracker mt = new MediaTracker(new Component() {});
+ mt.addImage(image, 1);
+ mt.waitForID(1, 5000);
+
+ int status = mt.statusID(1, false);
+
+ System.out.println("Status: " + status);
+
+ if (status != MediaTracker.ERRORED) {
+ throw new RuntimeException("MediaTracker.waitForID() hung.");
+ }
+ }
+}