Rename test parameter TIMEOUT to TIMEOUT_FACTOR to better reflect what it is. ihse-runtestprebuilt-branch
authorerikj
Fri, 05 Oct 2018 11:08:45 -0700
branchihse-runtestprebuilt-branch
changeset 56932 7346896cdea2
parent 56931 aff106ae3507
child 56937 3c92ada330a9
Rename test parameter TIMEOUT to TIMEOUT_FACTOR to better reflect what it is.
make/RunTests.gmk
--- a/make/RunTests.gmk	Fri Oct 05 09:59:30 2018 -0700
+++ b/make/RunTests.gmk	Fri Oct 05 11:08:45 2018 -0700
@@ -45,7 +45,7 @@
 endif
 
 $(eval $(call ParseKeywordVariable, TEST_OPTS, \
-    SINGLE_KEYWORDS := JOBS TIMEOUT GENERATE_CDS_ARCHIVE, \
+    SINGLE_KEYWORDS := JOBS TIMEOUT_FACTOR GENERATE_CDS_ARCHIVE, \
     STRING_KEYWORDS := VM_OPTIONS, \
 ))
 
@@ -156,11 +156,11 @@
   $(eval $(call SetTestOpt,VM_OPTIONS,GTEST))
 
   $(eval $(call SetTestOpt,JOBS,JTREG))
-  $(eval $(call SetTestOpt,TIMEOUT,JTREG))
+  $(eval $(call SetTestOpt,TIMEOUT_FACTOR,JTREG))
 endif
 
 $(eval $(call ParseKeywordVariable, JTREG, \
-    SINGLE_KEYWORDS := JOBS TIMEOUT TEST_MODE ASSERT VERBOSE RETAIN MAX_MEM \
+    SINGLE_KEYWORDS := JOBS TIMEOUT_FACTOR TEST_MODE ASSERT VERBOSE RETAIN MAX_MEM \
         EXTRA_PROBLEM_LISTS KEYWORDS, \
     STRING_KEYWORDS := OPTIONS JAVA_OPTIONS VM_OPTIONS, \
 ))
@@ -521,9 +521,7 @@
   # we may end up with a lot of JVM's
   $1_JTREG_MAX_RAM_PERCENTAGE := $$(shell $$(EXPR) 25 / $$($1_JTREG_JOBS))
 
-  $$(call PrintVar, TEST_OPTS_TIMEOUT)
-  $$(call PrintVar, JTREG_TIMEOUT)
-  JTREG_TIMEOUT ?= 4
+  JTREG_TIMEOUT_FACTOR ?= 4
   JTREG_VERBOSE ?= fail,error,summary
   JTREG_RETAIN ?= fail,error
 
@@ -534,7 +532,7 @@
 
   $1_JTREG_BASIC_OPTIONS += -$$($1_JTREG_TEST_MODE) \
       -verbose:$$(JTREG_VERBOSE) -retain:$$(JTREG_RETAIN) \
-      -concurrency:$$($1_JTREG_JOBS) -timeoutFactor:$$(JTREG_TIMEOUT) \
+      -concurrency:$$($1_JTREG_JOBS) -timeoutFactor:$$(JTREG_TIMEOUT_FACTOR) \
       -vmoption:-XX:MaxRAMPercentage=$$($1_JTREG_MAX_RAM_PERCENTAGE)
 
   $1_JTREG_BASIC_OPTIONS += -automatic -ignore:quiet