8023464: test/closed/sun/tracing/ProviderProxyTest.java failing
authorjbachorik
Thu, 05 Sep 2013 13:04:17 +0200
changeset 19813 4aa8cfd46576
parent 19812 634cd583f327
child 19814 77d0468c8874
8023464: test/closed/sun/tracing/ProviderProxyTest.java failing Summary: Don't rely on assertions when an Exception suits better Reviewed-by: alanb, dfuchs, sjiang
jdk/src/share/classes/sun/tracing/ProviderSkeleton.java
--- a/jdk/src/share/classes/sun/tracing/ProviderSkeleton.java	Wed Sep 04 19:47:26 2013 -0700
+++ b/jdk/src/share/classes/sun/tracing/ProviderSkeleton.java	Thu Sep 05 13:04:17 2013 +0200
@@ -164,7 +164,10 @@
                     declaringClass == Object.class) {
                     return method.invoke(this, args);
                 } else {
-                    assert false;
+                    // assert false : "this should never happen"
+                    //    reaching here would indicate a breach
+                    //    in security in the higher layers
+                    throw new SecurityException();
                 }
             } catch (IllegalAccessException e) {
                 assert false;