Mercurial Mercurial > jdk-sandbox / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8014891: Redundant setting of external access properties in setFeatures
authorjoehw
Mon, 20 May 2013 16:11:49 -0700
changeset 17786 4471252c40b4
parent 17538 d8d911c4e5d4
child 17787 8fe71e0094ed
8014891: Redundant setting of external access properties in setFeatures Reviewed-by: lancea
jaxp/src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java file | annotate | diff | comparison | revisions
jaxp/src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java file | annotate | diff | comparison | revisions 
--- a/jaxp/src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java	Fri May 17 10:40:21 2013 +0200
+++ b/jaxp/src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java	Mon May 20 16:11:49 2013 -0700
@@ -236,10 +236,6 @@
                 String feature = (String) entry.getKey();
                 boolean value = ((Boolean) entry.getValue()).booleanValue();
                 domParser.setFeature(feature, value);
-                if (feature.equals(XMLConstants.FEATURE_SECURE_PROCESSING)) {
-                    domParser.setProperty(ACCESS_EXTERNAL_DTD, "");
-                    domParser.setProperty(ACCESS_EXTERNAL_SCHEMA, "");
-                }
             }
         }
     }
--- a/jaxp/src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java	Fri May 17 10:40:21 2013 +0200
+++ b/jaxp/src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java	Mon May 20 16:11:49 2013 -0700
@@ -242,10 +242,6 @@
                 String feature = (String) entry.getKey();
                 boolean value = ((Boolean) entry.getValue()).booleanValue();
                 xmlReader.setFeature0(feature, value);
-                if (feature.equals(XMLConstants.FEATURE_SECURE_PROCESSING) && value) {
-                    xmlReader.setProperty0(ACCESS_EXTERNAL_DTD, "");
-                    xmlReader.setProperty0(ACCESS_EXTERNAL_SCHEMA, "");
-                }
             }
         }
     }
jdk-sandbox