Mercurial Mercurial > jdk-sandbox / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6892749: assert(UseParNewGC || UseSerialGC || UseConcMarkSweepGC, "...") fails
authorysr
Tue, 20 Oct 2009 00:00:23 -0700
changeset 4031 439e2afc9abc
parent 4030 4c471254865e
child 4032 73d42cedc44d
6892749: assert(UseParNewGC || UseSerialGC || UseConcMarkSweepGC, "...") fails Summary: Removed the assert: UseSerialGC is not necessarily always set when serial gc is being used. Reviewed-by: jcoomes, jmasa, tonyp
hotspot/src/share/vm/memory/genCollectedHeap.hpp file | annotate | diff | comparison | revisions 
--- a/hotspot/src/share/vm/memory/genCollectedHeap.hpp	Fri Oct 16 02:05:46 2009 -0700
+++ b/hotspot/src/share/vm/memory/genCollectedHeap.hpp	Tue Oct 20 00:00:23 2009 -0700
@@ -266,8 +266,11 @@
   // only and may need to be re-examined in case other
   // kinds of collectors are implemented in the future.
   virtual bool can_elide_initializing_store_barrier(oop new_obj) {
-    assert(UseParNewGC || UseSerialGC || UseConcMarkSweepGC,
-           "Check can_elide_initializing_store_barrier() for this collector");
+    // We wanted to assert that:-
+    // assert(UseParNewGC || UseSerialGC || UseConcMarkSweepGC,
+    //       "Check can_elide_initializing_store_barrier() for this collector");
+    // but unfortunately the flag UseSerialGC need not necessarily always
+    // be set when DefNew+Tenured are being used.
     return is_in_youngest((void*)new_obj);
   }
jdk-sandbox