6927458: font system should cache transient strikes with weak references.
authorprr
Thu, 23 Dec 2010 21:58:12 -0800
changeset 7758 3ed475e9013d
parent 7757 451411eff24b
child 7759 2e1579882018
6927458: font system should cache transient strikes with weak references. Reviewed-by: igor, jgodinez
jdk/src/share/classes/sun/font/Font2D.java
--- a/jdk/src/share/classes/sun/font/Font2D.java	Thu Dec 23 15:28:59 2010 -0800
+++ b/jdk/src/share/classes/sun/font/Font2D.java	Thu Dec 23 21:58:12 2010 -0800
@@ -343,7 +343,21 @@
             }
             strike = createStrike(desc);
             //StrikeCache.addStrike();
-            strikeRef = StrikeCache.getStrikeRef(strike);
+            /* If we are creating many strikes on this font which
+             * involve non-quadrant rotations, or more general
+             * transforms which include shears, then force the use
+             * of weak references rather than soft references.
+             * This means that it won't live much beyond the next GC,
+             * which is what we want for what is likely a transient strike.
+             */
+            int txType = desc.glyphTx.getType();
+            if (txType == AffineTransform.TYPE_GENERAL_TRANSFORM ||
+                (txType & AffineTransform.TYPE_GENERAL_ROTATION) != 0 &&
+                strikeCache.size() > 10) {
+                strikeRef = StrikeCache.getStrikeRef(strike, true);
+            } else {
+                strikeRef = StrikeCache.getStrikeRef(strike);
+            }
             strikeCache.put(desc, strikeRef);
             //strike.lastlookupTime = System.currentTimeMillis();
             lastFontStrike = new SoftReference(strike);