6635110: GTK problem when testing Sun Studio IDE on snv_77 with jdk1.6 using Gnome window manager
Summary: GTKIconFactory icons should protect against null context passed in
Reviewed-by: rupashka
--- a/jdk/src/share/classes/com/sun/java/swing/plaf/gtk/GTKIconFactory.java Thu Mar 26 11:04:47 2009 +0300
+++ b/jdk/src/share/classes/com/sun/java/swing/plaf/gtk/GTKIconFactory.java Mon Apr 06 13:06:24 2009 +0400
@@ -279,20 +279,22 @@
public void paintIcon(SynthContext context, Graphics g, int x, int y,
int w, int h) {
- JToolBar toolbar = (JToolBar)context.getComponent();
- Orientation orientation =
- (toolbar.getOrientation() == JToolBar.HORIZONTAL ?
- Orientation.HORIZONTAL : Orientation.VERTICAL);
+ if (context != null) {
+ JToolBar toolbar = (JToolBar)context.getComponent();
+ Orientation orientation =
+ (toolbar.getOrientation() == JToolBar.HORIZONTAL ?
+ Orientation.HORIZONTAL : Orientation.VERTICAL);
- if (style == null) {
- style = SynthLookAndFeel.getStyleFactory().getStyle(
- context.getComponent(), GTKRegion.HANDLE_BOX);
+ if (style == null) {
+ style = SynthLookAndFeel.getStyleFactory().getStyle(
+ context.getComponent(), GTKRegion.HANDLE_BOX);
+ }
+ context = new SynthContext(toolbar, GTKRegion.HANDLE_BOX,
+ style, SynthConstants.ENABLED);
+
+ GTKPainter.INSTANCE.paintIcon(context, g,
+ getMethod(), x, y, w, h, orientation);
}
- context = new SynthContext(toolbar, GTKRegion.HANDLE_BOX,
- style, SynthConstants.ENABLED);
-
- GTKPainter.INSTANCE.paintIcon(context, g,
- getMethod(), x, y, w, h, orientation);
}
public int getIconWidth(SynthContext context) {
@@ -336,12 +338,14 @@
public void paintIcon(SynthContext context, Graphics g, int x, int y,
int w, int h) {
- ArrowType arrowDir = ArrowType.RIGHT;
- if (!context.getComponent().getComponentOrientation().isLeftToRight()) {
- arrowDir = ArrowType.LEFT;
+ if (context != null) {
+ ArrowType arrowDir = ArrowType.RIGHT;
+ if (!context.getComponent().getComponentOrientation().isLeftToRight()) {
+ arrowDir = ArrowType.LEFT;
+ }
+ GTKPainter.INSTANCE.paintIcon(context, g,
+ getMethod(), x, y, w, h, arrowDir);
}
- GTKPainter.INSTANCE.paintIcon(context, g,
- getMethod(), x, y, w, h, arrowDir);
}
}
}
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/com/sun/java/swing/plaf/gtk/Test6635110.java Mon Apr 06 13:06:24 2009 +0400
@@ -0,0 +1,65 @@
+/*
+ * Copyright 2008 Sun Microsystems, Inc. All Rights Reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+/* @test
+ @bug 6635110
+ @summary GTK icons should not throw NPE when called by non-GTK UI
+ @author Peter Zhelezniakov
+ @run main Test6635110
+*/
+
+import com.sun.java.swing.plaf.gtk.GTKLookAndFeel;
+import javax.swing.*;
+import java.awt.*;
+import java.awt.image.BufferedImage;
+import javax.swing.plaf.basic.*;
+
+
+public class Test6635110 implements Runnable {
+
+ static final int WIDTH = 160;
+ static final int HEIGHT = 80;
+ final BufferedImage IMAGE =
+ new BufferedImage(WIDTH, HEIGHT, BufferedImage.TYPE_INT_ARGB);
+
+ @Override public void run() {
+ JMenu menu = new JMenu("menu");
+ menu.setUI(new BasicMenuUI());
+ paint(menu);
+
+ JToolBar tb = new JToolBar();
+ tb.setFloatable(true);
+ tb.setUI(new BasicToolBarUI());
+ paint(tb);
+ }
+
+ void paint(Component c) {
+ c.setSize(WIDTH, HEIGHT);
+ c.paint(IMAGE.getGraphics());
+ }
+
+ public static void main(String[] args) throws Exception {
+ UIManager.setLookAndFeel(new GTKLookAndFeel());
+ SwingUtilities.invokeAndWait(new Test6635110());
+ }
+}