8232735: Convert PrintJNIResolving to Unified Logging
Summary: converted the existing output at debug level because it is noisy
Reviewed-by: iklam, dholmes
--- a/src/hotspot/os/bsd/os_bsd.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/os/bsd/os_bsd.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -2845,15 +2845,11 @@
// and if UserSignalHandler is installed all bets are off
if (CheckJNICalls) {
if (libjsig_is_loaded) {
- if (PrintJNIResolving) {
- tty->print_cr("Info: libjsig is activated, all active signal checking is disabled");
- }
+ log_debug(jni, resolve)("Info: libjsig is activated, all active signal checking is disabled");
check_signals = false;
}
if (AllowUserSignalHandlers) {
- if (PrintJNIResolving) {
- tty->print_cr("Info: AllowUserSignalHandlers is activated, all active signal checking is disabled");
- }
+ log_debug(jni, resolve)("Info: AllowUserSignalHandlers is activated, all active signal checking is disabled");
check_signals = false;
}
}
--- a/src/hotspot/os/linux/os_linux.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/os/linux/os_linux.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -4789,15 +4789,11 @@
// Log that signal checking is off only if -verbose:jni is specified.
if (CheckJNICalls) {
if (libjsig_is_loaded) {
- if (PrintJNIResolving) {
- tty->print_cr("Info: libjsig is activated, all active signal checking is disabled");
- }
+ log_debug(jni, resolve)("Info: libjsig is activated, all active signal checking is disabled");
check_signals = false;
}
if (AllowUserSignalHandlers) {
- if (PrintJNIResolving) {
- tty->print_cr("Info: AllowUserSignalHandlers is activated, all active signal checking is disabled");
- }
+ log_debug(jni, resolve)("Info: AllowUserSignalHandlers is activated, all active signal checking is disabled");
check_signals = false;
}
}
--- a/src/hotspot/os/solaris/os_solaris.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/os/solaris/os_solaris.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -3684,15 +3684,11 @@
// Log that signal checking is off only if -verbose:jni is specified.
if (CheckJNICalls) {
if (libjsig_is_loaded) {
- if (PrintJNIResolving) {
- tty->print_cr("Info: libjsig is activated, all active signal checking is disabled");
- }
+ log_debug(jni, resolve)("Info: libjsig is activated, all active signal checking is disabled");
check_signals = false;
}
if (AllowUserSignalHandlers) {
- if (PrintJNIResolving) {
- tty->print_cr("Info: AllowUserSignalHandlers is activated, all active signal checking is disabled");
- }
+ log_debug(jni, resolve)("Info: AllowUserSignalHandlers is activated, all active signal checking is disabled");
check_signals = false;
}
}
--- a/src/hotspot/share/jvmci/jvmciCompilerToVM.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/share/jvmci/jvmciCompilerToVM.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -34,6 +34,8 @@
#include "jvmci/jvmciCompilerToVM.hpp"
#include "jvmci/jvmciCodeInstaller.hpp"
#include "jvmci/jvmciRuntime.hpp"
+#include "logging/log.hpp"
+#include "logging/logTag.hpp"
#include "memory/oopFactory.hpp"
#include "memory/universe.hpp"
#include "oops/constantPool.inline.hpp"
@@ -2296,11 +2298,9 @@
method->name_and_sig_as_C_string(), p2i(method->native_function()), p2i(entry)));
}
method->set_native_function(entry, Method::native_bind_event_is_interesting);
- if (PrintJNIResolving) {
- tty->print_cr("[Dynamic-linking native method %s.%s ... JNI]",
- method->method_holder()->external_name(),
- method->name()->as_C_string());
- }
+ log_debug(jni, resolve)("[Dynamic-linking native method %s.%s ... JNI]",
+ method->method_holder()->external_name(),
+ method->name()->as_C_string());
}
}
--- a/src/hotspot/share/oops/method.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/share/oops/method.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -36,6 +36,8 @@
#include "interpreter/bytecodes.hpp"
#include "interpreter/interpreter.hpp"
#include "interpreter/oopMapCache.hpp"
+#include "logging/log.hpp"
+#include "logging/logTag.hpp"
#include "memory/allocation.inline.hpp"
#include "memory/heapInspection.hpp"
#include "memory/metadataFactory.hpp"
@@ -448,11 +450,11 @@
} else {
method->clear_native_function();
}
- if (PrintJNIResolving) {
+ if (log_is_enabled(Debug, jni, resolve)) {
ResourceMark rm(THREAD);
- tty->print_cr("[Registering JNI native method %s.%s]",
- method->method_holder()->external_name(),
- method->name()->as_C_string());
+ log_debug(jni, resolve)("[Registering JNI native method %s.%s]",
+ method->method_holder()->external_name(),
+ method->name()->as_C_string());
}
return true;
}
--- a/src/hotspot/share/prims/jniCheck.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/share/prims/jniCheck.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -28,6 +28,8 @@
#include "classfile/javaClasses.inline.hpp"
#include "classfile/systemDictionary.hpp"
#include "classfile/vmSymbols.hpp"
+#include "logging/log.hpp"
+#include "logging/logTag.hpp"
#include "memory/allocation.inline.hpp"
#include "memory/guardedMemory.hpp"
#include "oops/instanceKlass.hpp"
@@ -2303,10 +2305,7 @@
"Mismatched JNINativeInterface tables, check for new entries");
// with -verbose:jni this message will print
- if (PrintJNIResolving) {
- tty->print_cr("Checked JNI functions are being used to " \
- "validate JNI usage");
- }
+ log_debug(jni, resolve)("Checked JNI functions are being used to validate JNI usage");
return &checked_jni_NativeInterface;
}
--- a/src/hotspot/share/prims/jvmtiEnv.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/share/prims/jvmtiEnv.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -809,14 +809,11 @@
LogConfiguration::configure_stdout(level, false, LOG_TAGS(class, load));
break;
case JVMTI_VERBOSE_GC:
- if (value == 0) {
- LogConfiguration::configure_stdout(LogLevel::Off, true, LOG_TAGS(gc));
- } else {
- LogConfiguration::configure_stdout(LogLevel::Info, true, LOG_TAGS(gc));
- }
+ LogConfiguration::configure_stdout(level, true, LOG_TAGS(gc));
break;
case JVMTI_VERBOSE_JNI:
- PrintJNIResolving = value != 0;
+ level = value == 0 ? LogLevel::Off : LogLevel::Debug;
+ LogConfiguration::configure_stdout(level, true, LOG_TAGS(jni, resolve));
break;
default:
return JVMTI_ERROR_ILLEGAL_ARGUMENT;
--- a/src/hotspot/share/prims/nativeLookup.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/share/prims/nativeLookup.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -27,6 +27,8 @@
#include "classfile/symbolTable.hpp"
#include "classfile/systemDictionary.hpp"
#include "classfile/vmSymbols.hpp"
+#include "logging/log.hpp"
+#include "logging/logTag.hpp"
#include "memory/oopFactory.hpp"
#include "memory/resourceArea.hpp"
#include "oops/instanceKlass.hpp"
@@ -413,11 +415,11 @@
method->set_native_function(entry,
Method::native_bind_event_is_interesting);
// -verbose:jni printing
- if (PrintJNIResolving) {
+ if (log_is_enabled(Debug, jni, resolve)) {
ResourceMark rm(THREAD);
- tty->print_cr("[Dynamic-linking native method %s.%s ... JNI]",
- method->method_holder()->external_name(),
- method->name()->as_C_string());
+ log_debug(jni, resolve)("[Dynamic-linking native method %s.%s ... JNI]",
+ method->method_holder()->external_name(),
+ method->name()->as_C_string());
}
}
return method->native_function();
--- a/src/hotspot/share/runtime/arguments.cpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/share/runtime/arguments.cpp Mon Nov 11 12:11:34 2019 -0500
@@ -588,6 +588,7 @@
{ "TraceSafepointCleanupTime", LogLevel::Info, true, LOG_TAGS(safepoint, cleanup) },
{ "TraceJVMTIObjectTagging", LogLevel::Debug, true, LOG_TAGS(jvmti, objecttagging) },
{ "TraceRedefineClasses", LogLevel::Info, false, LOG_TAGS(redefine, class) },
+ { "PrintJNIResolving", LogLevel::Debug, true, LOG_TAGS(jni, resolve) },
{ NULL, LogLevel::Off, false, LOG_TAGS(_NO_TAG) }
};
@@ -2400,9 +2401,7 @@
} else if (!strcmp(tail, ":gc")) {
LogConfiguration::configure_stdout(LogLevel::Info, true, LOG_TAGS(gc));
} else if (!strcmp(tail, ":jni")) {
- if (FLAG_SET_CMDLINE(PrintJNIResolving, true) != JVMFlag::SUCCESS) {
- return JNI_EINVAL;
- }
+ LogConfiguration::configure_stdout(LogLevel::Debug, true, LOG_TAGS(jni, resolve));
}
// -da / -ea / -disableassertions / -enableassertions
// These accept an optional class/package name separated by a colon, e.g.,
--- a/src/hotspot/share/runtime/globals.hpp Mon Nov 11 16:59:42 2019 +0100
+++ b/src/hotspot/share/runtime/globals.hpp Mon Nov 11 12:11:34 2019 -0500
@@ -305,9 +305,6 @@
notproduct(bool, TraceCodeBlobStacks, false, \
"Trace stack-walk of codeblobs") \
\
- product(bool, PrintJNIResolving, false, \
- "Used to implement -v:jni") \
- \
notproduct(bool, PrintRewrites, false, \
"Print methods that are being rewritten") \
\