8217707: JNICALL declaration breaks Splash screen functions
Reviewed-by: prr, stuefe
--- a/src/java.desktop/share/native/libsplashscreen/splashscreen_impl.c Thu Mar 28 14:52:41 2019 +0000
+++ b/src/java.desktop/share/native/libsplashscreen/splashscreen_impl.c Thu Mar 28 18:51:52 2019 +0000
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -46,7 +46,7 @@
return &splash;
}
-JNIEXPORT void JNICALL
+JNIEXPORT void
SplashSetFileJarName(const char* fileName, const char* jarName) {
Splash *splash = SplashGetInstance();
@@ -57,7 +57,7 @@
splash->jarName = SplashConvertStringAlloc(jarName, &splash->jarNameLen);
}
-JNIEXPORT void JNICALL
+JNIEXPORT void
SplashInit()
{
Splash *splash = SplashGetInstance();
@@ -70,7 +70,7 @@
SplashInitPlatform(splash);
}
-JNIEXPORT void JNICALL
+JNIEXPORT void
SplashClose()
{
Splash *splash = SplashGetInstance();
@@ -107,7 +107,7 @@
SplashSetFileJarName(NULL, NULL);
}
-JNIEXPORT void JNICALL
+JNIEXPORT void
SplashSetScaleFactor(float scaleFactor)
{
Splash *splash = SplashGetInstance();
@@ -302,7 +302,7 @@
return success;
}
-JNIEXPORT int JNICALL
+JNIEXPORT int
SplashLoadFile(const char *filename)
{
SplashStream stream;
@@ -310,7 +310,7 @@
SplashLoadStream(&stream);
}
-JNIEXPORT int JNICALL
+JNIEXPORT int
SplashLoadMemory(void *data, int size)
{
SplashStream stream;
@@ -395,7 +395,7 @@
return 1;
}
-JNIEXPORT int JNICALL
+JNIEXPORT int
SplashGetScaledImgNameMaxPstfixLen(const char *fileName){
return strlen(fileName) + strlen("@100pct") + 1;
}
--- a/src/java.desktop/share/native/libsplashscreen/splashscreen_impl.h Thu Mar 28 14:52:41 2019 +0000
+++ b/src/java.desktop/share/native/libsplashscreen/splashscreen_impl.h Thu Mar 28 18:51:52 2019 +0000
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -30,29 +30,29 @@
#include "splashscreen_gfx.h"
#include "jni.h"
-JNIEXPORT int JNICALL
+JNIEXPORT int
SplashLoadMemory(void *pdata, int size); /* requires preloading the file */
-JNIEXPORT int JNICALL
+JNIEXPORT int
SplashLoadFile(const char *filename); // FIXME: range checking for SplashLoadMemory
-JNIEXPORT void JNICALL
+JNIEXPORT void
SplashInit(void);
-JNIEXPORT void JNICALL
+JNIEXPORT void
SplashClose(void);
-JNIEXPORT void JNICALL
+JNIEXPORT void
SplashSetScaleFactor(float);
-JNIEXPORT jboolean JNICALL
+JNIEXPORT jboolean
SplashGetScaledImageName(const char*, const char*,
float*, char*, const size_t scaledImageNameLength);
-JNIEXPORT void JNICALL
+JNIEXPORT void
SplashSetFileJarName(const char* fileName, const char* jarName);
-JNIEXPORT int JNICALL
+JNIEXPORT int
SplashGetScaledImgNameMaxPstfixLen(const char*);
typedef struct SplashImage
{
--- a/src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c Thu Mar 28 14:52:41 2019 +0000
+++ b/src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c Thu Mar 28 18:51:52 2019 +0000
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -801,7 +801,7 @@
sendctl(splash, SPLASHCTL_RECONFIGURE);
}
-JNIEXPORT jboolean JNICALL
+JNIEXPORT jboolean
SplashGetScaledImageName(const char* jarName, const char* fileName,
float *scaleFactor, char *scaledImgName,
const size_t scaledImageNameLength)
--- a/src/java.desktop/windows/native/libsplashscreen/splashscreen_sys.c Thu Mar 28 14:52:41 2019 +0000
+++ b/src/java.desktop/windows/native/libsplashscreen/splashscreen_sys.c Thu Mar 28 18:51:52 2019 +0000
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2005, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -574,7 +574,7 @@
PostMessage(splash->hWnd, WM_SPLASHRECONFIGURE, 0, 0);
}
-JNIEXPORT jboolean JNICALL
+JNIEXPORT jboolean
SplashGetScaledImageName(const char* jarName, const char* fileName,
float *scaleFactor, char *scaleImageName,
const size_t scaledImageLength)