6999988: CMS: Increased fragmentation leading to promotion failure after CR#6631166 got implemented
authorysr
Tue, 01 Feb 2011 10:02:01 -0800
changeset 8101 1778246610fa
parent 8100 6d2b49640dd5
child 8102 0edfdab48098
6999988: CMS: Increased fragmentation leading to promotion failure after CR#6631166 got implemented Summary: Fix calculation of _desired, in free list statistics, which was missing an intended set of parentheses. Reviewed-by: poonam, jmasa
hotspot/src/share/vm/gc_implementation/shared/allocationStats.hpp
--- a/hotspot/src/share/vm/gc_implementation/shared/allocationStats.hpp	Mon Jan 31 16:28:40 2011 -0500
+++ b/hotspot/src/share/vm/gc_implementation/shared/allocationStats.hpp	Tue Feb 01 10:02:01 2011 -0800
@@ -116,10 +116,8 @@
       _demand_rate_estimate.sample(rate);
       float new_rate = _demand_rate_estimate.padded_average();
       ssize_t old_desired = _desired;
-      _desired = (ssize_t)(new_rate * (inter_sweep_estimate
-                                       + CMSExtrapolateSweep
-                                         ? intra_sweep_estimate
-                                         : 0.0));
+      float delta_ise = (CMSExtrapolateSweep ? intra_sweep_estimate : 0.0);
+      _desired = (ssize_t)(new_rate * (inter_sweep_estimate + delta_ise));
       if (PrintFLSStatistics > 1) {
         gclog_or_tty->print_cr("demand: %d, old_rate: %f, current_rate: %f, new_rate: %f, old_desired: %d, new_desired: %d",
                                 demand,     old_rate,     rate,             new_rate,     old_desired,     _desired);