# HG changeset patch # User coleenp # Date 1519240106 18000 # Node ID ebdbf7f901993030eaa7cc0eac5a5d1527a95db7 # Parent dc68aeea4840db0d1adae30d58645cedf0af63b4 8068593: Remove or repurpose unused PerfCounters from objectMonitor Reviewed-by: redestad, dcubed diff -r dc68aeea4840 -r ebdbf7f90199 src/hotspot/share/runtime/objectMonitor.cpp --- a/src/hotspot/share/runtime/objectMonitor.cpp Wed Feb 21 11:18:52 2018 -0500 +++ b/src/hotspot/share/runtime/objectMonitor.cpp Wed Feb 21 14:08:26 2018 -0500 @@ -102,8 +102,6 @@ int ObjectMonitor::Knob_VerifyInUse = 0; int ObjectMonitor::Knob_VerifyMatch = 0; int ObjectMonitor::Knob_SpinLimit = 5000; // derived by an external tool - -static int Knob_LogSpins = 0; // enable jvmstat tally for spins -static int Knob_HandOff = 0; static int Knob_ReportSettings = 0; static int Knob_SpinBase = 0; // Floor AKA SpinMin @@ -2229,18 +2227,7 @@ PerfCounter * ObjectMonitor::_sync_ContendedLockAttempts = NULL; PerfCounter * ObjectMonitor::_sync_FutileWakeups = NULL; PerfCounter * ObjectMonitor::_sync_Parks = NULL; -PerfCounter * ObjectMonitor::_sync_EmptyNotifications = NULL; PerfCounter * ObjectMonitor::_sync_Notifications = NULL; -PerfCounter * ObjectMonitor::_sync_PrivateA = NULL; -PerfCounter * ObjectMonitor::_sync_PrivateB = NULL; -PerfCounter * ObjectMonitor::_sync_SlowExit = NULL; -PerfCounter * ObjectMonitor::_sync_SlowEnter = NULL; -PerfCounter * ObjectMonitor::_sync_SlowNotify = NULL; -PerfCounter * ObjectMonitor::_sync_SlowNotifyAll = NULL; -PerfCounter * ObjectMonitor::_sync_FailedSpins = NULL; -PerfCounter * ObjectMonitor::_sync_SuccessfulSpins = NULL; -PerfCounter * ObjectMonitor::_sync_MonInCirculation = NULL; -PerfCounter * ObjectMonitor::_sync_MonScavenged = NULL; PerfCounter * ObjectMonitor::_sync_Inflations = NULL; PerfCounter * ObjectMonitor::_sync_Deflations = NULL; PerfLongVariable * ObjectMonitor::_sync_MonExtant = NULL; @@ -2271,18 +2258,7 @@ NEWPERFCOUNTER(_sync_ContendedLockAttempts); NEWPERFCOUNTER(_sync_FutileWakeups); NEWPERFCOUNTER(_sync_Parks); - NEWPERFCOUNTER(_sync_EmptyNotifications); NEWPERFCOUNTER(_sync_Notifications); - NEWPERFCOUNTER(_sync_SlowEnter); - NEWPERFCOUNTER(_sync_SlowExit); - NEWPERFCOUNTER(_sync_SlowNotify); - NEWPERFCOUNTER(_sync_SlowNotifyAll); - NEWPERFCOUNTER(_sync_FailedSpins); - NEWPERFCOUNTER(_sync_SuccessfulSpins); - NEWPERFCOUNTER(_sync_PrivateA); - NEWPERFCOUNTER(_sync_PrivateB); - NEWPERFCOUNTER(_sync_MonInCirculation); - NEWPERFCOUNTER(_sync_MonScavenged); NEWPERFVARIABLE(_sync_MonExtant); #undef NEWPERFCOUNTER #undef NEWPERFVARIABLE @@ -2351,7 +2327,6 @@ SETKNOB(SpinBackOff); SETKNOB(CASPenalty); SETKNOB(OXPenalty); - SETKNOB(LogSpins); SETKNOB(SpinSetSucc); SETKNOB(SuccEnabled); SETKNOB(SuccRestrict); @@ -2389,10 +2364,6 @@ Knob_FixedSpin = -1; } - if (Knob_LogSpins == 0) { - ObjectMonitor::_sync_FailedSpins = NULL; - } - os::free(knobs); OrderAccess::fence(); InitDone = 1; diff -r dc68aeea4840 -r ebdbf7f90199 src/hotspot/share/runtime/objectMonitor.hpp --- a/src/hotspot/share/runtime/objectMonitor.hpp Wed Feb 21 11:18:52 2018 -0500 +++ b/src/hotspot/share/runtime/objectMonitor.hpp Wed Feb 21 14:08:26 2018 -0500 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -191,18 +191,7 @@ static PerfCounter * _sync_ContendedLockAttempts; static PerfCounter * _sync_FutileWakeups; static PerfCounter * _sync_Parks; - static PerfCounter * _sync_EmptyNotifications; static PerfCounter * _sync_Notifications; - static PerfCounter * _sync_SlowEnter; - static PerfCounter * _sync_SlowExit; - static PerfCounter * _sync_SlowNotify; - static PerfCounter * _sync_SlowNotifyAll; - static PerfCounter * _sync_FailedSpins; - static PerfCounter * _sync_SuccessfulSpins; - static PerfCounter * _sync_PrivateA; - static PerfCounter * _sync_PrivateB; - static PerfCounter * _sync_MonInCirculation; - static PerfCounter * _sync_MonScavenged; static PerfCounter * _sync_Inflations; static PerfCounter * _sync_Deflations; static PerfLongVariable * _sync_MonExtant;